[GitHub] XD-DENG commented on issue #4395: [AIRFLOW-3587] Remove unnecessary condition checks in dag_stats & task_stats
XD-DENG commented on issue #4395: [AIRFLOW-3587] Remove unnecessary condition checks in dag_stats & task_stats URL: https://github.com/apache/incubator-airflow/pull/4395#issuecomment-450800234 Thanks @feng-tao :-) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] XD-DENG commented on issue #4395: [AIRFLOW-3587] Remove unnecessary condition checks in dag_stats & task_stats
XD-DENG commented on issue #4395: [AIRFLOW-3587] Remove unnecessary condition checks in dag_stats & task_stats URL: https://github.com/apache/incubator-airflow/pull/4395#issuecomment-450794525 Thanks @feng-tao . The logic you mentioned is in https://github.com/apache/incubator-airflow/pull/4395/files#diff-77df5adb32d964f37748c4557ffb3c4cR366 , which is not touched. The two lines I tries to remove in this PR were introduced by @ffinfo 6 days ago. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] XD-DENG commented on issue #4395: [AIRFLOW-3587] Remove unnecessary condition checks in dag_stats & task_stats
XD-DENG commented on issue #4395: [AIRFLOW-3587] Remove unnecessary condition checks in dag_stats & task_stats URL: https://github.com/apache/incubator-airflow/pull/4395#issuecomment-450313670 @Fokko PTAL. This PR is to remove two unnecessary condition checks in https://github.com/apache/incubator-airflow/pull/4368 authored by @ffinfo (@ffinfo PTAL as well). Please check my reasoning above in the PR message. Kindly let me know if I have misunderstood or missed anything. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
