[GitHub] feng-tao edited a comment on issue #4395: [AIRFLOW-3587] Remove unnecessary condition checks in dag_stats & task_stats
feng-tao edited a comment on issue #4395: [AIRFLOW-3587] Remove unnecessary condition checks in dag_stats & task_stats URL: https://github.com/apache/incubator-airflow/pull/4395#issuecomment-450793077 to give more context, if a user with a role of Admin, he will have all-dags privilege which could view/edit all the dags, otherwise, it will filter the dag only based on the role. So in this case your change is incorrect if we commit this change. A role(e.g which could only view example_python_operator) could view the task_stat or dag_stat for other dags as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] feng-tao edited a comment on issue #4395: [AIRFLOW-3587] Remove unnecessary condition checks in dag_stats & task_stats
feng-tao edited a comment on issue #4395: [AIRFLOW-3587] Remove unnecessary condition checks in dag_stats & task_stats URL: https://github.com/apache/incubator-airflow/pull/4395#issuecomment-450793077 to give more context, if a user with a role of Admin, he will have all-dags privilege which could view/edit all the dags, otherwise, it will filter the dag only based on the role. So in this case your change is incorrect. A role(e.g which could only view example_python_operator) could view the task_stat or dag_stat for other dags as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
