seelmann commented on a change in pull request #4147: [AIRFLOW-3307] Upgrade
rbac node deps via `npm audit fix`.
URL: https://github.com/apache/incubator-airflow/pull/4147#discussion_r244609571
##########
File path: airflow/www_rbac/package.json
##########
@@ -57,11 +56,11 @@
"bootstrap-toggle": "^2.2.2",
"d3": "^3.4.4",
"d3-tip": "^0.9.1",
- "dagre-d3": "^0.4.18",
+ "dagre-d3": "^0.6.1",
Review comment:
Unfortunately this breaks the www_rbac graph view, see JS error below. I
cleaned `airflow/www_rbac/node_modules/` and run
`airflow/www_rbac/compile_assets.sh`.
We still use d3 version 3, so dagre-d3 version 0.4.18 is the last that can
be used, see also https://github.com/dagrejs/dagre-d3/issues/309
If I revert back to dagre-d3 0.4.18 the graph view works. Should I create a
PR to revert back? But I only have limited npm knowledge, not sure how to
prevent the audit warnings. Or is there a plan to update d3?
```
dagre-d3.min.js:24 Uncaught TypeError: svgEdgeLabels.exit is not a function
at createEdgeLabels (dagre-d3.min.js:24)
at Array.fn (dagre-d3.min.js:90)
at Array.Co.call (d3.min.js:3)
at graph?dag_id=demo:1131
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
