Re: [I] Change the UI color for ExternalSensor tasks [airflow]

2024-04-12 Thread via GitHub


jscheffl closed issue #38845: Change the UI color for ExternalSensor tasks
URL: https://github.com/apache/airflow/issues/38845


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Change the UI color for ExternalSensor tasks [airflow]

2024-04-08 Thread via GitHub


idantepper commented on issue #38845:
URL: https://github.com/apache/airflow/issues/38845#issuecomment-2043379278

   Hi, I would like to take this issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Change the UI color for ExternalSensor tasks [airflow]

2024-04-08 Thread via GitHub


Timelessprod opened a new issue, #38845:
URL: https://github.com/apache/airflow/issues/38845

   ### Description
   
   With the recent update of the graph display in DAGs, there's a visibility 
issue regarding external task sensors. Indeed those tasks have a `#19647e` tile 
color while the status & operator name are displayed in 
`--chakra-colors-gray-500` (aka `#718096`) on top of it, which makes the text 
unreadable. You can see a screenshot below:
   
   https://github.com/apache/airflow/assets/69579602/8497faa7-9a61-4e59-a0ff-576844cfe67f;>
   
   I can submit a PR for it if needed but I'm unsure if there's a chart 
regarding which color to give to what type of operator etc. so please tell me. 
My idea would be to use same tint but lighter color like `#4db7db` which is 
more readable (see below) but not perfect for accessibility:
   
   https://github.com/apache/airflow/assets/69579602/e2fa562b-668f-4756-9ef0-421d5da3280e;>
   
   
   ### Use case/motivation
   
   The current color makes monitoring and debugging very annoying as it's 
unreadable. It is also a big issue regarding accessibility as color-blind 
people may not be able to guess the status name by the status color. As an 
argument, it was red flagged by Chrome Lighthouse when I ran a test on the 
webpage.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Change the UI color for ExternalSensor tasks [airflow]

2024-04-08 Thread via GitHub


boring-cyborg[bot] commented on issue #38845:
URL: https://github.com/apache/airflow/issues/38845#issuecomment-2043032243

   Thanks for opening your first issue here! Be sure to follow the issue 
template! If you are willing to raise PR to address this issue please do so, no 
need to wait for approval.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org