Re: [PR] [Core] Add deprecation module with decorator and custom warnings [airflow]
kacpermuda commented on PR #36952: URL: https://github.com/apache/airflow/pull/36952#issuecomment-2066025589 Adding another example of deprecations from Ray: https://github.com/ray-project/ray/blob/master/python/ray/_private/utils.py#L1090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Core] Add deprecation module with decorator and custom warnings [airflow]
Taragolis commented on PR #36952: URL: https://github.com/apache/airflow/pull/36952#issuecomment-2032294336 If you have a time also worthwhile to check [PEP-702 – Marking deprecations using the type system](https://peps.python.org/pep-0702/) (and [discussion](https://discuss.python.org/t/pep-702-marking-deprecations-using-the-type-system/23036)) and maybe it is possible to adopt it to use it, in python before 3.13 it back-ported in [`typing_extensions`](https://typing-extensions.readthedocs.io/en/latest/#typing_extensions.deprecated) Some upstream PEP-702 related issues/feature requests - https://github.com/python/mypy/issues/16111 - https://youtrack.jetbrains.com/issue/PY-61651/Deprecation-highlighting-with-PEP-702-deprecated-decorator - https://github.com/microsoft/pyright/issues/4456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Core] Add deprecation module with decorator and custom warnings [airflow]
kacpermuda commented on PR #36952: URL: https://github.com/apache/airflow/pull/36952#issuecomment-2032102661 Will reopen when i have time to do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Core] Add deprecation module with decorator and custom warnings [airflow]
kacpermuda closed pull request #36952: [Core] Add deprecation module with decorator and custom warnings URL: https://github.com/apache/airflow/pull/36952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Core] Add deprecation module with decorator and custom warnings [airflow]
github-actions[bot] commented on PR #36952: URL: https://github.com/apache/airflow/pull/36952#issuecomment-2028960814 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [Core] Add deprecation module with decorator and custom warnings [airflow]
kacpermuda opened a new pull request, #36952:
URL: https://github.com/apache/airflow/pull/36952
## Rationale
This is a step number 2 of the process described in #36876, please refer to
it for the rationale and in depth description. Possibly, it can also replace
the mechanism described in #31830.
## TLDR
See the two tests i wrote, for the demo of how it works.
I want to add a decorator (for now only for classes, functions, methods
etc.) that we can use for deprecations in the entire codebase (core and
providers). By defining a custom function, we can have the most common
information (now included in deprecation message) as separate arguments, so
it's easier to parse it and use in CI, docs etc.
## Todo after agreement on core functions
- Unit tests are missing right now, I just included some examples so we can
see how it works. I want to have an accepted functionality and then spend some
time on the tests.
- Also, possibly some changes in the documentation will be required, to
describe how the developers should deprecate things and what are the options.
- In the final solution, we can probably remove the warnings from current
location (`airflow.exceptions.py`) and only keep them in
`airflow.deprecation.py`.
## Questions
This is my first PR that touches the core airflow, so let me know if
anything needs to be changed 😄 I also have some questions to the functionality
itself:
1. Are there any more arguments that we can define in the deprecation
decorator? Some ideas?
2. Is it a good place (deprecation module in core) to have helper functions
like: `get_callable_full_path` or `validate_release_string`. We can just make
them private.
3. Should we define separate `provider_deprecated` decorator that will have
a default category set to AirflowProviderDeprecationWarning ?
4. Should we allow passing a different Adapter, so that You can alter the
deprecation message or we want to enforce standardization in the whole codebase
and remove that option for the end user?
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
