Re: [PR] Add Grid button to Task Instance view [airflow]
bbovenzi merged PR #39223: URL: https://github.com/apache/airflow/pull/39223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Grid button to Task Instance view [airflow]
csp33 commented on code in PR #39223:
URL: https://github.com/apache/airflow/pull/39223#discussion_r1579565320
##
airflow/www/views.py:
##
@@ -1650,6 +1653,7 @@ def log(self, session: Session = NEW_SESSION):
show_trigger_form_if_no_params=conf.getboolean("webserver",
"show_trigger_form_if_no_params"),
logs=logs,
dag=dag_model,
+dag_run_id=ti.dag_run.run_id if ti else "",
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add Grid button to Task Instance view [airflow]
bbovenzi commented on code in PR #39223:
URL: https://github.com/apache/airflow/pull/39223#discussion_r1579534235
##
airflow/www/views.py:
##
@@ -1650,6 +1653,7 @@ def log(self, session: Session = NEW_SESSION):
show_trigger_form_if_no_params=conf.getboolean("webserver",
"show_trigger_form_if_no_params"),
logs=logs,
dag=dag_model,
+dag_run_id=ti.dag_run.run_id if ti else "",
Review Comment:
We can just do `ti.run_id`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add Grid button to Task Instance view [airflow]
csp33 commented on code in PR #39223:
URL: https://github.com/apache/airflow/pull/39223#discussion_r1579197259
##
airflow/www/templates/airflow/task_instance.html:
##
@@ -39,6 +39,9 @@
{{ url_for(endpoint, dag_id=dag.dag_id, task_id=task_id,
execution_date=execution_date) }}
{%- endif -%}
{% endmacro -%}
+
Review Comment:
I did it! I'm not sure if it's the most optimal way, though.
Video has been updated in the PR description ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add Grid button to Task Instance view [airflow]
csp33 commented on code in PR #39223:
URL: https://github.com/apache/airflow/pull/39223#discussion_r1579197259
##
airflow/www/templates/airflow/task_instance.html:
##
@@ -39,6 +39,9 @@
{{ url_for(endpoint, dag_id=dag.dag_id, task_id=task_id,
execution_date=execution_date) }}
{%- endif -%}
{% endmacro -%}
+
Review Comment:
I did it! I'm not sure if it's the most optimal way, though.
##
airflow/www/templates/airflow/task_instance.html:
##
@@ -39,6 +39,9 @@
{{ url_for(endpoint, dag_id=dag.dag_id, task_id=task_id,
execution_date=execution_date) }}
{%- endif -%}
{% endmacro -%}
+
Review Comment:
I did it! I'm not sure if it's the most optimal way, though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add Grid button to Task Instance view [airflow]
csp33 commented on code in PR #39223:
URL: https://github.com/apache/airflow/pull/39223#discussion_r1578974010
##
airflow/www/templates/airflow/task_instance.html:
##
@@ -39,6 +39,9 @@
{{ url_for(endpoint, dag_id=dag.dag_id, task_id=task_id,
execution_date=execution_date) }}
{%- endif -%}
{% endmacro -%}
+
Review Comment:
I tried, but I don't know how to get the `dag_run_id` value 樂
Could you help me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add Grid button to Task Instance view [airflow]
bbovenzi commented on code in PR #39223:
URL: https://github.com/apache/airflow/pull/39223#discussion_r1578104205
##
airflow/www/templates/airflow/task_instance.html:
##
@@ -39,6 +39,9 @@
{{ url_for(endpoint, dag_id=dag.dag_id, task_id=task_id,
execution_date=execution_date) }}
{%- endif -%}
{% endmacro -%}
+
Review Comment:
Nice! Could we include the task_id, dag_run_id, map_index in the params to
link back to the same task instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add Grid button to Task Instance view [airflow]
csp33 commented on PR #39223: URL: https://github.com/apache/airflow/pull/39223#issuecomment-2074448398 @bbovenzi here's the PR ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add Grid button to Task Instance view [airflow]
csp33 opened a new pull request, #39223: URL: https://github.com/apache/airflow/pull/39223 https://github.com/apache/airflow/assets/28935464/315bfa42-cdba-49d7-ace4-7d41870fe256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
