Re: [PR] Add option for ExternalTaskSensor to automatically infer upstream execution dates [airflow]
jannisko closed pull request #38542: Add option for ExternalTaskSensor to automatically infer upstream execution dates URL: https://github.com/apache/airflow/pull/38542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add option for ExternalTaskSensor to automatically infer upstream execution dates [airflow]
jannisko commented on PR #38542: URL: https://github.com/apache/airflow/pull/38542#issuecomment-2048276970 Fair point. Thank you for the hint. @hussein-awala @uranusjr I see you two have been touching the sensor every once in a while. Do you mind taking a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add option for ExternalTaskSensor to automatically infer upstream execution dates [airflow]
potiuk commented on PR #38542: URL: https://github.com/apache/airflow/pull/38542#issuecomment-2041607356 If you tag me - you limit your chances of getting review. I might be busy/not available or simply not have anything to say I suggest you continue asking for review - there are others who have been contributing to the sensor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add option for ExternalTaskSensor to automatically infer upstream execution dates [airflow]
jannisko opened a new pull request, #38542:
URL: https://github.com/apache/airflow/pull/38542
This PR makes using the ExternalTaskSensor simpler in cases where the
upstream DAG runs more frequently than the downstream DAG (e.g. a daily dag
must wait for all 24 runs of an hourly dag).
If the option `infer_upstream_execution_dates` is set to True, all
downstream data intervals, that overlap with the data interval of the upstream
dag will be checked.
Alternatively, the same functionality could be implemented as a custom
`execution_date_fn` function, but I think it's useful enough to be a separate
option.
@potiuk let me know what you think about this!
If you think it's useful, I'll add some documentation to
`docs/apache-airflow/howto/operator/external_task_sensor.rst`
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add option for ExternalTaskSensor to automatically infer upstream execution dates [airflow]
boring-cyborg[bot] commented on PR #38542: URL: https://github.com/apache/airflow/pull/38542#issuecomment-2023713160 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better . In case of doubts contact the developers at: Mailing List: d...@airflow.apache.org Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
