Re: [PR] Correctly select task in DAG Graph View when clicking on its name [airflow]

[via GitHub]

jscheffl commented on PR #38782:
URL: https://github.com/apache/airflow/pull/38782#issuecomment-2144017205

   Still there are some static checks. Can you fix them? Maybe you can also run 
them locally via `pre-commit`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Correctly select task in DAG Graph View when clicking on its name [airflow]

[via GitHub]

jonhspyro commented on code in PR #38782:
URL: https://github.com/apache/airflow/pull/38782#discussion_r1614807696


##
airflow/www/static/js/dag/details/graph/DagNode.tsx:
##
@@ -126,10 +125,6 @@ const DagNode = ({
   label={taskName}
   isOpen={isOpen}
   isGroup={!!childCount}
-  onClick={(e) => {
-e.stopPropagation();

Review Comment:
   Can you check the changes I made? :) I think now it's working



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Correctly select task in DAG Graph View when clicking on its name [airflow]

[via GitHub]

github-actions[bot] commented on PR #38782:
URL: https://github.com/apache/airflow/pull/38782#issuecomment-2130540397

   This pull request has been automatically marked as stale because it has not 
had recent activity. It will be closed in 5 days if no further activity occurs. 
Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Correctly select task in DAG Graph View when clicking on its name [airflow]

[via GitHub]

bbovenzi commented on code in PR #38782:
URL: https://github.com/apache/airflow/pull/38782#discussion_r1557831020


##
airflow/www/static/js/dag/details/graph/DagNode.tsx:
##
@@ -126,10 +125,6 @@ const DagNode = ({
   label={taskName}
   isOpen={isOpen}
   isGroup={!!childCount}
-  onClick={(e) => {
-e.stopPropagation();

Review Comment:
   Yes, it was used to open and close task groups.
   
   We just need to change onClick to:
   
   ```
 onClick={(e) => {
   if (!!childCount) {
 e.stopPropagation();
 onToggleCollapse();
   }
 }}
 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Correctly select task in DAG Graph View when clicking on its name [airflow]

[via GitHub]

jonhspyro commented on code in PR #38782:
URL: https://github.com/apache/airflow/pull/38782#discussion_r1557745374


##
airflow/www/static/js/dag/details/graph/DagNode.tsx:
##
@@ -126,10 +125,6 @@ const DagNode = ({
   label={taskName}
   isOpen={isOpen}
   isGroup={!!childCount}
-  onClick={(e) => {
-e.stopPropagation();

Review Comment:
   So the code I deleted is making some other task not work?
   
   When I tested, everything was working.
   Can you give me some tips on how to solve this issue?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Correctly select task in DAG Graph View when clicking on its name [airflow]

[via GitHub]

bbovenzi commented on code in PR #38782:
URL: https://github.com/apache/airflow/pull/38782#discussion_r1556047065


##
airflow/www/static/js/dag/details/graph/DagNode.tsx:
##
@@ -126,10 +125,6 @@ const DagNode = ({
   label={taskName}
   isOpen={isOpen}
   isGroup={!!childCount}
-  onClick={(e) => {
-e.stopPropagation();

Review Comment:
   We need this for opening and closing task groups. But we can wrap it in an 
if statement `if (!!onToggleCollapse) {...` and have both function inside. 
Therefore, the onclick will propagate to selecting the task if it is not a task 
group



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org