Re: [PR] Improve task filtering UX [airflow]

2024-04-22 Thread via GitHub


bbovenzi merged PR #39119:
URL: https://github.com/apache/airflow/pull/39119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improve task filtering UX [airflow]

2024-04-19 Thread via GitHub


jscheffl commented on code in PR #39119:
URL: https://github.com/apache/airflow/pull/39119#discussion_r1572952793


##
airflow/www/static/js/dag/details/Header.tsx:
##
@@ -124,7 +124,7 @@ const Header = ({ mapIndex }: Props) => {
   
 
   )}
-  {mapIndex !== undefined && (
+  {mapIndex !== undefined && mapIndex !== -1 && (

Review Comment:
   Aaaah, also found this, thanks to fix it within this PR!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Improve task filtering UX [airflow]

2024-04-18 Thread via GitHub


bbovenzi opened a new pull request, #39119:
URL: https://github.com/apache/airflow/pull/39119

   Continuation of https://github.com/apache/airflow/pull/38660
   
   It was not always obvious if the DAG page was being filtered by the 
upstream/downstream of a task. A few fixes:
   - if a filter is applied, make the button blue
   - if a filter is applied, display the dropdown regardless of task/run 
selection
   - update copy
   - don't show map index in breadrcrumb if it is -1
   
   
   https://github.com/apache/airflow/assets/4600967/07a81973-9811-4d76-8a90-e9d1e88b67ae;>
   https://github.com/apache/airflow/assets/4600967/ccbbaaa9-b4d5-4ac0-99ca-ea468358bc4e;>
   
   
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org