Re: [PR] Make ImapHook mail body encoding configurable [airflow]
github-actions[bot] closed pull request #37517: Make ImapHook mail body encoding configurable URL: https://github.com/apache/airflow/pull/37517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make ImapHook mail body encoding configurable [airflow]
github-actions[bot] commented on PR #37517: URL: https://github.com/apache/airflow/pull/37517#issuecomment-2043917704 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make ImapHook mail body encoding configurable [airflow]
eladkal commented on PR #37517: URL: https://github.com/apache/airflow/pull/37517#issuecomment-1960992174 Tests are failing. Can you look into it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make ImapHook mail body encoding configurable [airflow]
prutheus commented on PR #37517: URL: https://github.com/apache/airflow/pull/37517#issuecomment-1951974475 @potiuk @dirrao I have added some tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make ImapHook mail body encoding configurable [airflow]
potiuk commented on PR #37517: URL: https://github.com/apache/airflow/pull/37517#issuecomment-1951443285 Usually we expect unit tests modified whenever any new functionality is added. Can you add one please? It seems imap has quite comprehensive set of tests and it should be possible to add some more similar tests with the new flag covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Make ImapHook mail body encoding configurable [airflow]
prutheus opened a new pull request, #37517:
URL: https://github.com/apache/airflow/pull/37517
---
**Airflow IMAP Hook only decodes with UTF-8**
I use the airflow imap hook, which internally only parses mail body with
UTF-8 encoding.
I have a mail with some German characters such as `ü` in text, so what is a
way to be able to parse that mails as well?
```
69with ImapHook(imap_conn_id="imap") as conn:
70attachments = conn.retrieve_mail_attachments(
71name="(.*).PDF",
72check_regex=True,
73mail_folder="INBOX",
74mail_filter="(UNSEEN)",
75not_found_mode="warn"
76)
```
Fails with:
```
[...]
mail_body_str = mail_body.decode("utf-8") # type: ignore
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfc in position 8269:
invalid start byte
```
https://airflow.apache.org/docs/apache-airflow-providers-imap/stable/_modules/airflow/providers/imap/hooks/imap.html#ImapHook.retrieve_mail_attachments
```
def _fetch_mail_body(self, mail_id: str) -> str:
if not self.mail_client:
raise Exception("The 'mail_client' should be initialized
before!")
_, data = self.mail_client.fetch(mail_id, "(RFC822)")
mail_body = data[0][1] # type: ignore # The mail body is always in
this specific location
mail_body_str = mail_body.decode("utf-8") # type: ignore
return mail_body_str
```
This PR makes the encoding configurable.
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Make ImapHook mail body encoding configurable [airflow]
boring-cyborg[bot] commented on PR #37517: URL: https://github.com/apache/airflow/pull/37517#issuecomment-1951215920 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better . In case of doubts contact the developers at: Mailing List: d...@airflow.apache.org Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
