Re: [PR] Rename model `ImportError` to `ParseImportError` for avoid shadowing with builtin exception [airflow]

2024-04-19 Thread via GitHub


hussein-awala merged PR #39116:
URL: https://github.com/apache/airflow/pull/39116


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Rename model `ImportError` to `ParseImportError` for avoid shadowing with builtin exception [airflow]

2024-04-18 Thread via GitHub


Taragolis opened a new pull request, #39116:
URL: https://github.com/apache/airflow/pull/39116

   
   
   
   
   I guess better not to use same name as it defined in python builtins.
   This also remove limitation in case if we need to use both model and 
exception in the same module, so we do not need to use one of the tricks
   
   ```python
   from airflow.models import errors
   
   ...
   
   errors.ImportError(...)
   ```
   
   or 
   
   ```python
   from airflow.models.errors import ImportError as IE
   
   ...
   
   IE(...)
   ```
   
   
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org