Re: [PR] add templated field support for extra containers [airflow]

[via GitHub]

mg-aik commented on PR #38510:
URL: https://github.com/apache/airflow/pull/38510#issuecomment-2048575212

   Finally, I have been waiting for this one!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] add templated field support for extra containers [airflow]

[via GitHub]

eladkal merged PR #38510:
URL: https://github.com/apache/airflow/pull/38510


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] add templated field support for extra containers [airflow]

[via GitHub]

romsharon98 commented on code in PR #38510:
URL: https://github.com/apache/airflow/pull/38510#discussion_r1545621725


##
chart/templates/dag-processor/dag-processor-deployment.yaml:
##
@@ -227,7 +227,7 @@ spec:
 {{- end }}
   {{- end }}
 {{- if .Values.dagProcessor.extraContainers }}
-  {{- toYaml .Values.dagProcessor.extraContainers | nindent 8 }}
+  {{- tpl (toYaml .Values.dagProcessor.extraContainers) . | nindent 8 
}}

Review Comment:
   I understand what u saying and it sound correct but when swapping it I get 
an error.
   Also when looking at the chart the order is like I did and not like u 
suggest.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] add templated field support for extra containers [airflow]

[via GitHub]

Avihais12344 commented on code in PR #38510:
URL: https://github.com/apache/airflow/pull/38510#discussion_r1544482974


##
chart/templates/dag-processor/dag-processor-deployment.yaml:
##
@@ -227,7 +227,7 @@ spec:
 {{- end }}
   {{- end }}
 {{- if .Values.dagProcessor.extraContainers }}
-  {{- toYaml .Values.dagProcessor.extraContainers | nindent 8 }}
+  {{- tpl (toYaml .Values.dagProcessor.extraContainers) . | nindent 8 
}}

Review Comment:
   Don't you need to template first and then convert to YAML?
   
   ```suggestion
 {{- toYaml (tpl .Values.dagProcessor.extraContainers) . | nindent 
8 }}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] add templated field support for extra containers [airflow]

[via GitHub]

romsharon98 opened a new pull request, #38510:
URL: https://github.com/apache/airflow/pull/38510

   closed: https://github.com/apache/airflow/issues/38154
   
   
   
   
   
   
   
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org