Re: [PR] fix: try002 for provider amazon [airflow]
Taragolis merged PR #38789: URL: https://github.com/apache/airflow/pull/38789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: try002 for provider amazon [airflow]
dondaum commented on PR #38789: URL: https://github.com/apache/airflow/pull/38789#issuecomment-2041200553 > Could you merge main? Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: try002 for provider amazon [airflow]
hussein-awala commented on PR #38789: URL: https://github.com/apache/airflow/pull/38789#issuecomment-2041183389 Could you merge main? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: try002 for provider amazon [airflow]
dondaum commented on code in PR #38789:
URL: https://github.com/apache/airflow/pull/38789#discussion_r1554420630
##
airflow/providers/amazon/aws/operators/emr.py:
##
@@ -576,7 +576,7 @@ def __init__(
stacklevel=2,
)
if max_polling_attempts and max_polling_attempts != max_tries:
-raise Exception("max_polling_attempts must be the same value
as max_tries")
+raise RuntimeError("max_polling_attempts must be the same
value as max_tries")
Review Comment:
Changed to `ValueError `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] fix: try002 for provider amazon [airflow]
o-nikolas commented on code in PR #38789:
URL: https://github.com/apache/airflow/pull/38789#discussion_r1554395424
##
airflow/providers/amazon/aws/operators/emr.py:
##
@@ -576,7 +576,7 @@ def __init__(
stacklevel=2,
)
if max_polling_attempts and max_polling_attempts != max_tries:
-raise Exception("max_polling_attempts must be the same value
as max_tries")
+raise RuntimeError("max_polling_attempts must be the same
value as max_tries")
Review Comment:
Maybe `ValueError` since we're validating the value of these arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] fix: try002 for provider amazon [airflow]
dondaum opened a new pull request, #38789:
URL: https://github.com/apache/airflow/pull/38789
related: #38761
fix TRY002 for provider amazon
###
[amazon](https://github.com/apache/airflow/tree/main/airflow/providers/amazon)
- [x] airflow/providers/amazon/aws/operators/athena.py
- [x] airflow/providers/amazon/aws/operators/emr.py
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
