[
https://issues.apache.org/jira/browse/AIRFLOW-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731758#comment-16731758
]
ASF GitHub Bot commented on AIRFLOW-3610:
-
danabananarama commented on pull request #4418: [AIRFLOW-3610] Add region param
for EMR jobflow creation
URL: https://github.com/apache/incubator-airflow/pull/4418
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-3610
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
This PR is to allow setting the AWS region in the `EmrCreateJobFlowOperator`
so that we can create an EMR job flow in any region.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Amending
[test](https://github.com/danabananarama/incubator-airflow/blob/c451cedc3b760059c04293b25772c42db7917f10/tests/contrib/operators/test_emr_create_job_flow_operator.py#L81),
did not add new test for functionality as it's essentially just persisting a
new init param. Let me know if a new test needs to be added!
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [X] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set AWS Region when creating an EMR job flow via EmrCreateJobFlowOperator
> -
>
> Key: AIRFLOW-3610
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3610
> Project: Apache Airflow
> Issue Type: Improvement
> Components: aws
>Affects Versions: 1.10.0
>Reporter: Dana Ma
>Assignee: Dana Ma
>Priority: Minor
>
> The EmrCreateJobFlowOperator currently does not accept AWS region name as a
> parameter, so the only option is to create the EMR job flows in the default
> region. We would like to be able to set the AWS region for which we create
> the job flow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
