[jira] [Commented] (AIRFLOW-4316) Keys/Variable names in the 'kubernetes_environment_variables' section are transformed to lower case
[ https://issues.apache.org/jira/browse/AIRFLOW-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944339#comment-16944339 ] ASF GitHub Bot commented on AIRFLOW-4316: - ashb commented on pull request #5379: AIRFLOW-4316 Don't make automatically lower case every variable from … URL: https://github.com/apache/airflow/pull/5379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Keys/Variable names in the 'kubernetes_environment_variables' section are > transformed to lower case > --- > > Key: AIRFLOW-4316 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4316 > Project: Apache Airflow > Issue Type: Improvement > Components: configuration, contrib >Affects Versions: 1.10.3 >Reporter: Vlad Precup >Assignee: QP Hou >Priority: Major > Labels: configuration, kubernetes > Fix For: 1.10.5 > > Original Estimate: 24h > Remaining Estimate: 24h > > All the environment variable names declared under the > kubernetes_environment_variables section are converted to lowercase in the > newly generated pods when running Airflow with the KubernetesExecutor in > version 1.10.3. > The behavior is not aligned with the comments in the documentation / code > comments in the default config file, airflow.cfg. > Investigation helper: > Since we are treating all the sections uniformly in the configuration > component, all the keys are lowered (i.e. `configuration.py`, line 342 ->`key > = env_var.replace(section_prefix, '').lower()`) > Please also write (a) unit test(s) for this special case. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-4316) Keys/Variable names in the 'kubernetes_environment_variables' section are transformed to lower case
[ https://issues.apache.org/jira/browse/AIRFLOW-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918663#comment-16918663 ] ASF subversion and git services commented on AIRFLOW-4316: -- Commit 1a2c8f285181a3cc120410759aa84d1400e1c4ab in airflow's branch refs/heads/v1-10-test from Qingping Hou [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=1a2c8f2 ] [AIRFLOW-4316] support setting kubernetes_environment_variables config section from env var (#5668) When AIRFLOW_KUBERNETES_ENVIRONMENT_VARIABLES__AIRFLOW_HOME is set in the scheduler, AIRFLOW_HOME should be set for workers, not airflow_home. (cherry picked from commit bffc0c9ceccbd201094cbe129b4731c87d20286a) > Keys/Variable names in the 'kubernetes_environment_variables' section are > transformed to lower case > --- > > Key: AIRFLOW-4316 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4316 > Project: Apache Airflow > Issue Type: Bug > Components: configuration, contrib >Affects Versions: 1.10.3 >Reporter: Vlad Precup >Assignee: QP Hou >Priority: Major > Labels: configuration, kubernetes > Fix For: 1.10.5 > > Original Estimate: 24h > Remaining Estimate: 24h > > All the environment variable names declared under the > kubernetes_environment_variables section are converted to lowercase in the > newly generated pods when running Airflow with the KubernetesExecutor in > version 1.10.3. > The behavior is not aligned with the comments in the documentation / code > comments in the default config file, airflow.cfg. > Investigation helper: > Since we are treating all the sections uniformly in the configuration > component, all the keys are lowered (i.e. `configuration.py`, line 342 ->`key > = env_var.replace(section_prefix, '').lower()`) > Please also write (a) unit test(s) for this special case. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-4316) Keys/Variable names in the 'kubernetes_environment_variables' section are transformed to lower case
[ https://issues.apache.org/jira/browse/AIRFLOW-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914142#comment-16914142 ] ASF subversion and git services commented on AIRFLOW-4316: -- Commit bffc0c9ceccbd201094cbe129b4731c87d20286a in airflow's branch refs/heads/master from Qingping Hou [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=bffc0c9 ] [AIRFLOW-4316] support setting kubernetes_environment_variables config section from env var (#5668) When AIRFLOW_KUBERNETES_ENVIRONMENT_VARIABLES__AIRFLOW_HOME is set in the scheduler, AIRFLOW_HOME should be set for workers, not airflow_home. > Keys/Variable names in the 'kubernetes_environment_variables' section are > transformed to lower case > --- > > Key: AIRFLOW-4316 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4316 > Project: Apache Airflow > Issue Type: Bug > Components: configuration, contrib >Affects Versions: 1.10.3 >Reporter: Vlad Precup >Assignee: QP Hou >Priority: Major > Labels: configuration, kubernetes > Fix For: 2.0.0 > > Original Estimate: 24h > Remaining Estimate: 24h > > All the environment variable names declared under the > kubernetes_environment_variables section are converted to lowercase in the > newly generated pods when running Airflow with the KubernetesExecutor in > version 1.10.3. > The behavior is not aligned with the comments in the documentation / code > comments in the default config file, airflow.cfg. > Investigation helper: > Since we are treating all the sections uniformly in the configuration > component, all the keys are lowered (i.e. `configuration.py`, line 342 ->`key > = env_var.replace(section_prefix, '').lower()`) > Please also write (a) unit test(s) for this special case. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-4316) Keys/Variable names in the 'kubernetes_environment_variables' section are transformed to lower case
[ https://issues.apache.org/jira/browse/AIRFLOW-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914141#comment-16914141 ] ASF GitHub Bot commented on AIRFLOW-4316: - ashb commented on pull request #5668: [AIRFLOW-4316] support setting kubernetes_environment_variables config section from env var URL: https://github.com/apache/airflow/pull/5668 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Keys/Variable names in the 'kubernetes_environment_variables' section are > transformed to lower case > --- > > Key: AIRFLOW-4316 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4316 > Project: Apache Airflow > Issue Type: Bug > Components: configuration, contrib >Affects Versions: 1.10.3 >Reporter: Vlad Precup >Assignee: QP Hou >Priority: Major > Labels: configuration, kubernetes > Fix For: 2.0.0 > > Original Estimate: 24h > Remaining Estimate: 24h > > All the environment variable names declared under the > kubernetes_environment_variables section are converted to lowercase in the > newly generated pods when running Airflow with the KubernetesExecutor in > version 1.10.3. > The behavior is not aligned with the comments in the documentation / code > comments in the default config file, airflow.cfg. > Investigation helper: > Since we are treating all the sections uniformly in the configuration > component, all the keys are lowered (i.e. `configuration.py`, line 342 ->`key > = env_var.replace(section_prefix, '').lower()`) > Please also write (a) unit test(s) for this special case. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-4316) Keys/Variable names in the 'kubernetes_environment_variables' section are transformed to lower case
[
https://issues.apache.org/jira/browse/AIRFLOW-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857453#comment-16857453
]
ASF GitHub Bot commented on AIRFLOW-4316:
-
mppetkov commented on pull request #5379: AIRFLOW-4316 Don't make automatically
lower case every variable from …
URL: https://github.com/apache/airflow/pull/5379
…the config
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4316
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Keys/Variable names in the 'kubernetes_environment_variables' section are
> transformed to lower case
> ---
>
> Key: AIRFLOW-4316
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4316
> Project: Apache Airflow
> Issue Type: Bug
> Components: configuration, contrib
>Affects Versions: 1.10.3
>Reporter: Vlad Precup
>Priority: Major
> Labels: configuration, kubernetes
> Fix For: 1.10.4
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> All the environment variable names declared under the
> kubernetes_environment_variables section are converted to lowercase in the
> newly generated pods when running Airflow with the KubernetesExecutor in
> version 1.10.3.
> The behavior is not aligned with the comments in the documentation / code
> comments in the default config file, airflow.cfg.
> Investigation helper:
> Since we are treating all the sections uniformly in the configuration
> component, all the keys are lowered (i.e. `configuration.py`, line 342 ->`key
> = env_var.replace(section_prefix, '').lower()`)
> Please also write (a) unit test(s) for this special case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
