[jira] [Commented] (AIRFLOW-4509) SubDagOperator using scheduler instead of backfill
[ https://issues.apache.org/jira/browse/AIRFLOW-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031310#comment-17031310 ] Chinmay Joshi commented on AIRFLOW-4509: Hi [~milton0825], I see that today the code in master is very different from the code when you had made this commit. We are currently on latest released version (1.10.7). Will this commit be portable to our current code base? We are actually facing deadlocks in SubDAGs ([AIRFLOW-2516|https://issues.apache.org/jira/browse/AIRFLOW-2516]), and thinking if we could change the way it is scheduled. Could you please let us know? Thank you. > SubDagOperator using scheduler instead of backfill > -- > > Key: AIRFLOW-4509 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4509 > Project: Apache Airflow > Issue Type: New Feature > Components: scheduler >Affects Versions: 1.10.3 >Reporter: Chao-Han Tsai >Assignee: Chao-Han Tsai >Priority: Major > Fix For: 2.0.0 > > > Make SubDagOperator use Airflow scheduler instead of backfill to schedule > tasks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-4509) SubDagOperator using scheduler instead of backfill
[ https://issues.apache.org/jira/browse/AIRFLOW-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902410#comment-16902410 ] ASF subversion and git services commented on AIRFLOW-4509: -- Commit 0be39219cd058ba7d50cdf34b2cc46513f4f5ab3 in airflow's branch refs/heads/master from Chao-Han Tsai [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=0be3921 ] [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill (#5498) Change SubDagOperator to use Airflow scheduler to schedule tasks in subdags instead of backfill. In the past, SubDagOperator relies on backfill scheduler to schedule tasks in the subdags. Tasks in parent DAG are scheduled via Airflow scheduler while tasks in a subdag are scheduled via backfill, which complicates the scheduling logic and adds difficulties to maintain the two scheduling code path. This PR simplifies how tasks in subdags are scheduled. SubDagOperator is reponsible for creating a DagRun for subdag and wait until all the tasks in the subdag finish. Airflow scheduler picks up the DagRun created by SubDagOperator, create andschedule the tasks accordingly. > SubDagOperator using scheduler instead of backfill > -- > > Key: AIRFLOW-4509 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4509 > Project: Apache Airflow > Issue Type: New Feature > Components: scheduler >Affects Versions: 1.10.3 >Reporter: Chao-Han Tsai >Assignee: Chao-Han Tsai >Priority: Major > Fix For: 1.10.5 > > > Make SubDagOperator use Airflow scheduler instead of backfill to schedule > tasks. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (AIRFLOW-4509) SubDagOperator using scheduler instead of backfill
[ https://issues.apache.org/jira/browse/AIRFLOW-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902409#comment-16902409 ] ASF GitHub Bot commented on AIRFLOW-4509: - potiuk commented on pull request #5498: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill URL: https://github.com/apache/airflow/pull/5498 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SubDagOperator using scheduler instead of backfill > -- > > Key: AIRFLOW-4509 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4509 > Project: Apache Airflow > Issue Type: New Feature > Components: scheduler >Affects Versions: 1.10.3 >Reporter: Chao-Han Tsai >Assignee: Chao-Han Tsai >Priority: Major > Fix For: 1.10.5 > > > Make SubDagOperator use Airflow scheduler instead of backfill to schedule > tasks. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (AIRFLOW-4509) SubDagOperator using scheduler instead of backfill
[
https://issues.apache.org/jira/browse/AIRFLOW-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874272#comment-16874272
]
ASF GitHub Bot commented on AIRFLOW-4509:
-
milton0825 commented on pull request #5498: [AIRFLOW-4509] SubDagOperator using
scheduler instead of backfill
URL: https://github.com/apache/airflow/pull/5498
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4509
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
Change `SubDagOperator` to use Airflow scheduler to schedule
tasks in subdags instead of backfill.
In the past, `SubDagOperator` relies on backfill scheduler
to schedule tasks in the subdags. Tasks in parent `DAG`
are scheduled via Airflow scheduler while tasks in
a subdag are scheduled via backfill, which complicates
the scheduling logic and adds difficulties to maintain
the two scheduling code path.
This PR simplifies how tasks in subdags are scheduled.
`SubDagOperator` is responsible for creating a DagRun for subdag
and wait until all the tasks in the subdag finish. Airflow
scheduler picks up the DagRun created by SubDagOperator,
create and schedule the tasks accordingly.
Although `SubDagOperator` can occupy a pool/concurrency slot,
user can specify the `mode=reschedule` so that the slot will be
released periodically to avoid potential deadlock.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [X] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SubDagOperator using scheduler instead of backfill
> --
>
> Key: AIRFLOW-4509
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4509
> Project: Apache Airflow
> Issue Type: New Feature
> Components: scheduler
>Reporter: Chao-Han Tsai
>Assignee: Chao-Han Tsai
>Priority: Major
>
> Make SubDagOperator use Airflow scheduler instead of backfill to schedule
> tasks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4509) SubDagOperator using scheduler instead of backfill
[ https://issues.apache.org/jira/browse/AIRFLOW-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874274#comment-16874274 ] ASF GitHub Bot commented on AIRFLOW-4509: - milton0825 commented on pull request #5493: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill URL: https://github.com/apache/airflow/pull/5493 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SubDagOperator using scheduler instead of backfill > -- > > Key: AIRFLOW-4509 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4509 > Project: Apache Airflow > Issue Type: New Feature > Components: scheduler >Reporter: Chao-Han Tsai >Assignee: Chao-Han Tsai >Priority: Major > > Make SubDagOperator use Airflow scheduler instead of backfill to schedule > tasks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4509) SubDagOperator using scheduler instead of backfill
[
https://issues.apache.org/jira/browse/AIRFLOW-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873866#comment-16873866
]
ASF GitHub Bot commented on AIRFLOW-4509:
-
milton0825 commented on pull request #5493: [AIRFLOW-4509] SubDagOperator using
scheduler instead of backfill
URL: https://github.com/apache/airflow/pull/5493
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4509
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
Change `SubDagOperator` to use Airflow scheduler to schedule
tasks in subdags instead of backfill.
In the past, `SubDagOperator` relies on backfill scheduler
to schedule tasks in the subdags. Tasks in parent `DAG`
are scheduled via Airflow scheduler while tasks in
a subdag are scheduled via backfill, which complicates
the scheduling logic and adds difficulties to maintain
the two scheduling code path.
This PR simplifies how tasks in subdags are scheduled.
`SubDagOperator` is responsible for creating a DagRun for subdag
and wait until all the tasks in the subdag finish. Airflow
scheduler picks up the DagRun created by SubDagOperator,
create and schedule the tasks accordingly.
Although `SubDagOperator` can occupy a pool/concurrency slot,
user can specify the `mode=reschedule` so that the slot will be
released periodically to avoid potential deadlock.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [X] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SubDagOperator using scheduler instead of backfill
> --
>
> Key: AIRFLOW-4509
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4509
> Project: Apache Airflow
> Issue Type: New Feature
> Components: scheduler
>Reporter: Chao-Han Tsai
>Assignee: Chao-Han Tsai
>Priority: Major
>
> Make SubDagOperator use Airflow scheduler instead of backfill to schedule
> tasks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4509) SubDagOperator using scheduler instead of backfill
[ https://issues.apache.org/jira/browse/AIRFLOW-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873867#comment-16873867 ] ASF GitHub Bot commented on AIRFLOW-4509: - milton0825 commented on pull request #5492: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill URL: https://github.com/apache/airflow/pull/5492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SubDagOperator using scheduler instead of backfill > -- > > Key: AIRFLOW-4509 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4509 > Project: Apache Airflow > Issue Type: New Feature > Components: scheduler >Reporter: Chao-Han Tsai >Assignee: Chao-Han Tsai >Priority: Major > > Make SubDagOperator use Airflow scheduler instead of backfill to schedule > tasks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4509) SubDagOperator using scheduler instead of backfill
[
https://issues.apache.org/jira/browse/AIRFLOW-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873812#comment-16873812
]
ASF GitHub Bot commented on AIRFLOW-4509:
-
milton0825 commented on pull request #5492: [AIRFLOW-4509] SubDagOperator using
scheduler instead of backfill
URL: https://github.com/apache/airflow/pull/5492
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4509
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
Change `SubDagOperator` to use Airflow scheduler to schedule
tasks in subdags instead of backfill.
In the past, `SubDagOperator` relies on backfill scheduler
to schedule tasks in the subdags. Tasks in parent `DAG`
are scheduled via Airflow scheduler while tasks in
a subdag are scheduled via backfill, which complicates
the scheduling logic and adds difficulties to maintain
the two scheduling code path.
This PR simplifies how tasks in subdags are scheduled.
`SubDagOperator` is responsible for creating a DagRun for subdag
and wait until all the tasks in the subdag finish. Airflow
scheduler picks up the DagRun created by SubDagOperator,
create and schedule the tasks accordingly.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [X] Passes `flake8`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SubDagOperator using scheduler instead of backfill
> --
>
> Key: AIRFLOW-4509
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4509
> Project: Apache Airflow
> Issue Type: New Feature
> Components: scheduler
>Reporter: Chao-Han Tsai
>Assignee: Chao-Han Tsai
>Priority: Major
>
> Make SubDagOperator use Airflow scheduler instead of backfill to schedule
> tasks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AIRFLOW-4509) SubDagOperator using scheduler instead of backfill
[ https://issues.apache.org/jira/browse/AIRFLOW-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859116#comment-16859116 ] ASF GitHub Bot commented on AIRFLOW-4509: - milton0825 commented on pull request #5279: [AIRFLOW-4509] SubDagOperator using scheduler instead of backfill URL: https://github.com/apache/airflow/pull/5279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SubDagOperator using scheduler instead of backfill > -- > > Key: AIRFLOW-4509 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4509 > Project: Apache Airflow > Issue Type: New Feature > Components: scheduler >Reporter: Chao-Han Tsai >Assignee: Chao-Han Tsai >Priority: Major > > Make SubDagOperator use Airflow scheduler instead of backfill to schedule > tasks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
