[jira] [Commented] (AIRFLOW-5501) in_cluster default value in KubernetesPodOperator overwrites configuration
[
https://issues.apache.org/jira/browse/AIRFLOW-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028392#comment-17028392
]
ASF subversion and git services commented on AIRFLOW-5501:
--
Commit 645e021303ad460ebca213ae5de56ba787c328f4 in airflow's branch
refs/heads/v1-10-test from Kaxil Naik
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=645e021 ]
[AIRFLOW-5501] Make default `in_cluster` value in KubernetesPodOperator respect
config (#6124)
(cherry-picked from e54fba5b4)
> in_cluster default value in KubernetesPodOperator overwrites configuration
> --
>
> Key: AIRFLOW-5501
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5501
> Project: Apache Airflow
> Issue Type: Bug
> Components: contrib
>Affects Versions: 1.10.5
>Reporter: Quentin Lemaire
>Priority: Major
> Fix For: 1.10.8
>
>
> Hi!
> The default value of the parameter *in_cluster* of the
> *kube_client.get_kube_client* function is
> *in_cluster=conf.getboolean('kubernetes', 'in_cluster').* Therefore, the
> expected behavior is that when, *in_cluster* is not set, it takes the value
> in the configuration file.
> However, the default value of *in_cluster* in *KubernetesPodOperator.py* is
> False and *in_cluster* is passed as a parameter when calling the
> *kube_client.get_kube_client* function. Therefore, it changes the expecting
> behavior by overwritting the default value. When *in_cluster* is not set when
> initializing *KubernetesPodOperator*, the value of *in_cluster* in
> *kube_client.get_kube_client* is False and not the value which is in the
> configuration file.
> It is quite confusing because it can feel like the value in the configuration
> file is not working properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5501) in_cluster default value in KubernetesPodOperator overwrites configuration
[
https://issues.apache.org/jira/browse/AIRFLOW-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022409#comment-17022409
]
ASF subversion and git services commented on AIRFLOW-5501:
--
Commit 645e021303ad460ebca213ae5de56ba787c328f4 in airflow's branch
refs/heads/v1-10-test from Kaxil Naik
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=645e021 ]
[AIRFLOW-5501] Make default `in_cluster` value in KubernetesPodOperator respect
config (#6124)
(cherry-picked from e54fba5b4)
> in_cluster default value in KubernetesPodOperator overwrites configuration
> --
>
> Key: AIRFLOW-5501
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5501
> Project: Apache Airflow
> Issue Type: Bug
> Components: contrib
>Affects Versions: 1.10.5
>Reporter: Quentin Lemaire
>Priority: Major
> Fix For: 1.10.8
>
>
> Hi!
> The default value of the parameter *in_cluster* of the
> *kube_client.get_kube_client* function is
> *in_cluster=conf.getboolean('kubernetes', 'in_cluster').* Therefore, the
> expected behavior is that when, *in_cluster* is not set, it takes the value
> in the configuration file.
> However, the default value of *in_cluster* in *KubernetesPodOperator.py* is
> False and *in_cluster* is passed as a parameter when calling the
> *kube_client.get_kube_client* function. Therefore, it changes the expecting
> behavior by overwritting the default value. When *in_cluster* is not set when
> initializing *KubernetesPodOperator*, the value of *in_cluster* in
> *kube_client.get_kube_client* is False and not the value which is in the
> configuration file.
> It is quite confusing because it can feel like the value in the configuration
> file is not working properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5501) in_cluster default value in KubernetesPodOperator overwrites configuration
[
https://issues.apache.org/jira/browse/AIRFLOW-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017306#comment-17017306
]
ASF subversion and git services commented on AIRFLOW-5501:
--
Commit e54fba5b479e36ecad6afb8d3920a534af6e6135 in airflow's branch
refs/heads/master from Quentin Lemaire
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=e54fba5 ]
[AIRFLOW-5501] Make default `in_cluster` value in KubernetesPodOperator respect
config (#6124)
The default value of the parameter in_cluster of the
kube_client.get_kube_client function is
in_cluster=conf.getboolean('kubernetes', 'in_cluster'). Therefore, the
expected behavior is that when, in_cluster is not set, it takes the
value in the configuration file.
However, the default value of in_cluster in KubernetesPodOperator.py is
False and in_cluster is passed as a parameter when calling the
kube_client.get_kube_client function. Therefore, it changes the
expecting behavior by overwritting the default value. When in_cluster is
not set when initializing KubernetesPodOperator, the value of in_cluster
in kube_client.get_kube_client is False and not the value which is in
the configuration file.
Therefore, the default value of in_cluster in KubernetesPodOperator has
been changed to None and will not be passed to get_kube_client if it is
not overwritten so that it takes the configuration value as a default
value.
Co-authored-by: Ash Berlin-Taylor
> in_cluster default value in KubernetesPodOperator overwrites configuration
> --
>
> Key: AIRFLOW-5501
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5501
> Project: Apache Airflow
> Issue Type: Bug
> Components: contrib
>Affects Versions: 1.10.5
>Reporter: Quentin Lemaire
>Priority: Major
> Fix For: 1.10.8
>
>
> Hi!
> The default value of the parameter *in_cluster* of the
> *kube_client.get_kube_client* function is
> *in_cluster=conf.getboolean('kubernetes', 'in_cluster').* Therefore, the
> expected behavior is that when, *in_cluster* is not set, it takes the value
> in the configuration file.
> However, the default value of *in_cluster* in *KubernetesPodOperator.py* is
> False and *in_cluster* is passed as a parameter when calling the
> *kube_client.get_kube_client* function. Therefore, it changes the expecting
> behavior by overwritting the default value. When *in_cluster* is not set when
> initializing *KubernetesPodOperator*, the value of *in_cluster* in
> *kube_client.get_kube_client* is False and not the value which is in the
> configuration file.
> It is quite confusing because it can feel like the value in the configuration
> file is not working properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5501) in_cluster default value in KubernetesPodOperator overwrites configuration
[
https://issues.apache.org/jira/browse/AIRFLOW-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017305#comment-17017305
]
ASF GitHub Bot commented on AIRFLOW-5501:
-
ashb commented on pull request #6124: [AIRFLOW-5501] in_cluster default value
in KubernetesPodOperator overwrites configuration
URL: https://github.com/apache/airflow/pull/6124
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> in_cluster default value in KubernetesPodOperator overwrites configuration
> --
>
> Key: AIRFLOW-5501
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5501
> Project: Apache Airflow
> Issue Type: Bug
> Components: contrib
>Affects Versions: 1.10.5
>Reporter: Quentin Lemaire
>Priority: Major
>
> Hi!
> The default value of the parameter *in_cluster* of the
> *kube_client.get_kube_client* function is
> *in_cluster=conf.getboolean('kubernetes', 'in_cluster').* Therefore, the
> expected behavior is that when, *in_cluster* is not set, it takes the value
> in the configuration file.
> However, the default value of *in_cluster* in *KubernetesPodOperator.py* is
> False and *in_cluster* is passed as a parameter when calling the
> *kube_client.get_kube_client* function. Therefore, it changes the expecting
> behavior by overwritting the default value. When *in_cluster* is not set when
> initializing *KubernetesPodOperator*, the value of *in_cluster* in
> *kube_client.get_kube_client* is False and not the value which is in the
> configuration file.
> It is quite confusing because it can feel like the value in the configuration
> file is not working properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5501) in_cluster default value in KubernetesPodOperator overwrites configuration
[
https://issues.apache.org/jira/browse/AIRFLOW-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015086#comment-17015086
]
ASF GitHub Bot commented on AIRFLOW-5501:
-
qlemaire22 commented on pull request #6124: [AIRFLOW-5501] in_cluster default
value in KubernetesPodOperator overwrites configuration
URL: https://github.com/apache/airflow/pull/6124
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5501
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
Hi!
The default value of the parameter in_cluster of the
kube_client.get_kube_client function is
in_cluster=conf.getboolean('kubernetes', 'in_cluster'). Therefore, the expected
behavior is that when, in_cluster is not set, it takes the value in the
configuration file.
However, the default value of in_cluster in KubernetesPodOperator.py is
False and in_cluster is passed as a parameter when calling the
kube_client.get_kube_client function. Therefore, it changes the expecting
behavior by overwritting the default value. When in_cluster is not set when
initializing KubernetesPodOperator, the value of in_cluster in
kube_client.get_kube_client is False and not the value which is in the
configuration file.
It is quite confusing because it can feel like the value in the
configuration file is not working properly.
Therefore, I changed the default value of the in_cluster parameter in
KubernetesPodOperator so that it takes the value of the configuration file as a
default and expected value instead of False as it is now.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> in_cluster default value in KubernetesPodOperator overwrites configuration
> --
>
> Key: AIRFLOW-5501
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5501
> Project: Apache Airflow
> Issue Type: Bug
> Components: contrib
>Affects Versions: 1.10.5
>Reporter: Quentin Lemaire
>Priority: Major
>
> Hi!
> The default value of the parameter *in_cluster* of the
> *kube_client.get_kube_client* function is
> *in_cluster=conf.getboolean('kubernetes', 'in_cluster').* Therefore, the
> expected behavior is that when, *in_cluster* is not set, it takes the value
> in the configuration file.
> However, the default value of *in_cluster* in *KubernetesPodOperator.py* is
> False and *in_cluster* is passed as a parameter when calling the
> *kube_client.get_kube_client* function. Therefore, it changes the expecting
> behavior by overwritting the default value. When *in_cluster* is not set when
> initializing *KubernetesPodOperator*, the value of *in_cluster* in
> *kube_client.get_kube_client* is False and not the value which is in the
> configuration file.
> It is quite confusing because it can feel like the value in the configuration
> file is not working properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5501) in_cluster default value in KubernetesPodOperator overwrites configuration
[
https://issues.apache.org/jira/browse/AIRFLOW-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013682#comment-17013682
]
ASF GitHub Bot commented on AIRFLOW-5501:
-
stale[bot] commented on pull request #6124: [AIRFLOW-5501] in_cluster default
value in KubernetesPodOperator overwrites configuration
URL: https://github.com/apache/airflow/pull/6124
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> in_cluster default value in KubernetesPodOperator overwrites configuration
> --
>
> Key: AIRFLOW-5501
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5501
> Project: Apache Airflow
> Issue Type: Bug
> Components: contrib
>Affects Versions: 1.10.5
>Reporter: Quentin Lemaire
>Priority: Major
>
> Hi!
> The default value of the parameter *in_cluster* of the
> *kube_client.get_kube_client* function is
> *in_cluster=conf.getboolean('kubernetes', 'in_cluster').* Therefore, the
> expected behavior is that when, *in_cluster* is not set, it takes the value
> in the configuration file.
> However, the default value of *in_cluster* in *KubernetesPodOperator.py* is
> False and *in_cluster* is passed as a parameter when calling the
> *kube_client.get_kube_client* function. Therefore, it changes the expecting
> behavior by overwritting the default value. When *in_cluster* is not set when
> initializing *KubernetesPodOperator*, the value of *in_cluster* in
> *kube_client.get_kube_client* is False and not the value which is in the
> configuration file.
> It is quite confusing because it can feel like the value in the configuration
> file is not working properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5501) in_cluster default value in KubernetesPodOperator overwrites configuration
[
https://issues.apache.org/jira/browse/AIRFLOW-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930491#comment-16930491
]
ASF GitHub Bot commented on AIRFLOW-5501:
-
qlemaire22 commented on pull request #6124: [AIRFLOW-5501] in_cluster default
value in KubernetesPodOperator overwrites configuration
URL: https://github.com/apache/airflow/pull/6124
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5501
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
Hi!
The default value of the parameter in_cluster of the
kube_client.get_kube_client function is
in_cluster=conf.getboolean('kubernetes', 'in_cluster'). Therefore, the expected
behavior is that when, in_cluster is not set, it takes the value in the
configuration file.
However, the default value of in_cluster in KubernetesPodOperator.py is
False and in_cluster is passed as a parameter when calling the
kube_client.get_kube_client function. Therefore, it changes the expecting
behavior by overwritting the default value. When in_cluster is not set when
initializing KubernetesPodOperator, the value of in_cluster in
kube_client.get_kube_client is False and not the value which is in the
configuration file.
It is quite confusing because it can feel like the value in the
configuration file is not working properly.
Therefore, I changed the default value of the in_cluster parameter for the
KubernetesPodOperator so that it takes the value of the configuration file as a
default and expected value instead of False.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> in_cluster default value in KubernetesPodOperator overwrites configuration
> --
>
> Key: AIRFLOW-5501
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5501
> Project: Apache Airflow
> Issue Type: Bug
> Components: contrib
>Affects Versions: 1.10.5
>Reporter: Quentin Lemaire
>Priority: Major
>
> Hi!
> The default value of the parameter *in_cluster* of the
> *kube_client.get_kube_client* function is
> *in_cluster=conf.getboolean('kubernetes', 'in_cluster').* Therefore, the
> expected behavior is that when, *in_cluster* is not set, it takes the value
> in the configuration file.
> However, the default value of *in_cluster* in *KubernetesPodOperator.py* is
> False and *in_cluster* is passed as a parameter when calling the
> *kube_client.get_kube_client* function. Therefore, it changes the expecting
> behavior by overwritting the default value. When *in_cluster* is not set when
> initializing *KubernetesPodOperator*, the value of *in_cluster* in
> *kube_client.get_kube_client* is False and not the value which is in the
> configuration file.
> It is quite confusing because it can feel like the value in the configuration
> file is not working properly.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
