[jira] [Commented] (AIRFLOW-5662) Scheduler incorrectly emits occupied slots count metric as used slot count
[ https://issues.apache.org/jira/browse/AIRFLOW-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078914#comment-17078914 ] ASF GitHub Bot commented on AIRFLOW-5662: - zhongjiajie commented on pull request #6342: [AIRFLOW-5662] Reduce DB queries used to emit pool usage metrics URL: https://github.com/apache/airflow/pull/6342 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Scheduler incorrectly emits occupied slots count metric as used slot count > -- > > Key: AIRFLOW-5662 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5662 > Project: Apache Airflow > Issue Type: Bug > Components: scheduler >Affects Versions: 2.0.0 >Reporter: QP Hou >Assignee: QP Hou >Priority: Trivial > > Value of pool.used_slots metric is actually occupied slot count. There is > also a redundant SQL query to the database that can be removed in that loop. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5662) Scheduler incorrectly emits occupied slots count metric as used slot count
[ https://issues.apache.org/jira/browse/AIRFLOW-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078916#comment-17078916 ] ASF subversion and git services commented on AIRFLOW-5662: -- Commit 6c79b097d6e15b9c445e61d3b720219212e3a999 in airflow's branch refs/heads/master from QP Hou [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=6c79b09 ] [AIRFLOW-5662] Reduce DB queries used to emit pool usage metrics (#6342) * [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics * report used slots value for used slots metrics (was sending occupied_slots) * move global scheduler metrics calculation and reporting outside of pool loop * optimize pool slots metrics report into constant time Co-authored-by: Ash Berlin-Taylor > Scheduler incorrectly emits occupied slots count metric as used slot count > -- > > Key: AIRFLOW-5662 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5662 > Project: Apache Airflow > Issue Type: Bug > Components: scheduler >Affects Versions: 2.0.0 >Reporter: QP Hou >Assignee: QP Hou >Priority: Trivial > > Value of pool.used_slots metric is actually occupied slot count. There is > also a redundant SQL query to the database that can be removed in that loop. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5662) Scheduler incorrectly emits occupied slots count metric as used slot count
[ https://issues.apache.org/jira/browse/AIRFLOW-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078915#comment-17078915 ] ASF subversion and git services commented on AIRFLOW-5662: -- Commit 6c79b097d6e15b9c445e61d3b720219212e3a999 in airflow's branch refs/heads/master from QP Hou [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=6c79b09 ] [AIRFLOW-5662] Reduce DB queries used to emit pool usage metrics (#6342) * [AIRFLOW-5662] fix incorrect naming and batch db call for scheduler metrics * report used slots value for used slots metrics (was sending occupied_slots) * move global scheduler metrics calculation and reporting outside of pool loop * optimize pool slots metrics report into constant time Co-authored-by: Ash Berlin-Taylor > Scheduler incorrectly emits occupied slots count metric as used slot count > -- > > Key: AIRFLOW-5662 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5662 > Project: Apache Airflow > Issue Type: Bug > Components: scheduler >Affects Versions: 2.0.0 >Reporter: QP Hou >Assignee: QP Hou >Priority: Trivial > > Value of pool.used_slots metric is actually occupied slot count. There is > also a redundant SQL query to the database that can be removed in that loop. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5662) Scheduler incorrectly emits occupied slots count metric as used slot count
[
https://issues.apache.org/jira/browse/AIRFLOW-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952230#comment-16952230
]
ASF GitHub Bot commented on AIRFLOW-5662:
-
houqp commented on pull request #6342: [AIRFLOW-5662] fix incorrect naming for
scheduler used slot metric
URL: https://github.com/apache/airflow/pull/6342
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5662
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
other than the naming fix, this patch also adds:
* metric collection code optimization to avoid unnecessary SQL query
* queued and occupied slots metrics
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Scheduler incorrectly emits occupied slots count metric as used slot count
> --
>
> Key: AIRFLOW-5662
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5662
> Project: Apache Airflow
> Issue Type: Bug
> Components: scheduler
>Affects Versions: 2.0.0
>Reporter: QP Hou
>Assignee: QP Hou
>Priority: Trivial
>
> Value of pool.used_slots metric is actually occupied slot count. There is
> also a redundant SQL query to the database that can be removed in that loop.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
