[jira] [Commented] (AIRFLOW-6167) Escape col name in MysqlToHive operator
[ https://issues.apache.org/jira/browse/AIRFLOW-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072170#comment-17072170 ] ASF subversion and git services commented on AIRFLOW-6167: -- Commit e85b0def44c0fd28aa5042b06349a176817ade4e in airflow's branch refs/heads/v1-10-test from Ping Zhang [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=e85b0de ] [AIRFLOW-6167] Escape column name in create table in hive (#6741) Hive query will fail if column name contains keyword, unless escaped. Fix is always escaping column name when creating table. (cherry picked from commit a1f3b29344d400aefd4a6c1f6842d2a345de) > Escape col name in MysqlToHive operator > --- > > Key: AIRFLOW-6167 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6167 > Project: Apache Airflow > Issue Type: Bug > Components: operators >Affects Versions: 1.10.4 >Reporter: Ping Zhang >Assignee: Ping Zhang >Priority: Major > Fix For: 1.10.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6167) Escape col name in MysqlToHive operator
[ https://issues.apache.org/jira/browse/AIRFLOW-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071991#comment-17071991 ] ASF subversion and git services commented on AIRFLOW-6167: -- Commit b1ab39f548745bf293bf7f5ba306f8ed85aab92e in airflow's branch refs/heads/v1-10-test from Ping Zhang [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=b1ab39f ] [AIRFLOW-6167] Escape column name in create table in hive (#6741) Hive query will fail if column name contains keyword, unless escaped. Fix is always escaping column name when creating table. (cherry picked from commit a1f3b29344d400aefd4a6c1f6842d2a345de) > Escape col name in MysqlToHive operator > --- > > Key: AIRFLOW-6167 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6167 > Project: Apache Airflow > Issue Type: Bug > Components: operators >Affects Versions: 1.10.4 >Reporter: Ping Zhang >Assignee: Ping Zhang >Priority: Major > Fix For: 1.10.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6167) Escape col name in MysqlToHive operator
[ https://issues.apache.org/jira/browse/AIRFLOW-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071388#comment-17071388 ] ASF subversion and git services commented on AIRFLOW-6167: -- Commit 81be4b5012e171691f86e1fd2fb3df48efe73548 in airflow's branch refs/heads/v1-10-test from Ping Zhang [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=81be4b5 ] [AIRFLOW-6167] Escape column name in create table in hive (#6741) Hive query will fail if column name contains keyword, unless escaped. Fix is always escaping column name when creating table. (cherry picked from commit a1f3b29344d400aefd4a6c1f6842d2a345de) > Escape col name in MysqlToHive operator > --- > > Key: AIRFLOW-6167 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6167 > Project: Apache Airflow > Issue Type: Bug > Components: operators >Affects Versions: 1.10.4 >Reporter: Ping Zhang >Assignee: Ping Zhang >Priority: Major > Fix For: 1.10.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6167) Escape col name in MysqlToHive operator
[ https://issues.apache.org/jira/browse/AIRFLOW-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990104#comment-16990104 ] ASF subversion and git services commented on AIRFLOW-6167: -- Commit a1f3b29344d400aefd4a6c1f6842d2a345de in airflow's branch refs/heads/master from Ping Zhang [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=a1f3b29 ] [AIRFLOW-6167] Escape column name in create table in hive (#6741) Hive query will fail if column name contains keyword, unless escaped. Fix is always escaping column name when creating table. > Escape col name in MysqlToHive operator > --- > > Key: AIRFLOW-6167 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6167 > Project: Apache Airflow > Issue Type: Bug > Components: operators >Affects Versions: 1.10.4 >Reporter: Ping Zhang >Assignee: Ping Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6167) Escape col name in MysqlToHive operator
[ https://issues.apache.org/jira/browse/AIRFLOW-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990103#comment-16990103 ] ASF GitHub Bot commented on AIRFLOW-6167: - KevinYang21 commented on pull request #6741: [AIRFLOW-6167] Escape column name in create table in hive URL: https://github.com/apache/airflow/pull/6741 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Escape col name in MysqlToHive operator > --- > > Key: AIRFLOW-6167 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6167 > Project: Apache Airflow > Issue Type: Bug > Components: operators >Affects Versions: 1.10.4 >Reporter: Ping Zhang >Assignee: Ping Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6167) Escape col name in MysqlToHive operator
[
https://issues.apache.org/jira/browse/AIRFLOW-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989058#comment-16989058
]
ASF GitHub Bot commented on AIRFLOW-6167:
-
pingzh commented on pull request #6741: [AIRFLOW-6167] Escape column name in
create table in hive
URL: https://github.com/apache/airflow/pull/6741
Hive query will fail if column name contains keyword, unless escaped.
Fix is always escaping column name when creating table.
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6167
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Hive query will fail if column name contains keyword, unless escaped.
Fix is always escaping column name when creating table.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
@KevinYang21
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Escape col name in MysqlToHive operator
> ---
>
> Key: AIRFLOW-6167
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6167
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
>Affects Versions: 1.10.4
>Reporter: Ping Zhang
>Assignee: Ping Zhang
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
