[jira] [Commented] (AIRFLOW-6185) SQLAlchemy Connection model schema not aligned with Alembic schema
[ https://issues.apache.org/jira/browse/AIRFLOW-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999487#comment-16999487 ] ASF subversion and git services commented on AIRFLOW-6185: -- Commit 541edc7b27d6d002c63b9ae93c6d1b5892d59aea in airflow's branch refs/heads/v1-10-test from Xinbin Huang [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=541edc7 ] [AIRFLOW-6185] SQLAlchemy Connection model schema not aligned with Alembic schema (#6754) * [AIRFLOW-6185] SQLAlchemy Connection model schema aligned with Alembic schema (cherry picked from commit e04059d88387117d85423dbfb258bbaa90220dcb) > SQLAlchemy Connection model schema not aligned with Alembic schema > -- > > Key: AIRFLOW-6185 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6185 > Project: Apache Airflow > Issue Type: Bug > Components: database >Affects Versions: 1.10.6 >Reporter: Xinbin Huang >Priority: Minor > Fix For: 1.10.7 > > Attachments: connection_schema.PNG > > > The SQLAlchemy model for the `Connection` table declare password as > `String(5000)` while Alembic migration script (i.e. `current_schema.py`) > declare password as `String(length=500)`, and the final table schema for > password is varchar(500) > * Alembic schema: > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/migrations/versions/e3a246e0dc1_current_schema.py#L54] > * models/connections.py > > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/models/connection.py#L62] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6185) SQLAlchemy Connection model schema not aligned with Alembic schema
[ https://issues.apache.org/jira/browse/AIRFLOW-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999486#comment-16999486 ] ASF subversion and git services commented on AIRFLOW-6185: -- Commit 541edc7b27d6d002c63b9ae93c6d1b5892d59aea in airflow's branch refs/heads/v1-10-test from Xinbin Huang [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=541edc7 ] [AIRFLOW-6185] SQLAlchemy Connection model schema not aligned with Alembic schema (#6754) * [AIRFLOW-6185] SQLAlchemy Connection model schema aligned with Alembic schema (cherry picked from commit e04059d88387117d85423dbfb258bbaa90220dcb) > SQLAlchemy Connection model schema not aligned with Alembic schema > -- > > Key: AIRFLOW-6185 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6185 > Project: Apache Airflow > Issue Type: Bug > Components: database >Affects Versions: 1.10.6 >Reporter: Xinbin Huang >Priority: Minor > Fix For: 1.10.7 > > Attachments: connection_schema.PNG > > > The SQLAlchemy model for the `Connection` table declare password as > `String(5000)` while Alembic migration script (i.e. `current_schema.py`) > declare password as `String(length=500)`, and the final table schema for > password is varchar(500) > * Alembic schema: > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/migrations/versions/e3a246e0dc1_current_schema.py#L54] > * models/connections.py > > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/models/connection.py#L62] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6185) SQLAlchemy Connection model schema not aligned with Alembic schema
[ https://issues.apache.org/jira/browse/AIRFLOW-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991378#comment-16991378 ] ASF subversion and git services commented on AIRFLOW-6185: -- Commit e04059d88387117d85423dbfb258bbaa90220dcb in airflow's branch refs/heads/master from Xinbin Huang [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=e04059d ] [AIRFLOW-6185] SQLAlchemy Connection model schema not aligned with Alembic schema (#6754) * [AIRFLOW-6185] SQLAlchemy Connection model schema aligned with Alembic schema > SQLAlchemy Connection model schema not aligned with Alembic schema > -- > > Key: AIRFLOW-6185 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6185 > Project: Apache Airflow > Issue Type: Bug > Components: database >Affects Versions: 1.10.6 >Reporter: Xinbin Huang >Priority: Blocker > Fix For: 2.0.0 > > Attachments: connection_schema.PNG > > > The SQLAlchemy model for the `Connection` table declare password as > `String(5000)` while Alembic migration script (i.e. `current_schema.py`) > declare password as `String(length=500)`, and the final table schema for > password is varchar(500) > * Alembic schema: > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/migrations/versions/e3a246e0dc1_current_schema.py#L54] > * models/connections.py > > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/models/connection.py#L62] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6185) SQLAlchemy Connection model schema not aligned with Alembic schema
[ https://issues.apache.org/jira/browse/AIRFLOW-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991377#comment-16991377 ] ASF subversion and git services commented on AIRFLOW-6185: -- Commit e04059d88387117d85423dbfb258bbaa90220dcb in airflow's branch refs/heads/master from Xinbin Huang [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=e04059d ] [AIRFLOW-6185] SQLAlchemy Connection model schema not aligned with Alembic schema (#6754) * [AIRFLOW-6185] SQLAlchemy Connection model schema aligned with Alembic schema > SQLAlchemy Connection model schema not aligned with Alembic schema > -- > > Key: AIRFLOW-6185 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6185 > Project: Apache Airflow > Issue Type: Bug > Components: database >Affects Versions: 1.10.6 >Reporter: Xinbin Huang >Priority: Blocker > Fix For: 2.0.0 > > Attachments: connection_schema.PNG > > > The SQLAlchemy model for the `Connection` table declare password as > `String(5000)` while Alembic migration script (i.e. `current_schema.py`) > declare password as `String(length=500)`, and the final table schema for > password is varchar(500) > * Alembic schema: > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/migrations/versions/e3a246e0dc1_current_schema.py#L54] > * models/connections.py > > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/models/connection.py#L62] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6185) SQLAlchemy Connection model schema not aligned with Alembic schema
[ https://issues.apache.org/jira/browse/AIRFLOW-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991337#comment-16991337 ] ASF GitHub Bot commented on AIRFLOW-6185: - potiuk commented on pull request #6754: [AIRFLOW-6185] SQLAlchemy Connection model schema not aligned with Alembic schema URL: https://github.com/apache/airflow/pull/6754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SQLAlchemy Connection model schema not aligned with Alembic schema > -- > > Key: AIRFLOW-6185 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6185 > Project: Apache Airflow > Issue Type: Bug > Components: database >Affects Versions: 1.10.6 >Reporter: Xinbin Huang >Priority: Blocker > Attachments: connection_schema.PNG > > > The SQLAlchemy model for the `Connection` table declare password as > `String(5000)` while Alembic migration script (i.e. `current_schema.py`) > declare password as `String(length=500)`, and the final table schema for > password is varchar(500) > * Alembic schema: > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/migrations/versions/e3a246e0dc1_current_schema.py#L54] > * models/connections.py > > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/models/connection.py#L62] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6185) SQLAlchemy Connection model schema not aligned with Alembic schema
[ https://issues.apache.org/jira/browse/AIRFLOW-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989289#comment-16989289 ] Xinbin Huang commented on AIRFLOW-6185: --- After some digging, the current migration script does not detect column changes with `COMPARE_TYPE = FALSE` in the env.py > SQLAlchemy Connection model schema not aligned with Alembic schema > -- > > Key: AIRFLOW-6185 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6185 > Project: Apache Airflow > Issue Type: Bug > Components: database >Affects Versions: 1.10.6 >Reporter: Xinbin Huang >Priority: Blocker > Attachments: connection_schema.PNG > > > The SQLAlchemy model for the `Connection` table declare password as > `String(5000)` while Alembic migration script (i.e. `current_schema.py`) > declare password as `String(length=500)`, and the final table schema for > password is varchar(500) > * Alembic schema: > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/migrations/versions/e3a246e0dc1_current_schema.py#L54] > * models/connections.py > > [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/models/connection.py#L62] -- This message was sent by Atlassian Jira (v8.3.4#803005)
