[jira] [Commented] (AIRFLOW-6195) queued_dttm is "None" on UI, and not updated when tasks requeued
[ https://issues.apache.org/jira/browse/AIRFLOW-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998547#comment-16998547 ] ASF subversion and git services commented on AIRFLOW-6195: -- Commit 285b1b2993329cb7b6bdf4e2d98ad92e7612e509 in airflow's branch refs/heads/v1-10-test from Bjorn Olsen [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=285b1b2 ] [AIRFLOW-6195] Fixed TaskInstance attrs not correct on UI (#6758) (cherry picked from commit d4a8afb5aef5b00f7c52c7ff1cc4088c8a00f4a7) > queued_dttm is "None" on UI, and not updated when tasks requeued > > > Key: AIRFLOW-6195 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6195 > Project: Apache Airflow > Issue Type: Bug > Components: ui >Affects Versions: 1.10.6 >Reporter: Bjorn Olsen >Assignee: Bjorn Olsen >Priority: Minor > Fix For: 1.10.7 > > Attachments: image-2019-12-08-14-44-56-762.png, > image-2019-12-08-14-45-34-266.png, image-2019-12-08-14-46-09-051.png > > > When inspecting a task instance on the UI, the value for queued_dttm displays > as 'None' despite having a value in the DB. Also, the value for queued_dttm > is from when the task was first queued and not updated if it is requeued - it > is not clear if this is intentional behaviour or not. > On UI: > !image-2019-12-08-14-44-56-762.png! > In DB: > !image-2019-12-08-14-45-34-266.png! > In reality, task was queued on 8 December and run shortly after. > queued_dttm in the DB is from the very first attempt, and is not updated from > recent attempts. > !image-2019-12-08-14-46-09-051.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6195) queued_dttm is "None" on UI, and not updated when tasks requeued
[ https://issues.apache.org/jira/browse/AIRFLOW-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998463#comment-16998463 ] ASF subversion and git services commented on AIRFLOW-6195: -- Commit de007d525144694dcedaa4d6feeeb4bb219acc08 in airflow's branch refs/heads/v1-10-test from Bjorn Olsen [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=de007d5 ] [AIRFLOW-6195] Fixed TaskInstance attrs not correct on UI (#6758) (cherry picked from commit d4a8afb5aef5b00f7c52c7ff1cc4088c8a00f4a7) > queued_dttm is "None" on UI, and not updated when tasks requeued > > > Key: AIRFLOW-6195 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6195 > Project: Apache Airflow > Issue Type: Bug > Components: ui >Affects Versions: 1.10.6 >Reporter: Bjorn Olsen >Assignee: Bjorn Olsen >Priority: Minor > Fix For: 1.10.7 > > Attachments: image-2019-12-08-14-44-56-762.png, > image-2019-12-08-14-45-34-266.png, image-2019-12-08-14-46-09-051.png > > > When inspecting a task instance on the UI, the value for queued_dttm displays > as 'None' despite having a value in the DB. Also, the value for queued_dttm > is from when the task was first queued and not updated if it is requeued - it > is not clear if this is intentional behaviour or not. > On UI: > !image-2019-12-08-14-44-56-762.png! > In DB: > !image-2019-12-08-14-45-34-266.png! > In reality, task was queued on 8 December and run shortly after. > queued_dttm in the DB is from the very first attempt, and is not updated from > recent attempts. > !image-2019-12-08-14-46-09-051.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6195) queued_dttm is "None" on UI, and not updated when tasks requeued
[ https://issues.apache.org/jira/browse/AIRFLOW-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998430#comment-16998430 ] ASF subversion and git services commented on AIRFLOW-6195: -- Commit abed1cc48da54d148f6643ecd3b4bedf24532e72 in airflow's branch refs/heads/v1-10-test from Bjorn Olsen [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=abed1cc ] [AIRFLOW-6195] Fixed TaskInstance attrs not correct on UI (#6758) (cherry picked from commit d4a8afb5aef5b00f7c52c7ff1cc4088c8a00f4a7) > queued_dttm is "None" on UI, and not updated when tasks requeued > > > Key: AIRFLOW-6195 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6195 > Project: Apache Airflow > Issue Type: Bug > Components: ui >Affects Versions: 1.10.6 >Reporter: Bjorn Olsen >Assignee: Bjorn Olsen >Priority: Minor > Fix For: 1.10.7 > > Attachments: image-2019-12-08-14-44-56-762.png, > image-2019-12-08-14-45-34-266.png, image-2019-12-08-14-46-09-051.png > > > When inspecting a task instance on the UI, the value for queued_dttm displays > as 'None' despite having a value in the DB. Also, the value for queued_dttm > is from when the task was first queued and not updated if it is requeued - it > is not clear if this is intentional behaviour or not. > On UI: > !image-2019-12-08-14-44-56-762.png! > In DB: > !image-2019-12-08-14-45-34-266.png! > In reality, task was queued on 8 December and run shortly after. > queued_dttm in the DB is from the very first attempt, and is not updated from > recent attempts. > !image-2019-12-08-14-46-09-051.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6195) queued_dttm is "None" on UI, and not updated when tasks requeued
[ https://issues.apache.org/jira/browse/AIRFLOW-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993413#comment-16993413 ] ASF GitHub Bot commented on AIRFLOW-6195: - ashb commented on pull request #6758: [AIRFLOW-6195] Fixed TaskInstance attrs not correct on UI URL: https://github.com/apache/airflow/pull/6758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > queued_dttm is "None" on UI, and not updated when tasks requeued > > > Key: AIRFLOW-6195 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6195 > Project: Apache Airflow > Issue Type: Bug > Components: ui >Affects Versions: 1.10.6 >Reporter: Bjorn Olsen >Assignee: Bjorn Olsen >Priority: Minor > Attachments: image-2019-12-08-14-44-56-762.png, > image-2019-12-08-14-45-34-266.png, image-2019-12-08-14-46-09-051.png > > > When inspecting a task instance on the UI, the value for queued_dttm displays > as 'None' despite having a value in the DB. Also, the value for queued_dttm > is from when the task was first queued and not updated if it is requeued - it > is not clear if this is intentional behaviour or not. > On UI: > !image-2019-12-08-14-44-56-762.png! > In DB: > !image-2019-12-08-14-45-34-266.png! > In reality, task was queued on 8 December and run shortly after. > queued_dttm in the DB is from the very first attempt, and is not updated from > recent attempts. > !image-2019-12-08-14-46-09-051.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6195) queued_dttm is "None" on UI, and not updated when tasks requeued
[ https://issues.apache.org/jira/browse/AIRFLOW-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993414#comment-16993414 ] ASF subversion and git services commented on AIRFLOW-6195: -- Commit d4a8afb5aef5b00f7c52c7ff1cc4088c8a00f4a7 in airflow's branch refs/heads/master from Bjorn Olsen [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=d4a8afb ] [AIRFLOW-6195] Fixed TaskInstance attrs not correct on UI (#6758) > queued_dttm is "None" on UI, and not updated when tasks requeued > > > Key: AIRFLOW-6195 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6195 > Project: Apache Airflow > Issue Type: Bug > Components: ui >Affects Versions: 1.10.6 >Reporter: Bjorn Olsen >Assignee: Bjorn Olsen >Priority: Minor > Fix For: 1.10.7 > > Attachments: image-2019-12-08-14-44-56-762.png, > image-2019-12-08-14-45-34-266.png, image-2019-12-08-14-46-09-051.png > > > When inspecting a task instance on the UI, the value for queued_dttm displays > as 'None' despite having a value in the DB. Also, the value for queued_dttm > is from when the task was first queued and not updated if it is requeued - it > is not clear if this is intentional behaviour or not. > On UI: > !image-2019-12-08-14-44-56-762.png! > In DB: > !image-2019-12-08-14-45-34-266.png! > In reality, task was queued on 8 December and run shortly after. > queued_dttm in the DB is from the very first attempt, and is not updated from > recent attempts. > !image-2019-12-08-14-46-09-051.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6195) queued_dttm is "None" on UI, and not updated when tasks requeued
[
https://issues.apache.org/jira/browse/AIRFLOW-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991224#comment-16991224
]
ASF GitHub Bot commented on AIRFLOW-6195:
-
baolsen commented on pull request #6758: [AIRFLOW-6195] Fixed TaskInstance
attrs not correct on UI
URL: https://github.com/apache/airflow/pull/6758
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
Fixed calculation of queued_dttm - was using the first/previous value from
prior attempts, when tasks are re-queued or retried for some other reason. This
is unexpected behavior, and although it was implemented specifically in that
way it is not referenced elsewhere in the application so it seems this
behaviour is also not needed. (queued_dttm is only referenced in the UI under
Task Instance details - but even then it was not being displayed at all anyway
due to below bug).
Fixed various fields not displaying correctly on the UI for "Task Instance
Details".
Before (just displays None instead of value from DB):
After (displays value from DB):
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested manually by looking at the UI
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> queued_dttm is "None" on UI, and not updated when tasks requeued
>
>
> Key: AIRFLOW-6195
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6195
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui
>Affects Versions: 1.10.6
>Reporter: Bjorn Olsen
>Assignee: Bjorn Olsen
>Priority: Minor
> Attachments: image-2019-12-08-14-44-56-762.png,
> image-2019-12-08-14-45-34-266.png, image-2019-12-08-14-46-09-051.png
>
>
> When inspecting a task instance on the UI, the value for queued_dttm displays
> as 'None' despite having a value in the DB. Also, the value for queued_dttm
> is from when the task was first queued and not updated if it is requeued - it
> is not clear if this is intentional behaviour or not.
> On UI:
> !image-2019-12-08-14-44-56-762.png!
> In DB:
> !image-2019-12-08-14-45-34-266.png!
> In reality, task was queued on 8 December and run shortly after.
> queued_dttm in the DB is from the very first attempt, and is not updated from
> recent attempts.
>
[jira] [Commented] (AIRFLOW-6195) queued_dttm is "None" on UI, and not updated when tasks requeued
[ https://issues.apache.org/jira/browse/AIRFLOW-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990952#comment-16990952 ] Bjorn Olsen commented on AIRFLOW-6195: -- Turns out this actually affects several fields, due to them being missing from refresh_from_db() in the TaskInstance model file. Fix incoming > queued_dttm is "None" on UI, and not updated when tasks requeued > > > Key: AIRFLOW-6195 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6195 > Project: Apache Airflow > Issue Type: Bug > Components: ui >Affects Versions: 1.10.6 >Reporter: Bjorn Olsen >Assignee: Bjorn Olsen >Priority: Minor > Attachments: image-2019-12-08-14-44-56-762.png, > image-2019-12-08-14-45-34-266.png, image-2019-12-08-14-46-09-051.png > > > When inspecting a task instance on the UI, the value for queued_dttm displays > as 'None' despite having a value in the DB. Also, the value for queued_dttm > is from when the task was first queued and not updated if it is requeued - it > is not clear if this is intentional behaviour or not. > On UI: > !image-2019-12-08-14-44-56-762.png! > In DB: > !image-2019-12-08-14-45-34-266.png! > In reality, task was queued on 8 December and run shortly after. > queued_dttm in the DB is from the very first attempt, and is not updated from > recent attempts. > !image-2019-12-08-14-46-09-051.png! > -- This message was sent by Atlassian Jira (v8.3.4#803005)
