[jira] [Updated] (AIRFLOW-4269) For-lop in jobs._process_task_instances can be faster by breaking from unnecessary steps
[ https://issues.apache.org/jira/browse/AIRFLOW-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-4269: --- Fix Version/s: (was: 2.0.0) 1.10.4 > For-lop in jobs._process_task_instances can be faster by breaking from > unnecessary steps > > > Key: AIRFLOW-4269 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4269 > Project: Apache Airflow > Issue Type: Improvement >Affects Versions: 1.10.2 >Reporter: Xiaodong DENG >Assignee: Xiaodong DENG >Priority: Minor > Fix For: 1.10.4 > > > [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923] > is a "continue" while it should be a break. > When *len(active_dag_runs) >= dag.max_active_runs* , the following part of > the for-loop will give the same result and result in a "continue" again and > again, doing nothing. > We should use a "break" here. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AIRFLOW-4269) For-lop in jobs._process_task_instances can be faster by breaking from unnecessary steps
[ https://issues.apache.org/jira/browse/AIRFLOW-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-4269: --- Summary: For-lop in jobs._process_task_instances can be faster by breaking from unnecessary steps (was: Minor refactoring on jobs._process_task_instances()) > For-lop in jobs._process_task_instances can be faster by breaking from > unnecessary steps > > > Key: AIRFLOW-4269 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4269 > Project: Apache Airflow > Issue Type: Improvement >Affects Versions: 1.10.2 >Reporter: Xiaodong DENG >Assignee: Xiaodong DENG >Priority: Minor > > Issue-1: > [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923] > is a "continue" while it should be a break. > When *len(active_dag_runs) >= dag.max_active_runs* , the following part of > the for-loop will give the same result and result in a "continue" again and > again, doing nothing. > We should use a "break" here. > > Issue-2: > [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L921] > *"if len(active_dag_runs) >= dag.max_active_runs:"* should be "*if > len(active_dag_runs) > dag.max_active_runs:".* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AIRFLOW-4269) For-lop in jobs._process_task_instances can be faster by breaking from unnecessary steps
[ https://issues.apache.org/jira/browse/AIRFLOW-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-4269: --- Description: [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923] is a "continue" while it should be a break. When *len(active_dag_runs) >= dag.max_active_runs* , the following part of the for-loop will give the same result and result in a "continue" again and again, doing nothing. We should use a "break" here. was: Issue-1: [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923] is a "continue" while it should be a break. When *len(active_dag_runs) >= dag.max_active_runs* , the following part of the for-loop will give the same result and result in a "continue" again and again, doing nothing. We should use a "break" here. Issue-2: [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L921] *"if len(active_dag_runs) >= dag.max_active_runs:"* should be "*if len(active_dag_runs) > dag.max_active_runs:".* > For-lop in jobs._process_task_instances can be faster by breaking from > unnecessary steps > > > Key: AIRFLOW-4269 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4269 > Project: Apache Airflow > Issue Type: Improvement >Affects Versions: 1.10.2 >Reporter: Xiaodong DENG >Assignee: Xiaodong DENG >Priority: Minor > > [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923] > is a "continue" while it should be a break. > When *len(active_dag_runs) >= dag.max_active_runs* , the following part of > the for-loop will give the same result and result in a "continue" again and > again, doing nothing. > We should use a "break" here. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AIRFLOW-4269) For-lop in jobs._process_task_instances can be faster by breaking from unnecessary steps
[ https://issues.apache.org/jira/browse/AIRFLOW-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-4269: --- Affects Version/s: 1.10.2 > For-lop in jobs._process_task_instances can be faster by breaking from > unnecessary steps > > > Key: AIRFLOW-4269 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4269 > Project: Apache Airflow > Issue Type: Improvement >Affects Versions: 1.10.2 >Reporter: Xiaodong DENG >Assignee: Xiaodong DENG >Priority: Minor > > [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923] > is a "continue" while it should be a break. > When *len(active_dag_runs) >= dag.max_active_runs* , the following part of > the for-loop will give the same result and result in a "continue" again and > again, doing nothing. > We should use a "break" here. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
