[jira] [Updated] (AIRFLOW-5072) gcs_hook causes out-of-memory error when downloading huge files

2019-11-21 Thread Ash Berlin-Taylor (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ash Berlin-Taylor updated AIRFLOW-5072:
---
Fix Version/s: (was: 2.0.0)
   1.10.7

> gcs_hook causes out-of-memory error when downloading huge files
> ---
>
> Key: AIRFLOW-5072
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5072
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: gcp
>Affects Versions: 1.10.3
>Reporter: Tobias Kaymak
>Assignee: Tobias Kaymak
>Priority: Major
> Fix For: 1.10.7
>
>
> Possibly there is an "else" missing here, but the gcs_hook's `download` 
> method *always* downloads a blob as a string even when a filename was 
> supplied. This causes the method to take twice as long when a filename is 
> supplied and for huge blobs it can even cause out-of-memory errors.
> I think that there is an else missing?
> [https://github.com/apache/airflow/blob/05c01a97497e992c7d8b05a39a7855343dee1603/airflow/contrib/hooks/gcs_hook.py#L176]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (AIRFLOW-5072) gcs_hook causes out-of-memory error when downloading huge files

2019-07-30 Thread Tobias Kaymak (JIRA)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Kaymak updated AIRFLOW-5072:
---
Description: 
Possibly there is an "else" missing here, but the gcs_hook's `download` method 
*always* downloads a blob as a string even when a filename was supplied. This 
causes the method to take twice as long when a filename is supplied and for 
huge blobs it can even cause out-of-memory errors.

I think that there is an else missing?

[https://github.com/apache/airflow/blob/05c01a97497e992c7d8b05a39a7855343dee1603/airflow/contrib/hooks/gcs_hook.py#L176]

  was:
Possibly there is an "else" missing here, but the gcs_hook's `download` method 
*always* downloads a blob as a string even when a filename was supplied. This 
causes the method to take twice as long when a filename is supplied and for 
huge blob's causes out of memory errors.

I think that there is an else missing?

https://github.com/apache/airflow/blob/05c01a97497e992c7d8b05a39a7855343dee1603/airflow/contrib/hooks/gcs_hook.py#L176


> gcs_hook causes out-of-memory error when downloading huge files
> ---
>
> Key: AIRFLOW-5072
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5072
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: gcp
>Affects Versions: 1.10.3
>Reporter: Tobias Kaymak
>Assignee: Tobias Kaymak
>Priority: Major
>
> Possibly there is an "else" missing here, but the gcs_hook's `download` 
> method *always* downloads a blob as a string even when a filename was 
> supplied. This causes the method to take twice as long when a filename is 
> supplied and for huge blobs it can even cause out-of-memory errors.
> I think that there is an else missing?
> [https://github.com/apache/airflow/blob/05c01a97497e992c7d8b05a39a7855343dee1603/airflow/contrib/hooks/gcs_hook.py#L176]



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)