[jira] [Updated] (AIRFLOW-6836) DebugExecutor failing to change task state.

2020-03-17 Thread Kaxil Naik (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kaxil Naik updated AIRFLOW-6836:

Fix Version/s: (was: 1.10.10)
   2.0.0

> DebugExecutor failing to change task state.
> ---
>
> Key: AIRFLOW-6836
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6836
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: executors
>Affects Versions: 1.10.9
>Reporter: Sam Wheating
>Assignee: Sam Wheating
>Priority: Minor
>  Labels: easyfix
> Fix For: 2.0.0
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Running a DAG locally with the DebugExecutor fails with the following error:
>  
> {noformat}
>   File 
> "/Users/samwheating/.pyenv/versions/3.7.3/lib/python3.7/site-packages/airflow/executors/debug_executor.py",
>  line 148, in change_state
>  self.running.remove(key)
>  AttributeError: 'dict' object has no attribute 'remove'
> {noformat}
> This seems to be because the change_state function is expecting a set rather 
> than a dict for `self.running`. This should be updated to use `del 
> self.running[key]` or `self.running.pop(key)`.
> I'll submit a PR for this tomorrow. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (AIRFLOW-6836) DebugExecutor failing to change task state.

2020-02-18 Thread Sam Wheating (Jira)


 [ 
https://issues.apache.org/jira/browse/AIRFLOW-6836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sam Wheating updated AIRFLOW-6836:
--
Description: 
Running a DAG locally with the DebugExecutor fails with the following error:

 

{noformat}
  File 
"/Users/samwheating/.pyenv/versions/3.7.3/lib/python3.7/site-packages/airflow/executors/debug_executor.py",
 line 148, in change_state
 self.running.remove(key)
 AttributeError: 'dict' object has no attribute 'remove'
{noformat}

This seems to be because the change_state function is expecting a set rather 
than a dict for `self.running`. This should be updated to use `del 
self.running[key]` or `self.running.pop(key)`.

I'll submit a PR for this tomorrow. 

  was:
Running a DAG locally with the DebugExecutor fails with the following error:

```
 File 
"/Users/samwheating/.pyenv/versions/3.7.3/lib/python3.7/site-packages/airflow/executors/debug_executor.py",
 line 148, in change_state
 self.running.remove(key)
AttributeError: 'dict' object has no attribute 'remove'
```

This seems to be because the change_state function is expecting a set rather 
than a dict for `self.running`. This should be updated to use `del 
self.running[key]` or `self.running.pop(key)`.

I'll submit a PR for this tomorrow. 


> DebugExecutor failing to change task state.
> ---
>
> Key: AIRFLOW-6836
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6836
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: executors
>Affects Versions: 1.10.9
>Reporter: Sam Wheating
>Assignee: Sam Wheating
>Priority: Minor
>  Labels: easyfix
> Fix For: 1.10.10
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Running a DAG locally with the DebugExecutor fails with the following error:
>  
> {noformat}
>   File 
> "/Users/samwheating/.pyenv/versions/3.7.3/lib/python3.7/site-packages/airflow/executors/debug_executor.py",
>  line 148, in change_state
>  self.running.remove(key)
>  AttributeError: 'dict' object has no attribute 'remove'
> {noformat}
> This seems to be because the change_state function is expecting a set rather 
> than a dict for `self.running`. This should be updated to use `del 
> self.running[key]` or `self.running.pop(key)`.
> I'll submit a PR for this tomorrow. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)