Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
potiuk merged PR #38673: URL: https://github.com/apache/airflow/pull/38673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
VladaZakharova commented on PR #38673: URL: https://github.com/apache/airflow/pull/38673#issuecomment-2102293010 Hey @shahar1 ! Would be nice if you can check the changes here again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
molcay commented on PR #38673: URL: https://github.com/apache/airflow/pull/38673#issuecomment-2089863072 I will work on this test failure and send an update. Thank you for the review @shahar1 Also, thank you for pinging and guiding along the way @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
molcay commented on code in PR #38673: URL: https://github.com/apache/airflow/pull/38673#discussion_r1584459964 ## airflow/providers/google/cloud/operators/automl.py: ## @@ -246,7 +306,7 @@ def execute(self, context: Context): metadata=self.metadata, ) project_id = self.project_id or hook.project_id -if project_id: +if project_id and self.model_id: Review Comment: Since we introduce the `endpoint_id`, `model_id` is optional right now. This check is to ensure the `model_id` is given. Because `AutoMLModelPredictLink` can be used only for `model_id` case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
molcay commented on PR #38673: URL: https://github.com/apache/airflow/pull/38673#issuecomment-2078885594 @potiuk, Ohh I see, there are some hidden conversations. I totally missed them. Sorry for the inconvenience. I will try to address and resolve them as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
potiuk commented on PR #38673: URL: https://github.com/apache/airflow/pull/38673#issuecomment-2076993546 @molcay -> can you please review and address/mark as resolved if they are - the comments made by @shahar1 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
VladaZakharova commented on PR #38673: URL: https://github.com/apache/airflow/pull/38673#issuecomment-2076740783 > cc: @VladaZakharova - there were some doubts for Google team about those deprecations - does this one look ok for you? Hi! Thanks, yes, changes look good, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
potiuk commented on PR #38673: URL: https://github.com/apache/airflow/pull/38673#issuecomment-2075537682 cc: @VladaZakharova - there were some doubts for Google team about those deprecations - does this one look ok for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
potiuk commented on PR #38673: URL: https://github.com/apache/airflow/pull/38673#issuecomment-2071782931 @molcay -> can you please rebase/resolve conflict and respond/mark as resolved all conversations that you think were resolved? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
molcay commented on code in PR #38673:
URL: https://github.com/apache/airflow/pull/38673#discussion_r1564955547
##
airflow/providers/google/cloud/hooks/vertex_ai/prediction_service.py:
##
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+from typing import TYPE_CHECKING, Sequence
+
+from google.api_core.client_options import ClientOptions
+from google.api_core.gapic_v1.method import DEFAULT, _MethodDefault
+from google.cloud.aiplatform_v1 import PredictionServiceClient
+
+from airflow.providers.google.common.consts import CLIENT_INFO
+from airflow.providers.google.common.hooks.base_google import
PROVIDE_PROJECT_ID, GoogleBaseHook
+
+if TYPE_CHECKING:
+from google.api_core.retry import Retry
+from google.cloud.aiplatform_v1.types import PredictResponse
+
+
+class PredictionServiceHook(GoogleBaseHook):
+"""Hook for Google Cloud Vertex AI Prediction API."""
+
+def get_prediction_service_client(self, region: str | None = None) ->
PredictionServiceClient:
+"""Return PredictionServiceClient object."""
+if region and region != "global":
+client_options =
ClientOptions(api_endpoint=f"{region}-aiplatform.googleapis.com:443")
+else:
+client_options = ClientOptions()
+
+return PredictionServiceClient(
+credentials=self.get_credentials(), client_info=CLIENT_INFO,
client_options=client_options
+)
+
+@GoogleBaseHook.fallback_to_default_project_id
+def predict(
+self,
+endpoint_id: str,
+instances: list[str],
+location: str,
+project_id: str = PROVIDE_PROJECT_ID,
+params: dict[str, str] | None = None,
+retry: Retry | _MethodDefault = DEFAULT,
+timeout: float | None = None,
+metadata: Sequence[tuple[str, str]] = (),
+) -> PredictResponse:
+"""
+Perform an online prediction and returns the prediction result in the
response.
+
+:param endpoint_id: Name of the endpoint_id requested to serve the
prediction.
+:param instances: Required. The instances that are the input to the
prediction call. A DeployedModel
+may have an upper limit on the number of instances it supports per
request, and when it is
+exceeded the prediction call errors in case of AutoML Models, or,
in case of customer created
+Models, the behaviour is as documented by that Model.
+:param params: Additional domain-specific parameters, any string must
be up to 25000 characters long.
+:param project_id: ID of the Google Cloud project where model is
located if None then
+default project_id is used.
+:param location: The location of the project.
+:param retry: A retry object used to retry requests. If `None` is
specified, requests will not be
+retried.
+:param timeout: The amount of time, in seconds, to wait for the
request to complete. Note that if
+`retry` is specified, the timeout applies to each individual
attempt.
+:param metadata: Additional metadata that is provided to the method.
+"""
+client = self.get_prediction_service_client(location)
+endpoint =
f"projects/{project_id}/locations/{location}/endpoints/{endpoint_id}"
+return client.predict(
+request={"endpoint": endpoint, "instances": instances, "params":
params},
Review Comment:
Nice catch! I changed it as `parameters`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
molcay commented on code in PR #38673:
URL: https://github.com/apache/airflow/pull/38673#discussion_r1564955395
##
tests/providers/google/cloud/operators/test_automl.py:
##
@@ -21,11 +21,16 @@
from unittest import mock
import pytest
-from google.api_core.gapic_v1.method import DEFAULT
-from google.cloud.automl_v1beta1 import BatchPredictResult, Dataset, Model,
PredictResponse
-from airflow.providers.google.cloud.hooks.automl import CloudAutoMLHook
-from airflow.providers.google.cloud.operators.automl import (
+# For no Pydantic environment, we need to skip the tests
+pytest.importorskip("google.cloud.aiplatform_v1")
+
+from google.api_core.gapic_v1.method import DEFAULT # noqa: E402
+from google.cloud.automl_v1beta1 import BatchPredictResult, Dataset, Model,
PredictResponse # noqa: E402
+
+from airflow.exceptions import AirflowProviderDeprecationWarning # noqa: E402
+from airflow.providers.google.cloud.hooks.automl import CloudAutoMLHook #
noqa: E402
+from airflow.providers.google.cloud.operators.automl import ( # noqa: E402
Review Comment:
I was not aware of this feature. Thank you for the information! I am
changing accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
Taragolis commented on code in PR #38673:
URL: https://github.com/apache/airflow/pull/38673#discussion_r1559084925
##
tests/providers/google/cloud/operators/test_automl.py:
##
@@ -90,6 +100,22 @@ def test_execute(self, mock_hook):
metadata=(),
)
+
@mock.patch("airflow.providers.google.cloud.operators.automl.CloudAutoMLHook")
+def test_execute_deprecated(self, mock_hook):
+op = AutoMLTrainModelOperator(
+model=MODEL_DEPRECATED,
+location=GCP_LOCATION,
+project_id=GCP_PROJECT_ID,
+task_id=TASK_ID,
+)
+with pytest.raises(AirflowProviderDeprecationWarning) as err:
Review Comment:
We should not raise warning as regular exception and usual it is
semantically incorrect, because this is user decision whether or not raise
specific warning as exception by configure `PYTHONWARNINGS`
(https://docs.python.org/3/library/warnings.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
shahar1 commented on code in PR #38673: URL: https://github.com/apache/airflow/pull/38673#discussion_r1558252126 ## airflow/providers/google/cloud/operators/automl.py: ## @@ -429,6 +519,8 @@ def __init__( self.impersonation_chain = impersonation_chain def execute(self, context: Context): +if "translation_dataset_metadata" in self.dataset: +_raise_exception_for_deprecated_operator(self.__class__.__name__, "CreateDatasetOperator") Review Comment: Please add a test for this `if` (and similar `if`s that raise an exception) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
shahar1 commented on code in PR #38673:
URL: https://github.com/apache/airflow/pull/38673#discussion_r1558240411
##
tests/providers/google/cloud/operators/test_automl.py:
##
@@ -21,11 +21,16 @@
from unittest import mock
import pytest
-from google.api_core.gapic_v1.method import DEFAULT
-from google.cloud.automl_v1beta1 import BatchPredictResult, Dataset, Model,
PredictResponse
-from airflow.providers.google.cloud.hooks.automl import CloudAutoMLHook
-from airflow.providers.google.cloud.operators.automl import (
+# For no Pydantic environment, we need to skip the tests
+pytest.importorskip("google.cloud.aiplatform_v1")
+
+from google.api_core.gapic_v1.method import DEFAULT # noqa: E402
+from google.cloud.automl_v1beta1 import BatchPredictResult, Dataset, Model,
PredictResponse # noqa: E402
+
+from airflow.exceptions import AirflowProviderDeprecationWarning # noqa: E402
+from airflow.providers.google.cloud.hooks.automl import CloudAutoMLHook #
noqa: E402
+from airflow.providers.google.cloud.operators.automl import ( # noqa: E402
Review Comment:
Instead of having these `#noqa: E402`, you could try adding a line in
`pyproject.toml` (around L356)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
shahar1 commented on code in PR #38673: URL: https://github.com/apache/airflow/pull/38673#discussion_r1558216902 ## airflow/providers/google/cloud/operators/automl.py: ## @@ -205,7 +231,8 @@ class AutoMLPredictOperator(GoogleCloudBaseOperator): def __init__( self, *, -model_id: str, +model_id: str | None = None, +endpoint_id: str | None = None, Review Comment: Please add a docstring for the new argument -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
shahar1 commented on code in PR #38673:
URL: https://github.com/apache/airflow/pull/38673#discussion_r1558097913
##
airflow/providers/google/cloud/hooks/vertex_ai/prediction_service.py:
##
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+from typing import TYPE_CHECKING, Sequence
+
+from google.api_core.client_options import ClientOptions
+from google.api_core.gapic_v1.method import DEFAULT, _MethodDefault
+from google.cloud.aiplatform_v1 import PredictionServiceClient
+
+from airflow.providers.google.common.consts import CLIENT_INFO
+from airflow.providers.google.common.hooks.base_google import
PROVIDE_PROJECT_ID, GoogleBaseHook
+
+if TYPE_CHECKING:
+from google.api_core.retry import Retry
+from google.cloud.aiplatform_v1.types import PredictResponse
+
+
+class PredictionServiceHook(GoogleBaseHook):
+"""Hook for Google Cloud Vertex AI Prediction API."""
+
+def get_prediction_service_client(self, region: str | None = None) ->
PredictionServiceClient:
+"""Return PredictionServiceClient object."""
+if region and region != "global":
+client_options =
ClientOptions(api_endpoint=f"{region}-aiplatform.googleapis.com:443")
+else:
+client_options = ClientOptions()
+
+return PredictionServiceClient(
+credentials=self.get_credentials(), client_info=CLIENT_INFO,
client_options=client_options
+)
+
+@GoogleBaseHook.fallback_to_default_project_id
+def predict(
+self,
+endpoint_id: str,
+instances: list[str],
+location: str,
+project_id: str = PROVIDE_PROJECT_ID,
+params: dict[str, str] | None = None,
+retry: Retry | _MethodDefault = DEFAULT,
+timeout: float | None = None,
+metadata: Sequence[tuple[str, str]] = (),
+) -> PredictResponse:
+"""
+Perform an online prediction and returns the prediction result in the
response.
+
+:param endpoint_id: Name of the endpoint_id requested to serve the
prediction.
+:param instances: Required. The instances that are the input to the
prediction call. A DeployedModel
+may have an upper limit on the number of instances it supports per
request, and when it is
+exceeded the prediction call errors in case of AutoML Models, or,
in case of customer created
+Models, the behaviour is as documented by that Model.
+:param params: Additional domain-specific parameters, any string must
be up to 25000 characters long.
+:param project_id: ID of the Google Cloud project where model is
located if None then
+default project_id is used.
+:param location: The location of the project.
+:param retry: A retry object used to retry requests. If `None` is
specified, requests will not be
+retried.
+:param timeout: The amount of time, in seconds, to wait for the
request to complete. Note that if
+`retry` is specified, the timeout applies to each individual
attempt.
+:param metadata: Additional metadata that is provided to the method.
+"""
+client = self.get_prediction_service_client(location)
+endpoint =
f"projects/{project_id}/locations/{location}/endpoints/{endpoint_id}"
+return client.predict(
+request={"endpoint": endpoint, "instances": instances, "params":
params},
Review Comment:
Could you please recheck the `params` argument?
According to the API, if I'm not wrong, it should be named `parameters`.
##
airflow/providers/google/cloud/operators/automl.py:
##
@@ -230,11 +261,40 @@ def __init__(
self.gcp_conn_id = gcp_conn_id
self.impersonation_chain = impersonation_chain
-def execute(self, context: Context):
-hook = CloudAutoMLHook(
-gcp_conn_id=self.gcp_conn_id,
-impersonation_chain=self.impersonation_chain,
+@cached_property
+def hook(self) -> CloudAutoMLHook | PredictionServiceHook:
+if self.model_id:
+return CloudAutoMLHook(
+gcp_conn_id=self.gcp_conn_id,
+
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
molcay commented on code in PR #38673:
URL: https://github.com/apache/airflow/pull/38673#discussion_r1557431376
##
tests/providers/google/cloud/operators/test_automl.py:
##
@@ -90,6 +100,22 @@ def test_execute(self, mock_hook):
metadata=(),
)
+
@mock.patch("airflow.providers.google.cloud.operators.automl.CloudAutoMLHook")
+def test_execute_deprecated(self, mock_hook):
+op = AutoMLTrainModelOperator(
+model=MODEL_DEPRECATED,
+location=GCP_LOCATION,
+project_id=GCP_PROJECT_ID,
+task_id=TASK_ID,
+)
+with pytest.raises(AirflowProviderDeprecationWarning) as err:
Review Comment:
@Taragolis Hi again, I checked the docs and tried to use warnings
(`pytest.warns`) but the thing is that we are **raising** the
`AirflowProviderDeprecationWarning` in case of specific usage of the operators.
I know it is a little bit different than general behavior but all these
services ([AutoML](https://cloud.google.com/automl/docs)
([Tables](https://cloud.google.com/automl-tables/docs/deprecations),
[Vision](https://cloud.google.com/vision/automl/docs/deprecations), [Video
Intelligence](https://cloud.google.com/video-intelligence/automl/docs/deprecations),
[Natural
Language](https://cloud.google.com/natural-language/automl/docs/deprecations)))
already are EoL but same operators can be use for AutoML Translation which is
not deprecated.
##
tests/providers/google/cloud/operators/test_automl.py:
##
@@ -90,6 +100,22 @@ def test_execute(self, mock_hook):
metadata=(),
)
+
@mock.patch("airflow.providers.google.cloud.operators.automl.CloudAutoMLHook")
+def test_execute_deprecated(self, mock_hook):
+op = AutoMLTrainModelOperator(
+model=MODEL_DEPRECATED,
+location=GCP_LOCATION,
+project_id=GCP_PROJECT_ID,
+task_id=TASK_ID,
+)
+with pytest.raises(AirflowProviderDeprecationWarning) as err:
Review Comment:
@Taragolis Hi again, I checked the docs and tried to use warnings
(`pytest.warns`) but the thing is that we are **raising** the
`AirflowProviderDeprecationWarning` in case of specific usage of the operators.
I know it is a little bit different than general behavior but all these
services ([AutoML](https://cloud.google.com/automl/docs)
([Tables](https://cloud.google.com/automl-tables/docs/deprecations),
[Vision](https://cloud.google.com/vision/automl/docs/deprecations), [Video
Intelligence](https://cloud.google.com/video-intelligence/automl/docs/deprecations),
[Natural
Language](https://cloud.google.com/natural-language/automl/docs/deprecations)))
already are EoL but same operators can be use for AutoML Translation which is
**NOT** deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
molcay commented on code in PR #38673:
URL: https://github.com/apache/airflow/pull/38673#discussion_r1557407141
##
tests/providers/google/cloud/operators/test_automl.py:
##
@@ -90,6 +100,22 @@ def test_execute(self, mock_hook):
metadata=(),
)
+
@mock.patch("airflow.providers.google.cloud.operators.automl.CloudAutoMLHook")
+def test_execute_deprecated(self, mock_hook):
+op = AutoMLTrainModelOperator(
+model=MODEL_DEPRECATED,
+location=GCP_LOCATION,
+project_id=GCP_PROJECT_ID,
+task_id=TASK_ID,
+)
+with pytest.raises(AirflowProviderDeprecationWarning) as err:
Review Comment:
@Taragolis I was not aware of this one. Thank you for the warning. I am on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
Taragolis commented on code in PR #38673:
URL: https://github.com/apache/airflow/pull/38673#discussion_r1557270621
##
tests/providers/google/cloud/operators/test_automl.py:
##
@@ -90,6 +100,22 @@ def test_execute(self, mock_hook):
metadata=(),
)
+
@mock.patch("airflow.providers.google.cloud.operators.automl.CloudAutoMLHook")
+def test_execute_deprecated(self, mock_hook):
+op = AutoMLTrainModelOperator(
+model=MODEL_DEPRECATED,
+location=GCP_LOCATION,
+project_id=GCP_PROJECT_ID,
+task_id=TASK_ID,
+)
+with pytest.raises(AirflowProviderDeprecationWarning) as err:
Review Comment:
warnings intends to be checked by the
[`pytest.warns`](https://docs.pytest.org/en/stable/how-to/capture-warnings.html#warns)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
potiuk commented on PR #38673: URL: https://github.com/apache/airflow/pull/38673#issuecomment-2040124823 I think you need to rebase the PR. It's 52 commits behind and this is likely why it fails -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecation of AutoML services: Add deprecation warnings and raise exceptions for already deprecated ones [airflow]
eladkal commented on code in PR #38673: URL: https://github.com/apache/airflow/pull/38673#discussion_r1548384082 ## airflow/providers/google/cloud/hooks/vertex_ai/prediction_service.py: ## @@ -0,0 +1,86 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +from typing import TYPE_CHECKING, Sequence + +from google.api_core.client_options import ClientOptions +from google.api_core.gapic_v1.method import DEFAULT, _MethodDefault +from google.cloud.aiplatform_v1 import PredictionServiceClient, PredictResponse + +from airflow.providers.google.common.consts import CLIENT_INFO +from airflow.providers.google.common.hooks.base_google import PROVIDE_PROJECT_ID, GoogleBaseHook + +if TYPE_CHECKING: +from google.api_core.retry import Retry + + +class PredictionServiceHook(GoogleBaseHook): Review Comment: You will need to add tests for this hook -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
