Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]
potiuk closed pull request #38525: Fix message raised on excepion in SFTP deferrable operator URL: https://github.com/apache/airflow/pull/38525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]
potiuk commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2035485085 Fixed in https://github.com/apache/airflow/pull/38518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]
potiuk commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2035484684 🤦 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]
shahar1 commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2035454759 > Needs rebase and solving conflict though :) Oh woops, I did it in mine: #38518 Sorry for the confusion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]
potiuk commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2035452511 Needs rebase and solving conflict though :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]
shahar1 commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2035446961 > > > Ah I see we also have #38518 with the same changes @shahar1 - do you want to proceed with yours? > > > > > > I prefer so :) > > @Bowrna no worries, feel free to review my PR and add suggestions! > > Suggestion @shahar1 . Look at this code, review and merge it and make @Bowrna co-author -> https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors : never hurts. Great suggestion! I will remember this option for similar occasions :) I merged changes from this PR and added @Bowrna as a co-author to mine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]
potiuk commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2033715578 > > Ah I see we also have #38518 with the same changes @shahar1 - do you want to proceed with yours? > > I prefer so :) > > @Bowrna no worries, feel free to review my PR and add suggestions! Suggestion @shahar1 . Look at this code, review and merge it and make @Bowrna co-author -> https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors : never hurts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]
shahar1 commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2033513027 > Ah I see we also have https://github.com/apache/airflow/pull/38518 with the same changes @shahar1 - do you want to proceed with yours? I prefer so :) @Bowrna no worries, feel free to review my PR and add suggestions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]
Bowrna commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2033511597 > Ah I see we also have #38518 with the same changes @shahar1 - do you want to proceed with yours? I didn't know @shahar1 is working on this changes, my bad! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix message raised on excepion in SFTP deferrable operator [airflow]
potiuk commented on PR #38525: URL: https://github.com/apache/airflow/pull/38525#issuecomment-2032870739 Ah I see we also have https://github.com/apache/airflow/pull/38518 with the same changes @shahar1 - do you want to proceed with yours? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
