[jira] [Updated] (AIRFLOW-4151) property "replace" in GenericTransfer.insert_rows is not accessible

[Konrad Riedel (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Riedel updated AIRFLOW-4151:
---
Affects Version/s: 1.10.5

> property "replace" in GenericTransfer.insert_rows is not accessible
> ---
>
> Key: AIRFLOW-4151
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4151
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: operators
>Affects Versions: 1.10.2, 1.10.3, 1.10.4, 1.10.5
>Reporter: Konrad Riedel
>Priority: Major
>
> want to set replace=True during insert, but existing param "replace" cannot 
> be set.
> Suggest something like:
> generic_transfer.py:
> destination_hook.insert_rows({color:#660099}table{color}={color:#94558d}self{color}.destination_table,
>  {color:#660099}rows{color}=results, 
> {color:#660099}replace{color}={color:#80}self.replace{color})



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [airflow] potiuk commented on issue #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI

[GitBox]

potiuk commented on issue #5837: [AIRFLOW-5223] Use KinD for Kubernetes in CI
URL: https://github.com/apache/airflow/pull/5837#issuecomment-532086603
 
 
   > Using the `dind` image makes sense. Thanks for your review @potiuk.
   > 
   > Now, I'm not completely sure about using `network_mode = host`. That mode 
is [not supported on Mac](https://docs.docker.com/network/host/). That means, 
it would work fine for CI, but it wouldn't work for local development.
   
   Yep. You are completely right. It was a quick one have a POC working - but 
you are right about mac  - in the final version i will simply use 
https://dind:2375 since it will be run under docker-compose :).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics

[GitBox]

mik-laj commented on a change in pull request #6130: [AIRFLOW-5508] Add a 
whitelist mechanism for the StatsD metrics
URL: https://github.com/apache/airflow/pull/6130#discussion_r325022764
 
 

 ##
 File path: docs/metrics.rst
 ##
 @@ -41,6 +41,13 @@ Add the following lines to your configuration file e.g. 
``airflow.cfg``
 statsd_port = 8125
 statsd_prefix = airflow
 
+If you want to avoid send all the available metrics to StatsD, you can 
configure a whitelist of prefixes to send only
+the metrics that start with the elements of the list:
+
+.. code-block:: bash
 
 Review comment:
   ```suggestion
   .. code-block:: init
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics

[GitBox]

mik-laj commented on a change in pull request #6130: [AIRFLOW-5508] Add a 
whitelist mechanism for the StatsD metrics
URL: https://github.com/apache/airflow/pull/6130#discussion_r325022764
 
 

 ##
 File path: docs/metrics.rst
 ##
 @@ -41,6 +41,13 @@ Add the following lines to your configuration file e.g. 
``airflow.cfg``
 statsd_port = 8125
 statsd_prefix = airflow
 
+If you want to avoid send all the available metrics to StatsD, you can 
configure a whitelist of prefixes to send only
+the metrics that start with the elements of the list:
+
+.. code-block:: bash
 
 Review comment:
   ```suggestion
   .. code-block:: none
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #6132: [AIRFLOW-XXX] Display Azure integration in table

[GitBox]

feluelle commented on a change in pull request #6132: [AIRFLOW-XXX] Display 
Azure integration in table
URL: https://github.com/apache/airflow/pull/6132#discussion_r325056770
 
 

 ##
 File path: docs/integration.rst
 ##
 @@ -38,80 +36,78 @@ Airflow can be configured to read and write task logs in 
Azure Blob Storage.
 See :ref:`write-logs-azure`.
 
 
-Azure Blob Storage
-''
-
-All classes communicate via the Window Azure Storage Blob protocol. Make sure 
that a
-Airflow connection of type `wasb` exists. Authorization can be done by 
supplying a
-login (=Storage account name) and password (=KEY), or login and SAS token in 
the extra
-field (see connection `wasb_default` for an example).
-
-The operators are defined in the following module:
-
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.wasb_delete_blob_operator`
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.file_to_wasb`
-
-They use :class:`airflow.contrib.hooks.wasb_hook.WasbHook` to communicate with 
Microsoft Azure.
-
-Azure File Share
-
+Operators and Hooks
+'''
 
-Cloud variant of a SMB file share. Make sure that a Airflow connection of
-type `wasb` exists. Authorization can be done by supplying a login (=Storage 
account name)
-and password (=Storage account key), or login and SAS token in the extra field
-(see connection `wasb_default` for an example).
+Service operators and hooks
+"""
 
-It uses :class:`airflow.contrib.hooks.azure_fileshare_hook.AzureFileShareHook` 
to communicate with Microsoft Azure.
+These integrations allow you to perform various operations within the 
Microsoft Azure.
 
-Azure CosmosDB
-''
 
-AzureCosmosDBHook communicates via the Azure Cosmos library. Make sure that a
-Airflow connection of type `azure_cosmos` exists. Authorization can be done by 
supplying a
-login (=Endpoint uri), password (=secret key) and extra fields database_name 
and collection_name to specify the
-default database and collection to use (see connection `azure_cosmos_default` 
for an example).
+.. list-table::
+   :header-rows: 1
 
-The operators are defined in the following modules:
+   * - Service name
+ - Hook
+ - Operators
+ - Sensors
 
-* :mod:`airflow.contrib.operators.azure_cosmos_operator`
-* :mod:`airflow.contrib.sensors.azure_cosmos_sensor`
+   * - `Azure Blob Storage 
`__
+ -
+ - :mod:`airflow.contrib.operators.wasb_delete_blob_operator`,
 
 Review comment:
   ```suggestion
- :mod:`airflow.contrib.operators.wasb_delete_blob_operator`
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj opened a new pull request #6133: [AIRLFOW-XXX] Display other integrations in single table

[GitBox]

mik-laj opened a new pull request #6133: [AIRLFOW-XXX] Display other 
integrations in single table
URL: https://github.com/apache/airflow/pull/6133
 
 
   This PR is one of a series about restructuring integration.rst
   https://issues.apache.org/jira/browse/AIRFLOW-5431
   
   ---
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-XXX
 - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
 - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
 - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain docstrings 
that explain what it does
 - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj opened a new pull request #6132: [AIRFLOW-XXX] Display Azure integration in table

[GitBox]

mik-laj opened a new pull request #6132: [AIRFLOW-XXX] Display Azure 
integration in table
URL: https://github.com/apache/airflow/pull/6132
 
 
   This PR is one of a series about restructuring integration.rst
   https://issues.apache.org/jira/browse/AIRFLOW-5431
   
   ---
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-XXX
 - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
 - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
 - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain docstrings 
that explain what it does
 - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics

[GitBox]

mik-laj commented on a change in pull request #6130: [AIRFLOW-5508] Add a 
whitelist mechanism for the StatsD metrics
URL: https://github.com/apache/airflow/pull/6130#discussion_r325022984
 
 

 ##
 File path: docs/metrics.rst
 ##
 @@ -41,6 +41,13 @@ Add the following lines to your configuration file e.g. 
``airflow.cfg``
 statsd_port = 8125
 statsd_prefix = airflow
 
+If you want to avoid send all the available metrics to StatsD, you can 
configure a whitelist of prefixes to send only
+the metrics that start with the elements of the list:
+
+.. code-block:: bash
+
 
 Review comment:
   ```suggestion
  [core]
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug

[GitBox]

feluelle commented on a change in pull request #6100: [AIRFLOW-5387] Fix show 
paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325070585
 
 

 ##
 File path: tests/www/test_utils.py
 ##
 @@ -103,14 +105,45 @@ def test_params_search(self):
 self.assertEqual('search=bash_',
  utils.get_params(search='bash_'))
 
-def test_params_showPaused_true(self):
-"""Should detect True as default for showPaused"""
-self.assertEqual('',
- utils.get_params(showPaused=True))
-
-def test_params_showPaused_false(self):
-self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+@parameterized.expand([
+(True, False, ''),
+(False, True, ''),
+(True, True, 'showPaused=True'),
+(False, False, 'showPaused=False'),
+(None, True, ''),
+(None, False, ''),
+])
+def test_params_showPaused(self, show_paused, hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
 
 Review comment:
   If it is only because of the `ModuleNotFoundError: No module named 
'tests.test_utils'` then you can remove it, because mik-laj fixed it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes

[GitBox]

potiuk commented on issue #5786:  [AIRFLOW-5170] [AIRFLOW-5256] Consistent 
licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786#issuecomment-532150526
 
 
   Right. I thought I squashed it together :(.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #6133: [AIRLFOW-XXX] Display other integrations in single table

[GitBox]

codecov-io commented on issue #6133: [AIRLFOW-XXX] Display other integrations 
in single table
URL: https://github.com/apache/airflow/pull/6133#issuecomment-532165093
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=h1) 
Report
   > Merging 
[#6133](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6133/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#6133   +/-   ##
   ===
 Coverage   80.12%   80.12%   
   ===
 Files 607  607   
 Lines   3490234902   
   ===
 Hits2796527965   
 Misses   6937 6937
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/hooks/databricks\_hook.py](https://codecov.io/gh/apache/airflow/pull/6133/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2RhdGFicmlja3NfaG9vay5weQ==)
 | `97.39% <100%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=footer). 
Last update 
[9cc748b...badedd2](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6133: [AIRLFOW-XXX] Display other integrations in single table

[GitBox]

codecov-io edited a comment on issue #6133: [AIRLFOW-XXX] Display other 
integrations in single table
URL: https://github.com/apache/airflow/pull/6133#issuecomment-532165093
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=h1) 
Report
   > Merging 
[#6133](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6133/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#6133   +/-   ##
   ===
 Coverage   80.12%   80.12%   
   ===
 Files 607  607   
 Lines   3490234902   
   ===
 Hits2796527965   
 Misses   6937 6937
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/hooks/databricks\_hook.py](https://codecov.io/gh/apache/airflow/pull/6133/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2RhdGFicmlja3NfaG9vay5weQ==)
 | `97.39% <100%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=footer). 
Last update 
[9cc748b...badedd2](https://codecov.io/gh/apache/airflow/pull/6133?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #6133: [AIRLFOW-XXX] Display other integrations in single table

[GitBox]

mik-laj merged pull request #6133: [AIRLFOW-XXX] Display other integrations in 
single table
URL: https://github.com/apache/airflow/pull/6133
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

[GitBox]

mik-laj commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to 
Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#issuecomment-532169521
 
 
   @TobKed Today we have had various conversations about this integration. Is 
this PR done?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-5447) KubernetesExecutor hangs on task queueing

[Kaxil Naik (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931309#comment-16931309
 ] 

Kaxil Naik commented on AIRFLOW-5447:
-

Wow, interesting !! Thank you so much [~cwegrzyn] and everyone.

 

This code has been around for ages, wondering the issue has been since the 
start or just from 1.10.4 [~dimberman]?

> KubernetesExecutor hangs on task queueing
> -
>
> Key: AIRFLOW-5447
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5447
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: executor-kubernetes
>Affects Versions: 1.10.4, 1.10.5
> Environment: Kubernetes version v1.14.3, Airflow version 1.10.4-1.10.5
>Reporter: Henry Cohen
>Assignee: Daniel Imberman
>Priority: Blocker
>
> Starting in 1.10.4, and continuing in 1.10.5, when using the 
> KubernetesExecutor, with the webserver and scheduler running in the 
> kubernetes cluster, tasks are scheduled, but when added to the task queue, 
> the executor process hangs indefinitely. Based on log messages, it appears to 
> be stuck at this line 
> https://github.com/apache/airflow/blob/v1-10-stable/airflow/contrib/executors/kubernetes_executor.py#L761



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [airflow] feluelle merged pull request #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes

[GitBox]

feluelle merged pull request #5786:  [AIRFLOW-5170] [AIRFLOW-5256] Consistent 
licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-5170) Add static checks consistent licences for python files

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931325#comment-16931325
 ] 

ASF GitHub Bot commented on AIRFLOW-5170:
-

feluelle commented on pull request #5786:  [AIRFLOW-5170] [AIRFLOW-5256] 
Consistent licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add static checks consistent licences for python files
> --
>
> Key: AIRFLOW-5170
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5170
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: ci
>Affects Versions: 2.0.0
>Reporter: Jarek Potiuk
>Assignee: Jarek Potiuk
>Priority: Major
>
> Automated check for encoding pragma, consisten licence files can be added for 
> python files.
> Since we have pylint checks in pre-commits added we should also make sure to 
> fix all pylint related changes however for all the changed python files.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (AIRFLOW-5256) Related pylint changes for common licences in python files

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931326#comment-16931326
 ] 

ASF subversion and git services commented on AIRFLOW-5256:
--

Commit 47801057989046dfcf7b424ce54afee103803815 in airflow's branch 
refs/heads/master from Jarek Potiuk
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=4780105 ]

[AIRFLOW-5256] Related pylint changes for common licences in python files 
(#5786)



> Related pylint changes for common licences in python files
> --
>
> Key: AIRFLOW-5256
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5256
> Project: Apache Airflow
>  Issue Type: Sub-task
>  Components: ci, core
>Affects Versions: 2.0.0
>Reporter: Jarek Potiuk
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [airflow] ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

[GitBox]

ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove 
aws_default's default region name
URL: https://github.com/apache/airflow/pull/5879#discussion_r325112605
 
 

 ##
 File path: UPDATING.md
 ##
 @@ -39,28 +39,36 @@ assists users migrating to a new version.
 
 ## Airflow Master
 
+### Changes to `aws_default` Connection's default region
+
+The region of Airflow's default connection to AWS (`aws_default`) has
+previously been set to `us-east-1` during installation.
+
+The region now needs to be set manually either in the connection screens in
+Airflow, or via the `AWS_DEFAULT_REGION` environment variable.
+
 ### Changes to FileSensor
 FileSensor is now takes a glob pattern, not just a filename. If the filename 
you are looking for has `*`, `?`, or `[` in it then you should replace these 
with `[*]`, `[?]`, and `[[]`.
 
 ### Change dag loading duration metric name
-Change DAG file loading duration metric from 
 
 Review comment:
   Could you avoid making white-space only changes to the rest of this file? 
(This will make this change harder to cherry-pick back to the release branch)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5731: [AIRFLOW-5117] support refreshing EKS api tokens

[GitBox]

ashb commented on issue #5731: [AIRFLOW-5117] support refreshing EKS api tokens
URL: https://github.com/apache/airflow/pull/5731#issuecomment-532179741
 
 
   @houqp Could you rebase please?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6133: [AIRLFOW-XXX] Display other integrations in single table

[GitBox]

mik-laj commented on a change in pull request #6133: [AIRLFOW-XXX] Display 
other integrations in single table
URL: https://github.com/apache/airflow/pull/6133#discussion_r325062873
 
 

 ##
 File path: docs/integration.rst
 ##
 @@ -595,17 +583,37 @@ Please note that this library is in maintenance mode 
hence it won't fully suppor
 Therefore it is recommended that you use the custom GCP Service Operators for 
working with the Google
 Cloud Platform.
 
-.. _Qubole:
+.. _other:
+
+Other integrations
+--
 
-Qubole
---
+Operators and Hooks
+'''
+
+Service operators and hooks
+"""
 
-Apache Airflow has a native operator and hooks to talk to `Qubole 
`__,
-which lets you submit your big data jobs directly to Qubole from Apache 
Airflow.
+These integrations allow you to perform various operations within various 
services.
 
-The operators are defined in the following module:
+.. list-table::
+   :header-rows: 1
+
+   * - Service name
+ - Guide
+ - Hook
+ - Operators
+ - Sensors
+
+   * - `Qubole `__
+ -
+ - :mod:`airflow.contrib.hooks.qubole_hook`
+ - :mod:`airflow.contrib.operators.qubole_operator`,
+   :mod:`airflow.contrib.operators.qubole_check_operator`
+ - :mod:`airflow.contrib.sensors.qubole_sensor`
 
- * :mod:`airflow.contrib.operators.qubole_operator`
- * :mod:`airflow.contrib.sensors.qubole_sensor`
- * :mod:`airflow.contrib.sensors.qubole_sensor`
- * :mod:`airflow.contrib.operators.qubole_check_operator`
+   * - `Databricks `__
+ -
+ - :mod:`airflow.contrib.hooks.databricks_hook`
+ - :class:`airflow.contrib.operators.databricks_operator`
 
 Review comment:
   ```suggestion
- :mod:`airflow.contrib.operators.databricks_operator`
   ```
   I will fix it now


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6133: [AIRLFOW-XXX] Display other integrations in single table

[GitBox]

mik-laj commented on a change in pull request #6133: [AIRLFOW-XXX] Display 
other integrations in single table
URL: https://github.com/apache/airflow/pull/6133#discussion_r325062873
 
 

 ##
 File path: docs/integration.rst
 ##
 @@ -595,17 +583,37 @@ Please note that this library is in maintenance mode 
hence it won't fully suppor
 Therefore it is recommended that you use the custom GCP Service Operators for 
working with the Google
 Cloud Platform.
 
-.. _Qubole:
+.. _other:
+
+Other integrations
+--
 
-Qubole
---
+Operators and Hooks
+'''
+
+Service operators and hooks
+"""
 
-Apache Airflow has a native operator and hooks to talk to `Qubole 
`__,
-which lets you submit your big data jobs directly to Qubole from Apache 
Airflow.
+These integrations allow you to perform various operations within various 
services.
 
-The operators are defined in the following module:
+.. list-table::
+   :header-rows: 1
+
+   * - Service name
+ - Guide
+ - Hook
+ - Operators
+ - Sensors
+
+   * - `Qubole `__
+ -
+ - :mod:`airflow.contrib.hooks.qubole_hook`
+ - :mod:`airflow.contrib.operators.qubole_operator`,
+   :mod:`airflow.contrib.operators.qubole_check_operator`
+ - :mod:`airflow.contrib.sensors.qubole_sensor`
 
- * :mod:`airflow.contrib.operators.qubole_operator`
- * :mod:`airflow.contrib.sensors.qubole_sensor`
- * :mod:`airflow.contrib.sensors.qubole_sensor`
- * :mod:`airflow.contrib.operators.qubole_check_operator`
+   * - `Databricks `__
+ -
+ - :mod:`airflow.contrib.hooks.databricks_hook`
+ - :class:`airflow.contrib.operators.databricks_operator`
 
 Review comment:
   ```suggestion
- :mod:`airflow.contrib.operators.databricks_operator`
   ```
   I fix it now


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-5498) Move Discovery hook to core

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931280#comment-16931280
 ] 

ASF GitHub Bot commented on AIRFLOW-5498:
-

mik-laj commented on pull request #6121: [AIRFLOW-5498] Move GCP Discovery hook 
to core
URL: https://github.com/apache/airflow/pull/6121
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move Discovery hook to core
> ---
>
> Key: AIRFLOW-5498
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5498
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [airflow] mik-laj merged pull request #6121: [AIRFLOW-5498] Move GCP Discovery hook to core

[GitBox]

mik-laj merged pull request #6121: [AIRFLOW-5498] Move GCP Discovery hook to 
core
URL: https://github.com/apache/airflow/pull/6121
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-3149) GCP dataproc cluster creation should have the option to delete an ERROR cluster

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931285#comment-16931285
 ] 

ASF GitHub Bot commented on AIRFLOW-3149:
-

mik-laj commented on pull request #4064: AIRFLOW-3149 Support dataproc cluster 
deletion on ERROR
URL: https://github.com/apache/airflow/pull/4064
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GCP dataproc cluster creation should have the option to delete an ERROR 
> cluster
> ---
>
> Key: AIRFLOW-3149
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3149
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 1.10.0
>Reporter: Aaron Dossett
>Assignee: Aaron Dossett
>Priority: Minor
>
> We sometimes encounter issues where a dataproc cluster creation ends up in 
> ERROR state. That is, the cluster “exists” but in the state of ERROR[1] (not 
> just that the cluster creation API call failed). This makes retries 
> impossible since the cluster name already exists subsequent retried creations 
> are guaranteed to fail. 
> A `delete_cluster_on_error` parameter should be added to the 
> `DataprocClusterCreateOperator` operator that controls whether or not an 
> attempt to delete an ERROR cluster is made.
>  
> [1] - I’ve seen that happen in two ways 1) a purely transient error from GCP 
> `Internal server error` or the like 2) when the request is rejected because 
> it would exceed the project quota.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (AIRFLOW-3149) GCP dataproc cluster creation should have the option to delete an ERROR cluster

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931286#comment-16931286
 ] 

ASF subversion and git services commented on AIRFLOW-3149:
--

Commit 578c57f1ccac0ef8b5d17b0c6d7b0fa9accff8e2 in airflow's branch 
refs/heads/master from Aaron Niskode-Dossett
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=578c57f ]

[AIRFLOW-3149] Support Dataproc cluster deletion on ERROR (#4064)



> GCP dataproc cluster creation should have the option to delete an ERROR 
> cluster
> ---
>
> Key: AIRFLOW-3149
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3149
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 1.10.0
>Reporter: Aaron Dossett
>Assignee: Aaron Dossett
>Priority: Minor
>
> We sometimes encounter issues where a dataproc cluster creation ends up in 
> ERROR state. That is, the cluster “exists” but in the state of ERROR[1] (not 
> just that the cluster creation API call failed). This makes retries 
> impossible since the cluster name already exists subsequent retried creations 
> are guaranteed to fail. 
> A `delete_cluster_on_error` parameter should be added to the 
> `DataprocClusterCreateOperator` operator that controls whether or not an 
> attempt to delete an ERROR cluster is made.
>  
> [1] - I’ve seen that happen in two ways 1) a purely transient error from GCP 
> `Internal server error` or the like 2) when the request is rejected because 
> it would exceed the project quota.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [airflow] mik-laj commented on issue #4785: [AIRFLOW-3965] Fixing GoogleCloudStorageToBigQueryOperator failing for jobs outside US and EU

[GitBox]

mik-laj commented on issue #4785: [AIRFLOW-3965] Fixing 
GoogleCloudStorageToBigQueryOperator failing for jobs outside US and EU
URL: https://github.com/apache/airflow/pull/4785#issuecomment-532167556
 
 
   @nuclearpinguin Is it done in separate PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #5419: [AIRFLOW-XXXX] Update pydoc of mlengine_operator

[GitBox]

mik-laj merged pull request #5419: [AIRFLOW-] Update pydoc of 
mlengine_operator
URL: https://github.com/apache/airflow/pull/5419
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR

[GitBox]

mik-laj merged pull request #4064: AIRFLOW-3149 Support dataproc cluster 
deletion on ERROR
URL: https://github.com/apache/airflow/pull/4064
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-5162) GCS Uploads for local files and file data (string or bytes)

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931291#comment-16931291
 ] 

ASF GitHub Bot commented on AIRFLOW-5162:
-

mik-laj commented on pull request #5770: [AIRFLOW-5162] GCS Hook Upload Method 
Improvement
URL: https://github.com/apache/airflow/pull/5770
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GCS Uploads for local files and file data (string or bytes)
> ---
>
> Key: AIRFLOW-5162
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5162
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 1.10.4, 1.10.5
>Reporter: Steven Freed
>Priority: Minor
>  Labels: beginner, features, pull-request-available
>
> Allows for gcs uploads to be done by specifying a local file name or by using 
> the file's content. File content can be uploaded as a string or bytes. This 
> gives developers more alternatives to uploading files where developers may 
> have constraints on disk space and prefer to upload via file content in 
> memory. This update also helps airflow update to Google's new 
> 'upload_from_string' method for gcs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [airflow] mik-laj merged pull request #5770: [AIRFLOW-5162] GCS Hook Upload Method Improvement

[GitBox]

mik-laj merged pull request #5770: [AIRFLOW-5162] GCS Hook Upload Method 
Improvement
URL: https://github.com/apache/airflow/pull/5770
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes

[GitBox]

codecov-io edited a comment on issue #5786:  [AIRFLOW-5170] [AIRFLOW-5256] 
Consistent licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786#issuecomment-530201564
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5786?src=pr=h1) 
Report
   > Merging 
[#5786](https://codecov.io/gh/apache/airflow/pull/5786?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `84.8%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/5786/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/5786?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #5786  +/-   ##
   =
   - Coverage   80.12%   80.1%   -0.02% 
   =
 Files 607 606   -1 
 Lines   34902   34916  +14 
   =
   + Hits27965   27971   +6 
   - Misses   69376945   +8
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/5786?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/docker\_copy\_data.py](https://codecov.io/gh/apache/airflow/pull/5786/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZG9ja2VyX2NvcHlfZGF0YS5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/utils/strings.py](https://codecov.io/gh/apache/airflow/pull/5786/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zdHJpbmdzLnB5)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/example\_dags/example\_bigtable.py](https://codecov.io/gh/apache/airflow/pull/5786/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlndGFibGUucHk=)
 | `0% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/5786/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/hooks/mlengine.py](https://codecov.io/gh/apache/airflow/pull/5786/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvbWxlbmdpbmUucHk=)
 | `20.66% <ø> (ø)` | :arrow_up: |
   | 
[airflow/gcp/utils/mlengine\_operator\_utils.py](https://codecov.io/gh/apache/airflow/pull/5786/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvdXRpbHMvbWxlbmdpbmVfb3BlcmF0b3JfdXRpbHMucHk=)
 | `95.34% <ø> (ø)` | :arrow_up: |
   | 
[airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/5786/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=)
 | `84% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/5786/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/ssh\_hook.py](https://codecov.io/gh/apache/airflow/pull/5786/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NzaF9ob29rLnB5)
 | `87.5% <ø> (ø)` | :arrow_up: |
   | 
[airflow/kubernetes/pod.py](https://codecov.io/gh/apache/airflow/pull/5786/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZC5weQ==)
 | `91.66% <ø> (ø)` | :arrow_up: |
   | ... and [35 
more](https://codecov.io/gh/apache/airflow/pull/5786/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/5786?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/5786?src=pr=footer). 
Last update 
[9cc748b...eee6687](https://codecov.io/gh/apache/airflow/pull/5786?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] alrolorojas commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug

[GitBox]

alrolorojas commented on a change in pull request #6100: [AIRFLOW-5387] Fix 
show paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325116240
 
 

 ##
 File path: tests/www/test_utils.py
 ##
 @@ -103,14 +105,45 @@ def test_params_search(self):
 self.assertEqual('search=bash_',
  utils.get_params(search='bash_'))
 
-def test_params_showPaused_true(self):
-"""Should detect True as default for showPaused"""
-self.assertEqual('',
- utils.get_params(showPaused=True))
-
-def test_params_showPaused_false(self):
-self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+@parameterized.expand([
+(True, False, ''),
+(False, True, ''),
+(True, True, 'showPaused=True'),
+(False, False, 'showPaused=False'),
+(None, True, ''),
+(None, False, ''),
+])
+def test_params_showPaused(self, show_paused, hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
 
 Review comment:
   > Okay, but I mean why should self.assertEqual(expected_result, 
utils.get_params(showPaused=show_paused)) raise an error?
   Wouldn't..
   self.assertEqual(expected_result, utils.get_params(showPaused=show_paused))
   del os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT']
   ..also work?
   
   @feluelle if for some reason `utils.get_params` method raises an error the 
`del os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] would not 
get executed leaving that environment enabled for other tests. That was a 
teardown that only applies to a single test.
   
   > Rather than setting the env var can you use the conf_vars context manager 
we use in other tests (check out ./tests/test_utils/config.py)
   
   @ashb I'm taking a look. Thanks for the pointer!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] alrolorojas commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug

[GitBox]

alrolorojas commented on a change in pull request #6100: [AIRFLOW-5387] Fix 
show paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325116240
 
 

 ##
 File path: tests/www/test_utils.py
 ##
 @@ -103,14 +105,45 @@ def test_params_search(self):
 self.assertEqual('search=bash_',
  utils.get_params(search='bash_'))
 
-def test_params_showPaused_true(self):
-"""Should detect True as default for showPaused"""
-self.assertEqual('',
- utils.get_params(showPaused=True))
-
-def test_params_showPaused_false(self):
-self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+@parameterized.expand([
+(True, False, ''),
+(False, True, ''),
+(True, True, 'showPaused=True'),
+(False, False, 'showPaused=False'),
+(None, True, ''),
+(None, False, ''),
+])
+def test_params_showPaused(self, show_paused, hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
 
 Review comment:
   > Okay, but I mean why should self.assertEqual(expected_result, 
utils.get_params(showPaused=show_paused)) raise an error?
   Wouldn't..
   self.assertEqual(expected_result, utils.get_params(showPaused=show_paused))
   del os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT']
   ..also work?
   
   @feluelle if for some reason `utils.get_params` method raises an error the 
`del os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT']` would not 
get executed leaving that environment variable enabled for other unit tests. 
That was a teardown that only applies to a single test.
   
   > Rather than setting the env var can you use the conf_vars context manager 
we use in other tests (check out ./tests/test_utils/config.py)
   
   @ashb I'm taking a look. Thanks for the pointer!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-5343) pool_pre_ping support for SQLAlchemy connection

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931337#comment-16931337
 ] 

ASF GitHub Bot commented on AIRFLOW-5343:
-

ashb commented on pull request #6034: [AIRFLOW-5343] Remove legacy way of 
pessimistic disconnect handling
URL: https://github.com/apache/airflow/pull/6034
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> pool_pre_ping support for SQLAlchemy connection
> ---
>
> Key: AIRFLOW-5343
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5343
> Project: Apache Airflow
>  Issue Type: Task
>  Components: configuration
>Affects Versions: 1.10.4
>Reporter: Igor Khrol
>Priority: Minor
> Fix For: 1.10.6
>
>
> SQLalchemy supports connection check while returning it from the pool. There 
> is a need to allow this parameter (`pool_pre_ping`) while creating the 
> connection to database.
>  
> [https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic]
> [https://github.com/apache/airflow/blob/master/airflow/settings.py#L189]
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [airflow] ashb commented on issue #6066: [AIRFLOW-XXX] Update to new logo

[GitBox]

ashb commented on issue #6066: [AIRFLOW-XXX] Update to new logo
URL: https://github.com/apache/airflow/pull/6066#issuecomment-532182768
 
 
   > The only thing missing is probably a **large transparent Airflow logo**.
   > 
   > We have a transparent image as emoji but not with bigger size.
   
   Done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #6132: [AIRFLOW-XXX] Display Azure integration in table

[GitBox]

feluelle commented on a change in pull request #6132: [AIRFLOW-XXX] Display 
Azure integration in table
URL: https://github.com/apache/airflow/pull/6132#discussion_r325059039
 
 

 ##
 File path: docs/integration.rst
 ##
 @@ -38,80 +36,78 @@ Airflow can be configured to read and write task logs in 
Azure Blob Storage.
 See :ref:`write-logs-azure`.
 
 
-Azure Blob Storage
-''
-
-All classes communicate via the Window Azure Storage Blob protocol. Make sure 
that a
-Airflow connection of type `wasb` exists. Authorization can be done by 
supplying a
-login (=Storage account name) and password (=KEY), or login and SAS token in 
the extra
-field (see connection `wasb_default` for an example).
-
-The operators are defined in the following module:
-
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.wasb_delete_blob_operator`
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.file_to_wasb`
-
-They use :class:`airflow.contrib.hooks.wasb_hook.WasbHook` to communicate with 
Microsoft Azure.
-
-Azure File Share
-
+Operators and Hooks
+'''
 
-Cloud variant of a SMB file share. Make sure that a Airflow connection of
-type `wasb` exists. Authorization can be done by supplying a login (=Storage 
account name)
-and password (=Storage account key), or login and SAS token in the extra field
-(see connection `wasb_default` for an example).
+Service operators and hooks
+"""
 
-It uses :class:`airflow.contrib.hooks.azure_fileshare_hook.AzureFileShareHook` 
to communicate with Microsoft Azure.
+These integrations allow you to perform various operations within the 
Microsoft Azure.
 
-Azure CosmosDB
-''
 
-AzureCosmosDBHook communicates via the Azure Cosmos library. Make sure that a
-Airflow connection of type `azure_cosmos` exists. Authorization can be done by 
supplying a
-login (=Endpoint uri), password (=secret key) and extra fields database_name 
and collection_name to specify the
-default database and collection to use (see connection `azure_cosmos_default` 
for an example).
+.. list-table::
+   :header-rows: 1
 
-The operators are defined in the following modules:
+   * - Service name
+ - Hook
+ - Operators
+ - Sensors
 
-* :mod:`airflow.contrib.operators.azure_cosmos_operator`
-* :mod:`airflow.contrib.sensors.azure_cosmos_sensor`
+   * - `Azure Blob Storage 
`__
+ -
+ - :mod:`airflow.contrib.operators.wasb_delete_blob_operator`,
+ - :mod:`airflow.contrib.sensors.wasb_sensor`
 
-They also use 
:class:`airflow.contrib.hooks.azure_cosmos_hook.AzureCosmosDBHook` to 
communicate with Microsoft Azure.
+   * - `Azure Container Instances 
`__
+ - :mod:`airflow.contrib.hooks.azure_container_instance_hook`
 
 Review comment:
   ```suggestion
- :mod:`airflow.contrib.hooks.azure_container_instance_hook`,
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #6132: [AIRFLOW-XXX] Display Azure integration in table

[GitBox]

feluelle commented on a change in pull request #6132: [AIRFLOW-XXX] Display 
Azure integration in table
URL: https://github.com/apache/airflow/pull/6132#discussion_r325059100
 
 

 ##
 File path: docs/integration.rst
 ##
 @@ -38,80 +36,78 @@ Airflow can be configured to read and write task logs in 
Azure Blob Storage.
 See :ref:`write-logs-azure`.
 
 
-Azure Blob Storage
-''
-
-All classes communicate via the Window Azure Storage Blob protocol. Make sure 
that a
-Airflow connection of type `wasb` exists. Authorization can be done by 
supplying a
-login (=Storage account name) and password (=KEY), or login and SAS token in 
the extra
-field (see connection `wasb_default` for an example).
-
-The operators are defined in the following module:
-
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.wasb_delete_blob_operator`
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.file_to_wasb`
-
-They use :class:`airflow.contrib.hooks.wasb_hook.WasbHook` to communicate with 
Microsoft Azure.
-
-Azure File Share
-
+Operators and Hooks
+'''
 
-Cloud variant of a SMB file share. Make sure that a Airflow connection of
-type `wasb` exists. Authorization can be done by supplying a login (=Storage 
account name)
-and password (=Storage account key), or login and SAS token in the extra field
-(see connection `wasb_default` for an example).
+Service operators and hooks
+"""
 
-It uses :class:`airflow.contrib.hooks.azure_fileshare_hook.AzureFileShareHook` 
to communicate with Microsoft Azure.
+These integrations allow you to perform various operations within the 
Microsoft Azure.
 
-Azure CosmosDB
-''
 
-AzureCosmosDBHook communicates via the Azure Cosmos library. Make sure that a
-Airflow connection of type `azure_cosmos` exists. Authorization can be done by 
supplying a
-login (=Endpoint uri), password (=secret key) and extra fields database_name 
and collection_name to specify the
-default database and collection to use (see connection `azure_cosmos_default` 
for an example).
+.. list-table::
+   :header-rows: 1
 
-The operators are defined in the following modules:
+   * - Service name
+ - Hook
+ - Operators
+ - Sensors
 
-* :mod:`airflow.contrib.operators.azure_cosmos_operator`
-* :mod:`airflow.contrib.sensors.azure_cosmos_sensor`
+   * - `Azure Blob Storage 
`__
+ -
+ - :mod:`airflow.contrib.operators.wasb_delete_blob_operator`,
+ - :mod:`airflow.contrib.sensors.wasb_sensor`
 
-They also use 
:class:`airflow.contrib.hooks.azure_cosmos_hook.AzureCosmosDBHook` to 
communicate with Microsoft Azure.
+   * - `Azure Container Instances 
`__
+ - :mod:`airflow.contrib.hooks.azure_container_instance_hook`
+   :mod:`airflow.contrib.hooks.azure_container_registry_hook`
 
 Review comment:
   ```suggestion
  :mod:`airflow.contrib.hooks.azure_container_registry_hook`,
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6132: [AIRFLOW-XXX] Display Azure integration in table

[GitBox]

mik-laj commented on a change in pull request #6132: [AIRFLOW-XXX] Display 
Azure integration in table
URL: https://github.com/apache/airflow/pull/6132#discussion_r325063916
 
 

 ##
 File path: docs/integration.rst
 ##
 @@ -38,80 +36,78 @@ Airflow can be configured to read and write task logs in 
Azure Blob Storage.
 See :ref:`write-logs-azure`.
 
 
-Azure Blob Storage
-''
-
-All classes communicate via the Window Azure Storage Blob protocol. Make sure 
that a
-Airflow connection of type `wasb` exists. Authorization can be done by 
supplying a
-login (=Storage account name) and password (=KEY), or login and SAS token in 
the extra
-field (see connection `wasb_default` for an example).
-
-The operators are defined in the following module:
-
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.wasb_delete_blob_operator`
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.file_to_wasb`
-
-They use :class:`airflow.contrib.hooks.wasb_hook.WasbHook` to communicate with 
Microsoft Azure.
-
-Azure File Share
-
+Operators and Hooks
+'''
 
-Cloud variant of a SMB file share. Make sure that a Airflow connection of
-type `wasb` exists. Authorization can be done by supplying a login (=Storage 
account name)
-and password (=Storage account key), or login and SAS token in the extra field
-(see connection `wasb_default` for an example).
+Service operators and hooks
+"""
 
-It uses :class:`airflow.contrib.hooks.azure_fileshare_hook.AzureFileShareHook` 
to communicate with Microsoft Azure.
+These integrations allow you to perform various operations within the 
Microsoft Azure.
 
-Azure CosmosDB
-''
 
-AzureCosmosDBHook communicates via the Azure Cosmos library. Make sure that a
-Airflow connection of type `azure_cosmos` exists. Authorization can be done by 
supplying a
-login (=Endpoint uri), password (=secret key) and extra fields database_name 
and collection_name to specify the
-default database and collection to use (see connection `azure_cosmos_default` 
for an example).
+.. list-table::
+   :header-rows: 1
 
-The operators are defined in the following modules:
+   * - Service name
+ - Hook
+ - Operators
+ - Sensors
 
-* :mod:`airflow.contrib.operators.azure_cosmos_operator`
-* :mod:`airflow.contrib.sensors.azure_cosmos_sensor`
+   * - `Azure Blob Storage 
`__
+ -
+ - :mod:`airflow.contrib.operators.wasb_delete_blob_operator`,
+ - :mod:`airflow.contrib.sensors.wasb_sensor`
 
-They also use 
:class:`airflow.contrib.hooks.azure_cosmos_hook.AzureCosmosDBHook` to 
communicate with Microsoft Azure.
+   * - `Azure Container Instances 
`__
+ - :mod:`airflow.contrib.hooks.azure_container_instance_hook`
+   :mod:`airflow.contrib.hooks.azure_container_registry_hook`
 
 Review comment:
   Thanks. Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6132: [AIRFLOW-XXX] Display Azure integration in table

[GitBox]

mik-laj commented on a change in pull request #6132: [AIRFLOW-XXX] Display 
Azure integration in table
URL: https://github.com/apache/airflow/pull/6132#discussion_r325063888
 
 

 ##
 File path: docs/integration.rst
 ##
 @@ -38,80 +36,78 @@ Airflow can be configured to read and write task logs in 
Azure Blob Storage.
 See :ref:`write-logs-azure`.
 
 
-Azure Blob Storage
-''
-
-All classes communicate via the Window Azure Storage Blob protocol. Make sure 
that a
-Airflow connection of type `wasb` exists. Authorization can be done by 
supplying a
-login (=Storage account name) and password (=KEY), or login and SAS token in 
the extra
-field (see connection `wasb_default` for an example).
-
-The operators are defined in the following module:
-
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.wasb_delete_blob_operator`
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.file_to_wasb`
-
-They use :class:`airflow.contrib.hooks.wasb_hook.WasbHook` to communicate with 
Microsoft Azure.
-
-Azure File Share
-
+Operators and Hooks
+'''
 
-Cloud variant of a SMB file share. Make sure that a Airflow connection of
-type `wasb` exists. Authorization can be done by supplying a login (=Storage 
account name)
-and password (=Storage account key), or login and SAS token in the extra field
-(see connection `wasb_default` for an example).
+Service operators and hooks
+"""
 
-It uses :class:`airflow.contrib.hooks.azure_fileshare_hook.AzureFileShareHook` 
to communicate with Microsoft Azure.
+These integrations allow you to perform various operations within the 
Microsoft Azure.
 
-Azure CosmosDB
-''
 
-AzureCosmosDBHook communicates via the Azure Cosmos library. Make sure that a
-Airflow connection of type `azure_cosmos` exists. Authorization can be done by 
supplying a
-login (=Endpoint uri), password (=secret key) and extra fields database_name 
and collection_name to specify the
-default database and collection to use (see connection `azure_cosmos_default` 
for an example).
+.. list-table::
+   :header-rows: 1
 
-The operators are defined in the following modules:
+   * - Service name
+ - Hook
+ - Operators
+ - Sensors
 
-* :mod:`airflow.contrib.operators.azure_cosmos_operator`
-* :mod:`airflow.contrib.sensors.azure_cosmos_sensor`
+   * - `Azure Blob Storage 
`__
+ -
+ - :mod:`airflow.contrib.operators.wasb_delete_blob_operator`,
+ - :mod:`airflow.contrib.sensors.wasb_sensor`
 
-They also use 
:class:`airflow.contrib.hooks.azure_cosmos_hook.AzureCosmosDBHook` to 
communicate with Microsoft Azure.
+   * - `Azure Container Instances 
`__
+ - :mod:`airflow.contrib.hooks.azure_container_instance_hook`
 
 Review comment:
   Thanks. Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6132: [AIRFLOW-XXX] Display Azure integration in table

[GitBox]

mik-laj commented on a change in pull request #6132: [AIRFLOW-XXX] Display 
Azure integration in table
URL: https://github.com/apache/airflow/pull/6132#discussion_r325063862
 
 

 ##
 File path: docs/integration.rst
 ##
 @@ -38,80 +36,78 @@ Airflow can be configured to read and write task logs in 
Azure Blob Storage.
 See :ref:`write-logs-azure`.
 
 
-Azure Blob Storage
-''
-
-All classes communicate via the Window Azure Storage Blob protocol. Make sure 
that a
-Airflow connection of type `wasb` exists. Authorization can be done by 
supplying a
-login (=Storage account name) and password (=KEY), or login and SAS token in 
the extra
-field (see connection `wasb_default` for an example).
-
-The operators are defined in the following module:
-
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.wasb_delete_blob_operator`
-* :mod:`airflow.contrib.sensors.wasb_sensor`
-* :mod:`airflow.contrib.operators.file_to_wasb`
-
-They use :class:`airflow.contrib.hooks.wasb_hook.WasbHook` to communicate with 
Microsoft Azure.
-
-Azure File Share
-
+Operators and Hooks
+'''
 
-Cloud variant of a SMB file share. Make sure that a Airflow connection of
-type `wasb` exists. Authorization can be done by supplying a login (=Storage 
account name)
-and password (=Storage account key), or login and SAS token in the extra field
-(see connection `wasb_default` for an example).
+Service operators and hooks
+"""
 
-It uses :class:`airflow.contrib.hooks.azure_fileshare_hook.AzureFileShareHook` 
to communicate with Microsoft Azure.
+These integrations allow you to perform various operations within the 
Microsoft Azure.
 
-Azure CosmosDB
-''
 
-AzureCosmosDBHook communicates via the Azure Cosmos library. Make sure that a
-Airflow connection of type `azure_cosmos` exists. Authorization can be done by 
supplying a
-login (=Endpoint uri), password (=secret key) and extra fields database_name 
and collection_name to specify the
-default database and collection to use (see connection `azure_cosmos_default` 
for an example).
+.. list-table::
+   :header-rows: 1
 
-The operators are defined in the following modules:
+   * - Service name
+ - Hook
+ - Operators
+ - Sensors
 
-* :mod:`airflow.contrib.operators.azure_cosmos_operator`
-* :mod:`airflow.contrib.sensors.azure_cosmos_sensor`
+   * - `Azure Blob Storage 
`__
+ -
+ - :mod:`airflow.contrib.operators.wasb_delete_blob_operator`,
 
 Review comment:
   Thanks. Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug

[GitBox]

feluelle commented on a change in pull request #6100: [AIRFLOW-5387] Fix show 
paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325068682
 
 

 ##
 File path: tests/www/test_utils.py
 ##
 @@ -103,14 +105,45 @@ def test_params_search(self):
 self.assertEqual('search=bash_',
  utils.get_params(search='bash_'))
 
-def test_params_showPaused_true(self):
-"""Should detect True as default for showPaused"""
-self.assertEqual('',
- utils.get_params(showPaused=True))
-
-def test_params_showPaused_false(self):
-self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+@parameterized.expand([
+(True, False, ''),
+(False, True, ''),
+(True, True, 'showPaused=True'),
+(False, False, 'showPaused=False'),
+(None, True, ''),
+(None, False, ''),
+])
+def test_params_showPaused(self, show_paused, hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
 
 Review comment:
   Why did you enclose it in a `try-finally` block?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug

[GitBox]

feluelle commented on a change in pull request #6100: [AIRFLOW-5387] Fix show 
paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325068816
 
 

 ##
 File path: tests/www/test_utils.py
 ##
 @@ -103,14 +105,45 @@ def test_params_search(self):
 self.assertEqual('search=bash_',
  utils.get_params(search='bash_'))
 
-def test_params_showPaused_true(self):
-"""Should detect True as default for showPaused"""
-self.assertEqual('',
- utils.get_params(showPaused=True))
-
-def test_params_showPaused_false(self):
-self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+@parameterized.expand([
+(True, False, ''),
+(False, True, ''),
+(True, True, 'showPaused=True'),
+(False, False, 'showPaused=False'),
+(None, True, ''),
+(None, False, ''),
+])
+def test_params_showPaused(self, show_paused, hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
+self.assertEqual(expected_result,
+ utils.get_params(showPaused=show_paused))
+finally:
+del os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT']
+
+@parameterized.expand([
+(True, False, True),
+(False, True, True),
+(True, True, False),
+(False, False, False),
+(None, True, True),
+(None, False, True),
+])
+def test_should_remove_show_paused_from_url_params(self, show_paused,
+   hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
 
 Review comment:
   Same here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] alrolorojas commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug

[GitBox]

alrolorojas commented on a change in pull request #6100: [AIRFLOW-5387] Fix 
show paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325072163
 
 

 ##
 File path: tests/www/test_utils.py
 ##
 @@ -103,14 +105,45 @@ def test_params_search(self):
 self.assertEqual('search=bash_',
  utils.get_params(search='bash_'))
 
-def test_params_showPaused_true(self):
-"""Should detect True as default for showPaused"""
-self.assertEqual('',
- utils.get_params(showPaused=True))
-
-def test_params_showPaused_false(self):
-self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+@parameterized.expand([
+(True, False, ''),
+(False, True, ''),
+(True, True, 'showPaused=True'),
+(False, False, 'showPaused=False'),
+(None, True, ''),
+(None, False, ''),
+])
+def test_params_showPaused(self, show_paused, hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
 
 Review comment:
   @feluelle This is to set a custom value for 
`AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT` environment variable before 
each test and tear it down after the test is done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] alrolorojas commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug

[GitBox]

alrolorojas commented on a change in pull request #6100: [AIRFLOW-5387] Fix 
show paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325072163
 
 

 ##
 File path: tests/www/test_utils.py
 ##
 @@ -103,14 +105,45 @@ def test_params_search(self):
 self.assertEqual('search=bash_',
  utils.get_params(search='bash_'))
 
-def test_params_showPaused_true(self):
-"""Should detect True as default for showPaused"""
-self.assertEqual('',
- utils.get_params(showPaused=True))
-
-def test_params_showPaused_false(self):
-self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+@parameterized.expand([
+(True, False, ''),
+(False, True, ''),
+(True, True, 'showPaused=True'),
+(False, False, 'showPaused=False'),
+(None, True, ''),
+(None, False, ''),
+])
+def test_params_showPaused(self, show_paused, hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
 
 Review comment:
   @feluelle That's a good question. This is to set a custom value for 
`AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT` environment variable before 
each test and tear it down after the test is done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #6132: [AIRFLOW-XXX] Display Azure integration in table

[GitBox]

codecov-io commented on issue #6132: [AIRFLOW-XXX] Display Azure integration in 
table
URL: https://github.com/apache/airflow/pull/6132#issuecomment-532162372
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6132?src=pr=h1) 
Report
   > Merging 
[#6132](https://codecov.io/gh/apache/airflow/pull/6132?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `0.61%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6132/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6132?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #6132  +/-   ##
   =
   - Coverage   80.12%   79.5%   -0.62% 
   =
 Files 607 607  
 Lines   34902   34905   +3 
   =
   - Hits27965   27751 -214 
   - Misses   69377154 +217
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6132?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/hooks/wasb\_hook.py](https://codecov.io/gh/apache/airflow/pull/6132/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3dhc2JfaG9vay5weQ==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[airflow/contrib/hooks/azure\_data\_lake\_hook.py](https://codecov.io/gh/apache/airflow/pull/6132/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2F6dXJlX2RhdGFfbGFrZV9ob29rLnB5)
 | `93.1% <100%> (+0.24%)` | :arrow_up: |
   | 
[airflow/contrib/hooks/azure\_cosmos\_hook.py](https://codecov.io/gh/apache/airflow/pull/6132/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2F6dXJlX2Nvc21vc19ob29rLnB5)
 | `76.1% <100%> (+0.21%)` | :arrow_up: |
   | 
[airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6132/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/6132/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/6132/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/6132/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==)
 | `0% <0%> (-100%)` | :arrow_down: |
   | 
[airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/6132/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5)
 | `40.74% <0%> (-35.56%)` | :arrow_down: |
   | 
[airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6132/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=)
 | `32.87% <0%> (-9.59%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6132/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `73.25% <0%> (-5.82%)` | :arrow_down: |
   | ... and [11 
more](https://codecov.io/gh/apache/airflow/pull/6132/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6132?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6132?src=pr=footer). 
Last update 
[9cc748b...0b6a80b](https://codecov.io/gh/apache/airflow/pull/6132?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-5498) Move Discovery hook to core

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931281#comment-16931281
 ] 

ASF subversion and git services commented on AIRFLOW-5498:
--

Commit 686fac044cc7208fd470aa9c81b172232ab04cd9 in airflow's branch 
refs/heads/master from Tomek
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=686fac0 ]

[AIRFLOW-5498] Move GCP Discovery hook to core (#6121)



> Move Discovery hook to core
> ---
>
> Key: AIRFLOW-5498
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5498
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (AIRFLOW-5162) GCS Uploads for local files and file data (string or bytes)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931299#comment-16931299
 ] 

ASF subversion and git services commented on AIRFLOW-5162:
--

Commit 26aa4ba648697ec582437b1e86ca3191bdcc253c in airflow's branch 
refs/heads/master from Steven Freed
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=26aa4ba ]

[AIRFLOW-5162] GCS Hook Upload Method Improvement (#5770)

* [AIRFLOW-5162] add to 'upload' method for gcs file data

Allows for local file uploads (parameter 'filename') and file content 
(parameter 'data') uploads to gcs by using Google's gcs api method 
'upload_from_string' which allows for uploading files content as a string or 
bytes.

* [AIRFLOW-5162] add ValueError exceptions and upload tests

ValueError exceptions are raised when the filename and data params are
provided or neither are provided. This avoids errors of local files and
file data. Tests assert file and data upload variants as well as assert
exceptions.

* [AIRFLOW-5162] fixed unit tests for gcs uploads

added seperate unit tests for uploading string content and byte content
using the upload_from_string gcp method. Prevents assertion being called
twice when tests are seperated as well as organizes testing.

* [AIRFLOW-5162] added type annotations and tests modifications

Added type annotations for static tests and ease of use for users. Tests
modifications get rid of assertions for None responses and add tests for
calling upload functions once.

* [AIRFLOW-5162] add pylint and flake8 fixes for type annotations

type annotation syntax requires a space between '=' sign for default
assignment.

* [AIRFLOW-5162] added called once and exception tests

added called once tests for upload methods for gzip data. This was added
to assert that the upload_from_string method was called correctly.
Assertions for exceptions confirming the correct exception messages.

* [AIRFLOW-5162] added fix to doc build

Fixed indentation in docstrings so that the documentation can build
properly. Added new lines after descriptions of the methods
functionalities.


> GCS Uploads for local files and file data (string or bytes)
> ---
>
> Key: AIRFLOW-5162
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5162
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 1.10.4, 1.10.5
>Reporter: Steven Freed
>Priority: Minor
>  Labels: beginner, features, pull-request-available
>
> Allows for gcs uploads to be done by specifying a local file name or by using 
> the file's content. File content can be uploaded as a string or bytes. This 
> gives developers more alternatives to uploading files where developers may 
> have constraints on disk space and prefer to upload via file content in 
> memory. This update also helps airflow update to Google's new 
> 'upload_from_string' method for gcs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (AIRFLOW-5162) GCS Uploads for local files and file data (string or bytes)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931295#comment-16931295
 ] 

ASF subversion and git services commented on AIRFLOW-5162:
--

Commit 26aa4ba648697ec582437b1e86ca3191bdcc253c in airflow's branch 
refs/heads/master from Steven Freed
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=26aa4ba ]

[AIRFLOW-5162] GCS Hook Upload Method Improvement (#5770)

* [AIRFLOW-5162] add to 'upload' method for gcs file data

Allows for local file uploads (parameter 'filename') and file content 
(parameter 'data') uploads to gcs by using Google's gcs api method 
'upload_from_string' which allows for uploading files content as a string or 
bytes.

* [AIRFLOW-5162] add ValueError exceptions and upload tests

ValueError exceptions are raised when the filename and data params are
provided or neither are provided. This avoids errors of local files and
file data. Tests assert file and data upload variants as well as assert
exceptions.

* [AIRFLOW-5162] fixed unit tests for gcs uploads

added seperate unit tests for uploading string content and byte content
using the upload_from_string gcp method. Prevents assertion being called
twice when tests are seperated as well as organizes testing.

* [AIRFLOW-5162] added type annotations and tests modifications

Added type annotations for static tests and ease of use for users. Tests
modifications get rid of assertions for None responses and add tests for
calling upload functions once.

* [AIRFLOW-5162] add pylint and flake8 fixes for type annotations

type annotation syntax requires a space between '=' sign for default
assignment.

* [AIRFLOW-5162] added called once and exception tests

added called once tests for upload methods for gzip data. This was added
to assert that the upload_from_string method was called correctly.
Assertions for exceptions confirming the correct exception messages.

* [AIRFLOW-5162] added fix to doc build

Fixed indentation in docstrings so that the documentation can build
properly. Added new lines after descriptions of the methods
functionalities.


> GCS Uploads for local files and file data (string or bytes)
> ---
>
> Key: AIRFLOW-5162
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5162
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 1.10.4, 1.10.5
>Reporter: Steven Freed
>Priority: Minor
>  Labels: beginner, features, pull-request-available
>
> Allows for gcs uploads to be done by specifying a local file name or by using 
> the file's content. File content can be uploaded as a string or bytes. This 
> gives developers more alternatives to uploading files where developers may 
> have constraints on disk space and prefer to upload via file content in 
> memory. This update also helps airflow update to Google's new 
> 'upload_from_string' method for gcs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (AIRFLOW-5162) GCS Uploads for local files and file data (string or bytes)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931296#comment-16931296
 ] 

ASF subversion and git services commented on AIRFLOW-5162:
--

Commit 26aa4ba648697ec582437b1e86ca3191bdcc253c in airflow's branch 
refs/heads/master from Steven Freed
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=26aa4ba ]

[AIRFLOW-5162] GCS Hook Upload Method Improvement (#5770)

* [AIRFLOW-5162] add to 'upload' method for gcs file data

Allows for local file uploads (parameter 'filename') and file content 
(parameter 'data') uploads to gcs by using Google's gcs api method 
'upload_from_string' which allows for uploading files content as a string or 
bytes.

* [AIRFLOW-5162] add ValueError exceptions and upload tests

ValueError exceptions are raised when the filename and data params are
provided or neither are provided. This avoids errors of local files and
file data. Tests assert file and data upload variants as well as assert
exceptions.

* [AIRFLOW-5162] fixed unit tests for gcs uploads

added seperate unit tests for uploading string content and byte content
using the upload_from_string gcp method. Prevents assertion being called
twice when tests are seperated as well as organizes testing.

* [AIRFLOW-5162] added type annotations and tests modifications

Added type annotations for static tests and ease of use for users. Tests
modifications get rid of assertions for None responses and add tests for
calling upload functions once.

* [AIRFLOW-5162] add pylint and flake8 fixes for type annotations

type annotation syntax requires a space between '=' sign for default
assignment.

* [AIRFLOW-5162] added called once and exception tests

added called once tests for upload methods for gzip data. This was added
to assert that the upload_from_string method was called correctly.
Assertions for exceptions confirming the correct exception messages.

* [AIRFLOW-5162] added fix to doc build

Fixed indentation in docstrings so that the documentation can build
properly. Added new lines after descriptions of the methods
functionalities.


> GCS Uploads for local files and file data (string or bytes)
> ---
>
> Key: AIRFLOW-5162
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5162
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 1.10.4, 1.10.5
>Reporter: Steven Freed
>Priority: Minor
>  Labels: beginner, features, pull-request-available
>
> Allows for gcs uploads to be done by specifying a local file name or by using 
> the file's content. File content can be uploaded as a string or bytes. This 
> gives developers more alternatives to uploading files where developers may 
> have constraints on disk space and prefer to upload via file content in 
> memory. This update also helps airflow update to Google's new 
> 'upload_from_string' method for gcs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (AIRFLOW-5162) GCS Uploads for local files and file data (string or bytes)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931298#comment-16931298
 ] 

ASF subversion and git services commented on AIRFLOW-5162:
--

Commit 26aa4ba648697ec582437b1e86ca3191bdcc253c in airflow's branch 
refs/heads/master from Steven Freed
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=26aa4ba ]

[AIRFLOW-5162] GCS Hook Upload Method Improvement (#5770)

* [AIRFLOW-5162] add to 'upload' method for gcs file data

Allows for local file uploads (parameter 'filename') and file content 
(parameter 'data') uploads to gcs by using Google's gcs api method 
'upload_from_string' which allows for uploading files content as a string or 
bytes.

* [AIRFLOW-5162] add ValueError exceptions and upload tests

ValueError exceptions are raised when the filename and data params are
provided or neither are provided. This avoids errors of local files and
file data. Tests assert file and data upload variants as well as assert
exceptions.

* [AIRFLOW-5162] fixed unit tests for gcs uploads

added seperate unit tests for uploading string content and byte content
using the upload_from_string gcp method. Prevents assertion being called
twice when tests are seperated as well as organizes testing.

* [AIRFLOW-5162] added type annotations and tests modifications

Added type annotations for static tests and ease of use for users. Tests
modifications get rid of assertions for None responses and add tests for
calling upload functions once.

* [AIRFLOW-5162] add pylint and flake8 fixes for type annotations

type annotation syntax requires a space between '=' sign for default
assignment.

* [AIRFLOW-5162] added called once and exception tests

added called once tests for upload methods for gzip data. This was added
to assert that the upload_from_string method was called correctly.
Assertions for exceptions confirming the correct exception messages.

* [AIRFLOW-5162] added fix to doc build

Fixed indentation in docstrings so that the documentation can build
properly. Added new lines after descriptions of the methods
functionalities.


> GCS Uploads for local files and file data (string or bytes)
> ---
>
> Key: AIRFLOW-5162
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5162
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 1.10.4, 1.10.5
>Reporter: Steven Freed
>Priority: Minor
>  Labels: beginner, features, pull-request-available
>
> Allows for gcs uploads to be done by specifying a local file name or by using 
> the file's content. File content can be uploaded as a string or bytes. This 
> gives developers more alternatives to uploading files where developers may 
> have constraints on disk space and prefer to upload via file content in 
> memory. This update also helps airflow update to Google's new 
> 'upload_from_string' method for gcs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (AIRFLOW-5162) GCS Uploads for local files and file data (string or bytes)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931297#comment-16931297
 ] 

ASF subversion and git services commented on AIRFLOW-5162:
--

Commit 26aa4ba648697ec582437b1e86ca3191bdcc253c in airflow's branch 
refs/heads/master from Steven Freed
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=26aa4ba ]

[AIRFLOW-5162] GCS Hook Upload Method Improvement (#5770)

* [AIRFLOW-5162] add to 'upload' method for gcs file data

Allows for local file uploads (parameter 'filename') and file content 
(parameter 'data') uploads to gcs by using Google's gcs api method 
'upload_from_string' which allows for uploading files content as a string or 
bytes.

* [AIRFLOW-5162] add ValueError exceptions and upload tests

ValueError exceptions are raised when the filename and data params are
provided or neither are provided. This avoids errors of local files and
file data. Tests assert file and data upload variants as well as assert
exceptions.

* [AIRFLOW-5162] fixed unit tests for gcs uploads

added seperate unit tests for uploading string content and byte content
using the upload_from_string gcp method. Prevents assertion being called
twice when tests are seperated as well as organizes testing.

* [AIRFLOW-5162] added type annotations and tests modifications

Added type annotations for static tests and ease of use for users. Tests
modifications get rid of assertions for None responses and add tests for
calling upload functions once.

* [AIRFLOW-5162] add pylint and flake8 fixes for type annotations

type annotation syntax requires a space between '=' sign for default
assignment.

* [AIRFLOW-5162] added called once and exception tests

added called once tests for upload methods for gzip data. This was added
to assert that the upload_from_string method was called correctly.
Assertions for exceptions confirming the correct exception messages.

* [AIRFLOW-5162] added fix to doc build

Fixed indentation in docstrings so that the documentation can build
properly. Added new lines after descriptions of the methods
functionalities.


> GCS Uploads for local files and file data (string or bytes)
> ---
>
> Key: AIRFLOW-5162
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5162
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 1.10.4, 1.10.5
>Reporter: Steven Freed
>Priority: Minor
>  Labels: beginner, features, pull-request-available
>
> Allows for gcs uploads to be done by specifying a local file name or by using 
> the file's content. File content can be uploaded as a string or bytes. This 
> gives developers more alternatives to uploading files where developers may 
> have constraints on disk space and prefer to upload via file content in 
> memory. This update also helps airflow update to Google's new 
> 'upload_from_string' method for gcs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [airflow] mik-laj commented on a change in pull request #6093: [AIRFLOW-5475] Normalize gcp_conn_id in operators and hooks

[GitBox]

mik-laj commented on a change in pull request #6093: [AIRFLOW-5475] Normalize 
gcp_conn_id in operators and hooks
URL: https://github.com/apache/airflow/pull/6093#discussion_r325102432
 
 

 ##
 File path: UPDATING.md
 ##
 @@ -40,6 +40,40 @@ assists users migrating to a new version.
 
 ## Airflow Master
 
+### Normalize gcp_conn_id for Google Cloud Platform
+
+Previously not all hooks and operators related to Google Cloud Platform use 
+conn_id as parameter for GCP connection. There is currently one parameter 
+which apply to most services. Parameters like ``datastore_conn_id``, 
``bigquery_conn_id``,
+``google_cloud_storage_conn_id`` and similar have been deprecated.
 
 Review comment:
   ```suggestion
   ``google_cloud_storage_conn_id`` and similar have been deprecated. Operators 
that require two connections are not changed.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-5162) GCS Uploads for local files and file data (string or bytes)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931293#comment-16931293
 ] 

ASF subversion and git services commented on AIRFLOW-5162:
--

Commit 26aa4ba648697ec582437b1e86ca3191bdcc253c in airflow's branch 
refs/heads/master from Steven Freed
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=26aa4ba ]

[AIRFLOW-5162] GCS Hook Upload Method Improvement (#5770)

* [AIRFLOW-5162] add to 'upload' method for gcs file data

Allows for local file uploads (parameter 'filename') and file content 
(parameter 'data') uploads to gcs by using Google's gcs api method 
'upload_from_string' which allows for uploading files content as a string or 
bytes.

* [AIRFLOW-5162] add ValueError exceptions and upload tests

ValueError exceptions are raised when the filename and data params are
provided or neither are provided. This avoids errors of local files and
file data. Tests assert file and data upload variants as well as assert
exceptions.

* [AIRFLOW-5162] fixed unit tests for gcs uploads

added seperate unit tests for uploading string content and byte content
using the upload_from_string gcp method. Prevents assertion being called
twice when tests are seperated as well as organizes testing.

* [AIRFLOW-5162] added type annotations and tests modifications

Added type annotations for static tests and ease of use for users. Tests
modifications get rid of assertions for None responses and add tests for
calling upload functions once.

* [AIRFLOW-5162] add pylint and flake8 fixes for type annotations

type annotation syntax requires a space between '=' sign for default
assignment.

* [AIRFLOW-5162] added called once and exception tests

added called once tests for upload methods for gzip data. This was added
to assert that the upload_from_string method was called correctly.
Assertions for exceptions confirming the correct exception messages.

* [AIRFLOW-5162] added fix to doc build

Fixed indentation in docstrings so that the documentation can build
properly. Added new lines after descriptions of the methods
functionalities.


> GCS Uploads for local files and file data (string or bytes)
> ---
>
> Key: AIRFLOW-5162
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5162
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 1.10.4, 1.10.5
>Reporter: Steven Freed
>Priority: Minor
>  Labels: beginner, features, pull-request-available
>
> Allows for gcs uploads to be done by specifying a local file name or by using 
> the file's content. File content can be uploaded as a string or bytes. This 
> gives developers more alternatives to uploading files where developers may 
> have constraints on disk space and prefer to upload via file content in 
> memory. This update also helps airflow update to Google's new 
> 'upload_from_string' method for gcs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (AIRFLOW-5162) GCS Uploads for local files and file data (string or bytes)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931294#comment-16931294
 ] 

ASF subversion and git services commented on AIRFLOW-5162:
--

Commit 26aa4ba648697ec582437b1e86ca3191bdcc253c in airflow's branch 
refs/heads/master from Steven Freed
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=26aa4ba ]

[AIRFLOW-5162] GCS Hook Upload Method Improvement (#5770)

* [AIRFLOW-5162] add to 'upload' method for gcs file data

Allows for local file uploads (parameter 'filename') and file content 
(parameter 'data') uploads to gcs by using Google's gcs api method 
'upload_from_string' which allows for uploading files content as a string or 
bytes.

* [AIRFLOW-5162] add ValueError exceptions and upload tests

ValueError exceptions are raised when the filename and data params are
provided or neither are provided. This avoids errors of local files and
file data. Tests assert file and data upload variants as well as assert
exceptions.

* [AIRFLOW-5162] fixed unit tests for gcs uploads

added seperate unit tests for uploading string content and byte content
using the upload_from_string gcp method. Prevents assertion being called
twice when tests are seperated as well as organizes testing.

* [AIRFLOW-5162] added type annotations and tests modifications

Added type annotations for static tests and ease of use for users. Tests
modifications get rid of assertions for None responses and add tests for
calling upload functions once.

* [AIRFLOW-5162] add pylint and flake8 fixes for type annotations

type annotation syntax requires a space between '=' sign for default
assignment.

* [AIRFLOW-5162] added called once and exception tests

added called once tests for upload methods for gzip data. This was added
to assert that the upload_from_string method was called correctly.
Assertions for exceptions confirming the correct exception messages.

* [AIRFLOW-5162] added fix to doc build

Fixed indentation in docstrings so that the documentation can build
properly. Added new lines after descriptions of the methods
functionalities.


> GCS Uploads for local files and file data (string or bytes)
> ---
>
> Key: AIRFLOW-5162
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5162
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 1.10.4, 1.10.5
>Reporter: Steven Freed
>Priority: Minor
>  Labels: beginner, features, pull-request-available
>
> Allows for gcs uploads to be done by specifying a local file name or by using 
> the file's content. File content can be uploaded as a string or bytes. This 
> gives developers more alternatives to uploading files where developers may 
> have constraints on disk space and prefer to upload via file content in 
> memory. This update also helps airflow update to Google's new 
> 'upload_from_string' method for gcs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (AIRFLOW-5162) GCS Uploads for local files and file data (string or bytes)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931292#comment-16931292
 ] 

ASF subversion and git services commented on AIRFLOW-5162:
--

Commit 26aa4ba648697ec582437b1e86ca3191bdcc253c in airflow's branch 
refs/heads/master from Steven Freed
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=26aa4ba ]

[AIRFLOW-5162] GCS Hook Upload Method Improvement (#5770)

* [AIRFLOW-5162] add to 'upload' method for gcs file data

Allows for local file uploads (parameter 'filename') and file content 
(parameter 'data') uploads to gcs by using Google's gcs api method 
'upload_from_string' which allows for uploading files content as a string or 
bytes.

* [AIRFLOW-5162] add ValueError exceptions and upload tests

ValueError exceptions are raised when the filename and data params are
provided or neither are provided. This avoids errors of local files and
file data. Tests assert file and data upload variants as well as assert
exceptions.

* [AIRFLOW-5162] fixed unit tests for gcs uploads

added seperate unit tests for uploading string content and byte content
using the upload_from_string gcp method. Prevents assertion being called
twice when tests are seperated as well as organizes testing.

* [AIRFLOW-5162] added type annotations and tests modifications

Added type annotations for static tests and ease of use for users. Tests
modifications get rid of assertions for None responses and add tests for
calling upload functions once.

* [AIRFLOW-5162] add pylint and flake8 fixes for type annotations

type annotation syntax requires a space between '=' sign for default
assignment.

* [AIRFLOW-5162] added called once and exception tests

added called once tests for upload methods for gzip data. This was added
to assert that the upload_from_string method was called correctly.
Assertions for exceptions confirming the correct exception messages.

* [AIRFLOW-5162] added fix to doc build

Fixed indentation in docstrings so that the documentation can build
properly. Added new lines after descriptions of the methods
functionalities.


> GCS Uploads for local files and file data (string or bytes)
> ---
>
> Key: AIRFLOW-5162
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5162
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: gcp
>Affects Versions: 1.10.4, 1.10.5
>Reporter: Steven Freed
>Priority: Minor
>  Labels: beginner, features, pull-request-available
>
> Allows for gcs uploads to be done by specifying a local file name or by using 
> the file's content. File content can be uploaded as a string or bytes. This 
> gives developers more alternatives to uploading files where developers may 
> have constraints on disk space and prefer to upload via file content in 
> memory. This update also helps airflow update to Google's new 
> 'upload_from_string' method for gcs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [airflow] mik-laj commented on a change in pull request #6093: [AIRFLOW-5475] Normalize gcp_conn_id in operators and hooks

[GitBox]

mik-laj commented on a change in pull request #6093: [AIRFLOW-5475] Normalize 
gcp_conn_id in operators and hooks
URL: https://github.com/apache/airflow/pull/6093#discussion_r325102153
 
 

 ##
 File path: UPDATING.md
 ##
 @@ -40,6 +40,40 @@ assists users migrating to a new version.
 
 ## Airflow Master
 
+### Normalize gcp_conn_id for Google Cloud Platform
+
+Previously not all hooks and operators related to Google Cloud Platform use 
+conn_id as parameter for GCP connection. There is currently one parameter 
 
 Review comment:
   ```suggestion
   `gcp_conn_id` as parameter for GCP connection. There is currently one 
parameter 
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on issue #4785: [AIRFLOW-3965] Fixing GoogleCloudStorageToBigQueryOperator failing for jobs outside US and EU

[GitBox]

nuclearpinguin commented on issue #4785: [AIRFLOW-3965] Fixing 
GoogleCloudStorageToBigQueryOperator failing for jobs outside US and EU
URL: https://github.com/apache/airflow/pull/4785#issuecomment-532174239
 
 
   > @nuclearpinguin Is it done in separate PR?
   
   If the issue was indeed due to lack of location parameter then it solved.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug

[GitBox]

feluelle commented on a change in pull request #6100: [AIRFLOW-5387] Fix show 
paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325109502
 
 

 ##
 File path: tests/www/test_utils.py
 ##
 @@ -103,14 +105,45 @@ def test_params_search(self):
 self.assertEqual('search=bash_',
  utils.get_params(search='bash_'))
 
-def test_params_showPaused_true(self):
-"""Should detect True as default for showPaused"""
-self.assertEqual('',
- utils.get_params(showPaused=True))
-
-def test_params_showPaused_false(self):
-self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+@parameterized.expand([
+(True, False, ''),
+(False, True, ''),
+(True, True, 'showPaused=True'),
+(False, False, 'showPaused=False'),
+(None, True, ''),
+(None, False, ''),
+])
+def test_params_showPaused(self, show_paused, hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
 
 Review comment:
   Okay, but I mean why should `self.assertEqual(expected_result, 
utils.get_params(showPaused=show_paused))` raise an error?
   
   Wouldn't..
   ```
   self.assertEqual(expected_result, utils.get_params(showPaused=show_paused))
   del os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT']
   ```
   ..also work?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

[GitBox]

ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove 
aws_default's default region name
URL: https://github.com/apache/airflow/pull/5879#discussion_r325112886
 
 

 ##
 File path: scripts/ci/in_container/entrypoint_ci.sh
 ##
 @@ -121,6 +121,10 @@ export 
PYTHONPATH=${PYTHONPATH:-${AIRFLOW_SOURCES}/tests/test_utils}
 export PATH=${PATH}:${AIRFLOW_SOURCES}
 
 export AIRFLOW__CORE__UNIT_TEST_MODE=True
+export HADOOP_DISTRO
 
 Review comment:
   Unrelated/old change?
   ```suggestion
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle edited a comment on issue #6080: Update postgres_hook.py

[GitBox]

feluelle edited a comment on issue #6080: Update postgres_hook.py
URL: https://github.com/apache/airflow/pull/6080#issuecomment-532146519
 
 
   Welcome @KarunakarGumudala !
   
   I like your feature   but I would like to point you to a few steps that you 
need to change/setup first.
   
   * Please associate a ticket to this change as described in the PR template.
   * Also please read the Contributing guide to [setup your development 
environment](https://github.com/apache/airflow/blob/master/CONTRIBUTING.md#development-environments)
 so that you can test your changes accordingly. 
   
   Thank you :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on issue #6080: Update postgres_hook.py

[GitBox]

feluelle commented on issue #6080: Update postgres_hook.py
URL: https://github.com/apache/airflow/pull/6080#issuecomment-532146519
 
 
   Welcome @KarunakarGumudala !
   
   I like your feature   but I would like to point you to a few steps that you 
need to change/setup first.
   
   * Please associate a ticket to this change as described in the PR template.
   * Also please read the Contributing guide to setup your development 
environment so that you can test your changes accordingly. 
   
   Thank you :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

[GitBox]

ashb commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG 
in DB for webserver scalability
URL: https://github.com/apache/airflow/pull/5743#issuecomment-532170163
 
 
   > * Do we want to let users use old versions of MySQL (and Mariadb that 
doesn't support JSON with sqlalchemy) or add a note and tell them that if you 
want to use serialisation you would need to use
   newer version of DB or a DB (Postgres) that supports JSON columns. Or else 
just keep store_serialised_dags=False. If we want to support old versions or DB 
that don't support JSON columns, that we will have to handle those exceptions 
and store the serialised DAG (python dicts) as string and use json.loads and 
json.dump.
   
   The one problem with this idea is that the migration is independent of the 
config setting, so we need a migration that works with either config setting.
   
   The tests currently run against Mysql 5.7 too :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj opened a new pull request #6134: [AIRFLOW-XXX] Add a third way to configure authorization

[GitBox]

mik-laj opened a new pull request #6134: [AIRFLOW-XXX] Add a third way to 
configure authorization
URL: https://github.com/apache/airflow/pull/6134
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-XXX
 - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
 - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
 - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain docstrings 
that explain what it does
 - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

[GitBox]

kaxil commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized 
DAG in DB for webserver scalability
URL: https://github.com/apache/airflow/pull/5743#issuecomment-532172943
 
 
   > > * Do we want to let users use old versions of MySQL (and Mariadb that 
doesn't support JSON with sqlalchemy) or add a note and tell them that if you 
want to use serialisation you would need to use
   > >   newer version of DB or a DB (Postgres) that supports JSON columns. Or 
else just keep store_serialised_dags=False. If we want to support old versions 
or DB that don't support JSON columns, that we will have to handle those 
exceptions and store the serialised DAG (python dicts) as string and use 
json.loads and json.dump.
   > 
   > The one problem with this idea is that the migration is independent of the 
config setting, so we need a migration that works with either config setting.
   > 
   > The tests currently run against Mysql 5.7 too :)
   
   Actually, that's how I figured too. I didn't knew that we were using that 
old version of Mysql in test. One of the tests errored and then I used your 
suggestion:
   
   
   
https://github.com/apache/airflow/blob/614a8d0b4fe66f42f97ee397015834d70ce8068b/airflow/migrations/versions/d38e04c12aa2_add_serialized_dag_table.py#L37-L49
   
   And it worked. Although I was expecting that I will have to do some changes 
in SerializedDagModel too:
   
   
https://github.com/apache/airflow/blob/614a8d0b4fe66f42f97ee397015834d70ce8068b/airflow/models/serialized_dag.py#L62-L71
   
   but it worked without having it change anything.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

[GitBox]

ashb commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG 
in DB for webserver scalability
URL: https://github.com/apache/airflow/pull/5743#issuecomment-532172833
 
 
   > * [ ] Agree / dis-agree on using 
https://pypi.org/project/SQLAlchemy-JSONField/
   
   That probably looks like it reduces the complexity of our code a bit. The 
only complexity to using it is that we'd need to set `enforce_string` to True 
or False based on what features the backend has, which isn't amazing. Though 
looking at the code I think we could try leaving it off/default and see how 
that copes with Mysql 5.7.
   
   (If we want to get this in 1.10.x then we can't change the required database 
versions.)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6122: [AIRFLOW-5499] Move GCP utils to core

[GitBox]

codecov-io edited a comment on issue #6122: [AIRFLOW-5499] Move GCP utils to 
core
URL: https://github.com/apache/airflow/pull/6122#issuecomment-531783904
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6122?src=pr=h1) 
Report
   > Merging 
[#6122](https://codecov.io/gh/apache/airflow/pull/6122?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/8ea2a07f2b81f5b302c66c383bdee1dafb779fb8?src=pr=desc)
 will **decrease** coverage by `1.05%`.
   > The diff coverage is `88.19%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6122/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6122?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6122  +/-   ##
   ==
   - Coverage   80.12%   79.06%   -1.06% 
   ==
 Files 607  611   +4 
 Lines   3490535367 +462 
   ==
   - Hits2796727964   -3 
   - Misses   6938 7403 +465
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6122?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/contrib/utils/gcp\_field\_validator.py](https://codecov.io/gh/apache/airflow/pull/6122/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3V0aWxzL2djcF9maWVsZF92YWxpZGF0b3IucHk=)
 | `0% <0%> (-92.31%)` | :arrow_down: |
   | 
[airflow/contrib/utils/gcp\_field\_sanitizer.py](https://codecov.io/gh/apache/airflow/pull/6122/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3V0aWxzL2djcF9maWVsZF9zYW5pdGl6ZXIucHk=)
 | `0% <0%> (-93.75%)` | :arrow_down: |
   | 
[airflow/gcp/operators/cloud\_sql.py](https://codecov.io/gh/apache/airflow/pull/6122/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2Nsb3VkX3NxbC5weQ==)
 | `88.26% <100%> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/compute.py](https://codecov.io/gh/apache/airflow/pull/6122/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2NvbXB1dGUucHk=)
 | `98.49% <100%> (ø)` | :arrow_up: |
   | 
[airflow/gcp/operators/functions.py](https://codecov.io/gh/apache/airflow/pull/6122/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2Z1bmN0aW9ucy5weQ==)
 | `98.01% <100%> (ø)` | :arrow_up: |
   | 
[airflow/gcp/utils/field\_validator.py](https://codecov.io/gh/apache/airflow/pull/6122/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvdXRpbHMvZmllbGRfdmFsaWRhdG9yLnB5)
 | `92.3% <92.3%> (ø)` | |
   | 
[airflow/gcp/utils/field\_sanitizer.py](https://codecov.io/gh/apache/airflow/pull/6122/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvdXRpbHMvZmllbGRfc2FuaXRpemVyLnB5)
 | `93.75% <93.75%> (ø)` | |
   | 
[airflow/contrib/hooks/databricks\_hook.py](https://codecov.io/gh/apache/airflow/pull/6122/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2RhdGFicmlja3NfaG9vay5weQ==)
 | `60.21% <0%> (-37.18%)` | :arrow_down: |
   | 
[airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6122/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5)
 | `52.18% <0%> (-34.38%)` | :arrow_down: |
   | 
[airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6122/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=)
 | `51.36% <0%> (-12.48%)` | :arrow_down: |
   | ... and [5 
more](https://codecov.io/gh/apache/airflow/pull/6122/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6122?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6122?src=pr=footer). 
Last update 
[8ea2a07...72c43fe](https://codecov.io/gh/apache/airflow/pull/6122?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug

[GitBox]

ashb commented on a change in pull request #6100: [AIRFLOW-5387] Fix show 
paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325110300
 
 

 ##
 File path: tests/www/test_utils.py
 ##
 @@ -103,14 +105,45 @@ def test_params_search(self):
 self.assertEqual('search=bash_',
  utils.get_params(search='bash_'))
 
-def test_params_showPaused_true(self):
-"""Should detect True as default for showPaused"""
-self.assertEqual('',
- utils.get_params(showPaused=True))
-
-def test_params_showPaused_false(self):
-self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+@parameterized.expand([
+(True, False, ''),
+(False, True, ''),
+(True, True, 'showPaused=True'),
+(False, False, 'showPaused=False'),
+(None, True, ''),
+(None, False, ''),
+])
+def test_params_showPaused(self, show_paused, hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
 
 Review comment:
   Rather than setting the env var can you use the `conf_vars` context manager 
we use in other tests (check out `./tests/test_utils/config.py`)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb merged pull request #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling

[GitBox]

ashb merged pull request #6034: [AIRFLOW-5343] Remove legacy way of pessimistic 
disconnect handling
URL: https://github.com/apache/airflow/pull/6034
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-5343) pool_pre_ping support for SQLAlchemy connection

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931338#comment-16931338
 ] 

ASF subversion and git services commented on AIRFLOW-5343:
--

Commit bc826070e15658cc182da5091b6a0f26eb2bc141 in airflow's branch 
refs/heads/master from Igor Khrol
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=bc82607 ]

[AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling (#6034)

Based on discussions in https://github.com/apache/airflow/pull/5949
it was figured out that there is already pessimistic disconnect
timeout handling. So instead of hand-written one only SQLAlchemy
embedded way should be used.

'sqlalchemy~=1.3' is in `setup.py` requirements and `pool_pre_ping`
appeared in SQLAlchemy 1.2.

> pool_pre_ping support for SQLAlchemy connection
> ---
>
> Key: AIRFLOW-5343
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5343
> Project: Apache Airflow
>  Issue Type: Task
>  Components: configuration
>Affects Versions: 1.10.4
>Reporter: Igor Khrol
>Priority: Minor
> Fix For: 1.10.6
>
>
> SQLalchemy supports connection check while returning it from the pool. There 
> is a need to allow this parameter (`pool_pre_ping`) while creating the 
> connection to database.
>  
> [https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic]
> [https://github.com/apache/airflow/blob/master/airflow/settings.py#L189]
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [airflow] alrolorojas commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug

[GitBox]

alrolorojas commented on a change in pull request #6100: [AIRFLOW-5387] Fix 
show paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325116240
 
 

 ##
 File path: tests/www/test_utils.py
 ##
 @@ -103,14 +105,45 @@ def test_params_search(self):
 self.assertEqual('search=bash_',
  utils.get_params(search='bash_'))
 
-def test_params_showPaused_true(self):
-"""Should detect True as default for showPaused"""
-self.assertEqual('',
- utils.get_params(showPaused=True))
-
-def test_params_showPaused_false(self):
-self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+@parameterized.expand([
+(True, False, ''),
+(False, True, ''),
+(True, True, 'showPaused=True'),
+(False, False, 'showPaused=False'),
+(None, True, ''),
+(None, False, ''),
+])
+def test_params_showPaused(self, show_paused, hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
 
 Review comment:
   > Okay, but I mean why should self.assertEqual(expected_result, 
utils.get_params(showPaused=show_paused)) raise an error?
   Wouldn't..
   self.assertEqual(expected_result, utils.get_params(showPaused=show_paused))
   del os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT']
   ..also work?
   
   @feluelle if for some reason `utils.get_params` method raises an exception, 
`del os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT']` would not 
get executed leaving that environment variable enabled for other unit tests. 
That was a teardown that only applies to a single test.
   
   > Rather than setting the env var can you use the conf_vars context manager 
we use in other tests (check out ./tests/test_utils/config.py)
   
   @ashb I'm taking a look. Thanks for the pointer!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #5407: [AIRFLOW-4741] Include Sentry into core Airflow

[GitBox]

ashb commented on a change in pull request #5407: [AIRFLOW-4741] Include Sentry 
into core Airflow
URL: https://github.com/apache/airflow/pull/5407#discussion_r325119750
 
 

 ##
 File path: airflow/sentry.py
 ##
 @@ -0,0 +1,196 @@
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Sentry Integration"""
+
+
+from typing import Any
+from functools import wraps
+from sqlalchemy import or_
+
+from airflow import configuration as conf
+from airflow.utils.db import provide_session
+from airflow.utils.log.logging_mixin import LoggingMixin
+from airflow.utils.state import State
+
+
+log = LoggingMixin().log
+
+
+class DummySentry:
+"""
+Blank class for Sentry.
+"""
+
+@classmethod
+def add_tagging(cls, task_instance):
+"""
+Blank function for tagging.
+"""
+
+@classmethod
+def add_breadcrumbs(cls, session=None):
+"""
+Blank function for breadcrumbs.
+"""
+
+@classmethod
+def format_run_task(cls, run):
+"""
+Blank function for formatting a TaskInstance._run_raw_task.
+"""
+return run
+
+
+@provide_session
+def get_task_instances(dag_id, task_ids, execution_date, session=None):
+"""
+Retrieves task instance based on dag_id and execution_date.
+"""
+from airflow.models.taskinstance import TaskInstance  # Avoid circular 
import
+
+if session is None or not task_ids:
+return []
+
+TI = TaskInstance
+return (
+session.query(TI)
+.filter(
+TI.dag_id == dag_id,
+TI.task_id.in_(task_ids),
+TI.execution_date == execution_date,
+or_(TI.state == State.SUCCESS, TI.state == State.FAILED),
+)
+.all()
+)
+
+
+class ConfiguredSentry:
+"""
+Configure Sentry SDK.
+"""
+
+SCOPE_TAGS = frozenset(("task_id", "dag_id", "execution_date", "operator"))
+SCOPE_CRUMBS = frozenset(
+("dag_id", "task_id", "execution_date", "state", "operator", 
"duration")
+)
+
+def __init__(self):
+"""
+Initialize the Sentry SDK.
+"""
+ignore_logger("airflow.task")
+ignore_logger("airflow.jobs.backfill_job.BackfillJob")
+executor_name = conf.get("core", "EXECUTOR")
+
+sentry_flask = FlaskIntegration()
+
+# LoggingIntegration is set by default.
+integrations = [sentry_flask]
+
+if executor_name == "CeleryExecutor":
+from sentry_sdk.integrations.celery import CeleryIntegration
+from sentry_sdk.integrations.tornado import TornadoIntegration
+
+sentry_celery = CeleryIntegration()
+sentry_tornado = TornadoIntegration()
+integrations += [sentry_celery, sentry_tornado]
+
+dsn = conf.get("sentry", "sentry_dsn")
+if dsn:
+init(dsn=dsn, integrations=integrations)
+else:
+# Setting up Sentry using environment variables.
+log.debug("Defaulting to SENTRY_DSN in environment.")
+init(integrations=integrations)
+
+def add_tagging(self, task_instance):
+"""
+Function to add tagging for a task_instance.
+"""
+task = task_instance.task
+
+with configure_scope() as scope:
+for tag_name in self.SCOPE_TAGS:
+attribute = getattr(task_instance, tag_name)
+if tag_name == "operator":
+attribute = task.__class__.__name__
+scope.set_tag(tag_name, attribute)
+
+@provide_session
+def add_breadcrumbs(self, task_instance, session=None):
+"""
+Function to add breadcrumbs inside of a task_instance.
+"""
+if session is None:
+return
+dag_id = task_instance.dag_id
+execution_date = task_instance.execution_date
+task = task_instance.task
+dag = task.dag
+task_ids = dag.task_ids
+task_instances = get_task_instances(
+dag_id, task_ids, execution_date, session=session
+)
+
+for ti in task_instances:
 
 Review comment:
   @tiopi I can't see that image (anymore?)

[GitHub] [airflow] codecov-io commented on issue #6000: [AIRFLOW-5393] UI crashes in the Ad Hoc Query menu (PULL REQUEST FIX)

[GitBox]

codecov-io commented on issue #6000: [AIRFLOW-5393] UI crashes in the Ad Hoc 
Query menu (PULL REQUEST FIX)
URL: https://github.com/apache/airflow/pull/6000#issuecomment-532185257
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6000?src=pr=h1) 
Report
   > :exclamation: No coverage uploaded for pull request base 
(`v1-10-stable@704e48d`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6000/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6000?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ## v1-10-stable#6000   +/-   ##
   ===
 Coverage?   10.73%   
   ===
 Files   ?  509   
 Lines   ?34256   
 Branches?0   
   ===
 Hits? 3678   
 Misses  ?30578   
 Partials?0
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6000?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6000/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=)
 | `0% <0%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6000?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6000?src=pr=footer). 
Last update 
[704e48d...f91ed51](https://codecov.io/gh/apache/airflow/pull/6000?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #6100: [AIRFLOW-5387] Fix show paused pagination bug

[GitBox]

feluelle commented on a change in pull request #6100: [AIRFLOW-5387] Fix show 
paused pagination bug
URL: https://github.com/apache/airflow/pull/6100#discussion_r325128932
 
 

 ##
 File path: tests/www/test_utils.py
 ##
 @@ -103,14 +105,45 @@ def test_params_search(self):
 self.assertEqual('search=bash_',
  utils.get_params(search='bash_'))
 
-def test_params_showPaused_true(self):
-"""Should detect True as default for showPaused"""
-self.assertEqual('',
- utils.get_params(showPaused=True))
-
-def test_params_showPaused_false(self):
-self.assertEqual('showPaused=False',
- utils.get_params(showPaused=False))
+@parameterized.expand([
+(True, False, ''),
+(False, True, ''),
+(True, True, 'showPaused=True'),
+(False, False, 'showPaused=False'),
+(None, True, ''),
+(None, False, ''),
+])
+def test_params_showPaused(self, show_paused, hide_by_default, 
expected_result):
+os.environ['AIRFLOW__WEBSERVER__HIDE_PAUSED_DAGS_BY_DEFAULT'] = 
str(hide_by_default)
+
+try:
 
 Review comment:
   @alrolorojas Thank you - makes sense. But yes the context manager would be 
probably nicer to use  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #6132: [AIRFLOW-XXX] Display Azure integration in table

[GitBox]

mik-laj merged pull request #6132: [AIRFLOW-XXX] Display Azure integration in 
table
URL: https://github.com/apache/airflow/pull/6132
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mrshu commented on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

[GitBox]

mrshu commented on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's 
default region name
URL: https://github.com/apache/airflow/pull/5879#issuecomment-532199570
 
 
   Thanks for all the help here @ashb! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (AIRFLOW-5170) Add static checks consistent licences for python files

[Jarek Potiuk (Jira)]

 [ 
https://issues.apache.org/jira/browse/AIRFLOW-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Potiuk resolved AIRFLOW-5170.
---
Fix Version/s: 2.0.0
   Resolution: Fixed

> Add static checks consistent licences for python files
> --
>
> Key: AIRFLOW-5170
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5170
> Project: Apache Airflow
>  Issue Type: Improvement
>  Components: ci
>Affects Versions: 2.0.0
>Reporter: Jarek Potiuk
>Assignee: Jarek Potiuk
>Priority: Major
> Fix For: 2.0.0
>
>
> Automated check for encoding pragma, consisten licence files can be added for 
> python files.
> Since we have pylint checks in pre-commits added we should also make sure to 
> fix all pylint related changes however for all the changed python files.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[GitHub] [airflow] TobKed opened a new pull request #6135: [AIRFLOW-XXX] Add stacklevel to GCP deprecation warnings

[GitBox]

TobKed opened a new pull request #6135: [AIRFLOW-XXX] Add stacklevel to GCP 
deprecation warnings
URL: https://github.com/apache/airflow/pull/6135
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
 - https://issues.apache.org/jira/browse/AIRFLOW-XXX
 - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
 - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
 - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
 1. Subject is separated from body by a blank line
 1. Subject is limited to 50 characters (not including Jira issue reference)
 1. Subject does not end with a period
 1. Subject uses the imperative mood ("add", not "adding")
 1. Body wraps at 72 characters
 1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
 - All the public functions and the classes in the PR contain docstrings 
that explain what it does
 - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python

[GitBox]

mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite 
Google PubSub Hook to Google Cloud Python
URL: https://github.com/apache/airflow/pull/6096#discussion_r325137820
 
 

 ##
 File path: airflow/gcp/operators/pubsub.py
 ##
 @@ -403,29 +617,43 @@ class PubSubPublishOperator(BaseOperator):
 For this to work, the service account making the request
 must have domain-wide delegation enabled.
 :type delegate_to: str
+:param project: (Deprecated) the GCP project ID where the topic will be 
created
+:type project: str
 """
-template_fields = ['project', 'topic', 'messages']
+template_fields = ['project_id', 'topic', 'messages']
 
 Review comment:
   ```suggestion
   template_fields = ['project', 'project_id', 'topic', 'messages']
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args

[GitBox]

codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls 
because second watcher thread in default args
URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) 
Report
   > Merging 
[#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6129/graphs/tree.svg?width=650=WdLKlKHOAU=150=pr)](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#6129  +/-   ##
   ==
   - Coverage   80.12%   80.11%   -0.01% 
   ==
 Files 607  607  
 Lines   3490234902  
   ==
   - Hits2796527963   -2 
   - Misses   6937 6939   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `74.28% <0%> (-0.31%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). 
Last update 
[9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services