[jira] [Resolved] (AIRFLOW-5256) Related pylint changes for common licences in python files
[ https://issues.apache.org/jira/browse/AIRFLOW-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-5256. --- Fix Version/s: 2.0.0 Resolution: Fixed > Related pylint changes for common licences in python files > -- > > Key: AIRFLOW-5256 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5256 > Project: Apache Airflow > Issue Type: Sub-task > Components: ci, core >Affects Versions: 2.0.0 >Reporter: Jarek Potiuk >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [airflow] TobKed closed pull request #6135: [AIRFLOW-XXX] Add stacklevel to GCP deprecation warnings
TobKed closed pull request #6135: [AIRFLOW-XXX] Add stacklevel to GCP deprecation warnings URL: https://github.com/apache/airflow/pull/6135 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mrshu commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name
mrshu commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name URL: https://github.com/apache/airflow/pull/5879#discussion_r325125602 ## File path: UPDATING.md ## @@ -39,28 +39,36 @@ assists users migrating to a new version. ## Airflow Master +### Changes to `aws_default` Connection's default region + +The region of Airflow's default connection to AWS (`aws_default`) has +previously been set to `us-east-1` during installation. + +The region now needs to be set manually either in the connection screens in +Airflow, or via the `AWS_DEFAULT_REGION` environment variable. + ### Changes to FileSensor FileSensor is now takes a glob pattern, not just a filename. If the filename you are looking for has `*`, `?`, or `[` in it then you should replace these with `[*]`, `[?]`, and `[[]`. ### Change dag loading duration metric name -Change DAG file loading duration metric from Review comment: Understood -- will do in a new commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6134: [AIRFLOW-XXX] Add a third way to configure authorization
codecov-io commented on issue #6134: [AIRFLOW-XXX] Add a third way to configure authorization URL: https://github.com/apache/airflow/pull/6134#issuecomment-532193243 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6134?src=pr=h1) Report > Merging [#6134](https://codecov.io/gh/apache/airflow/pull/6134?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/26aa4ba648697ec582437b1e86ca3191bdcc253c?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6134?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6134 +/- ## == + Coverage 80% 80.03% +0.02% == Files 607 607 Lines 3500635085 +79 == + Hits2800728079 +72 - Misses 6999 7006 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6134?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/grpc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6134/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2dycGNfaG9vay5weQ==) | `92.06% <0%> (-1.27%)` | :arrow_down: | | [airflow/operators/docker\_operator.py](https://codecov.io/gh/apache/airflow/pull/6134/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZG9ja2VyX29wZXJhdG9yLnB5) | `95.74% <0%> (-1%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/6134/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | | [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6134/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `95.1% <0%> (-0.25%)` | :arrow_down: | | [airflow/kubernetes/pod.py](https://codecov.io/gh/apache/airflow/pull/6134/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZC5weQ==) | `91.66% <0%> (ø)` | :arrow_up: | | [airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/6134/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=) | `84% <0%> (ø)` | :arrow_up: | | [airflow/utils/strings.py](https://codecov.io/gh/apache/airflow/pull/6134/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zdHJpbmdzLnB5) | `100% <0%> (ø)` | :arrow_up: | | [airflow/gcp/operators/mlengine.py](https://codecov.io/gh/apache/airflow/pull/6134/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL21sZW5naW5lLnB5) | `75.72% <0%> (ø)` | :arrow_up: | | [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/6134/diff?src=pr=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/mlengine.py](https://codecov.io/gh/apache/airflow/pull/6134/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvbWxlbmdpbmUucHk=) | `20.66% <0%> (ø)` | :arrow_up: | | ... and [28 more](https://codecov.io/gh/apache/airflow/pull/6134/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6134?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6134?src=pr=footer). Last update [26aa4ba...383278a](https://codecov.io/gh/apache/airflow/pull/6134?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
TobKed commented on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-532193257 @mik-laj Yes, hopefully PR is done. I've applied all necessary patches. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args
codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) Report > Merging [#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6129 +/- ## == - Coverage 80.12% 80.11% -0.01% == Files 607 607 Lines 3490234902 == - Hits2796527963 -2 - Misses 6937 6939 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5) | `86.52% <100%> (ø)` | :arrow_up: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `74.28% <0%> (-0.31%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). Last update [9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args
codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) Report > Merging [#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6129 +/- ## == - Coverage 80.12% 80.11% -0.01% == Files 607 607 Lines 3490234902 == - Hits2796527963 -2 - Misses 6937 6939 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5) | `86.52% <100%> (ø)` | :arrow_up: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `74.28% <0%> (-0.31%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). Last update [9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
mik-laj commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r325137231 ## File path: airflow/gcp/operators/pubsub.py ## @@ -326,34 +505,68 @@ class PubSubSubscriptionDeleteOperator(BaseOperator): For this to work, the service account making the request must have domain-wide delegation enabled. :type delegate_to: str +:param retry: (Optional) A retry object used to retry requests. +If None is specified, requests will not be retried. +:type retry: google.api_core.retry.Retry +:param timeout: (Optional) The amount of time, in seconds, to wait for the request +to complete. Note that if retry is specified, the timeout applies to each +individual attempt. +:type timeout: float +:param metadata: (Optional) Additional metadata that is provided to the method. +:type metadata: Sequence[Tuple[str, str]]] +:param project: (Deprecated) the GCP project ID where the topic will be created +:type project: str """ -template_fields = ['project', 'subscription'] +template_fields = ['project_id', 'subscription'] Review comment: ```suggestion template_fields = ['project', 'project_id', 'subscription'] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args
codecov-io edited a comment on issue #6129: [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args URL: https://github.com/apache/airflow/pull/6129#issuecomment-532198003 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=h1) Report > Merging [#6129](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9cc748bf4d9da2cd3e4a653aef3c7726564e7579?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6129 +/- ## == - Coverage 80.12% 80.11% -0.01% == Files 607 607 Lines 3490234902 == - Hits2796527963 -2 - Misses 6937 6939 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5) | `86.52% <100%> (ø)` | :arrow_up: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6129/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `74.28% <0%> (-0.31%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=footer). Last update [9cc748b...0cf92cd](https://codecov.io/gh/apache/airflow/pull/6129?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes
potiuk commented on issue #5786: [AIRFLOW-5170] [AIRFLOW-5256] Consistent licences for python files and related pylint fixes URL: https://github.com/apache/airflow/pull/5786#issuecomment-532199033 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
mik-laj commented on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-532206584 @potiuk Can you do rebase? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dossett commented on issue #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR
dossett commented on issue #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR URL: https://github.com/apache/airflow/pull/4064#issuecomment-532216503 Thank you @mik-laj @potiuk @OmerJog @fenglu-g for all the feedback along the way, it's exciting to see this get merged. Looking forward to making more contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-2970) Kubernetes logging is broken
[
https://issues.apache.org/jira/browse/AIRFLOW-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931615#comment-16931615
]
Steven Miller commented on AIRFLOW-2970:
Astronomer is debugging a similar issue in 1.10.x . If you try to download the
logs from the UI (NOT view the logs - download them by clicking the button with
a number on it) and you get a network error, and you check the webserver logs
and have this stack trace:
```
[2019-09-17 11:51:11 +] [10636] [ERROR] Error handling request
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/gunicorn/workers/sync.py", line 181,
in handle_request
for item in respiter:
File "/usr/lib/python3.7/site-packages/werkzeug/wsgi.py", line 507, in
__next__
return self._next()
File "/usr/lib/python3.7/site-packages/werkzeug/wrappers/base_response.py",
line 45, in _iter_encoded
for item in iterable:
File "/usr/lib/python3.7/site-packages/airflow/www_rbac/views.py", line 600,
in _generate_log_stream
logs, metadata = _get_logs_with_metadata(try_number, metadata)
File "/usr/lib/python3.7/site-packages/airflow/www_rbac/views.py", line 569,
in _get_logs_with_metadata
logs, metadatas = handler.read(ti, try_number, metadata=metadata)
File
"/usr/lib/python3.7/site-packages/airflow/utils/log/file_task_handler.py", line
164, in read
log, metadata = self._read(task_instance, try_number, metadata)
File "/usr/lib/python3.7/site-packages/airflow/utils/log/es_task_handler.py",
line 144, in _read
and offset >= metadata['max_offset']:
TypeError: '>=' not supported between instances of 'str' and 'int'
```
Then it is the same problem we are experiencing. If that is the case, this
change is what we are using to patch it while we get to the bottom of what's
going on. [https://github.com/astronomer/airflow/pull/63]
> Kubernetes logging is broken
>
>
> Key: AIRFLOW-2970
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2970
> Project: Apache Airflow
> Issue Type: Bug
> Components: executors
>Reporter: Jon Davies
>Assignee: Daniel Imberman
>Priority: Major
>
> I'm using Airflow with the Kubernetes executor and pod operator. And my DAGs
> are configured to do get_log=True and all my DAGs are set to log to stdout
> and I can see all the logs in kubectl logs.
> I can see that the scheduler logs things to:
> $AIRFLOW_HOME/logs/scheduler/2018-08-28/*
> However, this just consists of:
> {code:java}
> [2018-08-28 13:03:27,695] {jobs.py:385} INFO - Started process (PID=16994) to
> work on /home/airflow/dags/dag.py
> [2018-08-28 13:03:27,697] {jobs.py:1782} INFO - Processing file
> /home/airflow/dags/dag.py for tasks to queue
> [2018-08-28 13:03:27,697] {logging_mixin.py:95} INFO - [2018-08-28
> 13:03:27,697] {models.py:258} INFO - Filling up the DagBag from
> /home/airflow/dags/dag.py
> {code}
> If I quickly exec into the executor the scheduler spins up, I can see that
> things are properly logged to:
> {code:java}
> /home/airflow/logs/dag$ tail -f
> dag-downloader/2018-08-28T13\:05\:07.704072+00\:00/1.log
> [2018-08-28 13:05:24,399] {logging_mixin.py:95} INFO - [2018-08-28
> 13:05:24,399] {pod_launcher.py:112} INFO - Event: dag-downloader-015ca48c had
> an event of type Pending
> ...
> [2018-08-28 13:05:37,193] {logging_mixin.py:95} INFO - [2018-08-28
> 13:05:37,193] {pod_launcher.py:95} INFO -
> b'INFO:botocore.vendored.requests.packages.urllib3.connectionpool:Starting
> new HTTPS connection (7): blah-blah.s3.eu-west-1.amazonaws.com\n'
> ...
> ...all other log lines from pod...
> {code}
> However, this executor pod only exists for the duration of the lifetime of
> the task pod so the logs are lost pretty much immediately after the task
> runs. There is nothing that ships the logs back to the scheduler and/or web
> UI.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [airflow] kaxil commented on issue #6136: Update example_trigger_target_dag.py
kaxil commented on issue #6136: Update example_trigger_target_dag.py URL: https://github.com/apache/airflow/pull/6136#issuecomment-532362977 Are you installing Airflow from master? Or just using DAGs? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] brunolucatto edited a comment on issue #6136: Update example_trigger_target_dag.py
brunolucatto edited a comment on issue #6136: Update example_trigger_target_dag.py URL: https://github.com/apache/airflow/pull/6136#issuecomment-532362393 I understand it was intentionally removed, but without it, the example is not working on my airflow. I was really confused since two weeks ago it worked, so I went to the git page and saw these changes. Then, I tried adding it again and it solved the case. I don't know if this works in other circumstances, but it should definitely be double-checked. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] pgagnon commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook
pgagnon commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook URL: https://github.com/apache/airflow/pull/6104#issuecomment-532366320 I see this has just been merged, but nevertheless... I can see why this feature could be useful, but I am concerned that it might encourage users to paste key material in their code and subsequently publish it on their VCS. To put it mildly this is an inadvisable practice. @dstandish @mik-laj @kaxil WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-2970) Kubernetes logging is broken
[
https://issues.apache.org/jira/browse/AIRFLOW-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931617#comment-16931617
]
Steven Miller commented on AIRFLOW-2970:
for clarify, i'm talking about this button !image-2019-09-17-12-19-45-207.png!
> Kubernetes logging is broken
>
>
> Key: AIRFLOW-2970
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2970
> Project: Apache Airflow
> Issue Type: Bug
> Components: executors
>Reporter: Jon Davies
>Assignee: Daniel Imberman
>Priority: Major
> Attachments: image-2019-09-17-12-19-45-207.png
>
>
> I'm using Airflow with the Kubernetes executor and pod operator. And my DAGs
> are configured to do get_log=True and all my DAGs are set to log to stdout
> and I can see all the logs in kubectl logs.
> I can see that the scheduler logs things to:
> $AIRFLOW_HOME/logs/scheduler/2018-08-28/*
> However, this just consists of:
> {code:java}
> [2018-08-28 13:03:27,695] {jobs.py:385} INFO - Started process (PID=16994) to
> work on /home/airflow/dags/dag.py
> [2018-08-28 13:03:27,697] {jobs.py:1782} INFO - Processing file
> /home/airflow/dags/dag.py for tasks to queue
> [2018-08-28 13:03:27,697] {logging_mixin.py:95} INFO - [2018-08-28
> 13:03:27,697] {models.py:258} INFO - Filling up the DagBag from
> /home/airflow/dags/dag.py
> {code}
> If I quickly exec into the executor the scheduler spins up, I can see that
> things are properly logged to:
> {code:java}
> /home/airflow/logs/dag$ tail -f
> dag-downloader/2018-08-28T13\:05\:07.704072+00\:00/1.log
> [2018-08-28 13:05:24,399] {logging_mixin.py:95} INFO - [2018-08-28
> 13:05:24,399] {pod_launcher.py:112} INFO - Event: dag-downloader-015ca48c had
> an event of type Pending
> ...
> [2018-08-28 13:05:37,193] {logging_mixin.py:95} INFO - [2018-08-28
> 13:05:37,193] {pod_launcher.py:95} INFO -
> b'INFO:botocore.vendored.requests.packages.urllib3.connectionpool:Starting
> new HTTPS connection (7): blah-blah.s3.eu-west-1.amazonaws.com\n'
> ...
> ...all other log lines from pod...
> {code}
> However, this executor pod only exists for the duration of the lifetime of
> the task pod so the logs are lost pretty much immediately after the task
> runs. There is nothing that ships the logs back to the scheduler and/or web
> UI.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (AIRFLOW-2970) Kubernetes logging is broken
[
https://issues.apache.org/jira/browse/AIRFLOW-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931615#comment-16931615
]
Steven Miller edited comment on AIRFLOW-2970 at 9/17/19 4:18 PM:
-
Astronomer is debugging a similar issue in 1.10.x . If you try to download the
logs from the UI (NOT view the logs - download them by clicking the button with
a number on it) and you get a network error, and you check the webserver logs
and have this stack trace:
{code:java}
[2019-09-17 11:51:11 +] [10636] [ERROR] Error handling request
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/gunicorn/workers/sync.py", line 181,
in handle_request
for item in respiter:
File "/usr/lib/python3.7/site-packages/werkzeug/wsgi.py", line 507, in _next_
return self._next()
File "/usr/lib/python3.7/site-packages/werkzeug/wrappers/base_response.py",
line 45, in _iter_encoded
for item in iterable:
File "/usr/lib/python3.7/site-packages/airflow/www_rbac/views.py", line 600,
in _generate_log_stream
logs, metadata = _get_logs_with_metadata(try_number, metadata)
File "/usr/lib/python3.7/site-packages/airflow/www_rbac/views.py", line 569,
in _get_logs_with_metadata
logs, metadatas = handler.read(ti, try_number, metadata=metadata)
File
"/usr/lib/python3.7/site-packages/airflow/utils/log/file_task_handler.py", line
164, in read
log, metadata = self._read(task_instance, try_number, metadata)
File "/usr/lib/python3.7/site-packages/airflow/utils/log/es_task_handler.py",
line 144, in _read
and offset >= metadata['max_offset']:
TypeError: '>=' not supported between instances of 'str' and 'int'
{code}
Then it is the same problem we are experiencing. If that is the case, this
change is what we are using to patch it while we get to the bottom of what's
going on. [https://github.com/astronomer/airflow/pull/63]
was (Author: sjmiller609):
Astronomer is debugging a similar issue in 1.10.x . If you try to download the
logs from the UI (NOT view the logs - download them by clicking the button with
a number on it) and you get a network error, and you check the webserver logs
and have this stack trace:
```
[2019-09-17 11:51:11 +] [10636] [ERROR] Error handling request
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/gunicorn/workers/sync.py", line 181,
in handle_request
for item in respiter:
File "/usr/lib/python3.7/site-packages/werkzeug/wsgi.py", line 507, in
__next__
return self._next()
File "/usr/lib/python3.7/site-packages/werkzeug/wrappers/base_response.py",
line 45, in _iter_encoded
for item in iterable:
File "/usr/lib/python3.7/site-packages/airflow/www_rbac/views.py", line 600,
in _generate_log_stream
logs, metadata = _get_logs_with_metadata(try_number, metadata)
File "/usr/lib/python3.7/site-packages/airflow/www_rbac/views.py", line 569,
in _get_logs_with_metadata
logs, metadatas = handler.read(ti, try_number, metadata=metadata)
File
"/usr/lib/python3.7/site-packages/airflow/utils/log/file_task_handler.py", line
164, in read
log, metadata = self._read(task_instance, try_number, metadata)
File "/usr/lib/python3.7/site-packages/airflow/utils/log/es_task_handler.py",
line 144, in _read
and offset >= metadata['max_offset']:
TypeError: '>=' not supported between instances of 'str' and 'int'
```
Then it is the same problem we are experiencing. If that is the case, this
change is what we are using to patch it while we get to the bottom of what's
going on. [https://github.com/astronomer/airflow/pull/63]
> Kubernetes logging is broken
>
>
> Key: AIRFLOW-2970
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2970
> Project: Apache Airflow
> Issue Type: Bug
> Components: executors
>Reporter: Jon Davies
>Assignee: Daniel Imberman
>Priority: Major
>
> I'm using Airflow with the Kubernetes executor and pod operator. And my DAGs
> are configured to do get_log=True and all my DAGs are set to log to stdout
> and I can see all the logs in kubectl logs.
> I can see that the scheduler logs things to:
> $AIRFLOW_HOME/logs/scheduler/2018-08-28/*
> However, this just consists of:
> {code:java}
> [2018-08-28 13:03:27,695] {jobs.py:385} INFO - Started process (PID=16994) to
> work on /home/airflow/dags/dag.py
> [2018-08-28 13:03:27,697] {jobs.py:1782} INFO - Processing file
> /home/airflow/dags/dag.py for tasks to queue
> [2018-08-28 13:03:27,697] {logging_mixin.py:95} INFO - [2018-08-28
> 13:03:27,697] {models.py:258} INFO - Filling up the DagBag from
> /home/airflow/dags/dag.py
> {code}
> If I quickly exec into the executor the scheduler spins up, I can see that
> things are properly logged to:
> {code:java}
> /home/airflow/logs/dag$ tail -f
>
[GitHub] [airflow] kaxil commented on issue #6136: Update example_trigger_target_dag.py
kaxil commented on issue #6136: Update example_trigger_target_dag.py URL: https://github.com/apache/airflow/pull/6136#issuecomment-532359170 This has been intentionally removed by some awesome work from @Fokko https://github.com/apache/airflow/pull/5990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-5510) example_trigger_target_dag not working
[ https://issues.apache.org/jira/browse/AIRFLOW-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931759#comment-16931759 ] ASF GitHub Bot commented on AIRFLOW-5510: - kaxil commented on pull request #6137: [AIRFLOW-5510] Add provide context URL: https://github.com/apache/airflow/pull/6137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > example_trigger_target_dag not working > -- > > Key: AIRFLOW-5510 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5510 > Project: Apache Airflow > Issue Type: Bug > Components: DAG, DagRun >Affects Versions: 1.10.5 >Reporter: Bruno >Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > operator run_this should provide_context in order to make the function > run_this_func receive the message passed by the controller dag -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Closed] (AIRFLOW-5510) example_trigger_target_dag not working
[ https://issues.apache.org/jira/browse/AIRFLOW-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik closed AIRFLOW-5510. --- Resolution: Not A Problem > example_trigger_target_dag not working > -- > > Key: AIRFLOW-5510 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5510 > Project: Apache Airflow > Issue Type: Bug > Components: DAG, DagRun >Affects Versions: 1.10.5 >Reporter: Bruno >Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > operator run_this should provide_context in order to make the function > run_this_func receive the message passed by the controller dag -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-5447) KubernetesExecutor hangs on task queueing
[ https://issues.apache.org/jira/browse/AIRFLOW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931681#comment-16931681 ] Henry Cohen commented on AIRFLOW-5447: -- Thank you guys so much for working on this, any idea on how long until the fix is out now that it's been merged? > KubernetesExecutor hangs on task queueing > - > > Key: AIRFLOW-5447 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5447 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes >Affects Versions: 1.10.4, 1.10.5 > Environment: Kubernetes version v1.14.3, Airflow version 1.10.4-1.10.5 >Reporter: Henry Cohen >Assignee: Daniel Imberman >Priority: Blocker > > Starting in 1.10.4, and continuing in 1.10.5, when using the > KubernetesExecutor, with the webserver and scheduler running in the > kubernetes cluster, tasks are scheduled, but when added to the task queue, > the executor process hangs indefinitely. Based on log messages, it appears to > be stuck at this line > https://github.com/apache/airflow/blob/v1-10-stable/airflow/contrib/executors/kubernetes_executor.py#L761 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [airflow] brunolucatto opened a new pull request #6136: Update example_trigger_target_dag.py
brunolucatto opened a new pull request #6136: Update
example_trigger_target_dag.py
URL: https://github.com/apache/airflow/pull/6136
[fix] Add provide_context=True in order to make kwargs receive the passed
message
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (AIRFLOW-5511) MSSQL resetdb /initdb for 1.10.5 fails to create tables
ROHIT K RAMWAL created AIRFLOW-5511:
---
Summary: MSSQL resetdb /initdb for 1.10.5 fails to create tables
Key: AIRFLOW-5511
URL: https://issues.apache.org/jira/browse/AIRFLOW-5511
Project: Apache Airflow
Issue Type: Bug
Components: celery, database
Affects Versions: 1.10.5
Reporter: ROHIT K RAMWAL
Airflow 1.10.5 installation with MSSQL backend and celery fails with below
error .
Traceback (most recent call last):
File "/bin/airflow", line 32, in
args.func(args)
File "/usr/lib/python2.7/site-packages/airflow/bin/cli.py", line 1112, in
resetdb
db.resetdb(settings.RBAC)
File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 406, in
resetdb
initdb(rbac)
File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 106, in
initdb
upgradedb()
File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 377, in
upgradedb
command.upgrade(config, 'heads')
File "/usr/lib/python2.7/site-packages/alembic/command.py", line 279, in
upgrade
script.run_env()
File "/usr/lib/python2.7/site-packages/alembic/script/base.py", line 475, in
run_env
util.load_python_file(self.dir, "env.py")
File "/usr/lib/python2.7/site-packages/alembic/util/pyfiles.py", line 98, in
load_python_file
module = load_module_py(module_id, path)
File "/usr/lib/python2.7/site-packages/alembic/util/compat.py", line 240, in
load_module_py
mod = imp.load_source(module_id, path, fp)
File "/usr/lib/python2.7/site-packages/airflow/migrations/env.py", line 92,
in
run_migrations_online()
File "/usr/lib/python2.7/site-packages/airflow/migrations/env.py", line 86,
in run_migrations_online
context.run_migrations()
File "", line 8, in run_migrations
File "/usr/lib/python2.7/site-packages/alembic/runtime/environment.py", line
846, in run_migrations
self.get_context().run_migrations(**kw)
File "/usr/lib/python2.7/site-packages/alembic/runtime/migration.py", line
365, in run_migrations
step.migration_fn(**kw)
File
"/usr/lib/python2.7/site-packages/airflow/migrations/versions/6e96a59344a4_make_taskinstance_pool_not_nullable.py",
line 101, in upgrade
nullable=False,
File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
self.gen.next()
File "/usr/lib/python2.7/site-packages/alembic/operations/base.py", line 325,
in batch_alter_table
impl.flush()
File "/usr/lib/python2.7/site-packages/alembic/operations/batch.py", line 79,
in flush
fn(*arg, **kw)
File "/usr/lib/python2.7/site-packages/alembic/ddl/mssql.py", line 85, in
alter_column
**kw
File "/usr/lib/python2.7/site-packages/alembic/ddl/impl.py", line 172, in
alter_column
existing_comment=existing_comment,
File "/usr/lib/python2.7/site-packages/alembic/ddl/mssql.py", line 36, in
_exec
result = super(MSSQLImpl, self)._exec(construct, *args, **kw)
File "/usr/lib/python2.7/site-packages/alembic/ddl/impl.py", line 134, in
_exec
return conn.execute(construct, *multiparams, **params)
File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line
988, in execute
return meth(self, multiparams, params)
File "/usr/lib64/python2.7/site-packages/sqlalchemy/sql/ddl.py", line 72, in
_execute_on_connection
return connection._execute_ddl(self, multiparams, params)
File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line
1050, in _execute_ddl
compiled,
File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line
1253, in _execute_context
e, statement, parameters, cursor, context
File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line
1473, in _handle_dbapi_exception
util.raise_from_cause(sqlalchemy_exception, exc_info)
File "/usr/lib64/python2.7/site-packages/sqlalchemy/util/compat.py", line
398, in raise_from_cause
reraise(type(exception), exception, tb=exc_tb, cause=cause)
File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line
1249, in _execute_context
cursor, statement, parameters, context
File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/default.py", line
552, in do_execute
cursor.execute(statement, parameters)
sqlalchemy.exc.ProgrammingError: (pyodbc.ProgrammingError) ('42000', "[42000]
[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The index 'ti_pool' is
dependent on column 'pool'. (5074) (SQLExecDirectW)")
[SQL: ALTER TABLE task_instance ALTER COLUMN pool VARCHAR(50) NOT NULL]
(Background on this error at: http://sqlalche.me/e/f405)
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [airflow] kaxil commented on issue #6136: Update example_trigger_target_dag.py
kaxil commented on issue #6136: Update example_trigger_target_dag.py URL: https://github.com/apache/airflow/pull/6136#issuecomment-532365349 I understand the confusion. You should be checking the example DAGs of the version of Airflow you have installed. For example if you have Airflow 1.10.5 installed, you should look at https://github.com/apache/airflow/tree/1.10.5/airflow/example_dags This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil closed pull request #6136: Update example_trigger_target_dag.py
kaxil closed pull request #6136: Update example_trigger_target_dag.py URL: https://github.com/apache/airflow/pull/6136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (AIRFLOW-5385) SparkSubmit status spend lot of time
[
https://issues.apache.org/jira/browse/AIRFLOW-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931099#comment-16931099
]
t oo edited comment on AIRFLOW-5385 at 9/17/19 7:23 PM:
i created spark-27491, i noticed airflow is always at 99%cpu and i have 40
spark-submits running in parallel! thank u!
but i am facing this error with your patch:
[2019-09-17 19:06:01,135] \{__init__.py:1603} INFO - Marking task as
UP_FOR_RETRY
[2019-09-17 19:06:01,195] \{base_task_runner.py:101} INFO - Job x Traceback
(most recent call last):
[2019-09-17 19:06:01,195] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/bin/airflow", line 32, in
[2019-09-17 19:06:01,195] \{base_task_runner.py:101} INFO - Job x
args.func(args)
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/utils/cli.py",
line 74, in wrapper
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x return
f(*args, **kwargs)
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/bin/cli.py",
line 523, in run
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x _run(args,
dag, ti)
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/bin/cli.py",
line 442, in _run
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x
pool=args.pool,
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/utils/db.py",
line 73, in wrapper
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x return
func(*args, **kwargs)
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/models/__init__.py",
line 1441, in _run_raw_task
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x result =
task_copy.execute(context=context)
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/contrib/operators/spark_submit_operator.py",
line 176, in execute
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x
self._hook.submit(self._application)
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/contrib/hooks/spark_submit_hook.py",
line 384, in submit
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x
self._start_driver_status_tracking()
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/contrib/hooks/spark_submit_hook.py",
line 514, in _start_driver_status_tracking
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x
universal_newlines=True)
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x File
"/usr/lib64/python2.7/subprocess.py", line 394, in __init__
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x errread,
errwrite)
[2019-09-17 19:06:01,199] \{base_task_runner.py:101} INFO - Job x File
"/usr/lib64/python2.7/subprocess.py", line 1047, in _execute_child
[2019-09-17 19:06:01,199] \{base_task_runner.py:101} INFO - Job x raise
child_exception
[2019-09-17 19:06:01,199] \{base_task_runner.py:101} INFO - Job x OSError:
[Errno 2] No such file or directory
[2019-09-17 19:06:02,898] \{logging_mixin.py:95} INFO - [2019-09-17
19:06:02,897] \{jobs.py:2566} INFO - Task exited with return code 1
was (Author: toopt4):
i created spark-27491, i noticed airflow is always at 99%cpu and i have 40
spark-submits running in parallel! thank u!
> SparkSubmit status spend lot of time
>
>
> Key: AIRFLOW-5385
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5385
> Project: Apache Airflow
> Issue Type: Improvement
> Components: contrib
>Affects Versions: 1.10.2
>Reporter: Sergio Soto
>Priority: Blocker
>
> Hello,
> we have an issue with SparkSubmitOperator. Airflow DAGs shows that some
> streaming applications breaks out. I analyzed this behaviour. The
> SparkSubmitHook is the responsable of check the driver status.
> We discovered some timeouts and tried to reproduce checking command. This is
> an execution with `time`:
> {code:java}
> time /opt/java/jdk1.8.0_181/jre/bin/java -cp
> /opt/shared/spark/client/conf/:/opt/shared/spark/client/jars/* -Xmx1g
> org.apache.spark.deploy.SparkSubmit --master
> spark://spark-master.corp.com:6066 --status driver-20190901180337-2749
> Using Spark's default log4j profile:
> org/apache/spark/log4j-defaults.properties
> 19/09/02 17:05:53 INFO
[GitHub] [airflow] kaxil closed pull request #6137: [AIRFLOW-5510] Add provide context
kaxil closed pull request #6137: [AIRFLOW-5510] Add provide context URL: https://github.com/apache/airflow/pull/6137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] feng-tao commented on a change in pull request #5819: [AIRFLOW-5147] extended character set for for k8s worker pods annotations
feng-tao commented on a change in pull request #5819: [AIRFLOW-5147] extended character set for for k8s worker pods annotations URL: https://github.com/apache/airflow/pull/5819#discussion_r325256242 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -771,15 +771,17 @@ run_as_user = # that allows for the key to be read, e.g. 65533 fs_group = +# Annotations configuration as a single line formatted JSON object. +# See the naming convention in: +# https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/ +worker_annotations = + + [kubernetes_node_selectors] # The Key-value pairs to be given to worker pods. # The worker pods will be scheduled to the nodes of the specified key-value pairs. # Should be supplied in the format: key = value -[kubernetes_annotations] Review comment: given we remove this section, I think we may want to update in the UPDATE.md. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] brunolucatto opened a new pull request #6137: [AIRFLOW-5510] Add provide context
brunolucatto opened a new pull request #6137: [AIRFLOW-5510] Add provide context
URL: https://github.com/apache/airflow/pull/6137
Add provide context in order to make kwargs in run_this_func receive the
message passed from the controller dag
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (AIRFLOW-5510) example_trigger_target_dag not working
Bruno created AIRFLOW-5510: -- Summary: example_trigger_target_dag not working Key: AIRFLOW-5510 URL: https://issues.apache.org/jira/browse/AIRFLOW-5510 Project: Apache Airflow Issue Type: Bug Components: DAG, DagRun Affects Versions: 1.10.5 Reporter: Bruno operator run_this should provide_context in order to make the function run_this_func receive the message passed by the controller dag -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (AIRFLOW-2970) Kubernetes logging is broken
[
https://issues.apache.org/jira/browse/AIRFLOW-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931617#comment-16931617
]
Steven Miller edited comment on AIRFLOW-2970 at 9/17/19 4:19 PM:
-
for clarity, i'm talking about this button !image-2019-09-17-12-19-45-207.png!
was (Author: sjmiller609):
for clarify, i'm talking about this button !image-2019-09-17-12-19-45-207.png!
> Kubernetes logging is broken
>
>
> Key: AIRFLOW-2970
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2970
> Project: Apache Airflow
> Issue Type: Bug
> Components: executors
>Reporter: Jon Davies
>Assignee: Daniel Imberman
>Priority: Major
> Attachments: image-2019-09-17-12-19-45-207.png
>
>
> I'm using Airflow with the Kubernetes executor and pod operator. And my DAGs
> are configured to do get_log=True and all my DAGs are set to log to stdout
> and I can see all the logs in kubectl logs.
> I can see that the scheduler logs things to:
> $AIRFLOW_HOME/logs/scheduler/2018-08-28/*
> However, this just consists of:
> {code:java}
> [2018-08-28 13:03:27,695] {jobs.py:385} INFO - Started process (PID=16994) to
> work on /home/airflow/dags/dag.py
> [2018-08-28 13:03:27,697] {jobs.py:1782} INFO - Processing file
> /home/airflow/dags/dag.py for tasks to queue
> [2018-08-28 13:03:27,697] {logging_mixin.py:95} INFO - [2018-08-28
> 13:03:27,697] {models.py:258} INFO - Filling up the DagBag from
> /home/airflow/dags/dag.py
> {code}
> If I quickly exec into the executor the scheduler spins up, I can see that
> things are properly logged to:
> {code:java}
> /home/airflow/logs/dag$ tail -f
> dag-downloader/2018-08-28T13\:05\:07.704072+00\:00/1.log
> [2018-08-28 13:05:24,399] {logging_mixin.py:95} INFO - [2018-08-28
> 13:05:24,399] {pod_launcher.py:112} INFO - Event: dag-downloader-015ca48c had
> an event of type Pending
> ...
> [2018-08-28 13:05:37,193] {logging_mixin.py:95} INFO - [2018-08-28
> 13:05:37,193] {pod_launcher.py:95} INFO -
> b'INFO:botocore.vendored.requests.packages.urllib3.connectionpool:Starting
> new HTTPS connection (7): blah-blah.s3.eu-west-1.amazonaws.com\n'
> ...
> ...all other log lines from pod...
> {code}
> However, this executor pod only exists for the duration of the lifetime of
> the task pod so the logs are lost pretty much immediately after the task
> runs. There is nothing that ships the logs back to the scheduler and/or web
> UI.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (AIRFLOW-2970) Kubernetes logging is broken
[
https://issues.apache.org/jira/browse/AIRFLOW-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Miller updated AIRFLOW-2970:
---
Attachment: image-2019-09-17-12-19-45-207.png
> Kubernetes logging is broken
>
>
> Key: AIRFLOW-2970
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2970
> Project: Apache Airflow
> Issue Type: Bug
> Components: executors
>Reporter: Jon Davies
>Assignee: Daniel Imberman
>Priority: Major
> Attachments: image-2019-09-17-12-19-45-207.png
>
>
> I'm using Airflow with the Kubernetes executor and pod operator. And my DAGs
> are configured to do get_log=True and all my DAGs are set to log to stdout
> and I can see all the logs in kubectl logs.
> I can see that the scheduler logs things to:
> $AIRFLOW_HOME/logs/scheduler/2018-08-28/*
> However, this just consists of:
> {code:java}
> [2018-08-28 13:03:27,695] {jobs.py:385} INFO - Started process (PID=16994) to
> work on /home/airflow/dags/dag.py
> [2018-08-28 13:03:27,697] {jobs.py:1782} INFO - Processing file
> /home/airflow/dags/dag.py for tasks to queue
> [2018-08-28 13:03:27,697] {logging_mixin.py:95} INFO - [2018-08-28
> 13:03:27,697] {models.py:258} INFO - Filling up the DagBag from
> /home/airflow/dags/dag.py
> {code}
> If I quickly exec into the executor the scheduler spins up, I can see that
> things are properly logged to:
> {code:java}
> /home/airflow/logs/dag$ tail -f
> dag-downloader/2018-08-28T13\:05\:07.704072+00\:00/1.log
> [2018-08-28 13:05:24,399] {logging_mixin.py:95} INFO - [2018-08-28
> 13:05:24,399] {pod_launcher.py:112} INFO - Event: dag-downloader-015ca48c had
> an event of type Pending
> ...
> [2018-08-28 13:05:37,193] {logging_mixin.py:95} INFO - [2018-08-28
> 13:05:37,193] {pod_launcher.py:95} INFO -
> b'INFO:botocore.vendored.requests.packages.urllib3.connectionpool:Starting
> new HTTPS connection (7): blah-blah.s3.eu-west-1.amazonaws.com\n'
> ...
> ...all other log lines from pod...
> {code}
> However, this executor pod only exists for the duration of the lifetime of
> the task pod so the logs are lost pretty much immediately after the task
> runs. There is nothing that ships the logs back to the scheduler and/or web
> UI.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [airflow] galak75 commented on issue #4743: [AIRFLOW-3871] render Operators template fields recursively
galak75 commented on issue #4743: [AIRFLOW-3871] render Operators template fields recursively URL: https://github.com/apache/airflow/pull/4743#issuecomment-532329378 @ashb: I rebased onto master and build is green This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-5510) example_trigger_target_dag not working
[
https://issues.apache.org/jira/browse/AIRFLOW-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931744#comment-16931744
]
ASF GitHub Bot commented on AIRFLOW-5510:
-
brunolucatto commented on pull request #6137: [AIRFLOW-5510] Add provide context
URL: https://github.com/apache/airflow/pull/6137
Add provide context in order to make kwargs in run_this_func receive the
message passed from the controller dag
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> example_trigger_target_dag not working
> --
>
> Key: AIRFLOW-5510
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5510
> Project: Apache Airflow
> Issue Type: Bug
> Components: DAG, DagRun
>Affects Versions: 1.10.5
>Reporter: Bruno
>Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> operator run_this should provide_context in order to make the function
> run_this_func receive the message passed by the controller dag
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [airflow] brunolucatto commented on issue #6136: Update example_trigger_target_dag.py
brunolucatto commented on issue #6136: Update example_trigger_target_dag.py URL: https://github.com/apache/airflow/pull/6136#issuecomment-532362393 I understand it was intentionally removed, but without it, the example is not working in my airflow. I was really confused since two weeks ago it worked, so I went to the git page and saw it was changed. Then I tried adding it again and it solved the case. I don't know if this works in other circumstances, but it should definitely be double-checked. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-5447) KubernetesExecutor hangs on task queueing
[ https://issues.apache.org/jira/browse/AIRFLOW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931779#comment-16931779 ] ASF subversion and git services commented on AIRFLOW-5447: -- Commit 4fb29030a1f848f1cca64ad5558068509e94472e in airflow's branch refs/heads/v1-10-test from Daniel Imberman [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=4fb2903 ] [AIRFLOW-5447] Scheduler stalls because second watcher thread in default args > KubernetesExecutor hangs on task queueing > - > > Key: AIRFLOW-5447 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5447 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes >Affects Versions: 1.10.4, 1.10.5 > Environment: Kubernetes version v1.14.3, Airflow version 1.10.4-1.10.5 >Reporter: Henry Cohen >Assignee: Daniel Imberman >Priority: Blocker > > Starting in 1.10.4, and continuing in 1.10.5, when using the > KubernetesExecutor, with the webserver and scheduler running in the > kubernetes cluster, tasks are scheduled, but when added to the task queue, > the executor process hangs indefinitely. Based on log messages, it appears to > be stuck at this line > https://github.com/apache/airflow/blob/v1-10-stable/airflow/contrib/executors/kubernetes_executor.py#L761 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-5480) Fix flaky impersonation test
[ https://issues.apache.org/jira/browse/AIRFLOW-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931560#comment-16931560 ] ASF subversion and git services commented on AIRFLOW-5480: -- Commit 89af64dce3ca8dc1c7a5cdd9d80eb8fc08ae52f5 in airflow's branch refs/heads/v1-10-test from Kamil Breguła [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=89af64d ] [AIRFLOW-5480] Fix flaky impersonation (#6098) (cherry picked from commit 4459592e523bbeeda0747dd9f888c3e215a241d1) > Fix flaky impersonation test > > > Key: AIRFLOW-5480 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5480 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.5 >Reporter: Kamil Bregula >Priority: Critical > Fix For: 1.10.6 > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-5256) Related pylint changes for common licences in python files
[ https://issues.apache.org/jira/browse/AIRFLOW-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931559#comment-16931559 ] ASF subversion and git services commented on AIRFLOW-5256: -- Commit 1043c8530df321c7f4640842cdc2a4b12d3c662a in airflow's branch refs/heads/v1-10-test from Jarek Potiuk [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=1043c85 ] [AIRFLOW-5256] Related pylint changes for common licences in python files (#5786) (cherry picked from commit 47801057989046dfcf7b424ce54afee103803815) > Related pylint changes for common licences in python files > -- > > Key: AIRFLOW-5256 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5256 > Project: Apache Airflow > Issue Type: Sub-task > Components: ci, core >Affects Versions: 2.0.0 >Reporter: Jarek Potiuk >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [airflow] codecov-io edited a comment on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python
codecov-io edited a comment on issue #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#issuecomment-531411977 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6096?src=pr=h1) Report > Merging [#6096](https://codecov.io/gh/apache/airflow/pull/6096?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/bc826070e15658cc182da5091b6a0f26eb2bc141?src=pr=desc) will **decrease** coverage by `70.54%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/airflow/pull/6096?src=pr=tree) ```diff @@Coverage Diff @@ ## master #6096 +/- ## == - Coverage 80.03% 9.49% -70.55% == Files 607 607 Lines 35001 35089 +88 == - Hits280133331-24682 - Misses 6988 31758+24770 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6096?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/example\_dags/example\_pubsub.py](https://codecov.io/gh/apache/airflow/pull/6096/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfcHVic3ViLnB5) | `0% <0%> (ø)` | :arrow_up: | | [airflow/gcp/operators/pubsub.py](https://codecov.io/gh/apache/airflow/pull/6096/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL3B1YnN1Yi5weQ==) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/gcp/hooks/pubsub.py](https://codecov.io/gh/apache/airflow/pull/6096/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvcHVic3ViLnB5) | `0% <0%> (-93.75%)` | :arrow_down: | | [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/6096/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/example\_dags/subdags/subdag.py](https://codecov.io/gh/apache/airflow/pull/6096/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3Mvc3ViZGFncy9zdWJkYWcucHk=) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/gcp/sensors/bigquery\_dts.py](https://codecov.io/gh/apache/airflow/pull/6096/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avc2Vuc29ycy9iaWdxdWVyeV9kdHMucHk=) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/gcp/operators/text\_to\_speech.py](https://codecov.io/gh/apache/airflow/pull/6096/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL3RleHRfdG9fc3BlZWNoLnB5) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/contrib/sensors/emr\_base\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6096/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZW1yX2Jhc2Vfc2Vuc29yLnB5) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/gcp/hooks/discovery\_api.py](https://codecov.io/gh/apache/airflow/pull/6096/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGlzY292ZXJ5X2FwaS5weQ==) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6096/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `0% <0%> (-100%)` | :arrow_down: | | ... and [499 more](https://codecov.io/gh/apache/airflow/pull/6096/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6096?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6096?src=pr=footer). Last update [bc82607...2f0dd74](https://codecov.io/gh/apache/airflow/pull/6096?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil commented on issue #6066: [AIRFLOW-XXX] Update to new logo
kaxil commented on issue #6066: [AIRFLOW-XXX] Update to new logo
URL: https://github.com/apache/airflow/pull/6066#issuecomment-532359694
```
diff --git a/airflow/www/templates/airflow/circles.html
b/airflow/www/templates/airflow/circles.html
index b200508..0a9ea27 100644
--- a/airflow/www/templates/airflow/circles.html
+++ b/airflow/www/templates/airflow/circles.html
@@ -1,4 +1,6 @@
{#
+ TODO: This license is not consistent with license used in the project.
+ Delete the inconsistent license and above line and rerun pre-commit
to insert a good license.
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil edited a comment on issue #6066: [AIRFLOW-XXX] Update to new logo
kaxil edited a comment on issue #6066: [AIRFLOW-XXX] Update to new logo
URL: https://github.com/apache/airflow/pull/6066#issuecomment-532359694
From CI:
```
diff --git a/airflow/www/templates/airflow/circles.html
b/airflow/www/templates/airflow/circles.html
index b200508..0a9ea27 100644
--- a/airflow/www/templates/airflow/circles.html
+++ b/airflow/www/templates/airflow/circles.html
@@ -1,4 +1,6 @@
{#
+ TODO: This license is not consistent with license used in the project.
+ Delete the inconsistent license and above line and rerun pre-commit
to insert a good license.
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] brunolucatto commented on issue #6136: Update example_trigger_target_dag.py
brunolucatto commented on issue #6136: Update example_trigger_target_dag.py URL: https://github.com/apache/airflow/pull/6136#issuecomment-532364132 I did not install airflow, I have been using it as a tool at work, making DAGs. Actually, I was looking at these examples because I am a beginner, so it really gave me a hard time to figure out what was wrong. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #4743: [AIRFLOW-3871] render Operators template fields recursively
codecov-io edited a comment on issue #4743: [AIRFLOW-3871] render Operators template fields recursively URL: https://github.com/apache/airflow/pull/4743#issuecomment-466461316 # [Codecov](https://codecov.io/gh/apache/airflow/pull/4743?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@c098ff7`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `11.76%`. [](https://codecov.io/gh/apache/airflow/pull/4743?src=pr=tree) ```diff @@ Coverage Diff@@ ## master #4743 +/- ## Coverage ? 9.47% Files ? 607 Lines ? 35032 Branches ? 0 Hits ?3321 Misses? 31711 Partials ? 0 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/4743?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/4743/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `40.94% <11.76%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/4743?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/4743?src=pr=footer). Last update [c098ff7...8781b1e](https://codecov.io/gh/apache/airflow/pull/4743?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (AIRFLOW-5511) MSSQL resetdb /initdb for 1.10.5 fails to create tables
[
https://issues.apache.org/jira/browse/AIRFLOW-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ROHIT K RAMWAL updated AIRFLOW-5511:
Attachment: airflowbug
> MSSQL resetdb /initdb for 1.10.5 fails to create tables
> ---
>
> Key: AIRFLOW-5511
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5511
> Project: Apache Airflow
> Issue Type: Bug
> Components: celery, database
>Affects Versions: 1.10.5
>Reporter: ROHIT K RAMWAL
>Priority: Major
> Attachments: airflowbug
>
>
> Airflow 1.10.5 installation with MSSQL backend and celery fails with below
> error .
>
> Traceback (most recent call last):
> File "/bin/airflow", line 32, in
> args.func(args)
> File "/usr/lib/python2.7/site-packages/airflow/bin/cli.py", line 1112, in
> resetdb
> db.resetdb(settings.RBAC)
> File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 406, in
> resetdb
> initdb(rbac)
> File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 106, in
> initdb
> upgradedb()
> File "/usr/lib/python2.7/site-packages/airflow/utils/db.py", line 377, in
> upgradedb
> command.upgrade(config, 'heads')
> File "/usr/lib/python2.7/site-packages/alembic/command.py", line 279, in
> upgrade
> script.run_env()
> File "/usr/lib/python2.7/site-packages/alembic/script/base.py", line 475,
> in run_env
> util.load_python_file(self.dir, "env.py")
> File "/usr/lib/python2.7/site-packages/alembic/util/pyfiles.py", line 98,
> in load_python_file
> module = load_module_py(module_id, path)
> File "/usr/lib/python2.7/site-packages/alembic/util/compat.py", line 240,
> in load_module_py
> mod = imp.load_source(module_id, path, fp)
> File "/usr/lib/python2.7/site-packages/airflow/migrations/env.py", line 92,
> in
> run_migrations_online()
> File "/usr/lib/python2.7/site-packages/airflow/migrations/env.py", line 86,
> in run_migrations_online
> context.run_migrations()
> File "", line 8, in run_migrations
> File "/usr/lib/python2.7/site-packages/alembic/runtime/environment.py",
> line 846, in run_migrations
> self.get_context().run_migrations(**kw)
> File "/usr/lib/python2.7/site-packages/alembic/runtime/migration.py", line
> 365, in run_migrations
> step.migration_fn(**kw)
> File
> "/usr/lib/python2.7/site-packages/airflow/migrations/versions/6e96a59344a4_make_taskinstance_pool_not_nullable.py",
> line 101, in upgrade
> nullable=False,
> File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
> self.gen.next()
> File "/usr/lib/python2.7/site-packages/alembic/operations/base.py", line
> 325, in batch_alter_table
> impl.flush()
> File "/usr/lib/python2.7/site-packages/alembic/operations/batch.py", line
> 79, in flush
> fn(*arg, **kw)
> File "/usr/lib/python2.7/site-packages/alembic/ddl/mssql.py", line 85, in
> alter_column
> **kw
> File "/usr/lib/python2.7/site-packages/alembic/ddl/impl.py", line 172, in
> alter_column
> existing_comment=existing_comment,
> File "/usr/lib/python2.7/site-packages/alembic/ddl/mssql.py", line 36, in
> _exec
> result = super(MSSQLImpl, self)._exec(construct, *args, **kw)
> File "/usr/lib/python2.7/site-packages/alembic/ddl/impl.py", line 134, in
> _exec
> return conn.execute(construct, *multiparams, **params)
> File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line
> 988, in execute
> return meth(self, multiparams, params)
> File "/usr/lib64/python2.7/site-packages/sqlalchemy/sql/ddl.py", line 72,
> in _execute_on_connection
> return connection._execute_ddl(self, multiparams, params)
> File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line
> 1050, in _execute_ddl
> compiled,
> File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line
> 1253, in _execute_context
> e, statement, parameters, cursor, context
> File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line
> 1473, in _handle_dbapi_exception
> util.raise_from_cause(sqlalchemy_exception, exc_info)
> File "/usr/lib64/python2.7/site-packages/sqlalchemy/util/compat.py", line
> 398, in raise_from_cause
> reraise(type(exception), exception, tb=exc_tb, cause=cause)
> File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line
> 1249, in _execute_context
> cursor, statement, parameters, context
> File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/default.py",
> line 552, in do_execute
> cursor.execute(statement, parameters)
> sqlalchemy.exc.ProgrammingError: (pyodbc.ProgrammingError) ('42000', "[42000]
> [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The index 'ti_pool' is
> dependent on column 'pool'. (5074) (SQLExecDirectW)")
> [SQL: ALTER
[GitHub] [airflow] kaxil commented on issue #6137: [AIRFLOW-5510] Add provide context
kaxil commented on issue #6137: [AIRFLOW-5510] Add provide context URL: https://github.com/apache/airflow/pull/6137#issuecomment-532361046 This has been intentionally removed by some awesome work from @Fokko #5990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (AIRFLOW-5439) Schedule_interval is not recognized if specified in Default_args
[
https://issues.apache.org/jira/browse/AIRFLOW-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kaxil Naik closed AIRFLOW-5439.
---
Resolution: Not A Problem
We have deprecated using {{schedule_inteval}} at task level. You need to only
specify it as a DAG parameter instead.
> Schedule_interval is not recognized if specified in Default_args
>
>
> Key: AIRFLOW-5439
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5439
> Project: Apache Airflow
> Issue Type: Improvement
> Components: DAG
>Affects Versions: 1.9.0, 1.10.0, 1.10.1, 1.10.2, 1.10.3, 1.10.4, 1.10.5
>Reporter: Inigo San Jose Visiers
>Priority: Minor
>
> When specifying the "_schedule_interval_" inside the "_default_args_", it is
> not recognized.
> This can lead to confusion when creating a DAG.
> I have run into this confusion myself, as well as colleagues and some other
> users:
> https://stackoverflow.com/questions/57752214
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (AIRFLOW-5439) Schedule_interval is not recognized if specified in Default_args
[ https://issues.apache.org/jira/browse/AIRFLOW-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931755#comment-16931755 ] ASF GitHub Bot commented on AIRFLOW-5439: - kaxil commented on pull request #6058: [AIRFLOW-5439] Add 'schedule_interval' to 'default_args' URL: https://github.com/apache/airflow/pull/6058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Schedule_interval is not recognized if specified in Default_args > > > Key: AIRFLOW-5439 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5439 > Project: Apache Airflow > Issue Type: Improvement > Components: DAG >Affects Versions: 1.9.0, 1.10.0, 1.10.1, 1.10.2, 1.10.3, 1.10.4, 1.10.5 >Reporter: Inigo San Jose Visiers >Priority: Minor > > When specifying the "_schedule_interval_" inside the "_default_args_", it is > not recognized. > This can lead to confusion when creating a DAG. > I have run into this confusion myself, as well as colleagues and some other > users: > https://stackoverflow.com/questions/57752214 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [airflow] kaxil closed pull request #6058: [AIRFLOW-5439] Add 'schedule_interval' to 'default_args'
kaxil closed pull request #6058: [AIRFLOW-5439] Add 'schedule_interval' to 'default_args' URL: https://github.com/apache/airflow/pull/6058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator
codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator URL: https://github.com/apache/airflow/pull/6051#issuecomment-532497253 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=h1) Report > Merging [#6051](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6051 +/- ## == - Coverage 80.03% 80.02% -0.02% == Files 607 607 Lines 3501935004 -15 == - Hits2802928012 -17 - Misses 6990 6992 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <81.81%> (-2.74%)` | :arrow_down: | | [airflow/contrib/hooks/gcp\_api\_base\_hook.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9hcGlfYmFzZV9ob29rLnB5) | `97.2% <95.45%> (+0.08%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=footer). Last update [fa8e18a...40e5ea3](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator
codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator URL: https://github.com/apache/airflow/pull/6051#issuecomment-532497253 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=h1) Report > Merging [#6051](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6051 +/- ## == - Coverage 80.03% 80.02% -0.02% == Files 607 607 Lines 3501935004 -15 == - Hits2802928012 -17 - Misses 6990 6992 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <81.81%> (-2.74%)` | :arrow_down: | | [airflow/contrib/hooks/gcp\_api\_base\_hook.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9hcGlfYmFzZV9ob29rLnB5) | `97.2% <95.45%> (+0.08%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=footer). Last update [fa8e18a...40e5ea3](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator
codecov-io commented on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator URL: https://github.com/apache/airflow/pull/6051#issuecomment-532497253 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=h1) Report > Merging [#6051](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6051 +/- ## == - Coverage 80.03% 80.02% -0.02% == Files 607 607 Lines 3501935004 -15 == - Hits2802928012 -17 - Misses 6990 6992 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <81.81%> (-2.74%)` | :arrow_down: | | [airflow/contrib/hooks/gcp\_api\_base\_hook.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9hcGlfYmFzZV9ob29rLnB5) | `97.2% <95.45%> (+0.08%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=footer). Last update [fa8e18a...40e5ea3](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator
codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator URL: https://github.com/apache/airflow/pull/6051#issuecomment-532497253 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=h1) Report > Merging [#6051](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6051 +/- ## == - Coverage 80.03% 80.02% -0.02% == Files 607 607 Lines 3501935004 -15 == - Hits2802928012 -17 - Misses 6990 6992 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <81.81%> (-2.74%)` | :arrow_down: | | [airflow/contrib/hooks/gcp\_api\_base\_hook.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9hcGlfYmFzZV9ob29rLnB5) | `97.2% <95.45%> (+0.08%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=footer). Last update [fa8e18a...40e5ea3](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator
codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator URL: https://github.com/apache/airflow/pull/6051#issuecomment-532497253 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=h1) Report > Merging [#6051](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6051 +/- ## == - Coverage 80.03% 80.02% -0.02% == Files 607 607 Lines 3501935004 -15 == - Hits2802928012 -17 - Misses 6990 6992 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <81.81%> (-2.74%)` | :arrow_down: | | [airflow/contrib/hooks/gcp\_api\_base\_hook.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9hcGlfYmFzZV9ob29rLnB5) | `97.2% <95.45%> (+0.08%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=footer). Last update [fa8e18a...40e5ea3](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics
mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics URL: https://github.com/apache/airflow/pull/6130#discussion_r325452768 ## File path: docs/metrics.rst ## @@ -41,6 +41,13 @@ Add the following lines to your configuration file e.g. ``airflow.cfg`` statsd_port = 8125 statsd_prefix = airflow +If you want to avoid send all the available metrics to StatsD, you can configure a whitelist of prefixes to send only +the metrics that start with the elements of the list: + +.. code-block:: bash + Review comment: This config is under `[scheduler]`. I'll add that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics
mikedias commented on a change in pull request #6130: [AIRFLOW-5508] Add a whitelist mechanism for the StatsD metrics URL: https://github.com/apache/airflow/pull/6130#discussion_r325452402 ## File path: docs/metrics.rst ## @@ -41,6 +41,13 @@ Add the following lines to your configuration file e.g. ``airflow.cfg`` statsd_port = 8125 statsd_prefix = airflow +If you want to avoid send all the available metrics to StatsD, you can configure a whitelist of prefixes to send only +the metrics that start with the elements of the list: + +.. code-block:: bash Review comment: Hi @mik-laj, I just checked and currently, there is no `.. code-block:: init` in the codebase. Do you think it's a good idea to start that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator
codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator URL: https://github.com/apache/airflow/pull/6051#issuecomment-532497253 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=h1) Report > Merging [#6051](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6051 +/- ## == - Coverage 80.03% 80.02% -0.02% == Files 607 607 Lines 3501935004 -15 == - Hits2802928012 -17 - Misses 6990 6992 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <81.81%> (-2.74%)` | :arrow_down: | | [airflow/contrib/hooks/gcp\_api\_base\_hook.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9hcGlfYmFzZV9ob29rLnB5) | `97.2% <95.45%> (+0.08%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=footer). Last update [fa8e18a...40e5ea3](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator
codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator URL: https://github.com/apache/airflow/pull/6051#issuecomment-532497253 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=h1) Report > Merging [#6051](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6051 +/- ## == - Coverage 80.03% 80.02% -0.02% == Files 607 607 Lines 3501935004 -15 == - Hits2802928012 -17 - Misses 6990 6992 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <81.81%> (-2.74%)` | :arrow_down: | | [airflow/contrib/hooks/gcp\_api\_base\_hook.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9hcGlfYmFzZV9ob29rLnB5) | `97.2% <95.45%> (+0.08%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=footer). Last update [fa8e18a...40e5ea3](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator
codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator URL: https://github.com/apache/airflow/pull/6051#issuecomment-532497253 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=h1) Report > Merging [#6051](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6051 +/- ## == - Coverage 80.03% 80.02% -0.02% == Files 607 607 Lines 3501935004 -15 == - Hits2802928012 -17 - Misses 6990 6992 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <81.81%> (-2.74%)` | :arrow_down: | | [airflow/contrib/hooks/gcp\_api\_base\_hook.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9hcGlfYmFzZV9ob29rLnB5) | `97.2% <95.45%> (+0.08%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=footer). Last update [fa8e18a...40e5ea3](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator
codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator URL: https://github.com/apache/airflow/pull/6051#issuecomment-532497253 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=h1) Report > Merging [#6051](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6051 +/- ## == - Coverage 80.03% 80.02% -0.02% == Files 607 607 Lines 3501935004 -15 == - Hits2802928012 -17 - Misses 6990 6992 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <81.81%> (-2.74%)` | :arrow_down: | | [airflow/contrib/hooks/gcp\_api\_base\_hook.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9hcGlfYmFzZV9ob29rLnB5) | `97.2% <95.45%> (+0.08%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=footer). Last update [fa8e18a...40e5ea3](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator
codecov-io edited a comment on issue #6051: [AIRFLOW-5435][depends on AIRFLOW-5434] Add fallback for connection's project id in GKEPodOperator URL: https://github.com/apache/airflow/pull/6051#issuecomment-532497253 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=h1) Report > Merging [#6051](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `90.9%`. [](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6051 +/- ## == - Coverage 80.03% 80.02% -0.02% == Files 607 607 Lines 3501935004 -15 == - Hits2802928012 -17 - Misses 6990 6992 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/operators/kubernetes\_engine.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2t1YmVybmV0ZXNfZW5naW5lLnB5) | `97.26% <81.81%> (-2.74%)` | :arrow_down: | | [airflow/contrib/hooks/gcp\_api\_base\_hook.py](https://codecov.io/gh/apache/airflow/pull/6051/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9hcGlfYmFzZV9ob29rLnB5) | `97.2% <95.45%> (+0.08%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=footer). Last update [fa8e18a...40e5ea3](https://codecov.io/gh/apache/airflow/pull/6051?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook
dstandish commented on issue #6104: [AIRFLOW-4574] allow providing private_key in SSHHook URL: https://github.com/apache/airflow/pull/6104#issuecomment-532440383 @pgagnon the same could be said of password, which some hooks have. The point of this in my view is that ssh is a connection like any other. Any other connection, we can supply creds through DB or env var alone; this one for some reason requires we also create a file on the instance, does not allow us to supply directly via connection string. I suppose we could remove the option to supply param at hook instantiation, so it is an extras-only kind of deal, but I don't personally see the value. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-5447) KubernetesExecutor hangs on task queueing
[ https://issues.apache.org/jira/browse/AIRFLOW-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931826#comment-16931826 ] Daniel Imberman commented on AIRFLOW-5447: -- [~HPCohen] it's already in the 1-10-test branch. I'm gonna work with [~kaxilnaik] and [~ash] to see if we can't release hotfix 1.10.4/5 releases since this is such a critical bug. > KubernetesExecutor hangs on task queueing > - > > Key: AIRFLOW-5447 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5447 > Project: Apache Airflow > Issue Type: Bug > Components: executor-kubernetes >Affects Versions: 1.10.4, 1.10.5 > Environment: Kubernetes version v1.14.3, Airflow version 1.10.4-1.10.5 >Reporter: Henry Cohen >Assignee: Daniel Imberman >Priority: Blocker > > Starting in 1.10.4, and continuing in 1.10.5, when using the > KubernetesExecutor, with the webserver and scheduler running in the > kubernetes cluster, tasks are scheduled, but when added to the task queue, > the executor process hangs indefinitely. Based on log messages, it appears to > be stuck at this line > https://github.com/apache/airflow/blob/v1-10-stable/airflow/contrib/executors/kubernetes_executor.py#L761 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (AIRFLOW-5385) SparkSubmit status spend lot of time
[
https://issues.apache.org/jira/browse/AIRFLOW-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931099#comment-16931099
]
t oo edited comment on AIRFLOW-5385 at 9/17/19 10:21 PM:
-
i created spark-27491, i noticed airflow is always at 99%cpu and i have 40
spark-submits running in parallel! thank u!
was (Author: toopt4):
i created spark-27491, i noticed airflow is always at 99%cpu and i have 40
spark-submits running in parallel! thank u!
but i am facing this error with your patch:
[2019-09-17 19:06:01,135] \{__init__.py:1603} INFO - Marking task as
UP_FOR_RETRY
[2019-09-17 19:06:01,195] \{base_task_runner.py:101} INFO - Job x Traceback
(most recent call last):
[2019-09-17 19:06:01,195] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/bin/airflow", line 32, in
[2019-09-17 19:06:01,195] \{base_task_runner.py:101} INFO - Job x
args.func(args)
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/utils/cli.py",
line 74, in wrapper
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x return
f(*args, **kwargs)
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/bin/cli.py",
line 523, in run
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x _run(args,
dag, ti)
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/bin/cli.py",
line 442, in _run
[2019-09-17 19:06:01,196] \{base_task_runner.py:101} INFO - Job x
pool=args.pool,
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/utils/db.py",
line 73, in wrapper
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x return
func(*args, **kwargs)
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/models/__init__.py",
line 1441, in _run_raw_task
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x result =
task_copy.execute(context=context)
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/contrib/operators/spark_submit_operator.py",
line 176, in execute
[2019-09-17 19:06:01,197] \{base_task_runner.py:101} INFO - Job x
self._hook.submit(self._application)
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/contrib/hooks/spark_submit_hook.py",
line 384, in submit
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x
self._start_driver_status_tracking()
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/contrib/hooks/spark_submit_hook.py",
line 514, in _start_driver_status_tracking
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x
universal_newlines=True)
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x File
"/usr/lib64/python2.7/subprocess.py", line 394, in __init__
[2019-09-17 19:06:01,198] \{base_task_runner.py:101} INFO - Job x errread,
errwrite)
[2019-09-17 19:06:01,199] \{base_task_runner.py:101} INFO - Job x File
"/usr/lib64/python2.7/subprocess.py", line 1047, in _execute_child
[2019-09-17 19:06:01,199] \{base_task_runner.py:101} INFO - Job x raise
child_exception
[2019-09-17 19:06:01,199] \{base_task_runner.py:101} INFO - Job x OSError:
[Errno 2] No such file or directory
[2019-09-17 19:06:02,898] \{logging_mixin.py:95} INFO - [2019-09-17
19:06:02,897] \{jobs.py:2566} INFO - Task exited with return code 1
> SparkSubmit status spend lot of time
>
>
> Key: AIRFLOW-5385
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5385
> Project: Apache Airflow
> Issue Type: Improvement
> Components: contrib
>Affects Versions: 1.10.2
>Reporter: Sergio Soto
>Priority: Blocker
>
> Hello,
> we have an issue with SparkSubmitOperator. Airflow DAGs shows that some
> streaming applications breaks out. I analyzed this behaviour. The
> SparkSubmitHook is the responsable of check the driver status.
> We discovered some timeouts and tried to reproduce checking command. This is
> an execution with `time`:
> {code:java}
> time /opt/java/jdk1.8.0_181/jre/bin/java -cp
> /opt/shared/spark/client/conf/:/opt/shared/spark/client/jars/* -Xmx1g
> org.apache.spark.deploy.SparkSubmit --master
> spark://spark-master.corp.com:6066 --status driver-20190901180337-2749
> Using Spark's default log4j profile:
> org/apache/spark/log4j-defaults.properties
> 19/09/02 17:05:53
[GitHub] [airflow] codecov-io edited a comment on issue #6137: [AIRFLOW-5510] Add provide context
codecov-io edited a comment on issue #6137: [AIRFLOW-5510] Add provide context URL: https://github.com/apache/airflow/pull/6137#issuecomment-532444721 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=h1) Report > Merging [#6137](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6137 +/- ## === Coverage 80.03% 80.03% === Files 607 607 Lines 3501935019 === Hits2802928029 Misses 6990 6990 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6137/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=) | `92.3% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=footer). Last update [fa8e18a...4969533](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6137: [AIRFLOW-5510] Add provide context
codecov-io commented on issue #6137: [AIRFLOW-5510] Add provide context URL: https://github.com/apache/airflow/pull/6137#issuecomment-532444721 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=h1) Report > Merging [#6137](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6137 +/- ## === Coverage 80.03% 80.03% === Files 607 607 Lines 3501935019 === Hits2802928029 Misses 6990 6990 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6137/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=) | `92.3% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=footer). Last update [fa8e18a...4969533](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6137: [AIRFLOW-5510] Add provide context
codecov-io edited a comment on issue #6137: [AIRFLOW-5510] Add provide context URL: https://github.com/apache/airflow/pull/6137#issuecomment-532444721 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=h1) Report > Merging [#6137](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6137 +/- ## === Coverage 80.03% 80.03% === Files 607 607 Lines 3501935019 === Hits2802928029 Misses 6990 6990 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6137/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=) | `92.3% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=footer). Last update [fa8e18a...4969533](https://codecov.io/gh/apache/airflow/pull/6137?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging [#5976](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/fa8e18a2a833a2774f48c413a72df052e8c8f4f0?src=pr=desc) will **decrease** coverage by `0.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5976 +/- ## = - Coverage 80.03% 79.9% -0.14% = Files 607 607 Lines 35019 35019 = - Hits28029 27983 -46 - Misses 69907036 +46 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `81.81% <0%> (-11.37%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `86.44% <0%> (-6.78%)` | :arrow_down: | | [airflow/executors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvX19pbml0X18ucHk=) | `63.26% <0%> (-4.09%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `56.44% <0%> (-2.36%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `73.08% <0%> (-1.21%)` | :arrow_down: | | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5976/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.22% <0%> (-0.51%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=footer). Last update [fa8e18a...46a22e7](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] haoliang7 opened a new pull request #6138: [AIRFLOW-XXX] Fix typos in CONTRIBUTING.md
haoliang7 opened a new pull request #6138: [AIRFLOW-XXX] Fix typos in
CONTRIBUTING.md
URL: https://github.com/apache/airflow/pull/6138
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kurtqq commented on issue #6084: [AIRFLOW-5449] Users can now set existing variable values to None
kurtqq commented on issue #6084: [AIRFLOW-5449] Users can now set existing variable values to None URL: https://github.com/apache/airflow/pull/6084#issuecomment-532254893 This bug effects only 1.10 release? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name
codecov-io commented on issue #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name URL: https://github.com/apache/airflow/pull/5879#issuecomment-532257616 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5879?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@e326633`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/5879?src=pr=tree) ```diff @@Coverage Diff@@ ## master#5879 +/- ## = Coverage ? 80.05% = Files ? 607 Lines ?35059 Branches ?0 = Hits ?28067 Misses? 6992 Partials ?0 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5879?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/5879/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `90.09% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5879?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5879?src=pr=footer). Last update [e326633...8d9a5d9](https://codecov.io/gh/apache/airflow/pull/5879?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (AIRFLOW-5509) Support PATCH method in `DatabricksHook`
[
https://issues.apache.org/jira/browse/AIRFLOW-5509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rosalyn Taylor updated AIRFLOW-5509:
Priority: Major (was: Minor)
> Support PATCH method in `DatabricksHook`
>
>
> Key: AIRFLOW-5509
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5509
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
>Affects Versions: 1.10.5
>Reporter: Rosalyn Taylor
>Priority: Major
>
> The current `DatabricksHook` [0] currently only supports GET and POST HTTP
> operations against the Databricks API: [1]
> {code:python}
> if method == 'GET':
> request_func = requests.get
> elif method == 'POST':
> request_func = requests.post
> else:
> raise AirflowException('Unexpected HTTP Method: ' + method)
> {code}
> Some of the Databricks APIs require PATCH operations. [2] This ticket is to
> propose that PATCH operation support is added to the `_do_api_call()` method
> of the `DatabricksHook` class. [3]
> If this proposal is suitable, I'm happy to submit a PR.
> [0]:
> [https://github.com/apache/airflow/blob/master//airflow/contrib/hooks/databricks_hook.py#L83:7]
> [1]:
> [https://github.com/apache/airflow/blob/master//airflow/contrib/hooks/databricks_hook.py#L164-L169]
> [2]:
> [https://docs.databricks.com/api/latest/scim.html#update-user-by-id-patch]
> [3]:
> [https://github.com/apache/airflow/blob/master//airflow/contrib/hooks/databricks_hook.py#L136]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
