[jira] [Commented] (AIRFLOW-3447) Intended usage of ts_nodash macro broken with migration to new time system.
[
https://issues.apache.org/jira/browse/AIRFLOW-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710235#comment-16710235
]
Luka Draksler commented on AIRFLOW-3447:
We simply replaced ts_nodash in models.py with
{code:java}
ts_nodash = self.execution_date.strftime('%Y%m%dT%H%M%S')
{code}
resulting in the same value as before
> Intended usage of ts_nodash macro broken with migration to new time system.
> ---
>
> Key: AIRFLOW-3447
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3447
> Project: Apache Airflow
> Issue Type: Bug
> Components: core
>Reporter: Luka Draksler
>Priority: Minor
> Labels: easyfix
>
> Migration to timezone aware times broke the intended usage of ts_nodash macro.
> ts_nodash is used in certain placeholders to create different names (table
> names, cluster names...). As such it is alphanumeric only, it contains no
> characters that could be deemed illegal by various naming restrictions.
> Migration to new time system changed that.
> As an example, this would be returned currently:
> {{20181205T125657.169324+}}
> {{before:}}
> {{20181204T03}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AIRFLOW-3447) Intended usage of ts_nodash macro broken with migration to new time system.
[
https://issues.apache.org/jira/browse/AIRFLOW-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luka Draksler updated AIRFLOW-3447:
---
Description:
Migration to timezone aware times broke the intended usage of ts_nodash macro.
ts_nodash is used in certain placeholders to create different names (table
names, cluster names...). As such it is alphanumeric only, it contains no
characters that could be deemed illegal by various naming restrictions.
Migration to new time system changed that.
As an example, this would be returned currently:
{{20181205T125657.169324+}}
{{before:}}
{{20181204T03}}
was:
Migration to timezone aware times broke the intended usage of ts_nodash macro.
ts_nodash is used in certain placeholders to create different names (table
names, cluster names...). As such it is alphanumeric only, it contains no
characters that could be deemed illegal by various naming restrictions.
Migration to new time system changed that.
As an example, this would be returned currently:
{{20181205T125657.169324+}}
{{before:}}
{{20181204T03}}{{}}
> Intended usage of ts_nodash macro broken with migration to new time system.
> ---
>
> Key: AIRFLOW-3447
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3447
> Project: Apache Airflow
> Issue Type: Bug
> Components: core
>Reporter: Luka Draksler
>Priority: Minor
> Labels: easyfix
>
> Migration to timezone aware times broke the intended usage of ts_nodash macro.
> ts_nodash is used in certain placeholders to create different names (table
> names, cluster names...). As such it is alphanumeric only, it contains no
> characters that could be deemed illegal by various naming restrictions.
> Migration to new time system changed that.
> As an example, this would be returned currently:
> {{20181205T125657.169324+}}
> {{before:}}
> {{20181204T03}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AIRFLOW-3447) Intended usage of ts_nodash macro broken with migration to new time system.
[
https://issues.apache.org/jira/browse/AIRFLOW-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luka Draksler updated AIRFLOW-3447:
---
Summary: Intended usage of ts_nodash macro broken with migration to new
time system. (was: Migration to timezone aware times broke the intended usage
of ts_nodash macro.)
> Intended usage of ts_nodash macro broken with migration to new time system.
> ---
>
> Key: AIRFLOW-3447
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3447
> Project: Apache Airflow
> Issue Type: Bug
> Components: core
>Reporter: Luka Draksler
>Priority: Minor
> Labels: easyfix
>
> Migration to timezone aware times broke the intended usage of ts_nodash macro.
> ts_nodash is used in certain placeholders to create different names (table
> names, cluster names...). As such it is alphanumeric only, it contains no
> characters that could be deemed illegal by various naming restrictions.
> Migration to new time system changed that.
> As an example, this would be returned currently:
> {{20181205T125657.169324+}}
> {{before:}}
> {{20181204T03}}{{}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (AIRFLOW-3447) Migration to timezone aware times broke the intended usage of ts_nodash macro.
Luka Draksler created AIRFLOW-3447:
--
Summary: Migration to timezone aware times broke the intended
usage of ts_nodash macro.
Key: AIRFLOW-3447
URL: https://issues.apache.org/jira/browse/AIRFLOW-3447
Project: Apache Airflow
Issue Type: Bug
Components: core
Reporter: Luka Draksler
Migration to timezone aware times broke the intended usage of ts_nodash macro.
ts_nodash is used in certain placeholders to create different names (table
names, cluster names...). As such it is alphanumeric only, it contains no
characters that could be deemed illegal by various naming restrictions.
Migration to new time system changed that.
As an example, this would be returned currently:
{{20181205T125657.169324+}}
{{before:}}
{{20181204T03}}{{}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (AIRFLOW-3438) BigQueryOperator should default udf_config to None instead of false.
Luka Draksler created AIRFLOW-3438: -- Summary: BigQueryOperator should default udf_config to None instead of false. Key: AIRFLOW-3438 URL: https://issues.apache.org/jira/browse/AIRFLOW-3438 Project: Apache Airflow Issue Type: Bug Components: operators Reporter: Luka Draksler BigQueryOperator currently sets default value of udf_config to False. This no longer works due to [https://github.com/apache/incubator-airflow/pull/3733] validating the type of that parameter as either None or list. Default value needs to be changed to None. Note, other users of the hook may potentially encounter the same issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (AIRFLOW-3438) BigQueryOperator should default udf_config to None instead of false.
[
https://issues.apache.org/jira/browse/AIRFLOW-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luka Draksler updated AIRFLOW-3438:
---
Description:
BigQueryOperator currently sets default value of udf_config to False. This no
longer works due to [https://github.com/apache/incubator-airflow/pull/3733]
validating the type of that parameter as either None or list. Default value
needs to be changed to None.
The line in question added in the commit referenced above
{code:java}
(udf_config, 'userDefinedFunctionResources', None, list),
{code}
Note, other users of the hook may potentially encounter the same issue.
was:
BigQueryOperator currently sets default value of udf_config to False. This no
longer works due to [https://github.com/apache/incubator-airflow/pull/3733]
validating the type of that parameter as either None or list. Default value
needs to be changed to None.
Note, other users of the hook may potentially encounter the same issue.
> BigQueryOperator should default udf_config to None instead of false.
>
>
> Key: AIRFLOW-3438
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3438
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
>Reporter: Luka Draksler
>Priority: Major
> Labels: easyfix
>
> BigQueryOperator currently sets default value of udf_config to False. This no
> longer works due to [https://github.com/apache/incubator-airflow/pull/3733]
> validating the type of that parameter as either None or list. Default value
> needs to be changed to None.
> The line in question added in the commit referenced above
> {code:java}
> (udf_config, 'userDefinedFunctionResources', None, list),
> {code}
>
>
> Note, other users of the hook may potentially encounter the same issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
