[GitHub] Fokko commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py
Fokko commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-419018451 @ashb I'm working on removing tox, but removing tox this isn't trivial. Since we already encapsulate the tests in Docker, tox adds another layer of abstraction, which is not required in my opinion. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Fokko commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py
Fokko commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-412000219 I'd say that we would need to remove this tox install as well: https://github.com/apache/incubator-airflow/blob/master/.travis.yml#L98 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Fokko commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py
Fokko commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-410503637 In case who missed it: https://www.youtube.com/watch?v=5Il3w2P7IcM Awesome work @holdenk for getting people inspired to contribute to open source software! I've checked. The tox version being installed with `apt-get` by Travis is also 3.1.3. Not completely sure why this failed :-) In the end we should rely less on Travis and move to a Dockerized setup to make testing easier. There is a great effort going on in https://github.com/apache/incubator-airflow/pull/3393/ but there are still some lose ends that need to be fixed before we can merge it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
