[GitHub] jzucker2 commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync
jzucker2 commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#discussion_r239688963 ## File path: airflow/contrib/kubernetes/worker_configuration.py ## @@ -89,11 +100,18 @@ def _get_environment(self): if self.kube_config.airflow_configmap: env['AIRFLOW__CORE__AIRFLOW_HOME'] = self.worker_airflow_home -if self.kube_config.worker_dags_folder: -env['AIRFLOW__CORE__DAGS_FOLDER'] = self.kube_config.worker_dags_folder +env['AIRFLOW__CORE__DAGS_FOLDER'] = self.worker_airflow_dags Review comment: this always seemed like such an issue that it's hard coded in the `master` branch, I'm glad this is being addressed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jzucker2 commented on a change in pull request #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync
jzucker2 commented on a change in pull request #3770: [AIRFLOW-3281] Fix
Kubernetes operator with git-sync
URL: https://github.com/apache/incubator-airflow/pull/3770#discussion_r23968
##
File path: airflow/contrib/kubernetes/worker_configuration.py
##
@@ -50,13 +55,13 @@ def _get_init_containers(self, volume_mounts):
'value': self.kube_config.git_branch
}, {
'name': 'GIT_SYNC_ROOT',
-'value': os.path.join(
-self.worker_airflow_dags,
-self.kube_config.git_subpath
-)
+'value': self.kube_config.git_sync_root
}, {
'name': 'GIT_SYNC_DEST',
-'value': 'dags'
+'value': self.kube_config.git_sync_dest
+}, {
+'name': 'GIT_SYNC_DEPTH',
Review comment:
does this fix the issue of the revision being in the path directory?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
