[GitHub] odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync
odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#issuecomment-447659897 @dimberman @Fokko @jzucker2 branch rebased and the build is green Please merge this PR before #4319 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync
odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#issuecomment-446781808 @BrechtDeVlieger thanks a lot! I just fixed the code and pushed. Let's see what travis will say This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync
odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#issuecomment-446402481 @dimberman I realised now that your problem is different, I ran airflow with minikube locally using kubernetes provided by docker for mac (not using a virtual machine) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync
odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#issuecomment-446401293 @dimberman I was able to run minikube on mac, I think the permission problem you faced is the mess with pip install in the build: https://github.com/apache/incubator-airflow/blob/45c90a66dc3a9e9ef77a6deecdd165adef1ec1e0/.travis.yml#L53 https://github.com/apache/incubator-airflow/blob/c1b3d6d72c8e622dbcd0af91290d95b87b12afbe/scripts/ci/run-ci.sh#L38 In travis runs as `root`, in run-ci.sh runs inside the container as `airflow` user. I tried to fix it without success, I guess https://github.com/apache/incubator-airflow/commit/010924a06f173f0ec32fcdf2b9025539c89931cb#diff-b6397716b7c671f7f39455356f14ead6R35 is causing the issue. I did the same but I had some issue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync
odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#issuecomment-445072628 @dimberman please go ahead, any help is appreciated. I tried to debug this PR without success. This https://github.com/apache/incubator-airflow/pull/3855 is suspicious, the volume name is `test-volume` but there is already a volume named like that in the deployment https://github.com/apache/incubator-airflow/blob/788bd6fcb35ce6354ae874a508772e58a850683e/scripts/ci/kubernetes/kube/airflow.yaml#L133 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync
odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#issuecomment-436051806 @Fokko rebased This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync
odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with git-sync URL: https://github.com/apache/incubator-airflow/pull/3770#issuecomment-434866757 @ashb ticket created, branch rebase /cc @Fokko @dimberman This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services