[GitHub] xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'

2018-09-03 Thread GitBox
xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in 
BigQuery query method - with 'api_resource_configs'
URL: 
https://github.com/apache/incubator-airflow/pull/3733#issuecomment-418189110
 
 
   @kaxil , thank you for review! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'

2018-08-30 Thread GitBox
xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in 
BigQuery query method - with 'api_resource_configs'
URL: 
https://github.com/apache/incubator-airflow/pull/3733#issuecomment-417475558
 
 
   @kaxil, check pls. And thanks in advance!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'

2018-08-21 Thread GitBox
xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in 
BigQuery query method - with 'api_resource_configs'
URL: 
https://github.com/apache/incubator-airflow/pull/3733#issuecomment-414666013
 
 
   @ashb , yeap.. thx.. I'm trying to understand how I broke it)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'

2018-08-21 Thread GitBox
xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in 
BigQuery query method - with 'api_resource_configs'
URL: 
https://github.com/apache/incubator-airflow/pull/3733#issuecomment-414645184
 
 
   @kaxil and @tswast , pls check


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'

2018-08-21 Thread GitBox
xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in 
BigQuery query method - with 'api_resource_configs'
URL: 
https://github.com/apache/incubator-airflow/pull/3733#issuecomment-414644891
 
 
   @ashb , hi Ash, sorry for what I'm pulling you, but I know what only you can 
help me this travis :) I got a strange error and already had re-triggered 
Travis once (got 2 checks with the same error). Thank you in advance!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'src_fmt_configs'

2018-08-21 Thread GitBox
xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in 
BigQuery query method - with 'src_fmt_configs'
URL: 
https://github.com/apache/incubator-airflow/pull/3733#issuecomment-414561148
 
 
   @kaxil, no problem) I will make changes today


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'src_fmt_configs'

2018-08-17 Thread GitBox
xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in 
BigQuery query method - with 'src_fmt_configs'
URL: 
https://github.com/apache/incubator-airflow/pull/3733#issuecomment-413993667
 
 
   @tswast, I agree. For me, it was be more clearly if name of variable was 
smth like ‘api_params’ or smth else. But this var was offered upper, and it was 
seems for me like universal name that was taken before. Anyway, I can rename 
param and describe - 5 sec. but need to agree about naming, because it could be 
used in other operators also. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'src_fmt_configs'

2018-08-15 Thread GitBox
xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in 
BigQuery query method - with 'src_fmt_configs'
URL: 
https://github.com/apache/incubator-airflow/pull/3733#issuecomment-413147879
 
 
   @kaxil, pls review


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'src_fmt_configs'

2018-08-15 Thread GitBox
xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in 
BigQuery query method - with 'src_fmt_configs'
URL: 
https://github.com/apache/incubator-airflow/pull/3733#issuecomment-413107395
 
 
   strange results of Codecov


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] xnuinside commented on issue #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method

2018-08-10 Thread GitBox
xnuinside commented on issue #3733:  [AIRFLOW-491] Add cache parameter in 
BigQuery query method
URL: 
https://github.com/apache/incubator-airflow/pull/3733#issuecomment-412071257
 
 
   maybe make sense add use_query_cache=False for check operators


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services