[jira] [Commented] (AIRFLOW-2513) Change `bql` to `sql` for BigQuery Hooks & Operators for consistency
[ https://issues.apache.org/jira/browse/AIRFLOW-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601526#comment-16601526 ] Apache Spark commented on AIRFLOW-2513: --- User 'kaxil' has created a pull request for this issue: https://github.com/apache/incubator-airflow/pull/3454 > Change `bql` to `sql` for BigQuery Hooks & Operators for consistency > > > Key: AIRFLOW-2513 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2513 > Project: Apache Airflow > Issue Type: Task >Affects Versions: 1.9.0, 1.8.2 >Reporter: Kaxil Naik >Assignee: Kaxil Naik >Priority: Major > Fix For: 2.0.0 > > > After discussing this yesterday with Google data engineers I can confirm that > there is nothing called *bql* as used as parameter to pass SQL queries by > some of the BigQuery operators (*BigQueryCheckOperator* for example uses > *sql* and *BigQueryOperator* uses *bql* ) and hooks while some of the other > Bigquery operators and Hooks have *sql* instead. It makes more sense to stick > with *sql* instead of *bql*. > However as most of the previous stable versions used it, we should first show > a deprecation warning for a stable release or we can change this in *Airflow > 2.0* and mention it in the release doc that regarding the change of parameter > name. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2513) Change `bql` to `sql` for BigQuery Hooks & Operators for consistency
[ https://issues.apache.org/jira/browse/AIRFLOW-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499920#comment-16499920 ] ASF subversion and git services commented on AIRFLOW-2513: -- Commit b220fe60d5302546d85ee15cf6c8eaa5859316d3 in incubator-airflow's branch refs/heads/master from [~kaxilnaik] [ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=b220fe6 ] [AIRFLOW-2513] Change `bql` to `sql` for BigQuery Hooks & Ops - Change `bql` to `sql` for BigQuery Hooks & Operators for consistency Closes #3454 from kaxil/consistent-bq-lang > Change `bql` to `sql` for BigQuery Hooks & Operators for consistency > > > Key: AIRFLOW-2513 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2513 > Project: Apache Airflow > Issue Type: Task >Affects Versions: 1.9.0, 1.8.2 >Reporter: Kaxil Naik >Assignee: Kaxil Naik >Priority: Major > Fix For: 2.0.0 > > > After discussing this yesterday with Google data engineers I can confirm that > there is nothing called *bql* as used as parameter to pass SQL queries by > some of the BigQuery operators (*BigQueryCheckOperator* for example uses > *sql* and *BigQueryOperator* uses *bql* ) and hooks while some of the other > Bigquery operators and Hooks have *sql* instead. It makes more sense to stick > with *sql* instead of *bql*. > However as most of the previous stable versions used it, we should first show > a deprecation warning for a stable release or we can change this in *Airflow > 2.0* and mention it in the release doc that regarding the change of parameter > name. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2513) Change `bql` to `sql` for BigQuery Hooks & Operators for consistency
[ https://issues.apache.org/jira/browse/AIRFLOW-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494011#comment-16494011 ] Tim Swast commented on AIRFLOW-2513: Thanks! The *bql* parameter bugged me, too. As I understand it, the contrib packages have no guarantees for changes, so I think changing it and adding note to release notes makes sense. > Change `bql` to `sql` for BigQuery Hooks & Operators for consistency > > > Key: AIRFLOW-2513 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2513 > Project: Apache Airflow > Issue Type: Task >Affects Versions: 1.9.0, 1.8.2 >Reporter: Kaxil Naik >Assignee: Kaxil Naik >Priority: Major > Fix For: 2.0.0 > > > After discussing this yesterday with Google data engineers I can confirm that > there is nothing called *bql* as used as parameter to pass SQL queries by > some of the BigQuery operators (*BigQueryCheckOperator* for example uses > *sql* and *BigQueryOperator* uses *bql* ) and hooks while some of the other > Bigquery operators and Hooks have *sql* instead. It makes more sense to stick > with *sql* instead of *bql*. > However as most of the previous stable versions used it, we should first show > a deprecation warning for a stable release or we can change this in *Airflow > 2.0* and mention it in the release doc that regarding the change of parameter > name. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2513) Change `bql` to `sql` for BigQuery Hooks & Operators for consistency
[ https://issues.apache.org/jira/browse/AIRFLOW-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487434#comment-16487434 ] Feng Lu commented on AIRFLOW-2513: -- +1 for deprecating bql, thanks Kaxil! > Change `bql` to `sql` for BigQuery Hooks & Operators for consistency > > > Key: AIRFLOW-2513 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2513 > Project: Apache Airflow > Issue Type: Task >Affects Versions: 1.9.0, 1.8.2 >Reporter: Kaxil Naik >Assignee: Kaxil Naik >Priority: Major > Fix For: 2.0.0 > > > After discussing this yesterday with Google data engineers I can confirm that > there is nothing called *bql* as used as parameter to pass SQL queries by > some of the BigQuery operators (*BigQueryCheckOperator* for example uses > *sql* and *BigQueryOperator* uses *bql* ) and hooks while some of the other > Bigquery operators and Hooks have *sql* instead. It makes more sense to stick > with *sql* instead of *bql*. > However as most of the previous stable versions used it, we should first show > a deprecation warning for a stable release or we can change this in *Airflow > 2.0* and mention it in the release doc that regarding the change of parameter > name. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AIRFLOW-2513) Change `bql` to `sql` for BigQuery Hooks & Operators for consistency
[ https://issues.apache.org/jira/browse/AIRFLOW-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487003#comment-16487003 ] Kaxil Naik commented on AIRFLOW-2513: - I would like to get thoughts on whether we should deprecate the *bql* parameter after a stable release i.e. show a warning in *Airflow 2.0* and then remove it in *Airflow 2.1* or should we just change it in *Airflow 2.0* and provide instruction on changing it in release log or migration docs. [~Fokko] [~fenglu] [~joygao] > Change `bql` to `sql` for BigQuery Hooks & Operators for consistency > > > Key: AIRFLOW-2513 > URL: https://issues.apache.org/jira/browse/AIRFLOW-2513 > Project: Apache Airflow > Issue Type: Task >Affects Versions: 1.9.0, 1.8.2 >Reporter: Kaxil Naik >Assignee: Kaxil Naik >Priority: Major > Fix For: 2.0.0 > > > After discussing this yesterday with Google data engineers I can confirm that > there is nothing called *bql* as used as parameter to pass SQL queries by > some of the BigQuery operators and hooks while some of the other Bigquery > operators and Hooks have *sql* instead. It makes more sense to stick with > *sql* instead of *bql*. > However as most of the previous stable versions used it, we should first show > a deprecation warning for a stable release or we can change this in *Airflow > 2.0* and mention it in the release doc that regarding the change of parameter > name. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
