[GitHub] beam pull request #2809: BEAM-1773 Consider allowing Source#validate() to th...

2017-05-25 Thread tedyu
Github user tedyu closed the pull request at:

https://github.com/apache/beam/pull/2809


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] beam pull request #2809: BEAM-1773 Consider allowing Source#validate() to th...

2017-05-01 Thread tedyu
GitHub user tedyu opened a pull request:

https://github.com/apache/beam/pull/2809

BEAM-1773 Consider allowing Source#validate() to throw exception

See if this approach looks good.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/beam master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2809


commit e9e50e5af3934b7590df0e7c1571153d56ee9031
Author: tedyu <yuzhih...@gmail.com>
Date:   2017-05-01T22:21:07Z

BEAM-1773 Consider allowing Source#validate() to throw exception




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] beam pull request #2332: BEAM-1760 Potential null dereference in HDFSFileSin...

2017-04-03 Thread tedyu
Github user tedyu closed the pull request at:

https://github.com/apache/beam/pull/2332


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] beam pull request #2332: BEAM-1760 Potential null dereference in HDFSFileSin...

2017-03-26 Thread tedyu
GitHub user tedyu opened a pull request:

https://github.com/apache/beam/pull/2332

BEAM-1760 Potential null dereference in HDFSFileSink#doFinalize

Check whether s.getPath().getParent() is null.
If it is null, break out of the loop.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/beam master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2332.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2332


commit 6a36f605e6ba36559ebc71b9551c7fa2308fe906
Author: tedyu <yuzhih...@gmail.com>
Date:   2017-03-27T00:49:47Z

BEAM-1760 Potential null dereference in HDFSFileSink#doFinalize




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] beam pull request #2227: BEAM-1568 neffective null check in IsmFormat#struct...

2017-03-11 Thread tedyu
GitHub user tedyu opened a pull request:

https://github.com/apache/beam/pull/2227

BEAM-1568 neffective null check in IsmFormat#structuralValue

Add check for record at the beginning of the method.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/beam master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2227.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2227


commit 2326794e59a824dbb72f552034a1c18fae7d11dc
Author: tedyu <yuzhih...@gmail.com>
Date:   2017-03-12T03:59:19Z

BEAM-1568 neffective null check in IsmFormat#structuralValue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] beam pull request #2121: BEAM-1567 hashStream should be closed in PackageUti...

2017-02-27 Thread tedyu
GitHub user tedyu opened a pull request:

https://github.com/apache/beam/pull/2121

BEAM-1567 hashStream should be closed in 
PackageUtil#createPackageAttributes()

Here is related code:
```
  OutputStream hashStream = Funnels.asOutputStream(hasher);
```
hashStream should be closed upon return from the method

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/beam master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2121






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---