[GitHub] beam pull request #2507: [BEAM-1799] JdbcIOIT now uses writeThenRead style

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/2507


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2507: [BEAM-1799] JdbcIOIT now uses writeThenRead style

[ssisk]

GitHub user ssisk opened a pull request:

https://github.com/apache/beam/pull/2507

[BEAM-1799] JdbcIOIT now uses writeThenRead style

Removes JdbcTestDataSet's main, since it is no longer necessary for
loading data.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [X] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [X] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [X] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf).

---
I've now switched JdbcIOIT to do a write then a read. This code:
* creates a table during test class setup (this runs on the client)
* during the write test, generates data and populates data into that table
* reads the data from the table and verifies it via HashingFn + count

I really like the data generation - feels very clean, and I love the fact 
that using CountingSource means this part can be parallelized for larger data 
sets. I suspect that we may choose to refactor the "generate data" portion out 
into a helper method alongside HashingFn in io-common.

R @dhalperi 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssisk/beam jdbc-it-writeThenRead

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2507.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2507


commit 26fb99021b1edd48f6660b95a106ecd9116c6f16
Author: Stephen Sisk 
Date:   2017-04-04T22:46:19Z

JdbcIOIT now uses writeThenRead style

Removes JdbcTestDataSet's main, since it is no longer necessary for
loading data.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---