[jira] [Comment Edited] (BEAM-1650) Add code style xml to the project repo and website
[ https://issues.apache.org/jira/browse/BEAM-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903560#comment-15903560 ] Aviem Zur edited comment on BEAM-1650 at 3/10/17 5:30 AM: -- Changed to use Eclipse code formatter profile xml. These can be generated from checkstyle xml using Eclipse and they work in both Eclipse and IntelliJ. We might be able to leverage https://github.com/revelc/formatter-maven-plugin to format a test class before checkstyle runs so if the formatting does not match checkstyle it will fail. was (Author: aviemzur): Changed to use Eclipse code formatter profile xml, it works in both Eclipse and IntelliJ. We might be able to leverage https://github.com/revelc/formatter-maven-plugin to format a test class before checkstyle runs so if the formatting does not match checkstyle it will fail. > Add code style xml to the project repo and website > --- > > Key: BEAM-1650 > URL: https://issues.apache.org/jira/browse/BEAM-1650 > Project: Beam > Issue Type: New Feature > Components: website >Reporter: Aviem Zur >Assignee: Aviem Zur > > Contributors who develop using IntelliJ IDEa or Eclipse could benefit from > having an Eclipse code formatter xml which matches the checkstyle > enforcements of Beam. > Add such a code style xml to the repository and link to it from the website > under the IDE setup sections: > https://beam.apache.org/contribute/contribution-guide/#intellij > https://beam.apache.org/contribute/contribution-guide/#eclipse -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (BEAM-1650) Add code style xml to the project repo and website
[ https://issues.apache.org/jira/browse/BEAM-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903560#comment-15903560 ] Aviem Zur edited comment on BEAM-1650 at 3/10/17 5:28 AM: -- Changed to use Eclipse code formatter profile xml, it works in both Eclipse and IntelliJ. We might be able to leverage https://github.com/revelc/formatter-maven-plugin to format a test class before checkstyle runs so if the formatting does not match checkstyle it will fail. was (Author: aviemzur): We might be able to leverage https://github.com/revelc/formatter-maven-plugin (If we change to Eclipse code style xml, which could be a good idea since it would work in both Eclipse and IntelliJ) or https://confluence.jetbrains.com/display/IDEADEV/Command-Line+Source+Code+Formatter We can use one of these to format a test class before checkstyle runs so if the formatting does not match checkstyle it will fail. > Add code style xml to the project repo and website > --- > > Key: BEAM-1650 > URL: https://issues.apache.org/jira/browse/BEAM-1650 > Project: Beam > Issue Type: New Feature > Components: website >Reporter: Aviem Zur >Assignee: Aviem Zur > > Contributors who develop using IntelliJ IDEa or Eclipse could benefit from > having an Eclipse code formatter xml which matches the checkstyle > enforcements of Beam. > Add such a code style xml to the repository and link to it from the website > under the IDE setup sections: > https://beam.apache.org/contribute/contribution-guide/#intellij > https://beam.apache.org/contribute/contribution-guide/#eclipse -- This message was sent by Atlassian JIRA (v6.3.15#6346)
