[jira] [Comment Edited] (BEAM-2358) "/test-your-pipeline" example code results in an exception

2017-05-24 Thread Nicholas Ursa (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023187#comment-16023187
 ] 

Nicholas Ursa edited comment on BEAM-2358 at 5/24/17 4:36 PM:
--

@Rule only works on methods and fields, so this means you wouldn't be able to 
create a pipeline in a local variable, which seems overly restrictive.

{code}
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.FIELD, ElementType.METHOD})
public @interface Rule {

}
{code}

The change in code came out of this ticket: 
https://issues.apache.org/jira/browse/BEAM-1205



was (Author: nicku33):
@Rule only works on methods and fields, so this means you wouldn't be able to 
create a pipeline in a method, which seems overly restrictive.

{code}
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.FIELD, ElementType.METHOD})
public @interface Rule {

}
{code}

The change in code came out of this ticket: 
https://issues.apache.org/jira/browse/BEAM-1205


> "/test-your-pipeline" example code results in an exception
> --
>
> Key: BEAM-2358
> URL: https://issues.apache.org/jira/browse/BEAM-2358
> Project: Beam
>  Issue Type: Bug
>  Components: website
>Reporter: Nicholas Ursa
>Assignee: Davor Bonaci
>  Labels: documentation, easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> https://beam.apache.org/documentation/pipelines/test-your-pipeline/ has
> {code}
>  public void testCountWords() throws Exception {
>   Pipeline p = TestPipeline.create();
> {code}
> but this results in 
> {code}
> Exception in thread "main" java.lang.IllegalStateException: Is your 
> TestPipeline declaration missing a @Rule annotation? Usage: @Rule public 
> final transient TestPipeline pipeline = TestPipeline.Create();
>   at 
> org.apache.beam.sdk.repackaged.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
>   at org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:299)
>   at BasicPipelineTest.run(BasicPipelineTest.java:42)
>   at Main.main(Main.java:25)
> {code}
> In the [github 
> example|https://github.com/apache/beam/blob/master/examples/java8/src/test/java/org/apache/beam/examples/MinimalWordCountJava8Test.java#L56]
>  it's written as:
> {code}
> public TestPipeline p = 
> TestPipeline.create().enableAbandonedNodeEnforcement(false);
> {code}
> I'm using 2.0.0 from the maven repo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Comment Edited] (BEAM-2358) "/test-your-pipeline" example code results in an exception

2017-05-24 Thread Luke Cwik (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023132#comment-16023132
 ] 

Luke Cwik edited comment on BEAM-2358 at 5/24/17 3:58 PM:
--

It seems as though docs should be telling people to being using TestPipeline as 
a JUnit @Rule as described in the exception.


was (Author: lcwik):
It seems as though docs should be telling people to being using TestPipeline as 
a JUnit @Rule as described int he exception.

> "/test-your-pipeline" example code results in an exception
> --
>
> Key: BEAM-2358
> URL: https://issues.apache.org/jira/browse/BEAM-2358
> Project: Beam
>  Issue Type: Bug
>  Components: website
>Reporter: Nicholas Ursa
>Assignee: Davor Bonaci
>  Labels: documentation, easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> https://beam.apache.org/documentation/pipelines/test-your-pipeline/ has
> {code}
>  public void testCountWords() throws Exception {
>   Pipeline p = TestPipeline.create();
> {code}
> but this results in 
> {{monospaced}}
> Exception in thread "main" java.lang.IllegalStateException: Is your 
> TestPipeline declaration missing a @Rule annotation? Usage: @Rule public 
> final transient TestPipeline pipeline = TestPipeline.Create();
>   at 
> org.apache.beam.sdk.repackaged.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
>   at org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:299)
>   at BasicPipelineTest.run(BasicPipelineTest.java:42)
>   at Main.main(Main.java:25)
> {{monospaced}}
> In the [github 
> example|https://github.com/apache/beam/blob/master/examples/java8/src/test/java/org/apache/beam/examples/MinimalWordCountJava8Test.java#L56]
>  it's written as:
> {code}
> public TestPipeline p = 
> TestPipeline.create().enableAbandonedNodeEnforcement(false);
> {code}
> I'm using 2.0.0 from the maven repo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)