[jira] [Commented] (BEAM-1425) Window should comply with PTransform style guide

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951432#comment-15951432
 ] 

ASF GitHub Bot commented on BEAM-1425:
--

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/2362


> Window should comply with PTransform style guide
> 
>
> Key: BEAM-1425
> URL: https://issues.apache.org/jira/browse/BEAM-1425
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Eugene Kirpichov
>  Labels: backward-incompatible, starter
> Fix For: First stable release
>
>
> Suggested changes:
> - Remove static builder-like methods such as triggering(), 
> discardingFiredPanes() - the only static entry point should be .into().
> - (optional) use AutoValue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1425) Window should comply with PTransform style guide

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15947823#comment-15947823
 ] 

ASF GitHub Bot commented on BEAM-1425:
--

GitHub user jkff opened a pull request:

https://github.com/apache/beam/pull/2362

[BEAM-1425] Window should comply with PTransform style guide

Incompatible changes:

- Window.Bound class is now simply Window: matters for users that were 
extracting the transform into a variable.
- Static methods such as Window.triggering(), Window.withAllowedLateness() 
etc. are now available via Window.configure() - e.g. 
Window.configure().withAllowedLateness(...). The method Window.into() 
is left intact as it is the primary entry point for windowing a collection, 
whereas the other methods are for adjusting the parameters of the windowing 
function.

R: @tgroh 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jkff/incubator-beam window-style

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/2362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2362


commit 100b65f5b5203e664386192bc390c34a51a8005b
Author: Eugene Kirpichov 
Date:   2017-03-29T00:59:11Z

Removes unused name parameter

commit f981f40e9f7ec48663dfa692bf44ca680cf2528d
Author: Eugene Kirpichov 
Date:   2017-03-29T01:04:37Z

Fixes a few warnings in Window

commit 9a0fa6617d929ff626bb292232327f79597d241d
Author: Eugene Kirpichov 
Date:   2017-03-29T01:14:30Z

Uses AutoValue in Window

commit 9de5bb2fde66fc0738aec770fcfc1846fcd2be95
Author: Eugene Kirpichov 
Date:   2017-03-29T19:58:20Z

Replaced static Window.blah() methods with Window.configure().blah() except 
Window.into()

commit 0ec3afc5530df0e5d1f7bbba4093ef16be8e3657
Author: Eugene Kirpichov 
Date:   2017-03-29T20:09:49Z

Replaces Window.Bound with simply Window




> Window should comply with PTransform style guide
> 
>
> Key: BEAM-1425
> URL: https://issues.apache.org/jira/browse/BEAM-1425
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Eugene Kirpichov
>  Labels: backward-incompatible, starter
> Fix For: First stable release
>
>
> Suggested changes:
> - Remove static builder-like methods such as triggering(), 
> discardingFiredPanes() - the only static entry point should be .into().
> - (optional) use AutoValue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1425) Window should comply with PTransform style guide

[Kenneth Knowles (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903698#comment-15903698
 ] 

Kenneth Knowles commented on BEAM-1425:
---

This is WAI, in fact. You can window without touching the {{WindowFn}}.

> Window should comply with PTransform style guide
> 
>
> Key: BEAM-1425
> URL: https://issues.apache.org/jira/browse/BEAM-1425
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Eugene Kirpichov
>Assignee: Davor Bonaci
>  Labels: backward-incompatible
>
> Suggested changes:
> - Remove static builder-like methods such as triggering(), 
> discardingFiredPanes() - the only static entry point should be .into().
> - (optional) use AutoValue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-1425) Window should comply with PTransform style guide

[Kenneth Knowles (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903701#comment-15903701
 ] 

Kenneth Knowles commented on BEAM-1425:
---

But we should still get rid of {{Bound}} and likely use autovalue.

> Window should comply with PTransform style guide
> 
>
> Key: BEAM-1425
> URL: https://issues.apache.org/jira/browse/BEAM-1425
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-core
>Reporter: Eugene Kirpichov
>Assignee: Davor Bonaci
>  Labels: backward-incompatible
>
> Suggested changes:
> - Remove static builder-like methods such as triggering(), 
> discardingFiredPanes() - the only static entry point should be .into().
> - (optional) use AutoValue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)