[jira] [Commented] (BEAM-2378) extend join-library to support FULL OUTER JOIN

2017-06-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035046#comment-16035046
 ] 

ASF GitHub Bot commented on BEAM-2378:
--

Github user asfgit closed the pull request at:

https://github.com/apache/beam/pull/3267


> extend join-library to support FULL OUTER JOIN
> --
>
> Key: BEAM-2378
> URL: https://issues.apache.org/jira/browse/BEAM-2378
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: James Xu
>Assignee: James Xu
>
> Currently INNER, LEFT OUTER, RIGHT OUTER are supported, would be nice to 
> support FULL OUTER JOIN.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-2378) extend join-library to support FULL OUTER JOIN

2017-05-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030517#comment-16030517
 ] 

ASF GitHub Bot commented on BEAM-2378:
--

GitHub user xumingming opened a pull request:

https://github.com/apache/beam/pull/3267

[BEAM-2378] support FULL OUTER JOIN

@davorbonaci can you take a look at this please?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xumingming/beam BEAM-2378-full-outer-join

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/beam/pull/3267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3267


commit 86555d68b86f7b62cea8523e1a97aa99b677d7eb
Author: James Xu 
Date:   2017-05-31T02:28:55Z

[BEAM-2378] support FULL OUTER JOIN




> extend join-library to support FULL OUTER JOIN
> --
>
> Key: BEAM-2378
> URL: https://issues.apache.org/jira/browse/BEAM-2378
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: James Xu
>Assignee: James Xu
>
> Currently INNER, LEFT OUTER, RIGHT OUTER are supported, would be nice to 
> support FULL OUTER JOIN.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-2378) extend join-library to support FULL OUTER JOIN

2017-05-30 Thread Davor Bonaci (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029540#comment-16029540
 ] 

Davor Bonaci commented on BEAM-2378:


SGTM; please proceed as you see fit.

> extend join-library to support FULL OUTER JOIN
> --
>
> Key: BEAM-2378
> URL: https://issues.apache.org/jira/browse/BEAM-2378
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: James Xu
>
> Currently INNER, LEFT OUTER, RIGHT OUTER are supported, would be nice to 
> support FULL OUTER JOIN.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (BEAM-2378) extend join-library to support FULL OUTER JOIN

2017-05-29 Thread James Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028432#comment-16028432
 ] 

James Xu commented on BEAM-2378:


[~davor] if it is a reasonable, I will submit a PR for it.

> extend join-library to support FULL OUTER JOIN
> --
>
> Key: BEAM-2378
> URL: https://issues.apache.org/jira/browse/BEAM-2378
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-extensions
>Reporter: James Xu
>
> Currently INNER, LEFT OUTER, RIGHT OUTER are supported, would be nice to 
> support FULL OUTER JOIN.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)