[jira] [Commented] (BEAM-3519) GCP IO exposes netty on its API surface, causing conflicts with runners

2018-09-04 Thread Chamikara Jayalath (JIRA)


[ 
https://issues.apache.org/jira/browse/BEAM-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603172#comment-16603172
 ] 

Chamikara Jayalath commented on BEAM-3519:
--

Netty/gRPC/protobuf dependencies of Beam (including google-cloud-platform) were 
upgraded recently. So I suspect this is not an issue anymore. [~iemejia] can 
you confirm ?

> GCP IO exposes netty on its API surface, causing conflicts with runners
> ---
>
> Key: BEAM-3519
> URL: https://issues.apache.org/jira/browse/BEAM-3519
> Project: Beam
>  Issue Type: Bug
>  Components: io-java-gcp
>Reporter: Ismaël Mejía
>Assignee: Chamikara Jayalath
>Priority: Critical
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> Google Cloud Platform IOs module leaks netty this causes conflicts in 
> particular with execution systems that use conflicting versions of such 
> modules. 
>  For the case there is a dependency conflict with the Spark Runner version of 
> netty, see: BEAM-3492



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3519) GCP IO exposes netty on its API surface, causing conflicts with runners

2018-02-09 Thread JIRA

[ 
https://issues.apache.org/jira/browse/BEAM-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358132#comment-16358132
 ] 

Ismaël Mejía commented on BEAM-3519:


The explicit issue probably existed before (GCPIO leaking netty), but it was 
not detected because the previous version of the Spark runner (based on Spark 
1.x) used a version of netty that didn't complain.
In any case shading correctly GCPIO would be great to avoid this issue in the 
future in other runners too.

> GCP IO exposes netty on its API surface, causing conflicts with runners
> ---
>
> Key: BEAM-3519
> URL: https://issues.apache.org/jira/browse/BEAM-3519
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-gcp
>Reporter: Ismaël Mejía
>Assignee: Chamikara Jayalath
>Priority: Blocker
> Fix For: 2.3.0
>
>
> Google Cloud Platform IOs module leaks netty this causes conflicts in 
> particular with execution systems that use conflicting versions of such 
> modules. 
>  For the case there is a dependency conflict with the Spark Runner version of 
> netty, see: BEAM-3492



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3519) GCP IO exposes netty on its API surface, causing conflicts with runners

2018-02-08 Thread Chamikara Jayalath (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357782#comment-16357782
 ] 

Chamikara Jayalath commented on BEAM-3519:
--

Were previous releases affected by this issue as well or was there a recent 
change to the dependency structure that caused/exacerbated this ?

> GCP IO exposes netty on its API surface, causing conflicts with runners
> ---
>
> Key: BEAM-3519
> URL: https://issues.apache.org/jira/browse/BEAM-3519
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-gcp
>Reporter: Ismaël Mejía
>Assignee: Chamikara Jayalath
>Priority: Blocker
> Fix For: 2.3.0
>
>
> Google Cloud Platform IOs module leaks netty this causes conflicts in 
> particular with execution systems that use conflicting versions of such 
> modules. 
>  For the case there is a dependency conflict with the Spark Runner version of 
> netty, see: BEAM-3492



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3519) GCP IO exposes netty on its API surface, causing conflicts with runners

2018-02-08 Thread Luke Cwik (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357764#comment-16357764
 ] 

Luke Cwik commented on BEAM-3519:
-

Speaking with the gRPC folks, it seems like we should attempt to migrate to 
using [https://mvnrepository.com/artifact/io.grpc/grpc-netty-shaded/1.9.0]

This would require updating all GCP clients dependent on gRPC to this version.

 

Updating the gRPC/protobuf version will likely cause user pain unless we can 
shade them away completely as well.

> GCP IO exposes netty on its API surface, causing conflicts with runners
> ---
>
> Key: BEAM-3519
> URL: https://issues.apache.org/jira/browse/BEAM-3519
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-gcp
>Reporter: Ismaël Mejía
>Assignee: Chamikara Jayalath
>Priority: Blocker
> Fix For: 2.3.0
>
>
> Google Cloud Platform IOs module leaks netty this causes conflicts in 
> particular with execution systems that use conflicting versions of such 
> modules. 
>  For the case there is a dependency conflict with the Spark Runner version of 
> netty, see: BEAM-3492



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3519) GCP IO exposes netty on its API surface, causing conflicts with runners

2018-02-08 Thread Chamikara Jayalath (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357759#comment-16357759
 ] 

Chamikara Jayalath commented on BEAM-3519:
--

Possibly. Does this only have to be fixed for Maven build or do we have to look 
at Gradle as well ?

Also, can the release proceed with the fixe to 
https://issues.apache.org/jira/browse/BEAM-3668 ?

> GCP IO exposes netty on its API surface, causing conflicts with runners
> ---
>
> Key: BEAM-3519
> URL: https://issues.apache.org/jira/browse/BEAM-3519
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-gcp
>Reporter: Ismaël Mejía
>Assignee: Chamikara Jayalath
>Priority: Blocker
> Fix For: 2.3.0
>
>
> Google Cloud Platform IOs module leaks netty this causes conflicts in 
> particular with execution systems that use conflicting versions of such 
> modules. 
>  For the case there is a dependency conflict with the Spark Runner version of 
> netty, see: BEAM-3492



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (BEAM-3519) GCP IO exposes netty on its API surface, causing conflicts with runners

2018-02-08 Thread Kenneth Knowles (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357708#comment-16357708
 ] 

Kenneth Knowles commented on BEAM-3519:
---

Can it be shaded?

> GCP IO exposes netty on its API surface, causing conflicts with runners
> ---
>
> Key: BEAM-3519
> URL: https://issues.apache.org/jira/browse/BEAM-3519
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-gcp
>Reporter: Ismaël Mejía
>Priority: Critical
>
> Google Cloud Platform IOs module leaks netty this causes conflicts in 
> particular with execution systems that use conflicting versions of such 
> modules. 
>  For the case there is a dependency conflict with the Spark Runner version of 
> netty, see: BEAM-3492



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)