[jira] [Commented] (BEAM-4057) Ensure generated pom don't break consumers
[ https://issues.apache.org/jira/browse/BEAM-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546940#comment-16546940 ] Luke Cwik commented on BEAM-4057: - I believe this can be closed as release 2.5.0 has been released using Gradle. > Ensure generated pom don't break consumers > -- > > Key: BEAM-4057 > URL: https://issues.apache.org/jira/browse/BEAM-4057 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Romain Manni-Bucau >Priority: Major > > Out of my head here are the requirements: > 1. dependencies are all here (all scopes and well scoped: this means that > provided or test dependencies are not in compile scope for instance) > 2. META-INF should contain the pom.xml and pom.properties as maven generates > them (it is consumes by tools and libraries to grab the dependencies or scan > some classpath/lib folder) > 3. ensure the compiler plugin at least is defined with the java > version+compiler flags (a usage is to check if -parameters is activated for > instance) > 4. (nice to have) dont put all the boilerplate in all poms (license, etc) but > keep it in the parent pom as it was > 5. (if possible) respect the hierarchy (parents) - this is used sometimes as > a shortcut for dependencies analyzis cause it is faster than analyzing the > dependencies, probably not the best practise ever but it is efficient in > general > 6. ensure meta used by mainstream tools like mvnrepository are here > (description etc, should be a passthrough from gradle) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-4057) Ensure generated pom don't break consumers
[ https://issues.apache.org/jira/browse/BEAM-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484307#comment-16484307 ] Luke Cwik commented on BEAM-4057: - BEAM-4060 is now closed covering item #2. > Ensure generated pom don't break consumers > -- > > Key: BEAM-4057 > URL: https://issues.apache.org/jira/browse/BEAM-4057 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Romain Manni-Bucau >Priority: Major > > Out of my head here are the requirements: > 1. dependencies are all here (all scopes and well scoped: this means that > provided or test dependencies are not in compile scope for instance) > 2. META-INF should contain the pom.xml and pom.properties as maven generates > them (it is consumes by tools and libraries to grab the dependencies or scan > some classpath/lib folder) > 3. ensure the compiler plugin at least is defined with the java > version+compiler flags (a usage is to check if -parameters is activated for > instance) > 4. (nice to have) dont put all the boilerplate in all poms (license, etc) but > keep it in the parent pom as it was > 5. (if possible) respect the hierarchy (parents) - this is used sometimes as > a shortcut for dependencies analyzis cause it is faster than analyzing the > dependencies, probably not the best practise ever but it is efficient in > general > 6. ensure meta used by mainstream tools like mvnrepository are here > (description etc, should be a passthrough from gradle) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-4057) Ensure generated pom don't break consumers
[ https://issues.apache.org/jira/browse/BEAM-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460591#comment-16460591 ] Romain Manni-Bucau commented on BEAM-4057: -- Nothing ready but checking from nexus it seems the meta are still missing in the produced jar at least so 2 is clearly not done. 5 seems not done too which breaks some toolings as mentionned on the list by a user. I didn't check other points but all but 4 are quite critical for all the world outside beam core devs IMHO. > Ensure generated pom don't break consumers > -- > > Key: BEAM-4057 > URL: https://issues.apache.org/jira/browse/BEAM-4057 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Romain Manni-Bucau >Priority: Major > > Out of my head here are the requirements: > 1. dependencies are all here (all scopes and well scoped: this means that > provided or test dependencies are not in compile scope for instance) > 2. META-INF should contain the pom.xml and pom.properties as maven generates > them (it is consumes by tools and libraries to grab the dependencies or scan > some classpath/lib folder) > 3. ensure the compiler plugin at least is defined with the java > version+compiler flags (a usage is to check if -parameters is activated for > instance) > 4. (nice to have) dont put all the boilerplate in all poms (license, etc) but > keep it in the parent pom as it was > 5. (if possible) respect the hierarchy (parents) - this is used sometimes as > a shortcut for dependencies analyzis cause it is faster than analyzing the > dependencies, probably not the best practise ever but it is efficient in > general > 6. ensure meta used by mainstream tools like mvnrepository are here > (description etc, should be a passthrough from gradle) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-4057) Ensure generated pom don't break consumers
[ https://issues.apache.org/jira/browse/BEAM-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459977#comment-16459977 ] Scott Wegner commented on BEAM-4057: It seems like high-order item here is "Ensure Gradle can produce a valid release". Let's keep this open until we've validated the 2.5.0 release. [~kenn] / [~romain.manni-bucau], do we have a standard release validation set? For 2.3.0 I see [https://s.apache.org/beam-2.3.0-release-validation|https://s.apache.org/beam-2.3.0-release-validation.] If there are additional items to validate, let's propose they are added to the standard release validation so we ensure we uphold them for every release. > Ensure generated pom don't break consumers > -- > > Key: BEAM-4057 > URL: https://issues.apache.org/jira/browse/BEAM-4057 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Romain Manni-Bucau >Priority: Major > > Out of my head here are the requirements: > 1. dependencies are all here (all scopes and well scoped: this means that > provided or test dependencies are not in compile scope for instance) > 2. META-INF should contain the pom.xml and pom.properties as maven generates > them (it is consumes by tools and libraries to grab the dependencies or scan > some classpath/lib folder) > 3. ensure the compiler plugin at least is defined with the java > version+compiler flags (a usage is to check if -parameters is activated for > instance) > 4. (nice to have) dont put all the boilerplate in all poms (license, etc) but > keep it in the parent pom as it was > 5. (if possible) respect the hierarchy (parents) - this is used sometimes as > a shortcut for dependencies analyzis cause it is faster than analyzing the > dependencies, probably not the best practise ever but it is efficient in > general > 6. ensure meta used by mainstream tools like mvnrepository are here > (description etc, should be a passthrough from gradle) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-4057) Ensure generated pom don't break consumers
[ https://issues.apache.org/jira/browse/BEAM-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459887#comment-16459887 ] Kenneth Knowles commented on BEAM-4057: --- Are there known issues here? Let's make them specific and break out a JIRA for each one so they can be treated. If we don't have known issues, let's obsolete this. > Ensure generated pom don't break consumers > -- > > Key: BEAM-4057 > URL: https://issues.apache.org/jira/browse/BEAM-4057 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Romain Manni-Bucau >Priority: Major > > Out of my head here are the requirements: > 1. dependencies are all here (all scopes and well scoped: this means that > provided or test dependencies are not in compile scope for instance) > 2. META-INF should contain the pom.xml and pom.properties as maven generates > them (it is consumes by tools and libraries to grab the dependencies or scan > some classpath/lib folder) > 3. ensure the compiler plugin at least is defined with the java > version+compiler flags (a usage is to check if -parameters is activated for > instance) > 4. (nice to have) dont put all the boilerplate in all poms (license, etc) but > keep it in the parent pom as it was > 5. (if possible) respect the hierarchy (parents) - this is used sometimes as > a shortcut for dependencies analyzis cause it is faster than analyzing the > dependencies, probably not the best practise ever but it is efficient in > general > 6. ensure meta used by mainstream tools like mvnrepository are here > (description etc, should be a passthrough from gradle) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-4057) Ensure generated pom don't break consumers
[ https://issues.apache.org/jira/browse/BEAM-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441569#comment-16441569 ] Scott Wegner commented on BEAM-4057: I haven't had any trouble using IntelliJ with the pom files as-is. And there is another Jira [BEAM-3462|https://issues.apache.org/jira/browse/BEAM-3462] which proposes dropping parent poms. Let's have the debate there. In either case, I don't think this is a migration blocker. > Ensure generated pom don't break consumers > -- > > Key: BEAM-4057 > URL: https://issues.apache.org/jira/browse/BEAM-4057 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Romain Manni-Bucau >Assignee: Luke Cwik >Priority: Major > > Out of my head here are the requirements: > 1. dependencies are all here (all scopes and well scoped: this means that > provided or test dependencies are not in compile scope for instance) > 2. META-INF should contain the pom.xml and pom.properties as maven generates > them (it is consumes by tools and libraries to grab the dependencies or scan > some classpath/lib folder) > 3. ensure the compiler plugin at least is defined with the java > version+compiler flags (a usage is to check if -parameters is activated for > instance) > 4. (nice to have) dont put all the boilerplate in all poms (license, etc) but > keep it in the parent pom as it was > 5. (if possible) respect the hierarchy (parents) - this is used sometimes as > a shortcut for dependencies analyzis cause it is faster than analyzing the > dependencies, probably not the best practise ever but it is efficient in > general > 6. ensure meta used by mainstream tools like mvnrepository are here > (description etc, should be a passthrough from gradle) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-4057) Ensure generated pom don't break consumers
[ https://issues.apache.org/jira/browse/BEAM-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436178#comment-16436178 ] Romain Manni-Bucau commented on BEAM-4057: -- [~kenn] all tools allows native browsing (check idea) and it is common to browse a project like that to grab dep cause like 60 times faster for some cases so it is done by users you like it or not (note i didnt say i like it ;)). > Ensure generated pom don't break consumers > -- > > Key: BEAM-4057 > URL: https://issues.apache.org/jira/browse/BEAM-4057 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Romain Manni-Bucau >Assignee: Luke Cwik >Priority: Major > > Out of my head here are the requirements: > 1. dependencies are all here (all scopes and well scoped: this means that > provided or test dependencies are not in compile scope for instance) > 2. META-INF should contain the pom.xml and pom.properties as maven generates > them (it is consumes by tools and libraries to grab the dependencies or scan > some classpath/lib folder) > 3. ensure the compiler plugin at least is defined with the java > version+compiler flags (a usage is to check if -parameters is activated for > instance) > 4. (nice to have) dont put all the boilerplate in all poms (license, etc) but > keep it in the parent pom as it was > 5. (if possible) respect the hierarchy (parents) - this is used sometimes as > a shortcut for dependencies analyzis cause it is faster than analyzing the > dependencies, probably not the best practise ever but it is efficient in > general > 6. ensure meta used by mainstream tools like mvnrepository are here > (description etc, should be a passthrough from gradle) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-4057) Ensure generated pom don't break consumers
[ https://issues.apache.org/jira/browse/BEAM-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435932#comment-16435932 ] Kenneth Knowles commented on BEAM-4057: --- I'm a -1 on 4 and 5. Since it is machine readable it doesn't matter about the hierarchy. And when I go and browse a pom online and find it has a parent pointer that just creates extra work for someone trying to figure out what is going on. > Ensure generated pom don't break consumers > -- > > Key: BEAM-4057 > URL: https://issues.apache.org/jira/browse/BEAM-4057 > Project: Beam > Issue Type: Sub-task > Components: build-system >Reporter: Romain Manni-Bucau >Assignee: Luke Cwik >Priority: Major > > Out of my head here are the requirements: > 1. dependencies are all here (all scopes and well scoped: this means that > provided or test dependencies are not in compile scope for instance) > 2. META-INF should contain the pom.xml and pom.properties as maven generates > them (it is consumes by tools and libraries to grab the dependencies or scan > some classpath/lib folder) > 3. ensure the compiler plugin at least is defined with the java > version+compiler flags (a usage is to check if -parameters is activated for > instance) > 4. (nice to have) dont put all the boilerplate in all poms (license, etc) but > keep it in the parent pom as it was > 5. (if possible) respect the hierarchy (parents) - this is used sometimes as > a shortcut for dependencies analyzis cause it is faster than analyzing the > dependencies, probably not the best practise ever but it is efficient in > general > 6. ensure meta used by mainstream tools like mvnrepository are here > (description etc, should be a passthrough from gradle) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
