[jira] [Updated] (BEAM-3761) Fix Python 3 cmp function

2018-02-27 Thread holdenk (JIRA)

 [ 
https://issues.apache.org/jira/browse/BEAM-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

holdenk updated BEAM-3761:
--
Description: 
Various functions don't exist in Python 3 that did in python 2. This Jira is to 
fix the use of cmp (which often will involve rewriting __cmp__ as well).

 

Note: there are existing PRs for basestring and unicode ( 
[https://github.com/apache/beam/pull/4697|https://github.com/apache/beam/pull/4697,]
 , [https://github.com/apache/beam/pull/4730] )

 

Note once all of the missing names/functions are fixed we can enable F821 in 
falke8 python 3.

  was:
Various functions don't exist in Python 3 that did in python 2. This Jira is to 
fix the use of cmp (which often will involve rewriting __cmp__ as well).

 

Note: there are existing PRs for basestring and unicode ( 
[https://github.com/apache/beam/pull/4697|https://github.com/apache/beam/pull/4697,]
 , [https://github.com/apache/beam/pull/4730] )


> Fix Python 3 cmp function
> -
>
> Key: BEAM-3761
> URL: https://issues.apache.org/jira/browse/BEAM-3761
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: holdenk
>Assignee: Ahmet Altay
>Priority: Major
>
> Various functions don't exist in Python 3 that did in python 2. This Jira is 
> to fix the use of cmp (which often will involve rewriting __cmp__ as well).
>  
> Note: there are existing PRs for basestring and unicode ( 
> [https://github.com/apache/beam/pull/4697|https://github.com/apache/beam/pull/4697,]
>  , [https://github.com/apache/beam/pull/4730] )
>  
> Note once all of the missing names/functions are fixed we can enable F821 in 
> falke8 python 3.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (BEAM-3761) Fix Python 3 cmp function

2018-02-27 Thread holdenk (JIRA)

 [ 
https://issues.apache.org/jira/browse/BEAM-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

holdenk updated BEAM-3761:
--
Summary: Fix Python 3 cmp function  (was: Fix Python 3 missing functions)

> Fix Python 3 cmp function
> -
>
> Key: BEAM-3761
> URL: https://issues.apache.org/jira/browse/BEAM-3761
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: holdenk
>Assignee: Ahmet Altay
>Priority: Major
>
> cmp & file is no longer defined in Python 3. We can catch regressions of this 
> using flake8 f821 (although this catches some additional things as well)
>  
> Note: there are existing PRs for basestring and unicode ( 
> [https://github.com/apache/beam/pull/4697|https://github.com/apache/beam/pull/4697,]
>  , [https://github.com/apache/beam/pull/4730] )



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (BEAM-3761) Fix Python 3 cmp function

2018-02-27 Thread holdenk (JIRA)

 [ 
https://issues.apache.org/jira/browse/BEAM-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

holdenk updated BEAM-3761:
--
Description: 
Various functions don't exist in Python 3 that did in python 2. This Jira is to 
fix the use of cmp (which often will involve rewriting __cmp__ as well).

 

Note: there are existing PRs for basestring and unicode ( 
[https://github.com/apache/beam/pull/4697|https://github.com/apache/beam/pull/4697,]
 , [https://github.com/apache/beam/pull/4730] )

  was:
cmp & file is no longer defined in Python 3. We can catch regressions of this 
using flake8 f821 (although this catches some additional things as well)

 

Note: there are existing PRs for basestring and unicode ( 
[https://github.com/apache/beam/pull/4697|https://github.com/apache/beam/pull/4697,]
 , [https://github.com/apache/beam/pull/4730] )


> Fix Python 3 cmp function
> -
>
> Key: BEAM-3761
> URL: https://issues.apache.org/jira/browse/BEAM-3761
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-py-core
>Reporter: holdenk
>Assignee: Ahmet Altay
>Priority: Major
>
> Various functions don't exist in Python 3 that did in python 2. This Jira is 
> to fix the use of cmp (which often will involve rewriting __cmp__ as well).
>  
> Note: there are existing PRs for basestring and unicode ( 
> [https://github.com/apache/beam/pull/4697|https://github.com/apache/beam/pull/4697,]
>  , [https://github.com/apache/beam/pull/4730] )



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)