[jira] [Work logged] (BEAM-1081) annotations should support custom messages and classes
[ https://issues.apache.org/jira/browse/BEAM-1081?focusedWorklogId=154060&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154060 ] ASF GitHub Bot logged work on BEAM-1081: Author: ASF GitHub Bot Created on: 12/Oct/18 23:36 Start Date: 12/Oct/18 23:36 Worklog Time Spent: 10m Work Description: aaltay commented on issue #6670: [BEAM-1081] Annotations custom message support and classes tests. URL: https://github.com/apache/beam/pull/6670#issuecomment-429489882 @jglezt it looks like there are test issues, could you look at those? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 154060) Time Spent: 50m (was: 40m) > annotations should support custom messages and classes > -- > > Key: BEAM-1081 > URL: https://issues.apache.org/jira/browse/BEAM-1081 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ahmet Altay >Priority: Minor > Labels: newbie, starter > Time Spent: 50m > Remaining Estimate: 0h > > Update > https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/utils/annotations.py > to add 2 new features: > 1. ability to customize message > 2. ability to tag classes (not only functions) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1081) annotations should support custom messages and classes
[ https://issues.apache.org/jira/browse/BEAM-1081?focusedWorklogId=154009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154009 ] ASF GitHub Bot logged work on BEAM-1081: Author: ASF GitHub Bot Created on: 12/Oct/18 20:17 Start Date: 12/Oct/18 20:17 Worklog Time Spent: 10m Work Description: jglezt commented on issue #6670: [BEAM-1081] Annotations custom message support and classes tests. URL: https://github.com/apache/beam/pull/6670#issuecomment-429450311 Hi Pablo! I resolved the merge problems. Waiting for the Jenkins build. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 154009) Time Spent: 40m (was: 0.5h) > annotations should support custom messages and classes > -- > > Key: BEAM-1081 > URL: https://issues.apache.org/jira/browse/BEAM-1081 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ahmet Altay >Priority: Minor > Labels: newbie, starter > Time Spent: 40m > Remaining Estimate: 0h > > Update > https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/utils/annotations.py > to add 2 new features: > 1. ability to customize message > 2. ability to tag classes (not only functions) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1081) annotations should support custom messages and classes
[ https://issues.apache.org/jira/browse/BEAM-1081?focusedWorklogId=153967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153967 ] ASF GitHub Bot logged work on BEAM-1081: Author: ASF GitHub Bot Created on: 12/Oct/18 17:59 Start Date: 12/Oct/18 17:59 Worklog Time Spent: 10m Work Description: pabloem commented on a change in pull request #6670: [BEAM-1081] Annotations custom message support and classes tests. URL: https://github.com/apache/beam/pull/6670#discussion_r224868863 ## File path: sdks/python/apache_beam/utils/annotations_test.py ## @@ -78,6 +131,29 @@ def fnc_test_deprecated_without_since_should_fail(): fnc_test_deprecated_without_since_should_fail() assert not w +<<< HEAD + def test_deprecated_without_since_custom_should_fail(self): +with warnings.catch_warnings(record=True) as w: + with self.assertRaises(TypeError): +@deprecated(custom_message='Test %since%') +def fnc_test_deprecated_without_since_custom_should_fail(): + return 'lol' +fnc_test_deprecated_without_since_custom_should_fail() +=== + def test_deprecated_without_since_should_fail_class(self): +with warnings.catch_warnings(record=True) as w: + with self.assertRaises(TypeError): + +@deprecated() +class Class_test_deprecated_without_since_should_fail(): + fooo = 'lol' + def foo(self): +return 'lol' +foo = Class_test_deprecated_without_since_should_fail() +foo.foo() +>>> ae3ee47cf9e131cf66644532022178d559d9237d Review comment: merge trouble This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 153967) Time Spent: 20m (was: 10m) > annotations should support custom messages and classes > -- > > Key: BEAM-1081 > URL: https://issues.apache.org/jira/browse/BEAM-1081 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ahmet Altay >Priority: Minor > Labels: newbie, starter > Time Spent: 20m > Remaining Estimate: 0h > > Update > https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/utils/annotations.py > to add 2 new features: > 1. ability to customize message > 2. ability to tag classes (not only functions) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1081) annotations should support custom messages and classes
[ https://issues.apache.org/jira/browse/BEAM-1081?focusedWorklogId=153968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153968 ] ASF GitHub Bot logged work on BEAM-1081: Author: ASF GitHub Bot Created on: 12/Oct/18 17:59 Start Date: 12/Oct/18 17:59 Worklog Time Spent: 10m Work Description: pabloem commented on a change in pull request #6670: [BEAM-1081] Annotations custom message support and classes tests. URL: https://github.com/apache/beam/pull/6670#discussion_r224868835 ## File path: sdks/python/apache_beam/utils/annotations_test.py ## @@ -78,6 +131,29 @@ def fnc_test_deprecated_without_since_should_fail(): fnc_test_deprecated_without_since_should_fail() assert not w +<<< HEAD Review comment: it seems that there was some trouble merging here This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 153968) Time Spent: 20m (was: 10m) > annotations should support custom messages and classes > -- > > Key: BEAM-1081 > URL: https://issues.apache.org/jira/browse/BEAM-1081 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ahmet Altay >Priority: Minor > Labels: newbie, starter > Time Spent: 20m > Remaining Estimate: 0h > > Update > https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/utils/annotations.py > to add 2 new features: > 1. ability to customize message > 2. ability to tag classes (not only functions) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1081) annotations should support custom messages and classes
[ https://issues.apache.org/jira/browse/BEAM-1081?focusedWorklogId=153969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153969 ] ASF GitHub Bot logged work on BEAM-1081: Author: ASF GitHub Bot Created on: 12/Oct/18 17:59 Start Date: 12/Oct/18 17:59 Worklog Time Spent: 10m Work Description: pabloem commented on a change in pull request #6670: [BEAM-1081] Annotations custom message support and classes tests. URL: https://github.com/apache/beam/pull/6670#discussion_r224868893 ## File path: sdks/python/apache_beam/utils/annotations_test.py ## @@ -78,6 +131,29 @@ def fnc_test_deprecated_without_since_should_fail(): fnc_test_deprecated_without_since_should_fail() assert not w +<<< HEAD + def test_deprecated_without_since_custom_should_fail(self): +with warnings.catch_warnings(record=True) as w: + with self.assertRaises(TypeError): +@deprecated(custom_message='Test %since%') +def fnc_test_deprecated_without_since_custom_should_fail(): + return 'lol' +fnc_test_deprecated_without_since_custom_should_fail() +=== Review comment: merge trouble This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 153969) Time Spent: 0.5h (was: 20m) > annotations should support custom messages and classes > -- > > Key: BEAM-1081 > URL: https://issues.apache.org/jira/browse/BEAM-1081 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Ahmet Altay >Priority: Minor > Labels: newbie, starter > Time Spent: 0.5h > Remaining Estimate: 0h > > Update > https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/utils/annotations.py > to add 2 new features: > 1. ability to customize message > 2. ability to tag classes (not only functions) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1081) annotations should support custom messages and classes
[ https://issues.apache.org/jira/browse/BEAM-1081?focusedWorklogId=153750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153750 ] ASF GitHub Bot logged work on BEAM-1081: Author: ASF GitHub Bot Created on: 12/Oct/18 01:00 Start Date: 12/Oct/18 01:00 Worklog Time Spent: 10m Work Description: jglezt opened a new pull request #6670: [BEAM-1081] Annotations custom message support and classes tests. URL: https://github.com/apache/beam/pull/6670 Added support for custom messages using the arg "custom_message". The annotation decorator already supports tagging classes, I only added a few tests to check it out. Follow this checklist to help us incorporate your contribution quickly and easily: - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 153750) Time Spent: 10m Remaining Estimate: 0h > annotations should support custom messages and classes > -- > > Key: BEAM-1081 > URL: https://issues.apache.org/jira/br
