[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105781=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105781
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 24/May/18 23:33
Start Date: 24/May/18 23:33
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #5443: [BEAM-4357] Fix
SQL shadow jar
URL: https://github.com/apache/beam/pull/5443
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build_rules.gradle b/build_rules.gradle
index 0132c062c56..465d5283b71 100644
--- a/build_rules.gradle
+++ b/build_rules.gradle
@@ -564,6 +564,11 @@ ext.applyJavaNature = {
classifier = "shaded-tests"
from sourceSets.test.output
configurations = [project.configurations.testRuntime]
+
+exclude "META-INF/INDEX.LIST"
+exclude "META-INF/*.SF"
+exclude "META-INF/*.DSA"
+exclude "META-INF/*.RSA"
} << configuration.shadowClosure)
// Ensure that shaded jar and test-jar are part of the their own
configuration artifact sets
diff --git a/sdks/java/extensions/sql/build.gradle
b/sdks/java/extensions/sql/build.gradle
index 1f9005cfa1f..51d2f78c7ea 100644
--- a/sdks/java/extensions/sql/build.gradle
+++ b/sdks/java/extensions/sql/build.gradle
@@ -19,7 +19,25 @@ import groovy.json.JsonOutput
*/
apply from: project(":").file("build_rules.gradle")
-applyJavaNature(enableSpotless: true)
+applyJavaNature(enableSpotless: true, shadowClosure: DEFAULT_SHADOW_CLOSURE <<
{
+ dependencies {
+include(dependency(library.java.protobuf_java))
+include(dependency(library.java.protobuf_java_util))
+include(dependency("org.apache.calcite:.*"))
+include(dependency("org.apache.calcite.avatica:.*"))
+include(dependency("org.codehaus.janino:.*"))
+ }
+ relocate "com.google.protobuf", getJavaRelocatedPath("com.google.protobuf")
+ relocate "org.apache.calcite", getJavaRelocatedPath("org.apache.calcite")
+
+ // Looking up the compiler factory in Calcite depends on having a properties
+ // file in the right location. We package one that is shading compatible
+ // in src/main/resources. Note that if this shaded path changes, that
+ // files name and contents need to be updated as well. TODO, swap to use
+ // getJavaRelocatedPath once the Maven build is no longer also shading this
+ // module.
+ relocate "org.codehaus",
"org.apache.beam.sdks.java.extensions.sql.repackaged.org.codehaus"
+})
apply plugin: 'ca.coglinc.javacc'
description = "Apache Beam :: SDKs :: Java :: Extensions :: SQL"
@@ -31,6 +49,9 @@ configurations {
// TODO: Migrate to a FMPP plugin once one exists
fmppTask
fmppTemplates
+
+ // Run tests from shaded jar
+ shadowTestRuntimeClasspath
}
def calcite_version = "1.16.0"
@@ -45,23 +66,31 @@ dependencies {
compile "org.apache.calcite:calcite-core:$calcite_version"
compile "org.apache.calcite:calcite-linq4j:$calcite_version"
compile "org.apache.calcite.avatica:avatica-core:$avatica_version"
- compile "com.alibaba:fastjson:1.2.12"
compileOnly library.java.findbugs_jsr305
compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow project(path: ":beam-sdks-java-extensions-join-library",
configuration: "shadow")
shadow library.java.slf4j_api
shadow library.java.commons_csv
+ shadow library.java.commons_lang3
+ shadow library.java.jackson_databind
shadow library.java.joda_time
+ shadow "com.alibaba:fastjson:1.2.12"
shadow project(path: ":beam-runners-direct-java", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-kafka", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-google-cloud-platform",
configuration: "shadow")
provided library.java.kafka_clients
- testCompile library.java.slf4j_jdk14
- testCompile library.java.junit
- testCompile library.java.hamcrest_core
- testCompile library.java.mockito_core
- testCompile library.java.quickcheck_core
+ shadowTest library.java.slf4j_jdk14
+ shadowTest library.java.junit
+ shadowTest library.java.hamcrest_core
+ shadowTest library.java.mockito_core
+ shadowTest library.java.quickcheck_core
+ shadowTestRuntimeClasspath project(path: project.path, configuration:
"shadowTest")
+ shadowTestRuntimeClasspath project(path: project.path, configuration:
"provided")
+}
+
+test {
+ classpath = configurations.shadowTestRuntimeClasspath
}
// Copy Caclcite templates and our own template into the build directory
@@ -103,26 +132,6 @@ compileJavacc {
arguments = [grammar_encoding: "UTF-8", static: "false", lookahead: "2"]
}
-shadowJar {
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105730=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105730
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 24/May/18 21:28
Start Date: 24/May/18 21:28
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5443: [BEAM-4357] Fix SQL
shadow jar
URL: https://github.com/apache/beam/pull/5443#issuecomment-391868814
run java precommit
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105730)
Time Spent: 3.5h (was: 3h 20m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105729=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105729
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 24/May/18 21:27
Start Date: 24/May/18 21:27
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5443: [BEAM-4357] Fix SQL
shadow jar
URL: https://github.com/apache/beam/pull/5443#issuecomment-391868772
Now we get
`org.apache.beam.sdk.io.elasticsearch.ElasticsearchIOTest.testWriteWithIndexFn`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105729)
Time Spent: 3h 20m (was: 3h 10m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105712=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105712
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 24/May/18 20:25
Start Date: 24/May/18 20:25
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5443: [BEAM-4357] Fix
SQL shadow jar
URL: https://github.com/apache/beam/pull/5443#issuecomment-391847856
Noting that only JmsIO failed with an actual numeric mismatch in the
assertion and this should have no affect on that. But I'll rerun.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105712)
Time Spent: 3h (was: 2h 50m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105713=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105713
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 24/May/18 20:25
Start Date: 24/May/18 20:25
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5443: [BEAM-4357] Fix
SQL shadow jar
URL: https://github.com/apache/beam/pull/5443#issuecomment-391847891
run java precommit
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105713)
Time Spent: 3h 10m (was: 3h)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105647=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105647
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 24/May/18 16:39
Start Date: 24/May/18 16:39
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5443: [BEAM-4357] Fix SQL
shadow jar
URL: https://github.com/apache/beam/pull/5443#issuecomment-391781192
Dropping the scope of this PR to fix SQL.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105647)
Time Spent: 2h 50m (was: 2h 40m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105325=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105325
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 23/May/18 21:21
Start Date: 23/May/18 21:21
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5443: [BEAM-4357] Fix
shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#issuecomment-391500639
This PR makes the tests run against the shadow jar. I've been validating
them with some variant of this: `./gradlew :beam-sdks-java-extensions-sql:test`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105325)
Time Spent: 2h 40m (was: 2.5h)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105317=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105317
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 23/May/18 20:45
Start Date: 23/May/18 20:45
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5443:
[BEAM-4357] Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#discussion_r190393045
##
File path: build_rules.gradle
##
@@ -332,6 +328,12 @@ ext.DEFAULT_SHADOW_CLOSURE = {
exclude "com.google.common.util.concurrent.testing.**"
}
}
+ext.DEFAULT_SHADOW_CLOSURE = ext.RELOCATE_SHADOW_CLOSURE << {
+ dependencies {
+exclude(".*")
Review comment:
Try to merge the fixes the Boyuan is working through for the
sdks/java/harness
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105317)
Time Spent: 2.5h (was: 2h 20m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105311=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105311
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 23/May/18 20:25
Start Date: 23/May/18 20:25
Worklog Time Spent: 10m
Work Description: boyuanzz commented on issue #5443: [BEAM-4357] Fix
shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#issuecomment-391484737
Hey @apilloud , could you please explain how you run the build cmd to test
these gradle changes?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105311)
Time Spent: 2h 20m (was: 2h 10m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105177=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105177
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 23/May/18 16:59
Start Date: 23/May/18 16:59
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5443:
[BEAM-4357] Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#discussion_r190325242
##
File path: sdks/java/extensions/sql/build.gradle
##
@@ -45,23 +48,27 @@ dependencies {
compile "org.apache.calcite:calcite-core:$calcite_version"
compile "org.apache.calcite:calcite-linq4j:$calcite_version"
compile "org.apache.calcite.avatica:avatica-core:$avatica_version"
- compile "com.alibaba:fastjson:1.2.12"
compileOnly library.java.findbugs_jsr305
compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow project(path: ":beam-sdks-java-extensions-join-library",
configuration: "shadow")
shadow library.java.slf4j_api
+ shadow library.java.slf4j_jdk14
shadow library.java.commons_csv
+ shadow library.java.commons_lang3
+ shadow library.java.jackson_databind
shadow library.java.joda_time
+ shadow "com.alibaba:fastjson:1.2.12"
shadow project(path: ":beam-runners-direct-java", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-kafka", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-google-cloud-platform",
configuration: "shadow")
provided library.java.kafka_clients
- testCompile library.java.slf4j_jdk14
testCompile library.java.junit
testCompile library.java.hamcrest_core
testCompile library.java.mockito_core
testCompile library.java.quickcheck_core
+ shadowJarTest project(path: project.path, configuration: "shadow")
Review comment:
Is producing the `shadowJar/shadowTestJar` a dependency of the `test` task?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105177)
Time Spent: 2h 10m (was: 2h)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105176=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105176
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 23/May/18 16:55
Start Date: 23/May/18 16:55
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5443: [BEAM-4357] Fix
shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#issuecomment-39142
Pushed a new version, sql passes 100%. Lots of other things fail. Does this
look reasonable? How do we get this in? Do we need to hide this behind a flag
like we did with warnings as errors?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105176)
Time Spent: 2h (was: 1h 50m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=105162=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-105162
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 23/May/18 16:04
Start Date: 23/May/18 16:04
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #5443:
[BEAM-4357] [SQL] Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#discussion_r190307353
##
File path: sdks/java/extensions/sql/build.gradle
##
@@ -45,23 +48,27 @@ dependencies {
compile "org.apache.calcite:calcite-core:$calcite_version"
compile "org.apache.calcite:calcite-linq4j:$calcite_version"
compile "org.apache.calcite.avatica:avatica-core:$avatica_version"
- compile "com.alibaba:fastjson:1.2.12"
compileOnly library.java.findbugs_jsr305
compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow project(path: ":beam-sdks-java-extensions-join-library",
configuration: "shadow")
shadow library.java.slf4j_api
+ shadow library.java.slf4j_jdk14
shadow library.java.commons_csv
+ shadow library.java.commons_lang3
+ shadow library.java.jackson_databind
shadow library.java.joda_time
+ shadow "com.alibaba:fastjson:1.2.12"
shadow project(path: ":beam-runners-direct-java", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-kafka", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-google-cloud-platform",
configuration: "shadow")
provided library.java.kafka_clients
- testCompile library.java.slf4j_jdk14
testCompile library.java.junit
testCompile library.java.hamcrest_core
testCompile library.java.mockito_core
testCompile library.java.quickcheck_core
+ shadowJarTest project(path: project.path, configuration: "shadow")
Review comment:
Just setting the classpath to `configurations.shadowTest` didn't work,
because it didn't include the output jar. This works, but a good number of
tests fail everywhere due to dependency issues. They are all probably real
issues.
```
configurations {
validate
}
dependencies {
validate project(path: project.path, configuration: "shadowTest")
}
test {
classpath = configurations.validate
}
```
cc: @boyuanzz Who might be working on the same issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 105162)
Time Spent: 1h 50m (was: 1h 40m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=104794=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104794
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 22/May/18 21:25
Start Date: 22/May/18 21:25
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5443: [BEAM-4357] [SQL] Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#discussion_r190058260
##
File path: sdks/java/extensions/sql/build.gradle
##
@@ -45,23 +48,27 @@ dependencies {
compile "org.apache.calcite:calcite-core:$calcite_version"
compile "org.apache.calcite:calcite-linq4j:$calcite_version"
compile "org.apache.calcite.avatica:avatica-core:$avatica_version"
- compile "com.alibaba:fastjson:1.2.12"
compileOnly library.java.findbugs_jsr305
compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow project(path: ":beam-sdks-java-extensions-join-library",
configuration: "shadow")
shadow library.java.slf4j_api
+ shadow library.java.slf4j_jdk14
shadow library.java.commons_csv
+ shadow library.java.commons_lang3
+ shadow library.java.jackson_databind
shadow library.java.joda_time
+ shadow "com.alibaba:fastjson:1.2.12"
shadow project(path: ":beam-runners-direct-java", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-kafka", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-google-cloud-platform",
configuration: "shadow")
provided library.java.kafka_clients
- testCompile library.java.slf4j_jdk14
testCompile library.java.junit
testCompile library.java.hamcrest_core
testCompile library.java.mockito_core
testCompile library.java.quickcheck_core
+ shadowJarTest project(path: project.path, configuration: "shadow")
Review comment:
Yea, I think we should do that. I saw that as one of the big correctness
benefits of Gradle.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104794)
Time Spent: 1h 40m (was: 1.5h)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=104793=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104793
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 22/May/18 21:24
Start Date: 22/May/18 21:24
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5443:
[BEAM-4357] [SQL] Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#discussion_r190057717
##
File path: sdks/java/extensions/sql/build.gradle
##
@@ -45,23 +48,27 @@ dependencies {
compile "org.apache.calcite:calcite-core:$calcite_version"
compile "org.apache.calcite:calcite-linq4j:$calcite_version"
compile "org.apache.calcite.avatica:avatica-core:$avatica_version"
- compile "com.alibaba:fastjson:1.2.12"
compileOnly library.java.findbugs_jsr305
compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow project(path: ":beam-sdks-java-extensions-join-library",
configuration: "shadow")
shadow library.java.slf4j_api
+ shadow library.java.slf4j_jdk14
shadow library.java.commons_csv
+ shadow library.java.commons_lang3
+ shadow library.java.jackson_databind
shadow library.java.joda_time
+ shadow "com.alibaba:fastjson:1.2.12"
shadow project(path: ":beam-runners-direct-java", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-kafka", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-google-cloud-platform",
configuration: "shadow")
provided library.java.kafka_clients
- testCompile library.java.slf4j_jdk14
testCompile library.java.junit
testCompile library.java.hamcrest_core
testCompile library.java.mockito_core
testCompile library.java.quickcheck_core
+ shadowJarTest project(path: project.path, configuration: "shadow")
Review comment:
The tests run against the classes which aren't shaded (same as Maven before)
since the default is `project.sourceSets.test.runtimeClasspath` as per [Gradle
Test
documentation](https://docs.gradle.org/current/dsl/org.gradle.api.tasks.testing.Test.html#org.gradle.api.tasks.testing.Test:classpath).
Only the dependencies are correctly pulled in as shaded jars (an improvement
over Maven).
It might be better to attempt to run all unit tests using the shadowTest
configuration by specifying `classpath = configurations.shadowTest` on the
`test { }` closure in `build_rules.gradle`
The test wouldn't need to become an `IT` then.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104793)
Time Spent: 1.5h (was: 1h 20m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=104792=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104792
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 22/May/18 21:24
Start Date: 22/May/18 21:24
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5443:
[BEAM-4357] [SQL] Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#discussion_r190057717
##
File path: sdks/java/extensions/sql/build.gradle
##
@@ -45,23 +48,27 @@ dependencies {
compile "org.apache.calcite:calcite-core:$calcite_version"
compile "org.apache.calcite:calcite-linq4j:$calcite_version"
compile "org.apache.calcite.avatica:avatica-core:$avatica_version"
- compile "com.alibaba:fastjson:1.2.12"
compileOnly library.java.findbugs_jsr305
compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow project(path: ":beam-sdks-java-extensions-join-library",
configuration: "shadow")
shadow library.java.slf4j_api
+ shadow library.java.slf4j_jdk14
shadow library.java.commons_csv
+ shadow library.java.commons_lang3
+ shadow library.java.jackson_databind
shadow library.java.joda_time
+ shadow "com.alibaba:fastjson:1.2.12"
shadow project(path: ":beam-runners-direct-java", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-kafka", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-google-cloud-platform",
configuration: "shadow")
provided library.java.kafka_clients
- testCompile library.java.slf4j_jdk14
testCompile library.java.junit
testCompile library.java.hamcrest_core
testCompile library.java.mockito_core
testCompile library.java.quickcheck_core
+ shadowJarTest project(path: project.path, configuration: "shadow")
Review comment:
The tests run against the classes which aren't shaded (same as Maven before)
since the default is `project.sourceSets.test.runtimeClasspath` as per [Gradle
Test
documentation](https://docs.gradle.org/current/dsl/org.gradle.api.tasks.testing.Test.html#org.gradle.api.tasks.testing.Test:classpath).
Only the dependencies are correctly pulled in as shaded jars (an improvement
over Maven).
It might be better to attempt to run all unit tests using the shadowTest
configuration by specifying `classpath = configurations.shadowTest` on the
`test { }` closure in `build_rules.gradle`
The test wouldn't need to become an IT then.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104792)
Time Spent: 1h 20m (was: 1h 10m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=104738=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104738
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 22/May/18 18:24
Start Date: 22/May/18 18:24
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5443: [BEAM-4357] [SQL]
Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#issuecomment-391092627
run java precommit
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104738)
Time Spent: 1h (was: 50m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=104737=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104737
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 22/May/18 18:24
Start Date: 22/May/18 18:24
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5443: [BEAM-4357] [SQL]
Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#issuecomment-391092591
Failed on `ElasticsearchIOTest`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104737)
Time Spent: 50m (was: 40m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=104295=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104295
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 21/May/18 22:05
Start Date: 21/May/18 22:05
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5443: [BEAM-4357] [SQL]
Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#issuecomment-390797344
This LGTM and definitely needs to happen. I'm not sure the best way to
organize tests and ITs. I think the "do *Test in the precommit against the
class files and *IT in the postcommit against the final jars" is just a
holdover from Maven and we should hopefully move to a more target-based build
style, away from whole-project style.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104295)
Time Spent: 40m (was: 0.5h)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=104294=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104294
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 21/May/18 22:03
Start Date: 21/May/18 22:03
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5443: [BEAM-4357] [SQL] Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#discussion_r189726744
##
File path: sdks/java/extensions/sql/build.gradle
##
@@ -45,23 +48,27 @@ dependencies {
compile "org.apache.calcite:calcite-core:$calcite_version"
compile "org.apache.calcite:calcite-linq4j:$calcite_version"
compile "org.apache.calcite.avatica:avatica-core:$avatica_version"
- compile "com.alibaba:fastjson:1.2.12"
compileOnly library.java.findbugs_jsr305
compileOnly library.java.findbugs_annotations
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow project(path: ":beam-sdks-java-extensions-join-library",
configuration: "shadow")
shadow library.java.slf4j_api
+ shadow library.java.slf4j_jdk14
shadow library.java.commons_csv
+ shadow library.java.commons_lang3
+ shadow library.java.jackson_databind
shadow library.java.joda_time
+ shadow "com.alibaba:fastjson:1.2.12"
shadow project(path: ":beam-runners-direct-java", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-kafka", configuration: "shadow")
provided project(path: ":beam-sdks-java-io-google-cloud-platform",
configuration: "shadow")
provided library.java.kafka_clients
- testCompile library.java.slf4j_jdk14
testCompile library.java.junit
testCompile library.java.hamcrest_core
testCompile library.java.mockito_core
testCompile library.java.quickcheck_core
+ shadowJarTest project(path: project.path, configuration: "shadow")
Review comment:
A question more for @lukecwik than you: shouldn't all of our tests run
against the actual jar produced for users? Is the shadow configuration that
jar? Or is it a different one?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104294)
Time Spent: 0.5h (was: 20m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=104276=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104276
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 21/May/18 21:09
Start Date: 21/May/18 21:09
Worklog Time Spent: 10m
Work Description: apilloud commented on issue #5443: [BEAM-4357] [SQL]
Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443#issuecomment-390783803
@lukecwik @kennknowles Please take a look.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104276)
Time Spent: 20m (was: 10m)
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4357) SQL shaded jar returns NoClassDefFoundError
[
https://issues.apache.org/jira/browse/BEAM-4357?focusedWorklogId=104275=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104275
]
ASF GitHub Bot logged work on BEAM-4357:
Author: ASF GitHub Bot
Created on: 21/May/18 21:07
Start Date: 21/May/18 21:07
Worklog Time Spent: 10m
Work Description: apilloud opened a new pull request #5443: [BEAM-4357]
[SQL] Fix shadow jar and test it
URL: https://github.com/apache/beam/pull/5443
This fixes the missing dependencies and tests the shadow jar for SQL.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [X] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 104275)
Time Spent: 10m
Remaining Estimate: 0h
> SQL shaded jar returns NoClassDefFoundError
> ---
>
> Key: BEAM-4357
> URL: https://issues.apache.org/jira/browse/BEAM-4357
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
>Affects Versions: 2.5.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/fasterxml/jackson/databind/ObjectMapper
> I ran this:
> {code:java}
> java -cp
> ./sdks/java/extensions/sql/build/libs/beam-sdks-java-extensions-sql-2.5.0-SNAPSHOT-shaded.jar:$HOME/sqlline/sqlline-1.3.0.jar:$HOME/sqlline/jline-2.14.6.jar
> sqlline.SqlLine -u 'jdbc:beam:' -n admin -p admin{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
