[jira] [Work logged] (BEAM-4540) Hamcrest and JUnit are being leaked into the main path (should be test only)
[
https://issues.apache.org/jira/browse/BEAM-4540?focusedWorklogId=111552=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111552
]
ASF GitHub Bot logged work on BEAM-4540:
Author: ASF GitHub Bot
Created on: 13/Jun/18 16:26
Start Date: 13/Jun/18 16:26
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5604:
[BEAM-4540] Migrate junit/hamcrest to provided scope.
URL: https://github.com/apache/beam/pull/5604#discussion_r195151451
##
File path: sdks/java/fn-execution/build.gradle
##
@@ -37,6 +37,7 @@ dependencies {
shadow library.java.grpc_stub
shadow library.java.grpc_netty
shadow library.java.netty_transport_native_epoll
+ provided library.java.junit
Review comment:
I see. Now I understand your point.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 111552)
Time Spent: 1h 20m (was: 1h 10m)
> Hamcrest and JUnit are being leaked into the main path (should be test only)
>
>
> Key: BEAM-4540
> URL: https://issues.apache.org/jira/browse/BEAM-4540
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Luke Cwik
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The sdks/java/io/google-cloud-platform module includes Hamcrest and JUnit as
> a test dependency via shadowTest. However it seems both dependencies can be
> resolved from the the main java path (src/main/java).
> I discovered this while checking at BEAM-4539. We should probably validate
> the isolation level of shadowTest so deps don't leak to the main path
> otherwise developers will start to use them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4540) Hamcrest and JUnit are being leaked into the main path (should be test only)
[
https://issues.apache.org/jira/browse/BEAM-4540?focusedWorklogId=111540=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111540
]
ASF GitHub Bot logged work on BEAM-4540:
Author: ASF GitHub Bot
Created on: 13/Jun/18 15:51
Start Date: 13/Jun/18 15:51
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5604:
[BEAM-4540] Migrate junit/hamcrest to provided scope.
URL: https://github.com/apache/beam/pull/5604#discussion_r195138800
##
File path: sdks/java/fn-execution/build.gradle
##
@@ -37,6 +37,7 @@ dependencies {
shadow library.java.grpc_stub
shadow library.java.grpc_netty
shadow library.java.netty_transport_native_epoll
+ provided library.java.junit
Review comment:
(actually I made a mistake in the comment it was 'provided seems enough'
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 111540)
Time Spent: 1h 10m (was: 1h)
> Hamcrest and JUnit are being leaked into the main path (should be test only)
>
>
> Key: BEAM-4540
> URL: https://issues.apache.org/jira/browse/BEAM-4540
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Luke Cwik
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The sdks/java/io/google-cloud-platform module includes Hamcrest and JUnit as
> a test dependency via shadowTest. However it seems both dependencies can be
> resolved from the the main java path (src/main/java).
> I discovered this while checking at BEAM-4539. We should probably validate
> the isolation level of shadowTest so deps don't leak to the main path
> otherwise developers will start to use them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4540) Hamcrest and JUnit are being leaked into the main path (should be test only)
[
https://issues.apache.org/jira/browse/BEAM-4540?focusedWorklogId=111539=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111539
]
ASF GitHub Bot logged work on BEAM-4540:
Author: ASF GitHub Bot
Created on: 13/Jun/18 15:50
Start Date: 13/Jun/18 15:50
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5604:
[BEAM-4540] Migrate junit/hamcrest to provided scope.
URL: https://github.com/apache/beam/pull/5604#discussion_r195138541
##
File path: sdks/java/fn-execution/build.gradle
##
@@ -37,6 +37,7 @@ dependencies {
shadow library.java.grpc_stub
shadow library.java.grpc_netty
shadow library.java.netty_transport_native_epoll
+ provided library.java.junit
Review comment:
Well my point was about actually the next line where the junit dependency is
repeated but as `testCompile` which is unneeded given that it is now covered by
`provided`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 111539)
Time Spent: 1h (was: 50m)
> Hamcrest and JUnit are being leaked into the main path (should be test only)
>
>
> Key: BEAM-4540
> URL: https://issues.apache.org/jira/browse/BEAM-4540
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Luke Cwik
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The sdks/java/io/google-cloud-platform module includes Hamcrest and JUnit as
> a test dependency via shadowTest. However it seems both dependencies can be
> resolved from the the main java path (src/main/java).
> I discovered this while checking at BEAM-4539. We should probably validate
> the isolation level of shadowTest so deps don't leak to the main path
> otherwise developers will start to use them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4540) Hamcrest and JUnit are being leaked into the main path (should be test only)
[
https://issues.apache.org/jira/browse/BEAM-4540?focusedWorklogId=111534=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111534
]
ASF GitHub Bot logged work on BEAM-4540:
Author: ASF GitHub Bot
Created on: 13/Jun/18 15:37
Start Date: 13/Jun/18 15:37
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5604: [BEAM-4540] Migrate
junit/hamcrest to provided scope.
URL: https://github.com/apache/beam/pull/5604
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/core-construction-java/build.gradle
b/runners/core-construction-java/build.gradle
index f2d1a224a0c..09727d24a20 100644
--- a/runners/core-construction-java/build.gradle
+++ b/runners/core-construction-java/build.gradle
@@ -49,6 +49,7 @@ dependencies {
shadow library.java.grpc_stub
testCompileOnly library.java.findbugs_annotations
shadowTest library.java.hamcrest_core
+ shadowTest library.java.hamcrest_library
shadowTest library.java.junit
shadowTest library.java.mockito_core
shadowTest library.java.jackson_annotations
diff --git a/runners/core-java/build.gradle b/runners/core-java/build.gradle
index d3a85ce520c..850c332fc72 100644
--- a/runners/core-java/build.gradle
+++ b/runners/core-java/build.gradle
@@ -43,7 +43,9 @@ dependencies {
shadow library.java.joda_time
testCompileOnly library.java.findbugs_annotations
shadowTest project(path: ":beam-sdks-java-core", configuration: "shadowTest")
+ shadowTest library.java.junit
shadowTest library.java.hamcrest_core
+ shadowTest library.java.hamcrest_library
shadowTest library.java.mockito_core
shadowTest library.java.junit
shadowTest library.java.slf4j_api
diff --git a/runners/direct-java/build.gradle b/runners/direct-java/build.gradle
index d095ae116f6..59f8be9a383 100644
--- a/runners/direct-java/build.gradle
+++ b/runners/direct-java/build.gradle
@@ -67,9 +67,9 @@ dependencies {
shadow library.java.joda_time
shadow library.java.findbugs_jsr305
shadow library.java.slf4j_api
- shadow library.java.hamcrest_core
- shadow library.java.junit
shadow library.java.args4j
+ provided library.java.hamcrest_core
+ provided library.java.junit
testRuntime project(path: ":beam-sdks-java-harness")
shadowTest project(path: ":beam-sdks-java-core", configuration: "shadowTest")
shadowTest project(path: ":beam-runners-core-java", configuration:
"shadowTest")
diff --git a/runners/gearpump/build.gradle b/runners/gearpump/build.gradle
index 4a77c2e608c..f5ebb20d8dd 100644
--- a/runners/gearpump/build.gradle
+++ b/runners/gearpump/build.gradle
@@ -53,6 +53,7 @@ dependencies {
shadowTest project(path: ":beam-sdks-java-core", configuration: "shadowTest")
shadowTest library.java.junit
shadowTest library.java.hamcrest_core
+ shadowTest library.java.hamcrest_library
shadowTest library.java.jackson_databind
shadowTest library.java.jackson_dataformat_yaml
shadowTest library.java.mockito_core
@@ -90,4 +91,4 @@ task validatesRunner {
dependsOn validatesRunnerStreaming
}
-createJavaExamplesArchetypeValidationTask(type: 'Quickstart', runner:
'Gearpump')
\ No newline at end of file
+createJavaExamplesArchetypeValidationTask(type: 'Quickstart', runner:
'Gearpump')
diff --git a/runners/local-java/build.gradle b/runners/local-java/build.gradle
index a0bc081f40c..86d06ba3fc9 100644
--- a/runners/local-java/build.gradle
+++ b/runners/local-java/build.gradle
@@ -33,5 +33,6 @@ dependencies {
shadow library.java.findbugs_jsr305
shadow library.java.findbugs_annotations
shadowTest library.java.hamcrest_core
+ shadowTest library.java.hamcrest_library
shadowTest library.java.junit
}
diff --git a/runners/spark/build.gradle b/runners/spark/build.gradle
index acb85611700..f4afff08476 100644
--- a/runners/spark/build.gradle
+++ b/runners/spark/build.gradle
@@ -74,6 +74,7 @@ dependencies {
provided library.java.commons_lang3
provided library.java.commons_io_2x
provided library.java.hamcrest_core
+ provided library.java.hamcrest_library
provided "org.apache.zookeeper:zookeeper:3.4.11"
provided "org.scala-lang:scala-library:2.11.8"
provided "com.esotericsoftware.kryo:kryo:2.21"
diff --git a/sdks/java/core/build.gradle b/sdks/java/core/build.gradle
index ffe0de86246..51d2fe4be76 100644
--- a/sdks/java/core/build.gradle
+++ b/sdks/java/core/build.gradle
@@ -67,10 +67,10 @@ dependencies {
shadow library.java.avro
shadow library.java.snappy_java
shadow library.java.joda_time
- shadow library.java.hamcrest_core
- shadow library.java.hamcrest_library
- shadow library.java.junit
shadow "org.tukaani:xz:1.5"
+ provided library.java.junit
+
[jira] [Work logged] (BEAM-4540) Hamcrest and JUnit are being leaked into the main path (should be test only)
[
https://issues.apache.org/jira/browse/BEAM-4540?focusedWorklogId=111533=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111533
]
ASF GitHub Bot logged work on BEAM-4540:
Author: ASF GitHub Bot
Created on: 13/Jun/18 15:37
Start Date: 13/Jun/18 15:37
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5604:
[BEAM-4540] Migrate junit/hamcrest to provided scope.
URL: https://github.com/apache/beam/pull/5604#discussion_r195133249
##
File path: sdks/java/fn-execution/build.gradle
##
@@ -37,6 +37,7 @@ dependencies {
shadow library.java.grpc_stub
shadow library.java.grpc_netty
shadow library.java.netty_transport_native_epoll
+ provided library.java.junit
Review comment:
testCompile only applies to the test source set.
provided applies to the main source set, there are some test utility classes
in the main source set that rely on junit classes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 111533)
Time Spent: 40m (was: 0.5h)
> Hamcrest and JUnit are being leaked into the main path (should be test only)
>
>
> Key: BEAM-4540
> URL: https://issues.apache.org/jira/browse/BEAM-4540
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Luke Cwik
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The sdks/java/io/google-cloud-platform module includes Hamcrest and JUnit as
> a test dependency via shadowTest. However it seems both dependencies can be
> resolved from the the main java path (src/main/java).
> I discovered this while checking at BEAM-4539. We should probably validate
> the isolation level of shadowTest so deps don't leak to the main path
> otherwise developers will start to use them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4540) Hamcrest and JUnit are being leaked into the main path (should be test only)
[
https://issues.apache.org/jira/browse/BEAM-4540?focusedWorklogId=111502=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111502
]
ASF GitHub Bot logged work on BEAM-4540:
Author: ASF GitHub Bot
Created on: 13/Jun/18 14:04
Start Date: 13/Jun/18 14:04
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5604:
[BEAM-4540] Migrate junit/hamcrest to provided scope.
URL: https://github.com/apache/beam/pull/5604#discussion_r195093293
##
File path: sdks/java/fn-execution/build.gradle
##
@@ -37,6 +37,7 @@ dependencies {
shadow library.java.grpc_stub
shadow library.java.grpc_netty
shadow library.java.netty_transport_native_epoll
+ provided library.java.junit
Review comment:
Is it a mistake or what is the sense of having it provided and testCompile
too? testCompile seems enough.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 111502)
Time Spent: 0.5h (was: 20m)
> Hamcrest and JUnit are being leaked into the main path (should be test only)
>
>
> Key: BEAM-4540
> URL: https://issues.apache.org/jira/browse/BEAM-4540
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Luke Cwik
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The sdks/java/io/google-cloud-platform module includes Hamcrest and JUnit as
> a test dependency via shadowTest. However it seems both dependencies can be
> resolved from the the main java path (src/main/java).
> I discovered this while checking at BEAM-4539. We should probably validate
> the isolation level of shadowTest so deps don't leak to the main path
> otherwise developers will start to use them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4540) Hamcrest and JUnit are being leaked into the main path (should be test only)
[
https://issues.apache.org/jira/browse/BEAM-4540?focusedWorklogId=111501=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111501
]
ASF GitHub Bot logged work on BEAM-4540:
Author: ASF GitHub Bot
Created on: 13/Jun/18 14:03
Start Date: 13/Jun/18 14:03
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5604:
[BEAM-4540] Migrate junit/hamcrest to provided scope.
URL: https://github.com/apache/beam/pull/5604#discussion_r195093293
##
File path: sdks/java/fn-execution/build.gradle
##
@@ -37,6 +37,7 @@ dependencies {
shadow library.java.grpc_stub
shadow library.java.grpc_netty
shadow library.java.netty_transport_native_epoll
+ provided library.java.junit
Review comment:
Is it a mistake or what is the sense of having it provided and testCompile
too?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 111501)
Time Spent: 20m (was: 10m)
> Hamcrest and JUnit are being leaked into the main path (should be test only)
>
>
> Key: BEAM-4540
> URL: https://issues.apache.org/jira/browse/BEAM-4540
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Ismaël Mejía
>Assignee: Luke Cwik
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The sdks/java/io/google-cloud-platform module includes Hamcrest and JUnit as
> a test dependency via shadowTest. However it seems both dependencies can be
> resolved from the the main java path (src/main/java).
> I discovered this while checking at BEAM-4539. We should probably validate
> the isolation level of shadowTest so deps don't leak to the main path
> otherwise developers will start to use them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4540) Hamcrest and JUnit are being leaked into the main path (should be test only)
[ https://issues.apache.org/jira/browse/BEAM-4540?focusedWorklogId=111092=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111092 ] ASF GitHub Bot logged work on BEAM-4540: Author: ASF GitHub Bot Created on: 12/Jun/18 15:31 Start Date: 12/Jun/18 15:31 Worklog Time Spent: 10m Work Description: lukecwik opened a new pull request #5604: [BEAM-4540] Migrate junit/hamcrest to provided scope. URL: https://github.com/apache/beam/pull/5604 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 111092) Time Spent: 10m Remaining Estimate: 0h > Hamcrest and JUnit are being leaked into the main path (should be test only) > > > Key: BEAM-4540 > URL: https://issues.apache.org/jira/browse/BEAM-4540 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Ismaël Mejía >Assignee: Luke Cwik >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The sdks/java/io/google-cloud-platform module includes Hamcrest and JUnit as > a test dependency via shadowTest. However it seems both dependencies can be > resolved from the the main java path (src/main/java). > I discovered this while checking at BEAM-4539. We should probably validate > the isolation level of shadowTest so deps don't leak to the main path > otherwise developers will start to use them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
