[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=140250=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-140250 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 31/Aug/18 21:32 Start Date: 31/Aug/18 21:32 Worklog Time Spent: 10m Work Description: udim commented on issue #545: [BEAM-4790] Contribute: document how to find and add reviewers URL: https://github.com/apache/beam-site/pull/545#issuecomment-417794604 R: @melap This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 140250) Time Spent: 3h (was: 2h 50m) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=140212=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-140212 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 31/Aug/18 18:44 Start Date: 31/Aug/18 18:44 Worklog Time Spent: 10m Work Description: udim opened a new pull request #545: [BEAM-4790] Contribute: document how to find and add reviewers URL: https://github.com/apache/beam-site/pull/545 Document the new OWNERS files in apache/beam. Once your pull request has been opened and assigned a number, please edit the URL below, replacing `PULL_REQUEST_NUMBER` with the number of your pull request. http://apache-beam-website-pull-requests.storage.googleapis.com/PULL_REQUEST_NUMBER/index.html Finally, it will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 140212) Time Spent: 2h 50m (was: 2h 40m) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[
https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=135470=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135470
]
ASF GitHub Bot logged work on BEAM-4790:
Author: ASF GitHub Bot
Created on: 16/Aug/18 19:07
Start Date: 16/Aug/18 19:07
Worklog Time Spent: 10m
Work Description: charlesccychen closed pull request #6235: [BEAM-4790]
Add Prow-style OWNERS files.
URL: https://github.com/apache/beam/pull/6235
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.test-infra/OWNERS b/.test-infra/OWNERS
new file mode 100644
index 000..7d9c8cae4d7
--- /dev/null
+++ b/.test-infra/OWNERS
@@ -0,0 +1,4 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+reviewers:
+ - lgajowy
diff --git a/.test-infra/jenkins/OWNERS b/.test-infra/jenkins/OWNERS
new file mode 100644
index 000..ca45477af95
--- /dev/null
+++ b/.test-infra/jenkins/OWNERS
@@ -0,0 +1,6 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+reviewers:
+ - lgajowy
+ - kkucharc
+ - echauchot
diff --git a/.test-infra/jupyter/OWNERS b/.test-infra/jupyter/OWNERS
new file mode 100644
index 000..586139172ce
--- /dev/null
+++ b/.test-infra/jupyter/OWNERS
@@ -0,0 +1,4 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+reviewers:
+ - udim
diff --git a/.test-infra/kubernetes/OWNERS b/.test-infra/kubernetes/OWNERS
new file mode 100644
index 000..2a140107225
--- /dev/null
+++ b/.test-infra/kubernetes/OWNERS
@@ -0,0 +1,5 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+reviewers:
+ - lgajowy
+ - kkucharc
diff --git a/OWNERS b/OWNERS
new file mode 100644
index 000..6f6d2a478b2
--- /dev/null
+++ b/OWNERS
@@ -0,0 +1,22 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+filters:
+ # Per-language reviewers.
+ "\\.go$":
+reviewers:
+ - herohde
+ "\\.java$":
+reviewers:
+ - lukecwik
+ - kennknowles
+ - aaltay
+ "\\.py$":
+reviewers:
+ - pabloem
+ - robertwb
+ - aaltay
+ - charlesccychen
+
+ "build\\.gradle$":
+reviewers:
+ - lukecwik
diff --git a/assembly.xml b/assembly.xml
index 6534e3f1f5a..f523bf720ad 100644
--- a/assembly.xml
+++ b/assembly.xml
@@ -100,6 +100,9 @@
%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?pom\.xml\.releaseBackup]
%regex[(?!((?!${project.build.directory}/)[^/]+/)*src/)(.*/)?release\.properties]
+
+
+**/OWNERS
diff --git a/build.gradle b/build.gradle
index dcfadbbc414..093fcc40c4e 100644
--- a/build.gradle
+++ b/build.gradle
@@ -147,6 +147,7 @@ rat {
// Ignore ownership files
"ownership/**/*",
+"**/OWNERS",
]
// Add .gitignore excludes to the Apache Rat exclusion list. We re-create
the behavior
diff --git a/buildSrc/OWNERS b/buildSrc/OWNERS
new file mode 100644
index 000..af32c311923
--- /dev/null
+++ b/buildSrc/OWNERS
@@ -0,0 +1,4 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+reviewers:
+ - lukecwik
diff --git a/examples/OWNERS b/examples/OWNERS
new file mode 100644
index 000..3a2b3498379
--- /dev/null
+++ b/examples/OWNERS
@@ -0,0 +1,4 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+reviewers:
+ - aaltay
diff --git a/examples/java/OWNERS b/examples/java/OWNERS
new file mode 100644
index 000..38112463e09
--- /dev/null
+++ b/examples/java/OWNERS
@@ -0,0 +1,5 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+reviewers:
+ - lukecwik
+ - aaltay
diff --git a/gradle/OWNERS b/gradle/OWNERS
new file mode 100644
index 000..af32c311923
--- /dev/null
+++ b/gradle/OWNERS
@@ -0,0 +1,4 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+reviewers:
+ - lukecwik
diff --git a/model/OWNERS b/model/OWNERS
new file mode 100644
index 000..a5b32dc72cf
--- /dev/null
+++ b/model/OWNERS
@@ -0,0 +1,5 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+reviewers:
+ - herohde
+ - lukecwik
diff --git a/model/fn-execution/OWNERS b/model/fn-execution/OWNERS
new file mode 100644
index 000..23065b82b3f
--- /dev/null
+++ b/model/fn-execution/OWNERS
@@ -0,0 +1,6 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+reviewers:
+ - herohde
+ - robertwb
+ - lukecwik
diff --git a/model/job-management/OWNERS b/model/job-management/OWNERS
new file mode 100644
index 000..23065b82b3f
--- /dev/null
+++ b/model/job-management/OWNERS
@@ -0,0 +1,6 @@
+# See the OWNERS docs at https://s.apache.org/beam-owners
+
+reviewers:
+ - herohde
+ -
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=135469=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135469 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 16/Aug/18 19:07 Start Date: 16/Aug/18 19:07 Worklog Time Spent: 10m Work Description: charlesccychen commented on issue #6235: [BEAM-4790] Add Prow-style OWNERS files. URL: https://github.com/apache/beam/pull/6235#issuecomment-413652742 Thanks! This LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 135469) Time Spent: 2.5h (was: 2h 20m) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=135446=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135446 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 16/Aug/18 18:12 Start Date: 16/Aug/18 18:12 Worklog Time Spent: 10m Work Description: udim commented on issue #6235: [BEAM-4790] Add Prow-style OWNERS files. URL: https://github.com/apache/beam/pull/6235#issuecomment-413636535 @timrobertson100 done! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 135446) Time Spent: 2h 10m (was: 2h) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=135447=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135447 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 16/Aug/18 18:12 Start Date: 16/Aug/18 18:12 Worklog Time Spent: 10m Work Description: udim commented on issue #6235: [BEAM-4790] Add Prow-style OWNERS files. URL: https://github.com/apache/beam/pull/6235#issuecomment-413636640 R: @charlesccychen This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 135447) Time Spent: 2h 20m (was: 2h 10m) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=135259=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135259 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 16/Aug/18 05:42 Start Date: 16/Aug/18 05:42 Worklog Time Spent: 10m Work Description: timrobertson100 commented on issue #6235: [BEAM-4790] Add Prow-style OWNERS files. URL: https://github.com/apache/beam/pull/6235#issuecomment-413432255 Thanks @udim I can’t add to this branch. Can you please add me on the new io/kudu? Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 135259) Time Spent: 2h (was: 1h 50m) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=135193=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135193 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 15/Aug/18 23:45 Start Date: 15/Aug/18 23:45 Worklog Time Spent: 10m Work Description: udim commented on issue #6235: [BEAM-4790] Add Prow-style OWNERS files. URL: https://github.com/apache/beam/pull/6235#issuecomment-413374689 CC: @aaltay @akedin @amaliujia @angoenka @apilloud @aromanenko-dev @chamikaramj @charlesccychen @echauchot @herohde @jasonkuster @jbonofre @kennknowles @kkucharc @lgajowy @lukecwik @melap @pabloem @robertwb @swegner @timrobertson100 @udim @XuMingmin @xumingming This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 135193) Time Spent: 1h 50m (was: 1h 40m) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=135192=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135192 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 15/Aug/18 23:40 Start Date: 15/Aug/18 23:40 Worklog Time Spent: 10m Work Description: udim opened a new pull request #6235: [BEAM-4790] Add Prow-style OWNERS files. URL: https://github.com/apache/beam/pull/6235 Things to do (in another PR): - Add a short doc about these files and reviewer selection in the contribution guide. - Point https://s.apache.org/beam-owners to said doc. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 135192) Time Spent: 1h 40m (was: 1.5h) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 1h 40m >
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=126925=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-126925 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 24/Jul/18 22:11 Start Date: 24/Jul/18 22:11 Worklog Time Spent: 10m Work Description: lukecwik closed pull request #6049: [BEAM-4790] Remove CODEOWNERs. URL: https://github.com/apache/beam/pull/6049 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/CODEOWNERS b/CODEOWNERS deleted file mode 100644 index dc4b5da650e..000 --- a/CODEOWNERS +++ /dev/null @@ -1,131 +0,0 @@ -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -#http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -# This file is used for auto-assigning reviewers to PRs. -# -# The last matching rule wins. For details, see: -# https://help.github.com/articles/about-codeowners/ - -# Per-language reviewers. -*.go @herohde -*.java @lukecwik @kennknowles @aaltay -*.py @pabloem @robertwb @aaltay @charlesccychen - -# SDK components reviewers. -/sdks/go/ @herohde - -/sdks/java/ @aaltay @kennknowles -/sdks/java/core @lukecwik -#/sdks/java/extensions -/sdks/java/extensions/google-cloud-platform-core @lukecwik @chamikaramj -#/sdks/java/extensions/jackson -#/sdks/java/extensions/join-library -#/sdks/java/extensions/protobuf -#/sdks/java/extensions/sketching -#/sdks/java/extensions/sorter -/sdks/java/extensions/sql @akedin @apilloud @amaliujia @XuMingmin @xumingming @kennknowles -/sdks/java/container @herohde @aaltay -/sdks/java/fn-execution @lukecwik @angoenka -/sdks/java/nexmark @echauchot @aromanenko-dev -/sdks/java/build-tools @jasonkuster @swegner -/sdks/java/harness @lukecwik -/sdks/java/io @jbonofre @lukecwik @chamikaramj @timrobertson100 -/sdks/java/io/parquet @lgajowy @jbonofre @aromanenko-dev -/sdks/java/io/common @chamikaramj @timrobertson100 -/sdks/java/io/file-based-io-tests @lgajowy @kkucharc @chamikaramj @timrobertson100 -/sdks/java/io/elasticsearch-tests @echauchot @timrobertson100 -#/sdks/java/io/amazon-web-services -/sdks/java/io/google-cloud-platform @lukecwik @chamikaramj -/sdks/java/io/hadoop-input-format @aromanenko-dev @timrobertson100 -/sdks/java/io/solr @timrobertson100 -/sdks/java/io/kinesis @aromanenko-dev -/sdks/java/io/redis @jbonofre -/sdks/java/io/mongodb @jbonofre -/sdks/java/io/hcatalog @timrobertson100 -/sdks/java/io/elasticsearch @echauchot @jbonofre @timrobertson100 -/sdks/java/io/jdbc @jbonofre @timrobertson100 -/sdks/java/io/mqtt @jbonofre -/sdks/java/io/hadoop-file-system @timrobertson100 -/sdks/java/io/amqp @jbonofre -/sdks/java/io/cassandra @jbonofre @echauchot -#/sdks/java/io/tika -#/sdks/java/io/xml -#/sdks/java/io/kafka -/sdks/java/io/jms @jbonofre -/sdks/java/io/hbase @timrobertson100 @aromanenko-dev -/sdks/java/io/hadoop-common @timrobertson100 -#/sdks/java/maven-archetypes -/sdks/java/javadoc @melap - -/sdks/python/ @aaltay @charlesccychen -/sdks/python/scripts @aaltay -/sdks/python/container @herohde @aaltay @charlesccychen -/sdks/python/apache_beam/runners @pabloem @charlesccychen -/sdks/python/apache_beam/utils @pabloem @charlesccychen -/sdks/python/apache_beam/examples @aaltay @charlesccychen -/sdks/python/apache_beam/internal @aaltay @charlesccychen -/sdks/python/apache_beam/tools @pabloem @charlesccychen -/sdks/python/apache_beam/coders @charlesccychen -/sdks/python/apache_beam/portability @charlesccychen @robertwb @aaltay -/sdks/python/apache_beam/typehints @charlesccychen -/sdks/python/apache_beam/options @pabloem @charlesccychen -/sdks/python/apache_beam/transforms @pabloem @aaltay @charlesccychen -/sdks/python/apache_beam/testing @pabloem @aaltay -/sdks/python/apache_beam/metrics @pabloem @aaltay -/sdks/python/apache_beam/io @chamikaramj @aaltay @udim - -# Build and test infrastructure reviewers. -#/.github -/.test-infra @lgajowy -/.test-infra/jenkins @lgajowy @kkucharc @echauchot -/.test-infra/jupyter @udim -/.test-infra/kubernetes @lgajowy
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=126922=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-126922 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 24/Jul/18 22:00 Start Date: 24/Jul/18 22:00 Worklog Time Spent: 10m Work Description: udim commented on issue #6049: [BEAM-4790] Remove CODEOWNERs. URL: https://github.com/apache/beam/pull/6049#issuecomment-407566099 R: @charlesccychen This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 126922) Time Spent: 1h 20m (was: 1h 10m) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=126908=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-126908 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 24/Jul/18 21:39 Start Date: 24/Jul/18 21:39 Worklog Time Spent: 10m Work Description: udim opened a new pull request #6049: [BEAM-4790] Remove CODEOWNERs. URL: https://github.com/apache/beam/pull/6049 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 126908) Time Spent: 1h 10m (was: 1h) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: >
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[
https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=124161=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124161
]
ASF GitHub Bot logged work on BEAM-4790:
Author: ASF GitHub Bot
Created on: 17/Jul/18 18:19
Start Date: 17/Jul/18 18:19
Worklog Time Spent: 10m
Work Description: udim closed pull request #5951: [BEAM-4790] Replace
Github reviewer auto-assignment with suggest_reviewers.py script
URL: https://github.com/apache/beam/pull/5951
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/CODEOWNERS b/CODEOWNERS_
similarity index 94%
rename from CODEOWNERS
rename to CODEOWNERS_
index 3a125c5b4c4..f9efcf164c7 100644
--- a/CODEOWNERS
+++ b/CODEOWNERS_
@@ -15,10 +15,10 @@
# limitations under the License.
#
-# This file is used for auto-assigning reviewers to PRs.
-#
-# The last matching rule wins. For details, see:
-# https://help.github.com/articles/about-codeowners/
+# This file is used for suggesting reviewers for PRs.
+# The last matching rule wins.
+# See https://help.github.com/articles/about-codeowners/ for path pattern
+# examples.
# Per-language reviewers.
*.go @herohde
@@ -26,9 +26,9 @@
*.py @pabloem @robertwb @aaltay @charlesccychen
# SDK components reviewers.
-/sdks/go/ @herohde
+/sdks/go @herohde
-/sdks/java/ @aaltay @kennknowles
+/sdks/java @aaltay @kennknowles
/sdks/java/core @lukecwik
#/sdks/java/extensions
/sdks/java/extensions/google-cloud-platform-core @lukecwik @chamikaramj
@@ -71,7 +71,7 @@
#/sdks/java/maven-archetypes
/sdks/java/javadoc @melap
-/sdks/python/ @aaltay @charlesccychen
+/sdks/python @aaltay @charlesccychen
/sdks/python/scripts @aaltay
/sdks/python/container @herohde @aaltay @charlesccychen
/sdks/python/apache_beam/runners @pabloem @charlesccychen
diff --git a/suggest_reviewers.py b/suggest_reviewers.py
new file mode 100755
index 000..7272c84a573
--- /dev/null
+++ b/suggest_reviewers.py
@@ -0,0 +1,100 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from __future__ import print_function
+
+import argparse
+import collections
+import fnmatch
+import logging
+import requests
+import random
+import string
+
+CODEOWNERS_FILE = 'CODEOWNERS_'
+
+
+class Codeowners(object):
+
+ def __init__(self, codeowners_file):
+self.path_owner_map = collections.OrderedDict()
+for line in open(codeowners_file):
+ line = line.split('#', 1)[0].strip()
+ if not line:
+continue
+ path, owners = line.split(' ', 1)
+ self.path_owner_map[path] = owners.split()
+
+ def _get_reviewers_for_path(self, path):
+res = []
+for path_pattern, owners in self.path_owner_map.iteritems():
+ if '*' not in path_pattern:
+path_pattern += '*'
+if not path_pattern.startswith('/'):
+ path_pattern = '*/' + path_pattern
+ if fnmatch.fnmatch(path, path_pattern):
+res = (path_pattern, owners)
+return res
+
+ def get_reviewers(self, paths, random_seed):
+random.seed(random_seed)
+reviewers = set()
+for path in paths:
+ path_pattern, candidates = self._get_reviewers_for_path(path)
+ if not candidates:
+logging.warning('No candidate reviewers for path: %s', path)
+continue
+ selected_candidate = candidates[random.randint(0, len(candidates) - 1)]
+ logging.info('Selected reviewer %s for: %s (path_pattern: %s)',
+ selected_candidate, path, path_pattern)
+ reviewers.add(selected_candidate)
+
+return reviewers
+
+
+class PullRequest(object):
+
+ def __init__(self, number):
+self.number = number
+url = 'https://api.github.com/repos/apache/beam/pulls/%d/files' % number
+self.files = []
+for file_json in requests.get(url).json():
+ self.files.append('/' + file_json['filename'])
+
+
+def main():
+ logging.getLogger().setLevel(logging.INFO)
+ parser = argparse.ArgumentParser()
+
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=124160=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124160 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 17/Jul/18 18:19 Start Date: 17/Jul/18 18:19 Worklog Time Spent: 10m Work Description: udim commented on issue #5951: [BEAM-4790] Replace Github reviewer auto-assignment with suggest_reviewers.py script URL: https://github.com/apache/beam/pull/5951#issuecomment-405678755 Will just remove CODEOWNERS in another PR, in favor of blame-based assignment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 124160) Time Spent: 50m (was: 40m) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=123156=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123156 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 14/Jul/18 01:24 Start Date: 14/Jul/18 01:24 Worklog Time Spent: 10m Work Description: udim commented on issue #5951: [BEAM-4790] Replace Github reviewer auto-assignment with suggest_reviewers.py script URL: https://github.com/apache/beam/pull/5951#issuecomment-404988848 The idea is to run it like a precommit test on Jenkins, and have it report back the list of suggested reviewers. Still a work in progress, so for now users should run it manually. The current Github-based auto-assignment is problematic. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123156) Time Spent: 40m (was: 0.5h) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=123149=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123149 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 14/Jul/18 01:02 Start Date: 14/Jul/18 01:02 Worklog Time Spent: 10m Work Description: holdenk commented on issue #5951: [BEAM-4790] Replace Github reviewer auto-assignment with suggest_reviewers.py script URL: https://github.com/apache/beam/pull/5951#issuecomment-404987381 So are users supposed to run `suggest_reviewers.py` or is automatically run somewhere? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123149) Time Spent: 20m (was: 10m) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=123150=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123150 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 14/Jul/18 01:02 Start Date: 14/Jul/18 01:02 Worklog Time Spent: 10m Work Description: holdenk edited a comment on issue #5951: [BEAM-4790] Replace Github reviewer auto-assignment with suggest_reviewers.py script URL: https://github.com/apache/beam/pull/5951#issuecomment-404987381 So are devs supposed to run `suggest_reviewers.py` or is automatically run somewhere? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123150) Time Spent: 0.5h (was: 20m) > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4790) Make it easier to select coder reviewers for PRs
[ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=123147=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123147 ] ASF GitHub Bot logged work on BEAM-4790: Author: ASF GitHub Bot Created on: 14/Jul/18 00:58 Start Date: 14/Jul/18 00:58 Worklog Time Spent: 10m Work Description: udim commented on issue #5951: [BEAM-4790] Replace Github reviewer auto-assignment with suggest_reviewers.py script URL: https://github.com/apache/beam/pull/5951#issuecomment-404987057 @tweise Created a JIRA. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 123147) Time Spent: 10m Remaining Estimate: 0h > Make it easier to select coder reviewers for PRs > > > Key: BEAM-4790 > URL: https://issues.apache.org/jira/browse/BEAM-4790 > Project: Beam > Issue Type: Improvement > Components: project-management >Reporter: Udi Meiri >Assignee: Davor Bonaci >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The original idea was to use Github's CODEOWNERS feature, but that turned out > to not work well for Apache Beam. > Thread: > https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E > Document discussing this idea: > https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8 > Mailing list thread: > https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
