[jira] [Work logged] (BEAM-5304) Support running user pipelines with the Universal Local Runner in Java.
[
https://issues.apache.org/jira/browse/BEAM-5304?focusedWorklogId=148950&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-148950
]
ASF GitHub Bot logged work on BEAM-5304:
Author: ASF GitHub Bot
Created on: 27/Sep/18 23:36
Start Date: 27/Sep/18 23:36
Worklog Time Spent: 10m
Work Description: pabloem closed pull request #6498: [BEAM-5304] Adding
ReferenceRunner Job Server Gradle subproject.
URL: https://github.com/apache/beam/pull/6498
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/runners/reference/java/build.gradle
b/runners/reference/java/build.gradle
index 7bbaed09126..932a788b25f 100644
--- a/runners/reference/java/build.gradle
+++ b/runners/reference/java/build.gradle
@@ -29,6 +29,7 @@ configurations {
}
dependencies {
+ compile library.java.guava
compile library.java.hamcrest_library
shadow project(path: ":beam-model-pipeline", configuration: "shadow")
shadow project(path: ":beam-runners-core-construction-java", configuration:
"shadow")
diff --git a/runners/reference/job-server/build.gradle
b/runners/reference/job-server/build.gradle
new file mode 100644
index 000..1c81fba2dd5
--- /dev/null
+++ b/runners/reference/job-server/build.gradle
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+applyJavaNature(
+ validateShadowJar: false,
+ shadowClosure: {
+ }
+)
+
+description = "Apache Beam :: Runners :: Reference :: Job Server"
+
+apply plugin: "application"
+
+mainClassName =
"org.apache.beam.runners.direct.portable.job.ReferenceRunnerJobServer"
+
+dependencies {
+ compile project(path: ":beam-runners-direct-java", configuration: "shadow")
+ compile project(path: ":beam-runners-java-fn-execution", configuration:
"shadow")
+ compile library.java.slf4j_simple
+}
+
+run {
+ args = []
+ if (project.hasProperty('port'))
+args += ["--port=${project.property('port')}"]
+
+ // Enable remote debugging.
+ jvmArgs = ["-Xdebug",
"-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005"]
+ if (project.hasProperty("logLevel"))
+jvmArgs +=
["-Dorg.slf4j.simpleLogger.defaultLogLevel=${project.property('logLevel')}"]
+}
diff --git a/settings.gradle b/settings.gradle
index 2c806ed0a47..3600e41e862 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -58,6 +58,8 @@ include "beam-runners-local-java-core"
project(":beam-runners-local-java-core").dir = file("runners/local-java")
include "beam-runners-reference-java"
project(":beam-runners-reference-java").dir = file("runners/reference/java")
+include "beam-runners-reference-job-server"
+project(":beam-runners-reference-job-server").dir =
file("runners/reference/job-server")
include "beam-runners-spark"
project(":beam-runners-spark").dir = file("runners/spark")
include "beam-runners-samza"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 148950)
Time Spent: 1h 10m (was: 1h)
> Support running user pipelines with the Universal Local Runner in Java.
> ---
>
> Key: BEAM-5304
> URL: https://issues.apache.org/jira/browse/BEAM-5304
> Project: Beam
> Issue Type: Sub-task
> Components: runner-direct
>Reporter: Daniel Oliveira
>Assignee: Daniel Oliveira
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In order to aid testing, devs should be able to write pipelines and
[jira] [Work logged] (BEAM-5304) Support running user pipelines with the Universal Local Runner in Java.
[ https://issues.apache.org/jira/browse/BEAM-5304?focusedWorklogId=148947&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-148947 ] ASF GitHub Bot logged work on BEAM-5304: Author: ASF GitHub Bot Created on: 27/Sep/18 23:31 Start Date: 27/Sep/18 23:31 Worklog Time Spent: 10m Work Description: youngoli commented on issue #6498: [BEAM-5304] Adding ReferenceRunner Job Server Gradle subproject. URL: https://github.com/apache/beam/pull/6498#issuecomment-425274484 @pabloem For committer approval This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 148947) Time Spent: 1h (was: 50m) > Support running user pipelines with the Universal Local Runner in Java. > --- > > Key: BEAM-5304 > URL: https://issues.apache.org/jira/browse/BEAM-5304 > Project: Beam > Issue Type: Sub-task > Components: runner-direct >Reporter: Daniel Oliveira >Assignee: Daniel Oliveira >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > In order to aid testing, devs should be able to write pipelines and then > easily run them with the ULR. The Flink runner seems to have this > functionality, so the implementation could be based on that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-5304) Support running user pipelines with the Universal Local Runner in Java.
[ https://issues.apache.org/jira/browse/BEAM-5304?focusedWorklogId=148511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-148511 ] ASF GitHub Bot logged work on BEAM-5304: Author: ASF GitHub Bot Created on: 26/Sep/18 23:10 Start Date: 26/Sep/18 23:10 Worklog Time Spent: 10m Work Description: youngoli commented on issue #6498: [BEAM-5304] Adding ReferenceRunner Job Server Gradle subproject. URL: https://github.com/apache/beam/pull/6498#issuecomment-424899725 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 148511) Time Spent: 50m (was: 40m) > Support running user pipelines with the Universal Local Runner in Java. > --- > > Key: BEAM-5304 > URL: https://issues.apache.org/jira/browse/BEAM-5304 > Project: Beam > Issue Type: Sub-task > Components: runner-direct >Reporter: Daniel Oliveira >Assignee: Daniel Oliveira >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > In order to aid testing, devs should be able to write pipelines and then > easily run them with the ULR. The Flink runner seems to have this > functionality, so the implementation could be based on that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-5304) Support running user pipelines with the Universal Local Runner in Java.
[
https://issues.apache.org/jira/browse/BEAM-5304?focusedWorklogId=148510&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-148510
]
ASF GitHub Bot logged work on BEAM-5304:
Author: ASF GitHub Bot
Created on: 26/Sep/18 23:10
Start Date: 26/Sep/18 23:10
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #6498:
[BEAM-5304] Adding ReferenceRunner Job Server Gradle subproject.
URL: https://github.com/apache/beam/pull/6498#discussion_r220750716
##
File path: runners/reference/job-server/build.gradle
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+applyJavaNature(
+ validateShadowJar: false,
+ shadowClosure: {
+ }
+)
+
+description = "Apache Beam :: Runners :: Reference :: Job Server"
+
+apply plugin: "application"
+
+mainClassName =
"org.apache.beam.runners.direct.portable.job.ReferenceRunnerJobServer"
+
+dependencies {
+ compile project(path: ":beam-runners-direct-java", configuration: "shadow")
+ compile project(path: ":beam-runners-java-fn-execution", configuration:
"shadow")
+ compile library.java.slf4j_simple
+}
+
+run {
Review comment:
I don't think it's necessary because in this case the JobServer works with
just run. It feels odd using the shaded version just for consistency (unless
there's some other advantage to using runShadow that I don't know).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 148510)
Time Spent: 40m (was: 0.5h)
> Support running user pipelines with the Universal Local Runner in Java.
> ---
>
> Key: BEAM-5304
> URL: https://issues.apache.org/jira/browse/BEAM-5304
> Project: Beam
> Issue Type: Sub-task
> Components: runner-direct
>Reporter: Daniel Oliveira
>Assignee: Daniel Oliveira
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In order to aid testing, devs should be able to write pipelines and then
> easily run them with the ULR. The Flink runner seems to have this
> functionality, so the implementation could be based on that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5304) Support running user pipelines with the Universal Local Runner in Java.
[
https://issues.apache.org/jira/browse/BEAM-5304?focusedWorklogId=148331&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-148331
]
ASF GitHub Bot logged work on BEAM-5304:
Author: ASF GitHub Bot
Created on: 26/Sep/18 19:59
Start Date: 26/Sep/18 19:59
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6498:
[BEAM-5304] Adding ReferenceRunner Job Server Gradle subproject.
URL: https://github.com/apache/beam/pull/6498#discussion_r220702310
##
File path: runners/reference/job-server/build.gradle
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import groovy.json.JsonOutput
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+applyJavaNature(
+ validateShadowJar: false,
+ shadowClosure: {
+ }
+)
+
+description = "Apache Beam :: Runners :: Reference :: Job Server"
+
+apply plugin: "application"
+
+mainClassName =
"org.apache.beam.runners.direct.portable.job.ReferenceRunnerJobServer"
+
+dependencies {
+ compile project(path: ":beam-runners-direct-java", configuration: "shadow")
+ compile project(path: ":beam-runners-java-fn-execution", configuration:
"shadow")
+ compile library.java.slf4j_simple
+}
+
+run {
Review comment:
Shall we name it to `runShadow` for consistency
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 148331)
Time Spent: 0.5h (was: 20m)
> Support running user pipelines with the Universal Local Runner in Java.
> ---
>
> Key: BEAM-5304
> URL: https://issues.apache.org/jira/browse/BEAM-5304
> Project: Beam
> Issue Type: Sub-task
> Components: runner-direct
>Reporter: Daniel Oliveira
>Assignee: Daniel Oliveira
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In order to aid testing, devs should be able to write pipelines and then
> easily run them with the ULR. The Flink runner seems to have this
> functionality, so the implementation could be based on that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5304) Support running user pipelines with the Universal Local Runner in Java.
[ https://issues.apache.org/jira/browse/BEAM-5304?focusedWorklogId=148308&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-148308 ] ASF GitHub Bot logged work on BEAM-5304: Author: ASF GitHub Bot Created on: 26/Sep/18 19:41 Start Date: 26/Sep/18 19:41 Worklog Time Spent: 10m Work Description: youngoli commented on issue #6498: [BEAM-5304] Adding ReferenceRunner Job Server Gradle subproject. URL: https://github.com/apache/beam/pull/6498#issuecomment-424844233 R: @angoenka You have context in the Flink code this is based on and the Reference Runner. CC: @HuangLED This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 148308) Time Spent: 20m (was: 10m) > Support running user pipelines with the Universal Local Runner in Java. > --- > > Key: BEAM-5304 > URL: https://issues.apache.org/jira/browse/BEAM-5304 > Project: Beam > Issue Type: Sub-task > Components: runner-direct >Reporter: Daniel Oliveira >Assignee: Daniel Oliveira >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > In order to aid testing, devs should be able to write pipelines and then > easily run them with the ULR. The Flink runner seems to have this > functionality, so the implementation could be based on that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-5304) Support running user pipelines with the Universal Local Runner in Java.
[ https://issues.apache.org/jira/browse/BEAM-5304?focusedWorklogId=148304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-148304 ] ASF GitHub Bot logged work on BEAM-5304: Author: ASF GitHub Bot Created on: 26/Sep/18 19:38 Start Date: 26/Sep/18 19:38 Worklog Time Spent: 10m Work Description: youngoli opened a new pull request #6498: [BEAM-5304] Adding ReferenceRunner Job Server Gradle subproject. URL: https://github.com/apache/beam/pull/6498 Adding a Gradle subproject for running the ReferenceRunner's JobServer. Based on how Flink runs their JobServer. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 148304) Time Spent: 10m Remaining Estimate: 0h > Support running user pipelines with the Universal Local Runner in Java. > --- > > Key: BEAM-5304 > URL: https://issues.apache.org/jira/browse/BEAM-5304 >
