[GitHub] incubator-beam pull request #1070: [BEAM-733] Prohibit windowed side inputs ...

[robertwb]

Github user robertwb closed the pull request at:

https://github.com/apache/incubator-beam/pull/1070


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1070: [BEAM-733] Prohibit windowed side inputs ...

[robertwb]

GitHub user robertwb opened a pull request:

https://github.com/apache/incubator-beam/pull/1070

[BEAM-733] Prohibit windowed side inputs until they are implemented 
correctly.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertwb/incubator-beam side-inputs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1070.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1070


commit 5b8e7685b5d5582e894b726ce0189c76199f0b7a
Author: Robert Bradshaw 
Date:   2016-10-07T22:28:50Z

Dissallow (unimplemented) windowed side inputs.

commit fa079b99fcf300dc210d21020f821a88b6142b79
Author: Robert Bradshaw 
Date:   2016-10-07T23:17:47Z

Fix tests.

commit e10587b162944475290581dc8bb35dfec4cf0afd
Author: Robert Bradshaw 
Date:   2016-10-07T23:31:20Z

Add windowed side inputs failure test.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---