[GitHub] incubator-beam pull request #1435: Replace WindowAssignment OldDoFn by FlatM...

2016-11-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1435


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1435: Replace WindowAssignment OldDoFn by FlatM...

2016-11-24 Thread aljoscha
GitHub user aljoscha opened a pull request:

https://github.com/apache/incubator-beam/pull/1435

Replace WindowAssignment OldDoFn by FlatMap in FLink Runner

The streaming runner had an OldDoFn that was used for assigning windows
using a WindowFn. This is now done with a FlatMap.

R: @mxm for review please
CC: @kennknowles I thought you might enjoy seeing `OldDoFns` removed. 😃 

This is the first step towards getting rid of `OldDoFn` in the Flink 
runner. The next steps are:
 - https://issues.apache.org/jira/browse/BEAM-956: Execute ReduceFnRunner 
Directly in Flink Runner
 - https://issues.apache.org/jira/browse/BEAM-843: Use New DoFn Directly in 
Flink Runner

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aljoscha/incubator-beam flink-remove-olddofn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1435


commit da32dcd06dddc8f4e288e8778fd8ac4a572d72ab
Author: Aljoscha Krettek 
Date:   2016-11-08T10:03:21Z

Replace WindowAssignment OldDoFn by FlatMap in FLink Runner

The streaming runner had an OldDoFn that was used for assigning windows
using a WindowFn. This is now done with a FlatMap.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---